*** thorst has joined #openstack-watcher | 00:44 | |
*** thorst has quit IRC | 00:51 | |
*** thorst has joined #openstack-watcher | 01:17 | |
*** thorst has quit IRC | 01:23 | |
*** Kevin_Zheng has joined #openstack-watcher | 01:35 | |
*** thorst has joined #openstack-watcher | 01:42 | |
*** sauvik has joined #openstack-watcher | 01:42 | |
*** sauvik has joined #openstack-watcher | 01:43 | |
*** thorst has quit IRC | 01:43 | |
*** sauvik has quit IRC | 01:48 | |
*** sauvik has joined #openstack-watcher | 01:56 | |
*** sauvik has quit IRC | 02:10 | |
*** sauvik has joined #openstack-watcher | 02:17 | |
openstackgerrit | junjie.huang proposed openstack/watcher: Workload balance migration strategy implementation https://review.openstack.org/292188 | 03:11 |
---|---|---|
*** wootehfoot has quit IRC | 03:32 | |
*** vtech has quit IRC | 04:42 | |
openstackgerrit | junjie.huang proposed openstack/watcher: Workload balance migration strategy implementation https://review.openstack.org/292188 | 05:11 |
*** tpeoples is now known as tpeoples_vacatio | 05:23 | |
*** tpeoples_vacatio is now known as tpeoplesvacation | 05:24 | |
*** apoorv has joined #openstack-watcher | 06:07 | |
*** vmahe has joined #openstack-watcher | 06:08 | |
*** vtech has joined #openstack-watcher | 06:28 | |
*** vtech has quit IRC | 06:44 | |
*** apoorv has quit IRC | 06:58 | |
*** apoorv has joined #openstack-watcher | 06:59 | |
*** sauvik has joined #openstack-watcher | 07:06 | |
*** vtech has joined #openstack-watcher | 07:07 | |
*** vtech has quit IRC | 07:07 | |
*** vtech has joined #openstack-watcher | 07:08 | |
*** sauvik has quit IRC | 07:11 | |
*** vincentfrancoise has joined #openstack-watcher | 07:27 | |
*** vincentfrancoise has quit IRC | 07:34 | |
*** vincentfrancoise has joined #openstack-watcher | 07:35 | |
vtech | Good morning guys, jed56, vincentfrancoise, so I suggest removing watcher_non_live_migrate_instance and adding cold_migrate_instance in nova_helper.py. The implementation of cold_migrate_instance will be similar to implementation of built_in_non_live_migrate_instance in nova_wrapper.py. What I don't understand is what is the NovaWrapper class used for. And why are the same functions implemented in nova_wrapper.py and nova_helper.py | 07:39 |
jed56 | hello vtech | 07:40 |
jed56 | nova_wrapper is the ancestor of nova_helper | 07:40 |
jed56 | I think during the refactoring we removed the wrong version of the cold migration | 07:41 |
jed56 | I'm not sure that we can specify the destination of VM during a cold migraiton | 07:41 |
jed56 | It was maybe the reason of our cold migration | 07:42 |
vtech | it's possible for sure | 07:42 |
vtech | ok, now it's clear | 07:42 |
jed56 | great! | 07:43 |
*** apoorv has quit IRC | 07:45 | |
vtech | jed56, it seems you are right, there is now way how to specify destinatation hypervisor in cold_migration - this is strange. | 08:03 |
vtech | https://github.com/openstack/python-novaclient/blob/master/novaclient/v2/servers.py#L291 | 08:05 |
*** brunograz has joined #openstack-watcher | 08:07 | |
vtech | jed56, was the watcher_non_live_migrate_instance previously working as expected? your implementation seems to be fine, although I think it worth to give a shout to nova guys to add an option to choose destination hypervisor in cold migration as implementing this in watcher is IMO ugly solution. | 08:22 |
*** apoorv has joined #openstack-watcher | 08:26 | |
*** brunograz has quit IRC | 08:44 | |
*** brunograz has joined #openstack-watcher | 08:44 | |
jed56 | vtech, yes i was working on our infrastructure not sure on "real life" | 09:20 |
jed56 | we can maybe ask the nova team | 09:20 |
jed56 | I agree it is ugly :) | 09:20 |
jed56 | i was the only solution i found | 09:20 |
jed56 | on the previous version of openstack | 09:21 |
vtech | I asked already | 09:50 |
vtech | and it went huge :D | 09:50 |
*** vincentfrancoise has quit IRC | 10:22 | |
*** sauvik has joined #openstack-watcher | 10:43 | |
*** sauvik has quit IRC | 10:48 | |
*** aspiers_ is now known as aspiers | 10:54 | |
*** thorst has joined #openstack-watcher | 11:35 | |
jed56 | NP-Hard ! | 11:50 |
jed56 | vtech :) | 11:51 |
*** apoorv has quit IRC | 11:51 | |
vtech | jed56, heh? | 12:03 |
*** vincentfrancoise has joined #openstack-watcher | 12:06 | |
jed56 | you said that went huge => https://en.wikipedia.org/wiki/NP-hardness :) | 12:08 |
*** brunograz has quit IRC | 12:35 | |
*** brunograz has joined #openstack-watcher | 12:36 | |
*** edleafe is now known as figleaf | 13:01 | |
*** sauvik has joined #openstack-watcher | 13:07 | |
vtech | jed56, so the conclusion is that cold migration currently doesn't support target hypervisor specification. Nevertheless this will be added to nova eventually. Until then I would just go with your solution. | 13:19 |
*** sauvik has quit IRC | 13:25 | |
*** sauvik has joined #openstack-watcher | 13:26 | |
*** openstackgerrit has quit IRC | 13:33 | |
*** openstackgerrit has joined #openstack-watcher | 13:33 | |
*** vtech has quit IRC | 13:36 | |
*** vtech has joined #openstack-watcher | 13:36 | |
jed56 | vtech, okay could you please verify that everything is working ? | 13:42 |
jed56 | this code was design for Icehouse | 13:43 |
jed56 | i think :) | 13:43 |
vtech | right, I will give it a spin. | 13:43 |
jed56 | great, thanks a lot | 13:48 |
*** openstack has quit IRC | 13:58 | |
*** openstack has joined #openstack-watcher | 13:58 | |
*** sauvik has quit IRC | 14:02 | |
*** sauvik has joined #openstack-watcher | 14:09 | |
*** sauvik has quit IRC | 14:14 | |
*** sauvik has joined #openstack-watcher | 14:27 | |
*** wootehfoot has joined #openstack-watcher | 14:29 | |
*** dtardivel has joined #openstack-watcher | 14:32 | |
*** thorst has quit IRC | 15:01 | |
*** thorst has joined #openstack-watcher | 15:02 | |
*** esberglu has joined #openstack-watcher | 15:05 | |
*** sauvik has quit IRC | 15:11 | |
*** anem0ne has joined #openstack-watcher | 15:12 | |
anem0ne | Hello | 15:14 |
anem0ne | i have a question about unit tests | 15:14 |
anem0ne | i've pulled master yesterday, and from that i have such errors in tests: | 15:14 |
anem0ne | oslo_config.cfg.NoSuchOptError: no such option in group DEFAULT: watcher_clients_auth | 15:14 |
anem0ne | do you know what is wrong ? | 15:14 |
anem0ne | bug ? wrong conf option ? | 15:15 |
vincentfrancoise | Hi anem0ne | 15:16 |
vincentfrancoise | looks a bit odd | 15:17 |
anem0ne | vincentfrancoise: hello | 15:17 |
vincentfrancoise | how many tests are failing? | 15:17 |
anem0ne | vincentfrancoise: I'm writing my own strategy, and all my tests are failing, but before pulling master, everything was ok, tests was passing | 15:18 |
anem0ne | but there is more errors | 15:19 |
anem0ne | example: | 15:19 |
anem0ne | testtools.matchers._impl.MismatchError: 'SUCCEEDED' != u'FAILED' | 15:19 |
anem0ne | in watcher.tests.decision_engine.audit.test_default_audit_handler.TestDefaultAuditHandler.test_trigger_audit_state_success | 15:19 |
anem0ne | Bad response: 400 Bad Request (not 200 OK or 3xx redirect for http://localhost/v1/audit_templates) | 15:19 |
anem0ne | in watcher.tests.api.v1.test_audit_templates.TestPost.test_create_audit_template_generate_uuid | 15:20 |
anem0ne | at least 10 tests from upstream is failing | 15:20 |
anem0ne | on my side | 15:20 |
anem0ne | it's a bit strange for me, because everything was working, have you pushed changes that could break things ? | 15:22 |
vincentfrancoise | it can't be | 15:22 |
*** thorst has quit IRC | 15:22 | |
vincentfrancoise | the merge process goes through running all the tests | 15:22 |
vincentfrancoise | you can try cloning once again (say in /tmp) and run the tests in there to compare | 15:23 |
vincentfrancoise | but the tests you are pointing out clearly shouldn't be breaking | 15:26 |
anem0ne | vincentfrancoise: hmm... could be that, i have something broken on my side (some requirements) | 15:26 |
anem0ne | oki, checking | 15:26 |
anem0ne | vincentfrancoise: just to be sure, can you tell me how you run all unit test s? | 15:27 |
anem0ne | tests* | 15:27 |
vincentfrancoise | https://factory.b-com.com/www/watcher/doc/watcher/dev/testing.html#unit-tests | 15:28 |
vincentfrancoise | so basically you just need to run "tox" | 15:28 |
openstackgerrit | Vincent Mahe proposed openstack/watcher-specs: Provide efficacy indicators https://review.openstack.org/283449 | 15:29 |
*** thorst has joined #openstack-watcher | 15:30 | |
anem0ne | vincentfrancoise: - Failed: 14 :/ | 15:35 |
anem0ne | vincentfrancoise: you want see it ? | 15:36 |
*** pav0 has quit IRC | 15:36 | |
anem0ne | vincentfrancoise: http://pastebin.com/XAwYkEAK | 15:37 |
anem0ne | vincentfrancoise: sorry, need to go, I will be deeply checking this problem. Maybe it's something on my side | 15:40 |
vincentfrancoise | anem0ne: sorry I'm back | 15:45 |
*** vmahe has quit IRC | 15:53 | |
vincentfrancoise | anem0ne: so did you run these tests from a clean clone? | 15:56 |
vincentfrancoise | anem0ne: ok so I did clone and run the tests on my machine | 16:02 |
vincentfrancoise | on master | 16:03 |
vincentfrancoise | and everything's fine for me | 16:03 |
*** openstackgerrit has quit IRC | 16:31 | |
*** openstackgerrit has joined #openstack-watcher | 16:45 | |
*** sauvik has joined #openstack-watcher | 17:15 | |
*** harlowja has quit IRC | 18:02 | |
*** jed56 has quit IRC | 18:03 | |
*** dtardivel has quit IRC | 18:08 | |
*** wootehfoot has quit IRC | 19:09 | |
*** sauvik has quit IRC | 19:27 | |
*** harlowja has joined #openstack-watcher | 19:37 | |
*** wootehfoot has joined #openstack-watcher | 19:59 | |
*** wootehfoot has quit IRC | 20:40 | |
*** wootehfoot has joined #openstack-watcher | 20:53 | |
*** thorst has quit IRC | 21:17 | |
*** vtech has quit IRC | 21:19 | |
*** thorst has joined #openstack-watcher | 21:38 | |
*** thorst has quit IRC | 21:42 | |
*** wootehfoot has quit IRC | 22:04 | |
*** figleaf is now known as edleafe | 22:11 | |
*** wootehfoot has joined #openstack-watcher | 22:57 | |
*** harlowja has quit IRC | 23:36 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!