| *** esberglu has quit IRC | 00:03 | |
| *** esberglu has joined #openstack-watcher | 00:30 | |
| *** jwcroppe has joined #openstack-watcher | 00:43 | |
| *** jwcroppe has quit IRC | 00:47 | |
| *** thorst has quit IRC | 01:16 | |
| *** thorst has joined #openstack-watcher | 01:17 | |
| *** thorst has quit IRC | 01:25 | |
| openstackgerrit | junjie.huang proposed openstack/watcher: Closes-bug: #1569114 https://review.openstack.org/304359 | 01:35 |
|---|---|---|
| openstack | bug 1569114 in watcher "outlet-temperature-based-strategy calculates disk space not correctly " [Undecided,New] https://launchpad.net/bugs/1569114 | 01:35 |
| openstackgerrit | junjie.huang proposed openstack/watcher: correct the available disk, memory calculating Closes-bug: #1569114 https://review.openstack.org/304359 | 01:51 |
| openstack | bug 1569114 in watcher "outlet-temperature-based-strategy calculates disk space not correctly " [Undecided,New] https://launchpad.net/bugs/1569114 | 01:51 |
| *** jwcroppe has joined #openstack-watcher | 01:57 | |
| openstackgerrit | junjie.huang proposed openstack/watcher: correct the available disk, memory calculating Source data are misused in outlet temperature strategy. This patch fixes it. https://review.openstack.org/304359 | 02:05 |
| *** jwcroppe has quit IRC | 02:16 | |
| *** thorst has joined #openstack-watcher | 02:23 | |
| *** thorst has quit IRC | 02:30 | |
| *** thorst has joined #openstack-watcher | 03:28 | |
| *** thorst has quit IRC | 03:34 | |
| *** Kevin_Zheng has joined #openstack-watcher | 03:51 | |
| *** jwcroppe has joined #openstack-watcher | 04:19 | |
| *** jwcroppe has quit IRC | 04:24 | |
| *** thorst has joined #openstack-watcher | 04:33 | |
| *** thorst has quit IRC | 04:40 | |
| *** apoorv has joined #openstack-watcher | 04:50 | |
| apoorv | how do i know that compute node is successfully added | 05:24 |
| *** mestery has quit IRC | 05:32 | |
| *** thorst has joined #openstack-watcher | 05:38 | |
| *** mestery has joined #openstack-watcher | 05:38 | |
| *** mestery has quit IRC | 05:40 | |
| *** mestery has joined #openstack-watcher | 05:43 | |
| *** thorst has quit IRC | 05:45 | |
| *** jwcroppe has joined #openstack-watcher | 06:22 | |
| *** jwcroppe has quit IRC | 06:27 | |
| *** thorst has joined #openstack-watcher | 06:43 | |
| *** thorst has quit IRC | 06:51 | |
| openstackgerrit | Merged openstack/watcher: correct the available disk, memory calculating Source data are misused in outlet temperature strategy. This patch fixes it. https://review.openstack.org/304359 | 07:08 |
| *** vincentfrancoise has joined #openstack-watcher | 07:15 | |
| *** thorst has joined #openstack-watcher | 07:33 | |
| *** jinquan has joined #openstack-watcher | 07:39 | |
| *** jinquan has left #openstack-watcher | 07:40 | |
| *** thorst has quit IRC | 07:40 | |
| *** dtardivel has joined #openstack-watcher | 08:05 | |
| *** jwcroppe has joined #openstack-watcher | 08:25 | |
| *** jwcroppe has quit IRC | 08:30 | |
| *** thorst has joined #openstack-watcher | 08:39 | |
| *** thorst has quit IRC | 08:45 | |
| *** pav0 has joined #openstack-watcher | 08:50 | |
| *** alexchadin has joined #openstack-watcher | 08:50 | |
| alexchadin | hi | 08:50 |
| vincentfrancoise | hi | 08:50 |
| alexchadin | i added python-watcherclient to as affected project https://bugs.launchpad.net/watcher/+bug/1532843 | 08:51 |
| openstack | Launchpad bug 1532843 in watcher "Can create Audit with invalid parameters" [Low,Triaged] - Assigned to Alexander Chadin (joker946) | 08:51 |
| alexchadin | cause we can use audit_template_uuid and audit_template_name in api | 08:52 |
| alexchadin | and on client side we can check is audit_template uuid or string | 08:53 |
| vincentfrancoise | I see | 08:53 |
| alexchadin | is this ok? | 08:53 |
| vincentfrancoise | Well if the validation is made by the Watcher API, then you can still return the right error message | 08:54 |
| vincentfrancoise | So I would argue that fixing it on the server side should be enough | 08:55 |
| *** alexchadin has quit IRC | 08:55 | |
| vincentfrancoise | SO what you want to do is a pre-check on the client side right? | 08:55 |
| *** alexchadin has joined #openstack-watcher | 08:56 | |
| alexchadin | look | 08:57 |
| alexchadin | now api can handle audit_template_uuid and audit_template_name | 08:57 |
| alexchadin | we can either audit_template_uuid or audit_template_name in api request | 08:57 |
| alexchadin | use* | 08:58 |
| alexchadin | on api side we validate that audit_template_uuid = wtypes.wsattr(types.uuid, mandatory=False) | 08:58 |
| alexchadin | on client side, watcherclient use audit_template_uuid parameter which could be uuid or string name | 08:59 |
| alexchadin | help='Audit template used for this audit (name or uuid).') | 08:59 |
| vincentfrancoise | Ok but isn't this an API issue then? | 09:00 |
| alexchadin | i added audit_template_name = wtypes.wsattr(wtypes.text, mandatory=False) | 09:00 |
| alexchadin | to support this two params | 09:01 |
| alexchadin | and i suggest to use something like this on watcherclient | 09:01 |
| alexchadin | if namespace['audit_template']: | 09:01 |
| alexchadin | if utils.is_uuid_like(namespace['audit_template']): | 09:01 |
| alexchadin | namespace['audit_template_uuid'] = namespace['audit_template'] | 09:01 |
| alexchadin | field_list.append('audit_template_uuid') | 09:01 |
| vincentfrancoise | 1 sec I'm looking at the code | 09:01 |
| alexchadin | else: | 09:01 |
| alexchadin | namespace['audit_template_name'] = namespace['audit_template'] | 09:02 |
| alexchadin | field_list.append('audit_template_name') | 09:02 |
| alexchadin | ok;) | 09:02 |
| alexchadin | i saw something like this in novaclient | 09:03 |
| vincentfrancoise | Wouldn't it be best to make a single 'audit_template' param that can either be the name or the UUID of the audit template | 09:03 |
| vincentfrancoise | ? | 09:03 |
| alexchadin | on which side? | 09:05 |
| alexchadin | api or client? | 09:05 |
| vincentfrancoise | you can then use the UuidOrNameType https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/types.py#L29 for validation before knowing whether it is the name or UUID of the audit template | 09:06 |
| vincentfrancoise | both I guess (to make it consistent) | 09:06 |
| vincentfrancoise | but on the server side that would be attached to the AuditPostType before being "translated" into a UUID or name when doing the as_audit_template() call | 09:07 |
| vincentfrancoise | as_audit() * | 09:07 |
| alexchadin | audit_template = wtypes.wsattr(types.uuidorname, mandatory=True) | 09:09 |
| alexchadin | something like this? | 09:09 |
| vincentfrancoise | yes | 09:10 |
| alexchadin | it's a good idea | 09:10 |
| alexchadin | thank you for advice | 09:10 |
| vincentfrancoise | you're welcome :) | 09:11 |
| *** thorst has joined #openstack-watcher | 09:12 | |
| alexchadin | one more question: how may i reference to the two bugs in commit? | 09:12 |
| alexchadin | two "Closes-Bug" in a row? | 09:12 |
| vincentfrancoise | Yes | 09:15 |
| vincentfrancoise | BTW | 09:16 |
| vincentfrancoise | you can now run integration tests onto gerrit | 09:16 |
| vincentfrancoise | when you push your patchset | 09:16 |
| vincentfrancoise | post a comment saying "check experimental" to trigger a bot that will run the jenkins job | 09:17 |
| *** openstackgerrit has quit IRC | 09:17 | |
| *** openstackgerrit has joined #openstack-watcher | 09:17 | |
| vincentfrancoise | this way you can show that the Tempest tests you re-enabled are now passing | 09:18 |
| *** alexchadin has quit IRC | 09:23 | |
| *** alexchadin has joined #openstack-watcher | 09:24 | |
| *** alexchadin has quit IRC | 09:26 | |
| *** thorst has quit IRC | 09:29 | |
| *** openstack has joined #openstack-watcher | 09:58 | |
| *** jed56 has quit IRC | 10:23 | |
| *** alexchadin has joined #openstack-watcher | 10:25 | |
| *** jwcroppe has joined #openstack-watcher | 10:27 | |
| *** alexchadin has quit IRC | 10:29 | |
| *** jwcroppe has quit IRC | 10:35 | |
| *** alexchadin has joined #openstack-watcher | 10:40 | |
| *** alexchadin has quit IRC | 10:47 | |
| apoorv | what to do after modifying /etc/nova/nova.conf | 11:29 |
| sballe_ | Morning | 12:04 |
| *** openstack has quit IRC | 12:04 | |
| *** openstack has joined #openstack-watcher | 12:05 | |
| apoorv | how to know which metric is being used by a action plan | 12:06 |
| vincentfrancoise | hi apoorv | 12:06 |
| vincentfrancoise | the action plan doesn't use any metric | 12:06 |
| vincentfrancoise | only the audit does to eventually generate an action plan | 12:07 |
| vincentfrancoise | and the metrics used depend on the strategy you are using | 12:07 |
| vincentfrancoise | so you have to refer to the doc of the strategy to know which one are used | 12:07 |
| *** gzhai3 has quit IRC | 12:18 | |
| *** apoorv has quit IRC | 12:25 | |
| *** thorst has joined #openstack-watcher | 12:32 | |
| *** jwcroppe has joined #openstack-watcher | 12:33 | |
| *** thorst has quit IRC | 12:36 | |
| *** thorst has joined #openstack-watcher | 12:37 | |
| *** jwcroppe has quit IRC | 12:37 | |
| *** thorst has quit IRC | 12:41 | |
| *** esberglu has quit IRC | 13:56 | |
| *** thorst_ has joined #openstack-watcher | 14:10 | |
| *** gzhai has joined #openstack-watcher | 14:26 | |
| *** jwcroppe has joined #openstack-watcher | 14:35 | |
| *** jwcroppe has quit IRC | 14:40 | |
| *** thorst_ has quit IRC | 15:02 | |
| *** alexchadin has joined #openstack-watcher | 15:08 | |
| *** openstackgerrit has quit IRC | 15:18 | |
| *** openstackgerrit has joined #openstack-watcher | 15:18 | |
| *** logan- has quit IRC | 15:34 | |
| *** logan- has joined #openstack-watcher | 15:40 | |
| alexchadin | may i install tempest on the mac? | 15:44 |
| vincentfrancoise | tempest is pure python, so I guess it should be fine | 15:45 |
| alexchadin | i don't have openstack on it, only virtual env with watcher | 15:45 |
| vincentfrancoise | Did you find the doc explaining how to install it? | 15:45 |
| alexchadin | i found README in watcher_tempest_plugin folder | 15:46 |
| vincentfrancoise | yeah it's fine, I do the same: tempest is on my ubuntu machine and I give it the devstack IP | 15:46 |
| alexchadin | hm | 15:46 |
| alexchadin | devstack IP? | 15:46 |
| alexchadin | ah, got it | 15:46 |
| vincentfrancoise | well the keystone IP from my devstack to be precise | 15:47 |
| alexchadin | keystone auth | 15:47 |
| alexchadin | yeah | 15:47 |
| alexchadin | public_network_id = <PUBLIC_NETWORK_ID> | 15:47 |
| alexchadin | should there be my ext net uuid? | 15:47 |
| vincentfrancoise | the doc is also available in HTML: https://factory.b-com.com/www/watcher/doc/watcher/dev/testing.html#tempest-tests | 15:48 |
| vincentfrancoise | publich_network_id is the "ID of the public network that provides external connectivity" | 15:49 |
| vincentfrancoise | SO YEAH | 15:49 |
| vincentfrancoise | sorry caps | 15:49 |
| alexchadin | :D | 15:50 |
| *** alexchadin has quit IRC | 15:55 | |
| *** wootehfoot has joined #openstack-watcher | 16:11 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Documentation update for get-goal-from-strategy https://review.openstack.org/299900 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added Goal object + goal syncing https://review.openstack.org/296634 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Add Goal in BaseStrategy + Goal API reads from DB https://review.openstack.org/296635 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Remove watcher_goals section from devstack plugin https://review.openstack.org/299902 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added Goal model into Watcher DB https://review.openstack.org/296633 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Add strategy_id & goal_id fields in audit template https://review.openstack.org/296636 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added Strategy model https://review.openstack.org/298807 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added /strategies endpoint in Watcher API https://review.openstack.org/299899 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: DB registration for Strategies https://review.openstack.org/298808 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Updated purge to now include goals and strategies https://review.openstack.org/299539 | 16:24 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Refactored Strategy selector to select from DB https://review.openstack.org/304751 | 16:24 |
| *** alexchadin has joined #openstack-watcher | 16:24 | |
| openstackgerrit | Vincent Françoise proposed openstack/python-watcherclient: Added Strategy support in Watcher CLI https://review.openstack.org/299930 | 16:26 |
| openstackgerrit | Vincent Françoise proposed openstack/python-watcherclient: Updated CLI for new /goals API https://review.openstack.org/298631 | 16:26 |
| openstackgerrit | Vincent Françoise proposed openstack/python-watcherclient: Support for refactored /audit_templates endpoint https://review.openstack.org/304759 | 16:26 |
| *** jwcroppe has joined #openstack-watcher | 16:29 | |
| *** gzhai1 has joined #openstack-watcher | 16:41 | |
| *** gzhai has quit IRC | 16:44 | |
| *** jwcroppe has quit IRC | 16:50 | |
| *** jwcroppe has joined #openstack-watcher | 16:57 | |
| *** esberglu has joined #openstack-watcher | 16:57 | |
| *** jwcroppe has quit IRC | 17:01 | |
| *** alexchadin has quit IRC | 17:38 | |
| *** alexchadin has joined #openstack-watcher | 17:41 | |
| *** wootehfoot has quit IRC | 18:05 | |
| *** alexchadin has quit IRC | 18:11 | |
| *** esberglu has quit IRC | 18:13 | |
| *** wootehfoot has joined #openstack-watcher | 18:17 | |
| *** esberglu has joined #openstack-watcher | 18:34 | |
| *** jwcroppe has joined #openstack-watcher | 18:52 | |
| *** dtardivel has quit IRC | 19:38 | |
| *** jwcroppe_ has joined #openstack-watcher | 19:56 | |
| *** jwcroppe has quit IRC | 19:56 | |
| *** esberglu has quit IRC | 21:50 | |
| *** esberglu has joined #openstack-watcher | 22:01 | |
| *** aspiers has quit IRC | 22:24 | |
| *** aspiers has joined #openstack-watcher | 22:25 | |
| *** jwcroppe_ has quit IRC | 22:31 | |
| *** jwcroppe has joined #openstack-watcher | 22:32 | |
| *** jwcroppe has quit IRC | 22:36 | |
| *** wootehfoot has quit IRC | 23:04 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!