| *** thorst has joined #openstack-watcher | 00:55 | |
| *** thorst has quit IRC | 00:56 | |
| *** Kevin_Zheng has joined #openstack-watcher | 01:43 | |
| *** thorst has joined #openstack-watcher | 01:56 | |
| *** thorst has quit IRC | 01:59 | |
| *** thorst has joined #openstack-watcher | 01:59 | |
| *** thorst has quit IRC | 02:00 | |
| *** thorst has joined #openstack-watcher | 02:00 | |
| *** thorst has quit IRC | 02:05 | |
| *** esberglu has joined #openstack-watcher | 02:39 | |
| *** esberglu has quit IRC | 02:41 | |
| *** thorst has joined #openstack-watcher | 03:03 | |
| *** thorst has quit IRC | 03:10 | |
| *** thorst has joined #openstack-watcher | 04:09 | |
| *** thorst has quit IRC | 04:16 | |
| *** jwcroppe has joined #openstack-watcher | 04:46 | |
| *** jwcroppe has quit IRC | 04:46 | |
| *** jwcroppe has joined #openstack-watcher | 04:47 | |
| *** jwcroppe has quit IRC | 05:04 | |
| *** jwcroppe has joined #openstack-watcher | 05:10 | |
| *** thorst has joined #openstack-watcher | 05:14 | |
| *** ecelik has joined #openstack-watcher | 05:17 | |
| *** thorst has quit IRC | 05:20 | |
| *** openstackgerrit has quit IRC | 06:02 | |
| *** openstackgerrit has joined #openstack-watcher | 06:03 | |
| *** thorst has joined #openstack-watcher | 06:18 | |
| *** wootehfoot has joined #openstack-watcher | 06:22 | |
| *** thorst has quit IRC | 06:26 | |
| *** vmahe has joined #openstack-watcher | 06:33 | |
| *** apoorv has joined #openstack-watcher | 06:37 | |
| *** jwcroppe has quit IRC | 06:54 | |
| *** jwcroppe has joined #openstack-watcher | 06:56 | |
| *** jwcroppe has quit IRC | 07:00 | |
| *** jed56 has joined #openstack-watcher | 07:22 | |
| *** thorst has joined #openstack-watcher | 07:25 | |
| *** thorst has quit IRC | 07:31 | |
| *** vtech has joined #openstack-watcher | 07:31 | |
| *** vincentfrancoise has joined #openstack-watcher | 07:34 | |
| *** alexchadin has joined #openstack-watcher | 08:14 | |
| *** wootehfoot has quit IRC | 08:22 | |
| *** thorst has joined #openstack-watcher | 08:29 | |
| *** thorst has quit IRC | 08:35 | |
| *** apoorv has quit IRC | 08:42 | |
| *** apoorv has joined #openstack-watcher | 08:51 | |
| *** alexchadin has quit IRC | 08:53 | |
| *** alexchadin has joined #openstack-watcher | 08:53 | |
| *** danpawlik has quit IRC | 08:54 | |
| *** danpawlik has joined #openstack-watcher | 08:54 | |
| *** alexchadin has quit IRC | 08:57 | |
| *** alexchadin has joined #openstack-watcher | 09:00 | |
| vincentfrancoise | hi gzhai2 | 09:33 |
|---|---|---|
| *** thorst has joined #openstack-watcher | 09:33 | |
| *** thorst has quit IRC | 09:40 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added filter operators https://review.openstack.org/325794 | 09:43 |
| *** wootehfoot has joined #openstack-watcher | 09:46 | |
| *** wootehfoot has quit IRC | 09:46 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added filter operators https://review.openstack.org/325794 | 09:50 |
| *** alexchadin has quit IRC | 09:54 | |
| *** alexchadin has joined #openstack-watcher | 09:54 | |
| *** thorst has joined #openstack-watcher | 10:38 | |
| *** alexchadin has quit IRC | 10:38 | |
| *** alexchadin has joined #openstack-watcher | 10:39 | |
| *** alexchadin has quit IRC | 10:43 | |
| *** alexchadin has joined #openstack-watcher | 10:43 | |
| *** thorst has quit IRC | 10:46 | |
| *** alexchadin has quit IRC | 10:51 | |
| *** alexchadin has joined #openstack-watcher | 11:35 | |
| *** thorst has joined #openstack-watcher | 11:36 | |
| *** alexchadin has quit IRC | 11:38 | |
| *** apoorv has quit IRC | 12:19 | |
| *** hvprash has joined #openstack-watcher | 12:30 | |
| *** hvprash has quit IRC | 12:31 | |
| openstackgerrit | Antoine Cabot proposed openstack/watcher: Add reno for release notes management https://review.openstack.org/325190 | 12:32 |
| gzhai2 | vincentfrancoise:hi | 12:58 |
| vincentfrancoise | gzhai2: hi | 12:58 |
| gzhai2 | about my patch, want talk with you. | 12:59 |
| *** figleaf is now known as edleafe | 12:59 | |
| vincentfrancoise | ok | 12:59 |
| gzhai2 | about jsonschema. I can use it, but the issue is we need do the validation in strategy code rather than API | 13:00 |
| gzhai2 | As API has no knowledge of which strategy is used, so can't locate the right schema. | 13:01 |
| vincentfrancoise | yes but the persistent-audit-parameters blueprint should solves this issue (https://blueprints.launchpad.net/watcher/+spec/persistent-audit-parameters) | 13:02 |
| vincentfrancoise | so maybe there is a missing dependency then | 13:02 |
| vincentfrancoise | so maybe you can add the strategy_id foreign key to the Audit model so you can tell which strategy the audit is applying in the meantime | 13:04 |
| gzhai2 | Then let's merge optimization-threshold first, then change it after persistent-audit-parameters. | 13:05 |
| gzhai2 | I can add foreign key, but it's only be done in audit creation, where we alredy know the strategy id. | 13:06 |
| vincentfrancoise | ah yeah as I said in my comment, your audit doesn't know about the strategy if you are in "case 1" | 13:07 |
| vincentfrancoise | but in case 2, your audit knows which strategy it applies since it's the same as the related audit template | 13:08 |
| gzhai2 | What's case 1 and 2? | 13:10 |
| vincentfrancoise | ->Case 1: If no strategy was provided, I agree we cannot validate the parameters: should we still be able to provide parameters other than the defaults if don't even know what shall be run? BTW, that is a case we have yet to discuss as it is not described in the specs. ->Case 2: If a strategy has been provided, then we know the parameters we should apply, which means we can potentially validate the strategy parameters at t | 13:10 |
| vincentfrancoise | (copy/paste from https://review.openstack.org/#/c/297556/7/watcher/decision_engine/strategy/strategies/base.py) | 13:11 |
| gzhai2 | You want to different ways to handle case 1 & 2? The way in my patch for 1, while validation at API for 2? | 13:14 |
| vincentfrancoise | gzhai2: I'm not sure we should allow audit parameters unless we know in advance which strategy we are targeting | 13:15 |
| vincentfrancoise | gzhai2: that's just my opinion so we should probably ask the others about it | 13:16 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added efficacy indicators to /action_plans https://review.openstack.org/318179 | 13:16 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: [WIP] Strategy selector select based on efficacy https://review.openstack.org/325214 | 13:16 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Documentation on goal and efficacy https://review.openstack.org/319275 | 13:16 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added pre/post execution methods to strategies https://review.openstack.org/325212 | 13:16 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: [WIP] Cancel out related audits and action plans https://review.openstack.org/325213 | 13:16 |
| gzhai2 | How about raise exception if user input parameter for non-parameter strategy? | 13:17 |
| gzhai2 | You know. flexibilty is most important for strategy selection. I'm not sure if we can know which strategy would be used. | 13:18 |
| vincentfrancoise | We may do this but IMHO this is misleading: if you give some parameters, this means you know which strategy you want to use | 13:18 |
| gzhai2 | Especially in long term. | 13:18 |
| vincentfrancoise | otherwise, this means that some parameters should be shared because of the goal | 13:19 |
| gzhai2 | Yes. | 13:21 |
| gzhai2 | My original patch instantiate one strategy when creating audit-template to get the parameter info. Is it ok? | 13:22 |
| gzhai2 | Currently, user need search the strategy list to find the goal-strategy mapping. | 13:22 |
| gzhai2 | My point is: strategy-goal solution is not clear at this point, like how to map multiple stratey to one goal. I believe we need some enhancement in future. | 13:24 |
| jed56 | hello gzhai2 | 13:25 |
| gzhai2 | But strategy parameter is critical feature for watcher usage, so I want a for-now solution and change it in future. | 13:25 |
| jed56 | Exactly, we add a feature to give to watcher the ability to select the best strategy | 13:25 |
| gzhai2 | jed56: hi | 13:25 |
| jed56 | You can take a look to this blueprint https://blueprints.launchpad.net/watcher/+spec/watcher-strategy-selector | 13:26 |
| *** hvprash has joined #openstack-watcher | 13:26 | |
| jed56 | This is the reason why, if don't "force" a strategy you can't specify the parameters at this moment | 13:26 |
| gzhai2 | I know we have a lot of features to make Watcher mature, and I can wait for other features merged. But this is also critical features asked from last release. | 13:28 |
| jed56 | yes I agree. | 13:29 |
| jed56 | you can implement the parameters | 13:29 |
| jed56 | you just can't specify parameter if you don't specify a strategy | 13:30 |
| gzhai2 | This depends on our development strategy: long time perfect solution, or workable solution for now and change it gradually in future. | 13:30 |
| jed56 | gzhai2: I agree, we have to build watcher incrementally | 13:31 |
| jed56 | I don't understand well your point ? :) | 13:31 |
| vincentfrancoise | gzhai2: FYI, how can we generate the form on the watcher-dashboard to fill the strategy parameters if we don't know which one we want to apply? | 13:31 |
| gzhai2 | How about instantiate one strategy when audit tmplate creation to know the right stratey? | 13:32 |
| *** jwcroppe has joined #openstack-watcher | 13:32 | |
| *** hvprash_ has joined #openstack-watcher | 13:32 | |
| gzhai2 | Curently, I assume one goal only have one strategy, so user can search strategy list to find the right strategy for the goal. | 13:33 |
| gzhai2 | If it's not ture, I'd like to add extra instantiating strategy for check. | 13:34 |
| *** hvprash has quit IRC | 13:35 | |
| jed56 | IMHO, you should keep the code simple. If audit_template has not strategy you can't specify parameters | 13:36 |
| gzhai2 | Then I can add strategy foreign key for audit-template. | 13:36 |
| jed56 | otherwise, if the audit_template have a strategy you can | 13:36 |
| vincentfrancoise | gzhai2: one goal (server_consolidation) already has 2 strategies related to it (basic and vm_workload_consolidation), so cannot assume that | 13:37 |
| gzhai2 | jed56: ok | 13:37 |
| gzhai2 | You guys still prefer jsonschema, and validation in API? | 13:38 |
| jed56 | ghzai do you have an alternative ? | 13:38 |
| gzhai2 | If keep it as simple as you said, it's ok. | 13:40 |
| vincentfrancoise | +1 | 13:41 |
| gzhai2 | ok. I'll change it. | 13:41 |
| gzhai2 | Thanks for your comments. | 13:41 |
| jed56 | gzhai2: you are welcome. | 13:42 |
| vincentfrancoise | thanks for making the changes ;) | 13:43 |
| jed56 | if need help don't hesitate | 13:43 |
| gzhai2 | ok:) | 13:44 |
| *** brunograz has joined #openstack-watcher | 13:48 | |
| brunograz | Hi guys | 13:48 |
| brunograz | We have a testbed with watcher installed on it (we did the installation some months ago and actually never updated it) | 13:49 |
| brunograz | I did the update to the latest version of watcher | 13:49 |
| brunograz | and we are running into some issues - watcherclient has changed as well as the base strategy | 13:50 |
| vincentfrancoise | hi brunograz | 13:50 |
| brunograz | I had to drop the database and recreate it in order to use the new client | 13:50 |
| brunograz | but now there are no goals inserted | 13:51 |
| vincentfrancoise | yes it changed with the n1 release | 13:51 |
| vincentfrancoise | goals are now defined via the strategy itself | 13:51 |
| *** ecelik has quit IRC | 13:51 | |
| vincentfrancoise | and the decision engine syncs the goals and strategies with the DB to let the API expose it | 13:52 |
| brunograz | but how do I insert the goal into the DB? | 13:53 |
| brunograz | there is no option to create it and in my strategy I added the classmethod to return the goal name | 13:53 |
| vincentfrancoise | the decision engine does it automatically when you start it | 13:53 |
| brunograz | hmm got it | 13:54 |
| brunograz | let me try to restart it | 13:54 |
| brunograz | yep it worked (y) | 13:54 |
| brunograz | thx a mil | 13:55 |
| brunograz | my error was to restart the decision engine before recreating the database | 13:55 |
| vincentfrancoise | oh I see | 13:55 |
| vincentfrancoise | I guess we will have to start doing DB migrations since we are now into the big tent | 13:56 |
| vincentfrancoise | maybe we can put this in the open discussion of this week's meeting | 13:56 |
| brunograz | agreed | 13:59 |
| brunograz | and I think we will have to file another bug to our strategy | 13:59 |
| brunograz | and it does not implement the new abstract methos | 13:59 |
| brunograz | opss sorry - it is implemeted | 14:01 |
| *** esberglu has joined #openstack-watcher | 14:01 | |
| vincentfrancoise | it should be there otherwise some tests would have failed ;) | 14:05 |
| *** hvprash has joined #openstack-watcher | 14:28 | |
| *** hvprash_ has quit IRC | 14:32 | |
| *** jinquan has joined #openstack-watcher | 14:37 | |
| *** jwcroppe has quit IRC | 14:55 | |
| *** jwcroppe has joined #openstack-watcher | 14:56 | |
| *** jwcroppe has quit IRC | 15:01 | |
| *** alexchadin has joined #openstack-watcher | 15:05 | |
| alexchadin | hi | 15:06 |
| *** jinquan has quit IRC | 15:06 | |
| vincentfrancoise | hi | 15:06 |
| vincentfrancoise | alexchadin: I reviewed you changeset on continuously-optimization | 15:09 |
| alexchadin | I think we can change audit type via API. For example, we have audit with some parameters. If we want to change continuous type to oneshot we don't need to create new audit with the same parameters | 15:10 |
| alexchadin | vincentfrancoise: I saw, thank you:) | 15:10 |
| vincentfrancoise | alexchadin: the problem is more about the fact that an audit is triggered as soon as it gets created. So even if you change the type of the audit, you shouldn't be able the reverse the state of the audit which will be already ONGOING or even SUCCEEDED | 15:12 |
| alexchadin | vincentfrancoise: let me think of it | 15:13 |
| vincentfrancoise | ok | 15:13 |
| alexchadin | vincentfrancoise: I agree | 15:15 |
| danpawlik | hello! I see, that in https://factory.b-com.com/www/watcher/doc/watcher/deploy/conf-files.html doc file in section: keystone_authtoken there are memcache* parameters, but I guess this memcache* parameters should be moved to cache section (according to puppet-oslo module - https://github.com/openstack/puppet-oslo/blob/master/manifests/cache.pp#L124) or? | 15:17 |
| vincentfrancoise | alexchadin: if you want to make sure you do not have to specify parameters over and over again, maybe we'll need to move these parameters up in the audit template as well | 15:17 |
| alexchadin | vincentfrancoise: I think having parameters in audit is well | 15:18 |
| vincentfrancoise | danpawlik: Hi | 15:19 |
| vincentfrancoise | alexchadin: what we are talking about is pretty much what gzhai2 is working on BTW | 15:19 |
| vincentfrancoise | alexchadin: see https://blueprints.launchpad.net/watcher/+spec/optimization-threshold | 15:21 |
| alexchadin | vincentfrancoise: I know, I really want this changes to be merged ASAP:_ | 15:21 |
| alexchadin | :) | 15:21 |
| vincentfrancoise | danpawlik: Agreed, we are missing "namespace = oslo.cache" in etc/watcher/watcher-config-generator.conf | 15:21 |
| vincentfrancoise | danpawlik: but I don't know if memcache* params in keystone_authtoken are actually the same | 15:22 |
| danpawlik | vincentfrancoise: thanks. So I must confirm this params with guys from oslo/keystone/puppet etc. Hmm, maybe better if I make small changes in my puppet-watcher module and then community will say, what should I do ;P | 15:23 |
| alexchadin | vincentfrancoise: could you please give me an example of "IN" operator usage in your new PS? | 15:24 |
| vincentfrancoise | danpawlik: give me 2 secs, I'll see if I can find anything in keystone_authtoken that would point to oslo.cache | 15:24 |
| danpawlik | vincentfrancoise: ok | 15:25 |
| *** hvprash_ has joined #openstack-watcher | 15:25 | |
| vincentfrancoise | alexchadin: https://review.openstack.org/#/c/325794/2/watcher/db/sqlalchemy/api.py line 176 | 15:26 |
| vincentfrancoise | alexchadin: the docstring is a bit off by the way so I'll update it whenever I get some time | 15:28 |
| alexchadin | vincentfrancoise: it's okay, thank you! | 15:28 |
| *** hvprash has quit IRC | 15:28 | |
| vincentfrancoise | danpawlik: seems to me that these memcached* parameters are different from the olso.cache ones | 15:35 |
| danpawlik | vincentfrancoise: ok. Good to know. Thanks for checking ;) | 15:37 |
| vincentfrancoise | so that mean we need both these parameters and the missing oslo.cache ones | 15:37 |
| *** alexchadin has quit IRC | 15:44 | |
| *** alexchadin has joined #openstack-watcher | 15:46 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added missing config section for autogeneration https://review.openstack.org/325996 | 15:48 |
| vincentfrancoise | danpawlik: see ^ | 15:48 |
| danpawlik | vincentfrancoise: looks good :D | 15:49 |
| vincentfrancoise | danpawlik: there were way more than just oslo.cache that was actually missing :p | 15:50 |
| danpawlik | vincentfrancoise: I think that I can still find something xD | 15:52 |
| vincentfrancoise | danpawlik: that wouldn't surprise me :p The more you find the better anyway | 15:52 |
| danpawlik | vincentfrancoise: yeah :D | 15:54 |
| *** jwcroppe has joined #openstack-watcher | 15:57 | |
| *** brunograz has quit IRC | 16:00 | |
| *** jwcroppe has quit IRC | 16:03 | |
| *** vtech has quit IRC | 16:04 | |
| danpawlik | have a nice day / evening ;) | 16:06 |
| vincentfrancoise | danpawlik: see you ;) | 16:07 |
| *** danpawlik has quit IRC | 16:07 | |
| *** jinquan has joined #openstack-watcher | 16:08 | |
| *** vincentfrancoise has quit IRC | 16:16 | |
| *** jinquan has left #openstack-watcher | 16:23 | |
| *** vtech has joined #openstack-watcher | 16:44 | |
| *** jwcroppe has joined #openstack-watcher | 16:59 | |
| *** jwcroppe has quit IRC | 17:04 | |
| *** esberglu has quit IRC | 17:05 | |
| *** alexchadin has quit IRC | 17:15 | |
| *** jwcroppe has joined #openstack-watcher | 17:18 | |
| *** vtech has quit IRC | 17:29 | |
| *** alexchadin has joined #openstack-watcher | 17:32 | |
| *** harlowja has joined #openstack-watcher | 17:48 | |
| openstackgerrit | Alexander Chadin proposed openstack/watcher: Add continuously optimization https://review.openstack.org/321411 | 17:49 |
| *** esberglu has joined #openstack-watcher | 18:02 | |
| *** jed56 has quit IRC | 18:45 | |
| *** alexchadin has quit IRC | 18:47 | |
| *** vtech has joined #openstack-watcher | 19:00 | |
| *** alexchadin has joined #openstack-watcher | 20:35 | |
| *** hvprash_ has quit IRC | 21:01 | |
| *** thorst has quit IRC | 21:17 | |
| *** jwcroppe has quit IRC | 21:30 | |
| *** thorst has joined #openstack-watcher | 21:36 | |
| *** jwcroppe has joined #openstack-watcher | 21:39 | |
| *** thorst_ has joined #openstack-watcher | 21:39 | |
| *** thorst has quit IRC | 21:42 | |
| *** jwcroppe_ has joined #openstack-watcher | 21:43 | |
| *** jwcroppe has quit IRC | 21:44 | |
| *** thorst_ has quit IRC | 21:45 | |
| *** thorst has joined #openstack-watcher | 21:45 | |
| *** jwcroppe_ has quit IRC | 21:54 | |
| *** thorst has quit IRC | 21:55 | |
| *** jwcroppe has joined #openstack-watcher | 21:55 | |
| *** jwcroppe has quit IRC | 21:59 | |
| *** esberglu has quit IRC | 22:20 | |
| *** thorst has joined #openstack-watcher | 22:52 | |
| *** alexchadin has quit IRC | 22:53 | |
| *** thorst has quit IRC | 23:00 | |
| *** harlowja has quit IRC | 23:01 | |
| *** jwcroppe has joined #openstack-watcher | 23:13 | |
| *** jwcroppe has quit IRC | 23:16 | |
| openstackgerrit | Merged openstack/watcher: Updated from global requirements https://review.openstack.org/322551 | 23:39 |
| *** jwcroppe has joined #openstack-watcher | 23:55 | |
| *** thorst has joined #openstack-watcher | 23:58 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!