*** thorst has joined #openstack-watcher | 01:01 | |
*** thorst has quit IRC | 01:04 | |
*** thorst has joined #openstack-watcher | 01:05 | |
*** hvprash has joined #openstack-watcher | 01:05 | |
openstackgerrit | Merged openstack/watcher: Add reno for release notes management https://review.openstack.org/325190 | 01:07 |
---|---|---|
*** thorst has quit IRC | 01:13 | |
*** thorst has joined #openstack-watcher | 01:26 | |
*** thorst has quit IRC | 01:26 | |
*** thorst has joined #openstack-watcher | 01:27 | |
*** thorst has quit IRC | 01:31 | |
*** jwcroppe has quit IRC | 01:38 | |
*** jinquan1 has quit IRC | 01:39 | |
*** jwcroppe has joined #openstack-watcher | 01:39 | |
*** hvprash_ has joined #openstack-watcher | 01:48 | |
*** hvprash has quit IRC | 01:49 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/watcher: Updated from global requirements https://review.openstack.org/327393 | 01:55 |
*** thorst has joined #openstack-watcher | 02:30 | |
*** thorst has quit IRC | 02:30 | |
*** thorst has joined #openstack-watcher | 02:30 | |
*** thorst has quit IRC | 02:36 | |
*** jwcroppe_ has joined #openstack-watcher | 02:41 | |
*** jwcroppe has quit IRC | 02:44 | |
*** jwcroppe_ has quit IRC | 03:03 | |
*** jwcroppe has joined #openstack-watcher | 03:08 | |
*** jwcroppe has quit IRC | 03:13 | |
*** thorst has joined #openstack-watcher | 03:34 | |
*** hvprash_ has quit IRC | 03:40 | |
*** thorst has quit IRC | 03:41 | |
*** thorst has joined #openstack-watcher | 04:39 | |
*** thorst has quit IRC | 04:46 | |
*** thorst has joined #openstack-watcher | 05:43 | |
*** thorst has quit IRC | 05:51 | |
*** hvprash has joined #openstack-watcher | 05:52 | |
*** M00nr41n has quit IRC | 05:56 | |
*** hvprash has quit IRC | 05:57 | |
*** jinquan has joined #openstack-watcher | 06:07 | |
*** apoorv has joined #openstack-watcher | 06:27 | |
*** ecelik has joined #openstack-watcher | 06:38 | |
*** thorst has joined #openstack-watcher | 06:50 | |
*** thorst has quit IRC | 06:56 | |
*** jinquan has quit IRC | 07:20 | |
*** jinquan has joined #openstack-watcher | 07:21 | |
jed56 | hi | 07:24 |
*** thorst has joined #openstack-watcher | 07:53 | |
*** M00nr41n has joined #openstack-watcher | 07:55 | |
*** thorst has quit IRC | 08:01 | |
danpawlik | hello :) | 08:35 |
acabot | zigo : can you tell us which files ? | 08:45 |
zigo | acabot: Just do a grep ! | 08:45 |
zigo | Loads of them. | 08:45 |
acabot | zigo : we have a b<>com copyright but Apache license just after | 08:45 |
zigo | acabot: Copyright holders have nothing to do with licensing. | 08:46 |
zigo | These are 2 different things. | 08:46 |
acabot | ok so what do you need for copyright ? | 08:46 |
zigo | I'm well aware we're using Apache-2.0, never the less, I must list copyright holders properly in debian/copyright. | 08:46 |
zigo | grep -r 'b<>com' * | 08:47 |
zigo | acabot: Is this a real company called b<>com ? | 08:47 |
zigo | Or just some leftovers ? | 08:47 |
acabot | zigo : yes its a company | 08:47 |
zigo | acabot: Why not calling a company 'DELETE * FROM users then? :) | 08:48 |
zigo | Weird... | 08:48 |
acabot | zigo : you can use b-com or bcom is <> is problematic | 08:48 |
acabot | zigo : you should probably ask my CEO ;-) | 08:48 |
zigo | acabot: Is this b-com.com ? :) | 08:48 |
acabot | yes it is | 08:48 |
zigo | Ok. | 08:48 |
jed56 | MEGA LOL | 08:49 |
jed56 | marketing things | 08:49 |
jed56 | hello zigo | 08:49 |
zigo | Hi ! | 08:49 |
*** thorst has joined #openstack-watcher | 09:00 | |
*** thorst has quit IRC | 09:06 | |
*** M00nr41n has quit IRC | 09:28 | |
jinquan | jed56: hello? | 09:39 |
jed56 | Hello jinquan | 09:39 |
jinquan | Do you have a plan about the spec of https://blueprints.launchpad.net/watcher/+spec/select-destinations-filter? | 09:39 |
jed56 | yes | 09:40 |
jed56 | I'm working on it | 09:40 |
jed56 | at the end of the week, I will share a spec | 09:40 |
jinquan | So, Should i wait for you? or continue work on your comment in my patch set? | 09:41 |
acabot | jinquan : hi | 09:46 |
jinquan | acabot: hi | 09:47 |
acabot | we had a discussion with jed56 regarding the select_destinations implementation | 09:47 |
jinquan | acabot: yeah, do you have a result? | 09:47 |
acabot | after looking at what Nova is doing more precisely, we should probably adjust the spec regarding select_destinations | 09:48 |
jed56 | yes, I going to propose a new approach for the respect the nova policies | 09:48 |
acabot | jinquan : so I would suggest that you stop working on it and start another BP if you like | 09:48 |
acabot | jinquan : and we will resubmit the spec after dicussions with Nova | 09:49 |
jed56 | In my proposition, i argue that this is not the best approach to call select_destinations in the strategies | 09:49 |
jinquan | acabot: ok, get it! i will wait the new specs merged,and i also review it at first time! | 09:49 |
acabot | jinquan : just to be clear, its not related to your code at all, its because the assumptions we made in january are wrong | 09:49 |
acabot | jinquan : we will keep your code in gerrit and put it up when the spec will be improved | 09:50 |
acabot | jinquan : does it make sense ? | 09:51 |
jinquan | acabot: : ) get it, ok, no proplem! | 09:51 |
acabot | jinquan : thx, do you want to work on https://blueprints.launchpad.net/watcher/+spec/cluster-energy-saving ? | 09:52 |
jinquan | acabot: I will assign another buleprint | 09:52 |
acabot | jinquan : ok let me know which one you choose | 09:52 |
jinquan | acabot: of course, | 09:52 |
jinquan | acabot: Hi, what's the situation of https://blueprints.launchpad.net/watcher/+spec/cluster-energy-saving? | 09:55 |
jinquan | we have discuss about it | 09:55 |
jinquan | but we did not get a final result | 09:56 |
jinquan | jed56: thank you for your work about the new spec. :) | 09:57 |
*** thorst has joined #openstack-watcher | 10:04 | |
*** thorst has quit IRC | 10:11 | |
*** apoorv has quit IRC | 10:46 | |
*** wootehfoot has joined #openstack-watcher | 10:58 | |
*** thorst has joined #openstack-watcher | 11:08 | |
*** thorst has quit IRC | 11:15 | |
tkaczynski | hi guys. sooner or later ;) I will have some code for scoring-module blueprint to commit / review. I would like to split changes into smaller batches, so it will be easier for reviewers to understand and for me to get feedback and fix issues early :) | 11:23 |
tkaczynski | my question is: what's the best approach to achieve that? I've created a branch bp/scoring on top of recent watcher code. what's next? do commits and send each commit for review? or have different branch for each review? | 11:24 |
tkaczynski | it's possible that I will have some work in parallel, so applying feedback from one code review might get tricky if there will be some other code commits already | 11:26 |
*** thorst has joined #openstack-watcher | 11:33 | |
acabot | tkaczynski : hi | 11:54 |
acabot | all your code must be hosted under the same branch which will be bp/scoring-module in your case | 11:55 |
acabot | but of course you need to split your contribution in multiple commits | 11:56 |
jed56 | hello tkaczynski | 11:59 |
tkaczynski | this is clear. but how to apply feedback from code review to specific commits without affecting the other commits? rebasing will change all subsequent commits | 11:59 |
jed56 | There is not rules to explain how to split your code because it can be very specific | 11:59 |
jed56 | however, the size of the patchset have to be under 600 lines | 12:00 |
jed56 | you should try to link your patchset in way that we can understand gradually your work | 12:00 |
edleafe | tkaczynski: you can't :( | 12:01 |
tkaczynski | so the question is not how to split the code - this I can do myself :) the question is how to review the multiple commits in parallel | 12:01 |
edleafe | tkaczynski: that's simply how rebasing works with Gerrit | 12:01 |
jed56 | hello edleafe | 12:01 |
edleafe | hi | 12:01 |
jed56 | edleafe: +1 | 12:02 |
tkaczynski | so ideal scenario is: make commit, start review, ask people to hurry ;), apply feedback, merge and then only create a new commit and open new review | 12:03 |
edleafe | tkaczynski: each commit should be able to stand on its own. Not only passing tests, but logically a single step | 12:03 |
edleafe | tkaczynski: it's not a bad thing to have to go through that dance a few times. That's simply what happens with large changes | 12:04 |
tkaczynski | of course, that is clear to me and this is my intention. I just expect that the review process might take a while (bad assumption?), so I could work on the next steps in parallel | 12:04 |
openstackgerrit | Merged openstack/python-watcherclient: Add support continuously-optimization https://review.openstack.org/321421 | 12:05 |
edleafe | tkaczynski: sure, that's expected, too | 12:05 |
edleafe | the reviews will take a while, and some patches will have to be reviewed several times. | 12:05 |
tkaczynski | ok, thanks guys for help | 12:07 |
jed56 | welcome, don't hesitate if you have any questions :) | 12:07 |
*** thorst has quit IRC | 12:11 | |
*** thorst has joined #openstack-watcher | 12:15 | |
*** jwcroppe has joined #openstack-watcher | 12:16 | |
danpawlik | small question: is all watcher services require parameters to rabbit/amqp/zmq or only api and applier? | 12:20 |
jed56 | hello danpawlik | 12:20 |
danpawlik | second question: the same question but about redis_* parameters | 12:21 |
danpawlik | jed56: hi :) | 12:21 |
danpawlik | jed56: I have some question in my puppet-watcher review. maybe you can answer? https://review.openstack.org/#/c/326593/4/manifests/init.pp | 12:21 |
jed56 | yes, for your first question, every services need of rabbitmq | 12:23 |
jed56 | danpawlik: yes i will | 12:24 |
jed56 | which service require them? All? => this is only the applier module and the decision engine | 12:24 |
danpawlik | jed56: thanks a lot | 12:24 |
jed56 | FYI, for the current version of watcher we only need ceilometer and nova | 12:25 |
danpawlik | I know, that parameters like nova_client_api_version (and another parameters *_api_version) are required by watcher-api. | 12:26 |
jed56 | I don't think we need that in the watcher-api | 12:26 |
danpawlik | jed56: version available in master or in version 0.27.0 ? | 12:27 |
jed56 | danpawlik: yes 0.27.0 | 12:27 |
danpawlik | jed56: hmm, but it exist in config file example xD If you can, please answer EmiliemM :) | 12:28 |
jed56 | you can you give me this config file | 12:28 |
danpawlik | jed56: sure, https://factory.b-com.com/www/watcher/doc/watcher/deploy/conf-files.html | 12:29 |
jed56 | okay, this is part of the API section but we only use it in the decision engine and the applier | 12:30 |
danpawlik | jed56: ok, so *_api_version I will move ;) | 12:33 |
danpawlik | jed56: or you are talking about rabbit ? | 12:33 |
jed56 | *_api_version | 12:33 |
danpawlik | :) | 12:33 |
jed56 | jed56: hmm, but it exist in config file example xD If you can, please answer EmiliemM : => done | 12:36 |
danpawlik | ok :) | 12:36 |
danpawlik | jed56: thx | 12:38 |
*** Zucan has joined #openstack-watcher | 13:08 | |
*** jwcroppe_ has joined #openstack-watcher | 13:16 | |
*** jwcropp__ has joined #openstack-watcher | 13:17 | |
*** jwcroppe has quit IRC | 13:18 | |
*** jwcroppe_ has quit IRC | 13:20 | |
*** hvprash has joined #openstack-watcher | 13:31 | |
*** hvprash has quit IRC | 13:32 | |
*** esberglu has joined #openstack-watcher | 13:34 | |
*** michaelgugino has joined #openstack-watcher | 13:49 | |
*** ecelik has quit IRC | 13:54 | |
openstackgerrit | Daniel Pawlik proposed openstack/puppet-watcher: This commit adds the initial project files. https://review.openstack.org/326593 | 14:09 |
*** hvprash has joined #openstack-watcher | 14:19 | |
*** hvprash has quit IRC | 14:19 | |
*** hvprash has joined #openstack-watcher | 14:20 | |
*** dronshaw has joined #openstack-watcher | 14:24 | |
*** hvprash has quit IRC | 14:24 | |
*** hvprash has joined #openstack-watcher | 14:25 | |
*** dtardivel has joined #openstack-watcher | 14:42 | |
*** michaelgugino has quit IRC | 15:03 | |
*** michaelgugino has joined #openstack-watcher | 15:07 | |
*** jwcroppe has joined #openstack-watcher | 15:07 | |
*** jwcropp__ has quit IRC | 15:10 | |
sballe_ | morning | 15:14 |
sballe_ | jed56: have you tried to run https://github.com/GoogleCloudPlatform/PerfKitBenchmarker in your enviroment | 15:14 |
acabot | sballe_ : hi | 15:15 |
sballe_ | acabot: hi :) | 15:15 |
acabot | sballe_ : not yet, we are currently updating our infra to Mitaka | 15:15 |
acabot | dtardivel is working on it | 15:15 |
acabot | we hope to have it ready by EOW | 15:15 |
acabot | and then start working on Monasca | 15:16 |
sballe_ | ok. Once you run could maybe have access to the telemtry data/traces from the runs? | 15:16 |
jed56 | sballe_: hello | 15:16 |
sballe_ | I am not sure how big it is so maybe it is not possible | 15:16 |
acabot | sballe_ : I think we will be able to dump the DB but we will probably do it with Monasca | 15:17 |
jed56 | sballe_: I didn't have the time to test it yet | 15:17 |
sballe_ | ok thx | 15:18 |
sballe_ | acabot: Is there an output mode where I can get it in cvs files? | 15:18 |
acabot | sballe_ : I don't know | 15:19 |
sballe_ | ok np | 15:19 |
acabot | https://github.com/openstack/monasca-persister | 15:19 |
acabot | the best would be probably to give an access to DropWizard | 15:20 |
*** jwcroppe_ has joined #openstack-watcher | 15:20 | |
jed56 | sballe_ IMHO, you call the Monasca API and export easily the measurements to a csv file | 15:21 |
sballe_ | ok the reason I was asking is that I do not have mosnaca | 15:22 |
jed56 | : ) | 15:22 |
jed56 | what do you have ? | 15:22 |
sballe_ | I just wanted the data on a CVS file so our data scientist can look at t | 15:22 |
jed56 | ah : ) | 15:22 |
*** jwcroppe has quit IRC | 15:23 | |
jed56 | you should extract the data from a cloud infrastructure in production | 15:23 |
jed56 | if you have an Openstack deployement with Ceilometer. you can also call his API | 15:24 |
*** danpawlik has quit IRC | 15:28 | |
sballe_ | yeah I could do it with Ceilomter | 15:34 |
jed56 | okay you can maybe reuse https://github.com/openstack/watcher/blob/master/watcher/common/ceilometer_helper.py | 15:36 |
*** hvprash has quit IRC | 16:12 | |
*** hvprash has joined #openstack-watcher | 16:12 | |
*** michaelgugino has quit IRC | 16:24 | |
*** hvprash_ has joined #openstack-watcher | 16:38 | |
*** hvprash has quit IRC | 16:41 | |
*** michaelgugino has joined #openstack-watcher | 16:46 | |
*** M00nr41n has joined #openstack-watcher | 16:47 | |
*** Zucan has quit IRC | 17:15 | |
*** Zucan has joined #openstack-watcher | 18:07 | |
*** pkoniszewski has quit IRC | 18:45 | |
*** pkoniszewski has joined #openstack-watcher | 18:48 | |
*** Zucan has quit IRC | 18:49 | |
*** dtardivel has quit IRC | 19:57 | |
*** M00nr41n has quit IRC | 20:25 | |
*** thorst has quit IRC | 20:56 | |
*** thorst has joined #openstack-watcher | 21:03 | |
*** thorst has quit IRC | 21:07 | |
*** thorst has joined #openstack-watcher | 21:35 | |
*** thorst_ has joined #openstack-watcher | 21:39 | |
*** thorst has quit IRC | 21:39 | |
*** michaelgugino has quit IRC | 21:41 | |
*** hvprash_ has quit IRC | 21:43 | |
*** thorst_ has quit IRC | 21:43 | |
*** dronshaw has quit IRC | 23:51 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!