*** thorst has joined #openstack-watcher | 00:48 | |
*** thorst has quit IRC | 00:56 | |
*** esberglu has joined #openstack-watcher | 01:36 | |
*** thorst has joined #openstack-watcher | 01:53 | |
*** thorst has quit IRC | 01:59 | |
*** esberglu has quit IRC | 02:00 | |
*** thorst has joined #openstack-watcher | 02:05 | |
*** thorst has quit IRC | 02:11 | |
openstackgerrit | Edwin Zhai proposed openstack/python-watcherclient: Revert "Add support continuously-optimization" https://review.openstack.org/333090 | 02:41 |
---|---|---|
hanrong1 | https://blueprints.launchpad.net/watcher/+spec/watcher-policies Does this bp need to submit a spec file before writing code? | 02:51 |
*** thorst has joined #openstack-watcher | 03:16 | |
*** thorst has quit IRC | 03:21 | |
*** thorst has joined #openstack-watcher | 04:19 | |
*** thorst has quit IRC | 04:25 | |
*** ecelik has joined #openstack-watcher | 05:22 | |
*** thorst has joined #openstack-watcher | 05:23 | |
*** thorst has quit IRC | 05:31 | |
*** Kevin_Zheng has joined #openstack-watcher | 06:08 | |
*** thorst has joined #openstack-watcher | 06:28 | |
*** thorst has quit IRC | 06:36 | |
*** vtech has joined #openstack-watcher | 06:58 | |
jed56 | hanrong1: no you don't need a blueprint | 07:08 |
jed56 | Good UTC Moorning | 07:08 |
*** brunograz has joined #openstack-watcher | 07:25 | |
*** vincentfrancoise has joined #openstack-watcher | 07:28 | |
*** thorst has joined #openstack-watcher | 07:34 | |
openstackgerrit | Merged openstack/watcher: Centralize plugin loaders in decision engine https://review.openstack.org/332624 | 07:38 |
*** thorst has quit IRC | 07:41 | |
openstackgerrit | Tin Lam proposed openstack/watcher: Centralize plugin loaders in watcher/applier https://review.openstack.org/332627 | 07:51 |
*** alexchadin has joined #openstack-watcher | 07:54 | |
alexchadin | vincentfrancoise: hi! | 07:54 |
alexchadin | how are you? :) | 07:54 |
*** alexchadin has quit IRC | 08:05 | |
*** alexchadin has joined #openstack-watcher | 08:05 | |
hanrong1 | jed56:hi, don't need a blueprint? | 08:12 |
*** alexstav has joined #openstack-watcher | 08:18 | |
alexstav | Hi, guys! Review my bug fix, please :) https://review.openstack.org/#/c/332241/ | 08:18 |
*** alexchadin has quit IRC | 08:22 | |
vincentfrancoise | hi | 08:22 |
*** alexchadin has joined #openstack-watcher | 08:22 | |
*** dtardivel has joined #openstack-watcher | 08:23 | |
dtardivel | hanrong1: Hi | 08:23 |
*** acabot has quit IRC | 08:26 | |
*** acabot has joined #openstack-watcher | 08:29 | |
hanrong1 | dtardivel:hi | 08:38 |
*** thorst has joined #openstack-watcher | 08:39 | |
hanrong1 | https://blueprints.launchpad.net/watcher/+spec/watcher-policies Does this bp need to submit a spec file before writing code? | 08:39 |
dtardivel | IMHO, I don't think so. | 08:39 |
dtardivel | Spec is not mandatory, when the BP is simple and cleat. | 08:39 |
dtardivel | clear | 08:39 |
hanrong1 | dtardivel: ok, I will submit a patch code. | 08:40 |
dtardivel | Do you want we discuss about this feature to implement ? | 08:40 |
dtardivel | ok, I will review it . | 08:41 |
alexchadin | tpeoples: hi | 08:43 |
alexchadin | tpeoples: are you working on https://bugs.launchpad.net/watcher/+bug/1533392 ? | 08:43 |
openstack | Launchpad bug 1533392 in watcher "Fields should not be named the built-in type keyword" [Low,Triaged] - Assigned to Taylor Peoples (tpeoples) | 08:43 |
*** thorst has quit IRC | 08:46 | |
hanrong1 | dtardivel: All the actions should be performed by only admin in watcher project. It's similar to ironic project. | 08:48 |
hanrong1 | dtardivel: So policy.json file doesn't need to modified. | 08:49 |
jed56 | alexchadin: hello | 08:50 |
alexchadin | jed56: good morning | 08:51 |
jed56 | alexchadin: how are you ? | 08:51 |
alexchadin | jed56: I'm fine, are you? | 08:51 |
jed56 | very well thanks you | 08:51 |
jed56 | Regarding the continuous optimization. There is too many decisions in the patchset Add Oslo Versioned Object + Indirection API | 08:52 |
jed56 | so, we can't merge it quickly | 08:52 |
jed56 | so, for the version of continuous audit | 08:52 |
jed56 | we will not use events | 08:52 |
jed56 | You just to add a periodic task in charge of updating the audit status | 08:53 |
jed56 | *need | 08:53 |
alexchadin | hm | 08:53 |
jed56 | what do you think ? | 08:54 |
alexchadin | you propose to remove any using of APScheduler? | 08:54 |
jed56 | No, you have to kepp APScheduler | 08:54 |
jed56 | keep | 08:54 |
alexchadin | let me see the code | 08:54 |
jed56 | only the even driven | 08:54 |
jed56 | I think that you code is already doing that | 08:55 |
jed56 | alexchadin: I will review it today | 08:56 |
alexchadin | wwwwait :D | 08:56 |
jed56 | vincentfrancoise: could you also review it today ? | 08:56 |
alexchadin | are you speaking about updating audit state? | 08:57 |
jed56 | alexchadin: yes | 08:57 |
vincentfrancoise | jed56 alexchadin: yes I'll do it | 08:57 |
jed56 | vincentfrancoise: thanks | 08:57 |
vincentfrancoise | So as a quick recap | 08:58 |
vincentfrancoise | alexchadin doesn't do the notification part of his BP | 08:58 |
vincentfrancoise | we create a BP + spec for oslo versionedobjects and notifications | 08:59 |
vincentfrancoise | when it gets implemented | 08:59 |
vincentfrancoise | we can add back the notification system to make it even driven | 08:59 |
vincentfrancoise | is that right? | 08:59 |
alexchadin | Looks good | 08:59 |
vincentfrancoise | jed56: ^ | 08:59 |
alexchadin | vincentfrancoise: may I ask you some questions regarding test_objects? | 09:00 |
jed56 | vincentfrancoise: yes exactly | 09:00 |
vincentfrancoise | alexchadin: what about it? | 09:00 |
alexchadin | jed56: could you advise some little and easy BP for my trainee? | 09:01 |
alexchadin | vincentfrancoise: for example test_obj_to_primitive_list | 09:01 |
jed56 | alexchadin: let me take a look | 09:01 |
alexchadin | I see that we don't have obj_to_primitive_list method anymore | 09:01 |
alexchadin | Don't we use this method anymore? | 09:02 |
vincentfrancoise | alexchadin: how about https://blueprints.launchpad.net/python-watcherclient/+spec/tempest-cli-test ? | 09:03 |
jed56 | vincentfrancoise: +1 | 09:03 |
vincentfrancoise | it will take some time to do it but I don't think it will be too complicated | 09:03 |
alexchadin | vincentfrancoise: I agree | 09:04 |
alexchadin | vincentfrancoise: Tests are good starting point | 09:04 |
jed56 | the functional tests are always a good start | 09:04 |
alexchadin | jed56: +1 | 09:04 |
vincentfrancoise | alexchadin: about obj_to_primitive_list, we are doing list comprehensions wherever needed instead | 09:05 |
alexchadin | As I understand, most work with objects is handled by OVO now | 09:06 |
dtardivel | hanrong1: I prefer the magnum approach. Did you see it ? https://github.com/openstack/magnum/blob/master/etc/magnum/policy.json | 09:06 |
vincentfrancoise | alexchadin: I amended the CLI tempest test BP to add the doc link and a github repo which has done CLI tempest tests already | 09:08 |
dtardivel | hanrong1: With this code, an admin can defined another admin roles: one the creators of audit templates, another one for the guy who will launch an audit ... | 09:09 |
vincentfrancoise | alexchadin: Yes, OVO simplifies quite a lot the logic we previously had in Watcher | 09:09 |
alexchadin | vincentfrancoise: thank you so much, I sent to him this BP | 09:10 |
dtardivel | hanrong1: and the policy check is very easy to implement: https://github.com/openstack/magnum/blob/cd1297148ba6906be44c46e3cf22377c704a6046/magnum/api/controllers/v1/baymodel.py#L265 | 09:10 |
alexchadin | vincentfrancoise: so, I think we have to remove all the test methods that we don't have now | 09:11 |
alexchadin | all the tests for methods* | 09:12 |
hanrong1 | dtardivel: Thank you very much. | 09:12 |
dtardivel | hanrong1: you're welcome | 09:13 |
*** thorst has joined #openstack-watcher | 09:44 | |
*** thorst has quit IRC | 09:51 | |
*** alexstav has quit IRC | 10:06 | |
openstackgerrit | Vincent Françoise proposed openstack/watcher-specs: Cluster model objects wrapper https://review.openstack.org/287019 | 10:11 |
*** vtech has quit IRC | 10:11 | |
*** vtech has joined #openstack-watcher | 10:12 | |
*** vincentfrancoise has quit IRC | 10:15 | |
openstackgerrit | Edwin Zhai proposed openstack/watcher: Enable strategy parameters https://review.openstack.org/297556 | 10:31 |
*** thorst has joined #openstack-watcher | 10:49 | |
*** thorst has quit IRC | 10:56 | |
*** alexchadin has quit IRC | 11:14 | |
*** vtech has quit IRC | 11:22 | |
*** thorst has joined #openstack-watcher | 11:41 | |
openstackgerrit | Jean-Emile DARTOIS proposed openstack/watcher-specs: Update the continuously optimization spec. https://review.openstack.org/330021 | 12:11 |
*** vtech has joined #openstack-watcher | 12:11 | |
openstackgerrit | Jean-Emile DARTOIS proposed openstack/watcher-specs: Update the continuously optimization spec. https://review.openstack.org/330021 | 12:16 |
*** vincentfrancoise has joined #openstack-watcher | 12:21 | |
*** alexstav has joined #openstack-watcher | 12:48 | |
openstackgerrit | Merged openstack/watcher: Centralize plugin loaders in watcher/applier https://review.openstack.org/332627 | 13:00 |
*** alexchadin has joined #openstack-watcher | 13:20 | |
alexstav | vincentfrancoise: thanks for review! What does it need for merging? :) | 13:21 |
vincentfrancoise | alexstav: another core reviewers needs to validate it as well | 13:28 |
openstackgerrit | Vincent Françoise proposed openstack/python-watcherclient: Restore "Add support continuously-optimization" https://review.openstack.org/333356 | 13:35 |
*** esberglu has joined #openstack-watcher | 13:37 | |
*** hvprash has joined #openstack-watcher | 13:51 | |
*** esberglu has quit IRC | 13:55 | |
*** hvprash_ has joined #openstack-watcher | 13:56 | |
*** hvprash has quit IRC | 13:59 | |
*** esberglu has joined #openstack-watcher | 14:02 | |
*** esberglu has quit IRC | 14:02 | |
openstackgerrit | Alexander Chadin proposed openstack/watcher: Add rally-jobs folder to get rally support https://review.openstack.org/333371 | 14:14 |
*** hvprash has joined #openstack-watcher | 14:19 | |
*** hvprash__ has joined #openstack-watcher | 14:20 | |
*** hvprash_ has quit IRC | 14:22 | |
*** vtech has quit IRC | 14:23 | |
*** hvprash has quit IRC | 14:24 | |
openstackgerrit | Alexander Chadin proposed openstack/watcher: Add rally-jobs folder to get rally support https://review.openstack.org/333371 | 14:39 |
*** hvprash__ has quit IRC | 14:51 | |
*** hvprash has joined #openstack-watcher | 14:54 | |
*** esberglu has joined #openstack-watcher | 15:08 | |
*** ostroverkhov has joined #openstack-watcher | 15:19 | |
vincentfrancoise | alexchadin: are you there? | 15:21 |
alexchadin | vincentfrancoise: hi again | 15:21 |
vincentfrancoise | regarding the rally changeset you made | 15:21 |
alexchadin | vincentfrancoise: yes? | 15:22 |
vincentfrancoise | are you planning on creating a new rally job for the gate? | 15:22 |
alexchadin | yes | 15:22 |
vincentfrancoise | ok cool | 15:23 |
vincentfrancoise | then can you do it like for the tempest job: both non-voting and experimental for now ? | 15:24 |
alexchadin | Yes, of course | 15:24 |
vincentfrancoise | can you put me as reviewer on it once you push it to project-config? | 15:24 |
alexchadin | vincentfrancoise: will do | 15:25 |
alexchadin | Do you have experience with gates? | 15:25 |
vincentfrancoise | a bit yes | 15:25 |
alexchadin | Is there any way to test gates before submitting? | 15:25 |
vincentfrancoise | not really ^^ | 15:26 |
alexchadin | woah | 15:26 |
vincentfrancoise | you have to "mentally" test it | 15:26 |
vincentfrancoise | unless you have a full replica of zuul and stuff | 15:27 |
alexchadin | I also thought so | 15:27 |
alexchadin | Could you give me link | 15:28 |
alexchadin | with your gate commit? | 15:28 |
*** alexstav has quit IRC | 15:29 | |
*** alexstav has joined #openstack-watcher | 15:30 | |
vincentfrancoise | https://review.openstack.org/#/q/project:openstack-infra/project-config+owner:v-francoise | 15:30 |
*** alexstav_ has joined #openstack-watcher | 15:32 | |
*** alexstav has quit IRC | 15:33 | |
alexchadin | vincentfrancoise: thanks :) | 15:36 |
openstackgerrit | Merged openstack/watcher: Add importing modules instead of classes https://review.openstack.org/332241 | 15:39 |
ostroverkhov | vincentfrancoise: hi, this commit https://review.openstack.org/#/c/331552/ is already merged, but it depend on https://review.openstack.org/#/c/331551/ witch is not merged yet. I think there could be problems :( | 15:39 |
jed56 | alexchadin: we discussed with vincentfrancoise about the implement of continuous is going to propose some few modifications | 15:48 |
alexchadin | jed56: I'm listening | 15:48 |
jed56 | vincentfrancoise is currently making the comments on the patchset | 15:50 |
jed56 | :) | 15:50 |
alexchadin | jed56: cool ;) | 15:50 |
jed56 | alexstav_ and ostroverkhov you are now member of watcher-drivers | 15:50 |
alexchadin | congrats! | 15:50 |
alexstav_ | jed56: thanks! | 15:50 |
jed56 | welcome is great to have new contributors ! | 15:51 |
ostroverkhov | s/witch/which | 15:51 |
ostroverkhov | jed56: thanks! | 15:51 |
alexchadin | vincentfrancoise: are you here? | 15:55 |
vincentfrancoise | alexchadin: yeah | 15:55 |
vincentfrancoise | alexchadin: I am writing comments on your continuously-optimization patchset | 15:57 |
alexchadin | whether should I add gate-rally-dsvm-watcher to check or experimental branch? | 15:57 |
vincentfrancoise | after discussing it with jed56 | 15:57 |
vincentfrancoise | but it takes a bit of time | 15:57 |
alexchadin | It is non-voting | 15:57 |
vincentfrancoise | experimental first | 15:58 |
alexchadin | We don't have any experimental gates for now, right? | 15:58 |
vincentfrancoise | then after a couple of weeks, if we see there's no issue, we can move on to make it 'check' | 15:58 |
alexchadin | vincentfrancoise: cool, got it | 15:59 |
vincentfrancoise | we had experimental jobs before | 16:00 |
vincentfrancoise | the gate-dsvm-multinode-watcher one | 16:00 |
*** alexstav_ has quit IRC | 16:22 | |
*** alexstav has joined #openstack-watcher | 16:23 | |
vincentfrancoise | ostroverkhov: hi | 16:27 |
vincentfrancoise | are you still there ? | 16:28 |
ostroverkhov | yes | 16:28 |
*** esberglu has quit IRC | 16:28 | |
*** esberglu has joined #openstack-watcher | 16:32 | |
*** vincentfrancoise has quit IRC | 16:33 | |
*** ostroverkhov has quit IRC | 16:38 | |
*** ostroverkhov has joined #openstack-watcher | 16:38 | |
*** ostroverkhov has quit IRC | 16:39 | |
*** alexstav has quit IRC | 16:47 | |
*** alexchadin has quit IRC | 16:48 | |
*** esberglu_ has joined #openstack-watcher | 17:04 | |
*** esberglu has quit IRC | 17:07 | |
*** esberglu_ has quit IRC | 17:10 | |
*** hvprash has quit IRC | 17:10 | |
*** esberglu has joined #openstack-watcher | 17:12 | |
*** ostroverkhov has joined #openstack-watcher | 17:25 | |
*** ostroverkhov has quit IRC | 17:27 | |
*** hvprash has joined #openstack-watcher | 17:28 | |
*** hvprash has quit IRC | 17:33 | |
*** wootehfoot has joined #openstack-watcher | 17:35 | |
*** hvprash has joined #openstack-watcher | 17:54 | |
*** thorst is now known as thorst_away | 18:55 | |
*** dtardivel has quit IRC | 19:57 | |
*** zigo has quit IRC | 20:27 | |
*** junjie has quit IRC | 20:27 | |
*** odyssey4me has quit IRC | 20:27 | |
*** odyssey4me has joined #openstack-watcher | 20:28 | |
*** zigo has joined #openstack-watcher | 20:29 | |
*** junjie has joined #openstack-watcher | 20:31 | |
*** thorst_away has quit IRC | 21:10 | |
*** thorst_away has joined #openstack-watcher | 21:13 | |
*** thorst_a_ has joined #openstack-watcher | 21:15 | |
*** thorst_away has quit IRC | 21:17 | |
*** thorst_a_ has quit IRC | 21:19 | |
*** esberglu has quit IRC | 21:27 | |
openstackgerrit | Merged openstack/puppet-watcher: Implement api.pp https://review.openstack.org/329830 | 21:28 |
*** thorst_away has joined #openstack-watcher | 21:38 | |
*** thorst_away has quit IRC | 21:43 | |
*** thorst_away has joined #openstack-watcher | 21:43 | |
*** thorst_away has quit IRC | 21:47 | |
*** esberglu has joined #openstack-watcher | 21:48 | |
*** hvprash_ has joined #openstack-watcher | 22:25 | |
*** hvprash has quit IRC | 22:28 | |
*** hvprash_ has quit IRC | 22:31 | |
*** hvprash has joined #openstack-watcher | 22:43 | |
*** hvprash has quit IRC | 22:44 | |
*** hvprash has joined #openstack-watcher | 22:48 | |
*** hvprash has quit IRC | 22:52 | |
*** wootehfoot has quit IRC | 23:12 | |
*** vtech has joined #openstack-watcher | 23:22 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!