| *** thorst has quit IRC | 00:06 | |
| *** thorst has joined #openstack-watcher | 01:04 | |
| *** thorst has quit IRC | 01:11 | |
| *** thorst has joined #openstack-watcher | 01:15 | |
| *** thorst has quit IRC | 01:16 | |
| *** esberglu has quit IRC | 01:43 | |
| openstackgerrit | Merged openstack/watcher: Removed unused function in uniform airflow https://review.openstack.org/351163 | 01:43 |
|---|---|---|
| *** esberglu has joined #openstack-watcher | 02:14 | |
| *** thorst has joined #openstack-watcher | 02:17 | |
| *** thorst has quit IRC | 02:25 | |
| *** esberglu has quit IRC | 02:35 | |
| *** thorst has joined #openstack-watcher | 02:43 | |
| *** thorst has quit IRC | 02:43 | |
| *** esberglu has joined #openstack-watcher | 02:58 | |
| *** esberglu has quit IRC | 02:59 | |
| *** thorst has joined #openstack-watcher | 03:44 | |
| *** thorst has quit IRC | 03:52 | |
| *** gzhai has quit IRC | 03:55 | |
| *** gzhai has joined #openstack-watcher | 03:55 | |
| *** esberglu has joined #openstack-watcher | 03:55 | |
| *** esberglu has quit IRC | 04:02 | |
| *** thorst has joined #openstack-watcher | 04:51 | |
| *** thorst has quit IRC | 04:58 | |
| *** gzhai has quit IRC | 04:58 | |
| *** gzhai has joined #openstack-watcher | 04:59 | |
| *** gzhai has quit IRC | 05:00 | |
| *** gzhai has joined #openstack-watcher | 05:00 | |
| *** jwcroppe has joined #openstack-watcher | 05:11 | |
| *** jwcroppe has quit IRC | 05:51 | |
| *** thorst has joined #openstack-watcher | 05:56 | |
| *** thorst has quit IRC | 06:03 | |
| *** ecelik has joined #openstack-watcher | 06:07 | |
| *** jimbaker has quit IRC | 06:19 | |
| *** jimbaker has joined #openstack-watcher | 06:23 | |
| *** jimbaker has quit IRC | 06:23 | |
| *** jimbaker has joined #openstack-watcher | 06:23 | |
| *** diga has joined #openstack-watcher | 06:34 | |
| *** danpawlik has joined #openstack-watcher | 06:44 | |
| *** thorst has joined #openstack-watcher | 07:01 | |
| *** thorst has quit IRC | 07:08 | |
| *** jimbaker has quit IRC | 07:16 | |
| *** jimbaker has joined #openstack-watcher | 07:19 | |
| *** jimbaker has quit IRC | 07:20 | |
| *** jimbaker has joined #openstack-watcher | 07:20 | |
| *** vincentfrancoise has joined #openstack-watcher | 07:34 | |
| *** openstackgerrit has quit IRC | 08:03 | |
| *** openstackgerrit has joined #openstack-watcher | 08:03 | |
| *** thorst has joined #openstack-watcher | 08:08 | |
| *** thorst has quit IRC | 08:13 | |
| *** gzhai has quit IRC | 08:21 | |
| openstackgerrit | Tomasz Kaczynski proposed openstack/watcher: Add Scoring Module implementation https://review.openstack.org/351577 | 08:46 |
| *** thorst has joined #openstack-watcher | 09:10 | |
| *** thorst has quit IRC | 09:18 | |
| vincentfrancoise | hi tkaczynski | 09:51 |
| tkaczynski | hi vincentfrancoise | 09:52 |
| vincentfrancoise | I started reading your code on the scoring engine | 09:52 |
| tkaczynski | +1 :) | 09:52 |
| vincentfrancoise | and I was wondering if you tested the dynamic reload that I see in https://review.openstack.org/#/c/351577/1/watcher/decision_engine/scoring/scoring_factory.py | 09:52 |
| vincentfrancoise | I mean without restarting Watcher | 09:53 |
| tkaczynski | yes, I tested | 09:53 |
| tkaczynski | essentially, this reload is being called from Sync class. I tested it using watcher-sync script | 09:55 |
| vincentfrancoise | but if you add a new scoring engine in the SEcontainer | 09:55 |
| vincentfrancoise | can you then execute it? | 09:55 |
| vincentfrancoise | I asking because by default, python caches the modules that were already loaded | 09:56 |
| vincentfrancoise | so the watcher-sync works because it is in a separate process | 09:56 |
| vincentfrancoise | but the currently one would not see the newly synced SE code | 09:56 |
| vincentfrancoise | at least that is my guess | 09:56 |
| tkaczynski | so the SE container is returning the instances, not classes. the idea behind this dynamic behavior is that this list can be dynamic and configuration driven | 09:57 |
| tkaczynski | I guess it won't be possible to change the implementation "on the fly". it it's possible to change some DB configuration and then for example instantiate some additional scoring engines | 09:58 |
| tkaczynski | of course using the same already loaded class | 09:58 |
| tkaczynski | please look at this: https://review.openstack.org/#/c/351577/1/watcher/decision_engine/scoring/scoring_container.py | 09:59 |
| tkaczynski | sorry, wrong link: https://review.openstack.org/#/c/351577/1/watcher/decision_engine/scoring/dummy_scoring_container.py | 10:00 |
| vincentfrancoise | in the 1st link you say "dynamic reloading of Scoring Engineimplementations without having to restart any Watcher services" | 10:00 |
| vincentfrancoise | that's why I was asking about this | 10:01 |
| tkaczynski | there is SimpleFunctionScorer, which implements a generic scoring engine (takes a function as an argument) | 10:01 |
| tkaczynski | imagine that this can be based on some config and for example be a proxy to some scoring engine running in the cloud | 10:01 |
| tkaczynski | yes, but there is no magic - I don't plan to change the code on the fly, but I plan to change the configuration based on which the code is running | 10:02 |
| tkaczynski | (I need to go now, be back in 1 hour if you still need me) | 10:03 |
| vincentfrancoise | that's what I thaught | 10:03 |
| vincentfrancoise | ok no pb | 10:03 |
| vincentfrancoise | will continue making comments | 10:03 |
| vincentfrancoise | most is styling issues | 10:03 |
| *** thorst has joined #openstack-watcher | 10:16 | |
| *** thorst has quit IRC | 10:23 | |
| tkaczynski | sure, did my best, but I'm still new to python etc. | 11:03 |
| tkaczynski | vincentfrancoise: long list :) thanks for taking time on this review, I will address all points | 11:07 |
| *** thorst has joined #openstack-watcher | 11:20 | |
| *** thorst has quit IRC | 11:28 | |
| *** thorst has joined #openstack-watcher | 11:48 | |
| vincentfrancoise | tkaczynski: yeah but most of it is just aesthetic comments | 12:09 |
| *** thorst_ has joined #openstack-watcher | 12:45 | |
| *** thorst has quit IRC | 12:49 | |
| *** edleafe is now known as figleaf | 12:51 | |
| *** diga has quit IRC | 13:07 | |
| *** esberglu has joined #openstack-watcher | 13:12 | |
| *** hvprash has joined #openstack-watcher | 13:19 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Add Oslo Versioned Object + Indirection API https://review.openstack.org/327793 | 13:20 |
| *** akijak has left #openstack-watcher | 13:22 | |
| *** hvprash_ has joined #openstack-watcher | 13:25 | |
| *** hvprash has quit IRC | 13:28 | |
| *** hvprash_ has quit IRC | 13:32 | |
| *** hvprash has joined #openstack-watcher | 13:33 | |
| *** jwcroppe has joined #openstack-watcher | 13:33 | |
| *** hvprash_ has joined #openstack-watcher | 13:37 | |
| *** hvprash has quit IRC | 13:40 | |
| *** danpawlik has quit IRC | 13:42 | |
| *** michaelgugino has joined #openstack-watcher | 13:53 | |
| *** ecelik has quit IRC | 13:54 | |
| openstackgerrit | Tomasz Kaczynski proposed openstack/watcher: Add Scoring Module implementation https://review.openstack.org/351577 | 13:59 |
| *** hvprash has joined #openstack-watcher | 14:01 | |
| *** hvprash_ has quit IRC | 14:02 | |
| *** openstackgerrit has quit IRC | 14:03 | |
| *** openstackgerrit has joined #openstack-watcher | 14:03 | |
| *** hvprash has quit IRC | 14:03 | |
| *** hvprash has joined #openstack-watcher | 14:04 | |
| *** hvprash has quit IRC | 14:04 | |
| *** hvprash has joined #openstack-watcher | 14:04 | |
| *** hvprash has quit IRC | 14:15 | |
| *** hvprash_ has joined #openstack-watcher | 14:15 | |
| *** AndroUser2 has joined #openstack-watcher | 15:10 | |
| *** jwcroppe has quit IRC | 15:12 | |
| *** jwcroppe has joined #openstack-watcher | 15:13 | |
| *** vincentfrancoise has quit IRC | 15:35 | |
| *** jimbaker has quit IRC | 16:11 | |
| *** jimbaker has joined #openstack-watcher | 16:15 | |
| *** jimbaker has quit IRC | 16:15 | |
| *** jimbaker has joined #openstack-watcher | 16:15 | |
| *** AndroUser2 has quit IRC | 16:37 | |
| *** jed56 has quit IRC | 17:35 | |
| *** vincentfrancoise has joined #openstack-watcher | 18:48 | |
| *** esberglu has quit IRC | 18:53 | |
| *** jimbaker has quit IRC | 18:58 | |
| *** jimbaker has joined #openstack-watcher | 19:02 | |
| *** jimbaker has quit IRC | 19:02 | |
| *** jimbaker has joined #openstack-watcher | 19:02 | |
| *** ss4 has joined #openstack-watcher | 19:05 | |
| *** esberglu has joined #openstack-watcher | 19:10 | |
| *** thorst__ has joined #openstack-watcher | 19:23 | |
| *** thorst_ has quit IRC | 19:26 | |
| *** thorst__ is now known as thorst_ | 19:26 | |
| *** thorst__ has joined #openstack-watcher | 20:16 | |
| *** thorst_ has quit IRC | 20:18 | |
| *** hvprash has joined #openstack-watcher | 20:25 | |
| *** hvprash_ has quit IRC | 20:26 | |
| *** hvprash_ has joined #openstack-watcher | 20:40 | |
| *** hvprash has quit IRC | 20:43 | |
| *** thorst__ has quit IRC | 20:46 | |
| *** thorst_ has joined #openstack-watcher | 20:50 | |
| *** thorst_ has quit IRC | 20:55 | |
| *** Metabulation has joined #openstack-watcher | 21:11 | |
| *** ss4 has quit IRC | 21:14 | |
| *** hvprash_ has quit IRC | 21:14 | |
| *** Metabulation has quit IRC | 21:20 | |
| *** michaelgugino has quit IRC | 21:28 | |
| *** vincentfrancoise has quit IRC | 21:32 | |
| *** figleaf is now known as edleafe | 21:54 | |
| *** esberglu has quit IRC | 23:52 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!