| *** thorst has quit IRC | 00:01 | |
| *** tri2sing has quit IRC | 00:01 | |
| *** thorst has joined #openstack-watcher | 00:30 | |
| *** thorst has quit IRC | 00:37 | |
| *** thorst has joined #openstack-watcher | 00:38 | |
| *** thorst has quit IRC | 00:46 | |
| *** thorst has joined #openstack-watcher | 01:18 | |
| *** thorst has quit IRC | 01:19 | |
| *** thorst has joined #openstack-watcher | 01:19 | |
| *** thorst has quit IRC | 01:28 | |
| *** thorst has joined #openstack-watcher | 01:55 | |
| *** thorst has quit IRC | 01:55 | |
| *** thorst has joined #openstack-watcher | 01:56 | |
| *** thorst has quit IRC | 02:04 | |
| *** thorst has joined #openstack-watcher | 02:16 | |
| *** thorst has quit IRC | 02:17 | |
| *** thorst has joined #openstack-watcher | 02:47 | |
| *** thorst has quit IRC | 02:52 | |
| *** thorst has joined #openstack-watcher | 02:53 | |
| *** thorst has quit IRC | 03:01 | |
| *** thorst has joined #openstack-watcher | 03:59 | |
| *** thorst has quit IRC | 04:07 | |
| *** thorst has joined #openstack-watcher | 05:04 | |
| *** gabor_antal has quit IRC | 05:08 | |
| *** thorst has quit IRC | 05:11 | |
| *** thorst has joined #openstack-watcher | 06:09 | |
| *** thorst has quit IRC | 06:16 | |
| *** tkaczynski_ has joined #openstack-watcher | 06:57 | |
| *** dtardivel has joined #openstack-watcher | 07:07 | |
| *** thorst has joined #openstack-watcher | 07:15 | |
| *** thorst has quit IRC | 07:21 | |
| openstackgerrit | Tomasz Kaczynski proposed openstack/watcher: Add Scoring Module implementation https://review.openstack.org/351577 | 07:24 |
|---|---|---|
| tkaczynski | good morning | 07:26 |
| vincentfrancoise | tkaczynski: hi | 07:27 |
| tkaczynski | are there plans to merge bp/scoring-module? | 07:27 |
| tkaczynski | acabot said that it should happen before 28th Aug, today is 26th and it's Friday... :) | 07:27 |
| vincentfrancoise | tkaczynski: there is | 07:30 |
| vincentfrancoise | we are about to | 07:30 |
| vincentfrancoise | but there was the merge conflict you just resolved | 07:30 |
| tkaczynski | yes, I've seen that today, so I fixed asap | 07:30 |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Doc on how to add notification endpoints https://review.openstack.org/358007 | 07:30 |
| vincentfrancoise | today is a big review/merge day :p | 07:31 |
| tkaczynski | ok, fingers crossed then :) | 07:31 |
| vincentfrancoise | tkaczynski: yup | 07:32 |
| tkaczynski | just wondering - I plan to also add some documentation, but not sure when it will be ready (few days I guess). does it mean that the doc won't be part of the release? | 07:32 |
| dtardivel | tkaczynski: I think if you can provide it next week, we will be able to include it in the release. | 07:34 |
| vincentfrancoise | tkaczynski: it won't be part of the n3 release but hopefully it will be in the newton-rc one | 07:35 |
| tkaczynski | I think it would be good to have it in newton (rc is fine with me), so we could completely close this blueprint. I will do my best to have it next week, will aim for tuesday-wednesday | 07:36 |
| vincentfrancoise | tkaczynski: we have to have some documentation by the end of newton for sure | 07:37 |
| *** danpawlik has joined #openstack-watcher | 07:46 | |
| *** tkaczynski_ has quit IRC | 08:03 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added tests on API hooks and related context https://review.openstack.org/357938 | 08:07 |
| *** openstackgerrit has quit IRC | 08:18 | |
| *** openstackgerrit has joined #openstack-watcher | 08:18 | |
| *** thorst has joined #openstack-watcher | 08:18 | |
| *** gzhai has quit IRC | 08:22 | |
| *** thorst has quit IRC | 08:26 | |
| openstackgerrit | gengchc2 proposed openstack/watcher: Correct watcher reraising of exception https://review.openstack.org/361003 | 09:05 |
| openstackgerrit | gengchc2 proposed openstack/watcher: Correct watcher reraising of exception https://review.openstack.org/361003 | 09:09 |
| *** thorst has joined #openstack-watcher | 09:24 | |
| *** gzhai has joined #openstack-watcher | 09:24 | |
| *** thorst has quit IRC | 09:31 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: [WIP] Added Versioned notification support for audits https://review.openstack.org/360008 | 09:39 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Refactored Watcher objects to use OVO https://review.openstack.org/359065 | 09:39 |
| openstackgerrit | Jinquan Ni proposed openstack/watcher: Check unspecified parameters create audit https://review.openstack.org/359818 | 09:41 |
| openstackgerrit | Antoine Cabot proposed openstack/watcher: [WIP] Add Audit Scope Handler https://review.openstack.org/359963 | 09:44 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: [WIP] Added Versioned notification support for audits https://review.openstack.org/360008 | 09:47 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Refactored Watcher objects to use OVO https://review.openstack.org/359065 | 09:47 |
| *** brunograz_ has quit IRC | 09:48 | |
| *** brunograz has joined #openstack-watcher | 09:48 | |
| openstackgerrit | Merged openstack/python-watcherclient: Add strategy name in action plan fields https://review.openstack.org/357734 | 09:53 |
| *** gzhai has quit IRC | 10:13 | |
| *** alexchadin has joined #openstack-watcher | 10:17 | |
| alexchadin | Hi | 10:17 |
| alexchadin | I will be at the workplace in one hour max | 10:18 |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Fix loading of plugin configuration parameters https://review.openstack.org/361058 | 10:18 |
| alexchadin | I will review Tomasz scoring module asap | 10:19 |
| vincentfrancoise | alexchadin: this is great | 10:19 |
| vincentfrancoise | if you have time, could you also go through my changesets? dtardivel already reviewed with +2 most of them | 10:20 |
| alexchadin | vincentfrancoise, could you please review scope module? | 10:20 |
| alexchadin | Ok, will do | 10:20 |
| *** gzhai has joined #openstack-watcher | 10:20 | |
| vincentfrancoise | alexchadin: yes I'll have a look this afternoon :) | 10:20 |
| alexchadin | Can we still push bug fixes in the following days? | 10:21 |
| vincentfrancoise | alexchadin: yes of course | 10:22 |
| alexchadin | Ok, my colleague will push some | 10:23 |
| vincentfrancoise | that's the whole point of the feature freeze, we try to stabilise things before the Newton release | 10:24 |
| alexchadin | When can we continue our work on features? | 10:26 |
| alexchadin | I mean reviewing and merging the bp implementations | 10:27 |
| alexchadin | Or we can still review new patch sets but not merge them | 10:34 |
| *** AndChat|176409 has joined #openstack-watcher | 10:44 | |
| *** alexchadin has quit IRC | 10:47 | |
| *** thorst has joined #openstack-watcher | 10:56 | |
| *** gzhai is now known as gzhai1 | 10:59 | |
| openstackgerrit | Jinquan Ni proposed openstack/watcher: Check unspecified parameters create audit https://review.openstack.org/359818 | 11:02 |
| *** gzhai1 has quit IRC | 11:14 | |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Update configuration section for notifications https://review.openstack.org/361092 | 11:16 |
| *** alexchadin has joined #openstack-watcher | 11:25 | |
| *** alexchadin has quit IRC | 11:42 | |
| *** AndChat|176409 has quit IRC | 12:04 | |
| *** alexchadin has joined #openstack-watcher | 12:25 | |
| alexchadin | hi tkaczynski | 12:33 |
| alexchadin | tkaczynski: ping | 12:33 |
| tkaczynski | alexchadin: hi | 12:34 |
| alexchadin | I'm reviewing your scoring engine and have a little question | 12:35 |
| tkaczynski | sure | 12:35 |
| alexchadin | What do you think about renaming scoring_engine.py to the base_engine.py? | 12:36 |
| tkaczynski | can I ask why? Is that not clear or against some convention? | 12:37 |
| *** jed56 has joined #openstack-watcher | 12:40 | |
| alexchadin | no, but we have features across the Watcher that have base.py module. It is more clear when you are looking enter point to the module and find base.py at once | 12:41 |
| alexchadin | It is not necessary to rename it right now | 12:41 |
| tkaczynski | I'm not too attached to the scoring_engine.py file name (I assume that you are talking about changing the name of the file only), I'm just not sure if this is the right moment for such change. it's supposed to be merged today and doing this kind of changes is quite risky at this point | 12:42 |
| alexchadin | Cause it is just a little wish to the following patches regarding scoring engine | 12:42 |
| vincentfrancoise | alexchadin, tkaczynski: I reckon we can keep it as is for now | 12:42 |
| *** edleafe is now known as figleaf | 12:42 | |
| vincentfrancoise | we can create a small bug to change this | 12:43 |
| alexchadin | +1 | 12:43 |
| alexchadin | ^ | 12:43 |
| alexchadin | later, not now | 12:43 |
| alexchadin | let me end my review | 12:43 |
| vincentfrancoise | but I agree about the naming convention | 12:43 |
| tkaczynski | as I said, I'm not too attached to this name. and as long as we will handle this separately, I don't mind doing this if there is a common agreement that this makes more sense | 12:44 |
| tkaczynski | I guess the same would have to be for scoring_container.py ? | 12:44 |
| alexchadin | +1 | 12:45 |
| tkaczynski | or maybe even just create base.py file with both classes? | 12:45 |
| alexchadin | we will discuss it later | 12:45 |
| alexchadin | I propose:) | 12:45 |
| vincentfrancoise | merging them but would be more sensible | 12:45 |
| vincentfrancoise | but yeah this is not really important for now | 12:46 |
| tkaczynski | no problem then, please file the bug then and I will fix it some time next week. would that work? :) | 12:46 |
| alexchadin | oh | 12:47 |
| alexchadin | wait | 12:47 |
| alexchadin | I want my colleague to fix this bug later | 12:47 |
| alexchadin | wouldn't you mind? | 12:47 |
| tkaczynski | I don't mind at all :) | 12:47 |
| alexchadin | ok | 12:47 |
| tkaczynski | but I guess it will be a breaking change. I'm implementing a plugin for scoring engine right now, so it would be good to have it fixed sooner rather than later | 12:48 |
| tkaczynski | also, the documentation is coming, which will have references to these files... it would also have to be updated | 12:49 |
| alexchadin | He will do it today | 12:50 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Added start/end date params on ceilometer queries https://review.openstack.org/358465 | 12:50 |
| tkaczynski | so the change will be merged as is, then fixed later today? | 12:50 |
| alexchadin | I guess yes | 12:51 |
| alexchadin | is it ok for you? | 12:51 |
| tkaczynski | great, so documentation (next week) will reference the fixed files. fine with me! | 12:51 |
| openstackgerrit | gengchc2 proposed openstack/watcher: Correct watcher reraising of exception https://review.openstack.org/361003 | 12:52 |
| alexchadin | tkaczynski: remind me - do we need to launch sync service once or it should work all the time? | 12:53 |
| tkaczynski | are you asking about watcher-sync script? | 12:54 |
| alexchadin | yeap | 12:54 |
| tkaczynski | it should work all the time. the intention is that somebody might implement a scoring engine plugin by extending ScoringContainer class, which might return different scoring engine list every time it's called (normally during sync) | 12:55 |
| tkaczynski | so it makes it possible that plugin will be more "dynamic", e.g. will return scoring engines based on its own configuration, then these changes can be re-synced and become immediately visible in the DB/API/CLI | 12:56 |
| tkaczynski | no decision engine restart is required then | 12:57 |
| alexchadin | Yeah, I see | 12:57 |
| alexchadin | It is clear for me right now:) | 12:57 |
| alexchadin | I have no questions anymore | 12:58 |
| alexchadin | It looks good to me | 12:58 |
| tkaczynski | no worries, if you need anything in the future please just ping me | 12:58 |
| alexchadin | sure! | 12:58 |
| alexchadin | tkaczynski: +2 | 13:02 |
| alexchadin | +1W | 13:02 |
| openstackgerrit | Merged openstack/watcher: Add Scoring Module implementation https://review.openstack.org/351577 | 13:04 |
| *** alexchadin has quit IRC | 13:15 | |
| *** michaelgugino has joined #openstack-watcher | 13:26 | |
| *** aswadr_ has joined #openstack-watcher | 13:28 | |
| *** alexchadin has joined #openstack-watcher | 13:43 | |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Added start/end date params on ceilometer queries https://review.openstack.org/358465 | 14:16 |
| openstackgerrit | Merged openstack/watcher: Correct watcher reraising of exception https://review.openstack.org/361003 | 14:16 |
| alexchadin | vincentfrancoise: ping | 14:17 |
| alexchadin | I think it would be good to use validator of jsonschema to validate audit scope schema | 14:17 |
| vincentfrancoise | alexchadin: why not yes | 14:18 |
| vincentfrancoise | alexchadin: I was reviewing your code | 14:18 |
| alexchadin | Mention it in your review | 14:18 |
| vincentfrancoise | and IMHO the BaseScope.__init__ should take the audit_scope schema directly | 14:19 |
| vincentfrancoise | we shouldn't need to reference the audit UUID into the strategy | 14:20 |
| vincentfrancoise | instead we can give it a scope as parameter which is already fed with the schema given in the audit | 14:21 |
| alexchadin | on base strategy level we can get audit object | 14:21 |
| alexchadin | and give audit.scope to the scope base class, right? | 14:21 |
| vincentfrancoise | in its __init__, yes | 14:22 |
| alexchadin | good point:) | 14:22 |
| vincentfrancoise | so that when you do the get_scoped_model() you don't need to specify the audit uuid anymore | 14:23 |
| alexchadin | yeap | 14:23 |
| vincentfrancoise | also the remove_instance() methods you did are very similar to mine in the cluster-data-model-wrapper so we should make sure only 1 version remains | 14:24 |
| vincentfrancoise | coffee break but will finish your review in a bit ;) | 14:24 |
| alexchadin | I will register new bug regarding our previous discussion | 14:25 |
| alexchadin | And I found another one | 14:25 |
| alexchadin | https://github.com/openstack/watcher/blob/master/watcher/common/nova_helper.py#L342 | 14:26 |
| alexchadin | This line is unreachable | 14:26 |
| alexchadin | I will register it too | 14:26 |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Update configuration section for notifications https://review.openstack.org/361092 | 14:37 |
| *** alexchadin has quit IRC | 14:44 | |
| *** alexchadin has joined #openstack-watcher | 14:44 | |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Refactored Watcher objects to use OVO https://review.openstack.org/359065 | 14:45 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Notification and CDM partial update https://review.openstack.org/357802 | 14:48 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Doc on how to add notification endpoints https://review.openstack.org/358007 | 14:48 |
| openstackgerrit | Viacheslav proposed openstack/watcher: Remove unreachable line https://review.openstack.org/361266 | 14:50 |
| openstackgerrit | Merged openstack/watcher: Check unspecified parameters create audit https://review.openstack.org/359818 | 14:53 |
| *** tri2sing has joined #openstack-watcher | 14:59 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Notification and CDM partial update https://review.openstack.org/357802 | 15:08 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Doc on how to add notification endpoints https://review.openstack.org/358007 | 15:08 |
| *** danpawlik has quit IRC | 15:26 | |
| openstackgerrit | Alexander Chadin proposed openstack/watcher: Add rally-jobs folder to get rally support https://review.openstack.org/333371 | 15:42 |
| *** alexchadin has quit IRC | 15:42 | |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Notification and CDM partial update https://review.openstack.org/357802 | 15:47 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Doc on how to add notification endpoints https://review.openstack.org/358007 | 15:47 |
| vincentfrancoise | FYI, I won't be there next week ;) | 15:51 |
| jed56 | me too ;-) | 15:53 |
| openstackgerrit | David TARDIVEL proposed openstack/watcher: Update configuration section for notifications https://review.openstack.org/361092 | 15:57 |
| openstackgerrit | Merged openstack/watcher: Remove unreachable line https://review.openstack.org/361266 | 16:16 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: Refactored Watcher objects to use OVO https://review.openstack.org/359065 | 16:17 |
| openstackgerrit | Merged openstack/python-watcherclient: Add again parameters as Audit creation attributes https://review.openstack.org/361230 | 16:24 |
| openstackgerrit | Merged openstack/watcher: Fix loading of plugin configuration parameters https://review.openstack.org/361058 | 16:26 |
| openstackgerrit | Vincent Françoise proposed openstack/watcher: PoC Bench https://review.openstack.org/361352 | 16:27 |
| openstackgerrit | Merged openstack/watcher: Added start/end date params on ceilometer queries https://review.openstack.org/358465 | 16:29 |
| *** vincentfrancoise has quit IRC | 16:34 | |
| openstackgerrit | Merged openstack/watcher: Notification and CDM partial update https://review.openstack.org/357802 | 17:01 |
| *** michaelgugino has quit IRC | 17:14 | |
| openstackgerrit | Merged openstack/watcher: Doc on how to add notification endpoints https://review.openstack.org/358007 | 17:22 |
| openstackgerrit | Merged openstack/watcher: Update configuration section for notifications https://review.openstack.org/361092 | 17:22 |
| *** aswadr_ has quit IRC | 17:31 | |
| openstackgerrit | Merged openstack/watcher: Add unit tests for continuous.py https://review.openstack.org/360336 | 17:44 |
| *** jed56 has quit IRC | 17:55 | |
| *** michaelgugino has joined #openstack-watcher | 18:23 | |
| *** dtardivel has quit IRC | 18:27 | |
| *** michaelgugino has quit IRC | 19:38 | |
| *** sballe_ has quit IRC | 20:00 | |
| *** sballe_ has joined #openstack-watcher | 20:47 | |
| *** thorst has quit IRC | 21:07 | |
| *** thorst has joined #openstack-watcher | 22:07 | |
| *** thorst has quit IRC | 22:11 | |
| *** sballe_ has quit IRC | 23:03 | |
| *** tri2sing has quit IRC | 23:08 | |
| *** figleaf is now known as edleafe | 23:19 | |
| *** sballe_ has joined #openstack-watcher | 23:29 | |
| *** sballe_ has quit IRC | 23:46 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!