| *** thorst has quit IRC | 00:25 | |
| *** thorst has joined #openstack-watcher | 00:26 | |
| *** thorst has quit IRC | 00:35 | |
| *** thorst has joined #openstack-watcher | 00:35 | |
| *** thorst_ has joined #openstack-watcher | 00:36 | |
| *** thorst has quit IRC | 00:39 | |
| *** thorst_ has quit IRC | 00:41 | |
| *** thorst has joined #openstack-watcher | 00:43 | |
| *** thorst has quit IRC | 00:48 | |
| *** thorst has joined #openstack-watcher | 01:03 | |
| *** eil397 has quit IRC | 01:07 | |
| *** thorst_ has joined #openstack-watcher | 01:07 | |
| *** thorst has quit IRC | 01:08 | |
| *** jwcroppe has quit IRC | 01:10 | |
| *** jwcroppe has joined #openstack-watcher | 01:10 | |
| *** yuanying has quit IRC | 01:11 | |
| *** yuanying has joined #openstack-watcher | 01:11 | |
| *** thorst_ has quit IRC | 01:12 | |
| *** thorst has joined #openstack-watcher | 01:35 | |
| *** thorst_ has joined #openstack-watcher | 01:38 | |
| *** thorst has quit IRC | 01:42 | |
| *** thorst_ has quit IRC | 01:44 | |
| *** thorst has joined #openstack-watcher | 01:49 | |
| *** thorst_ has joined #openstack-watcher | 01:51 | |
| *** thorst has quit IRC | 01:53 | |
| *** thorst has joined #openstack-watcher | 01:55 | |
| *** thorst_ has quit IRC | 01:56 | |
| *** thorst has quit IRC | 02:00 | |
| *** thorst has joined #openstack-watcher | 02:01 | |
| *** thorst has quit IRC | 02:06 | |
| *** thorst has joined #openstack-watcher | 02:11 | |
| *** yuanying has quit IRC | 02:11 | |
| *** thorst has quit IRC | 02:13 | |
| *** thorst has joined #openstack-watcher | 02:13 | |
| *** thorst has quit IRC | 02:23 | |
| *** thorst has joined #openstack-watcher | 02:25 | |
| *** thorst_ has joined #openstack-watcher | 02:40 | |
| *** thorst has quit IRC | 02:43 | |
| *** thorst has joined #openstack-watcher | 02:44 | |
| *** thorst_ has quit IRC | 02:45 | |
| *** thorst_ has joined #openstack-watcher | 02:53 | |
| *** thorst__ has joined #openstack-watcher | 02:55 | |
| *** thorst has quit IRC | 02:56 | |
| *** thorst_ has quit IRC | 02:58 | |
| *** thorst has joined #openstack-watcher | 02:58 | |
| *** thorst__ has quit IRC | 03:01 | |
| openstackgerrit | licanwei proposed openstack/watcher: Function call pass parameter error https://review.openstack.org/410010 | 03:03 |
|---|---|---|
| *** thorst_ has joined #openstack-watcher | 03:17 | |
| *** thorst has quit IRC | 03:19 | |
| *** thorst has joined #openstack-watcher | 03:19 | |
| *** thorst_ has quit IRC | 03:22 | |
| *** thorst_ has joined #openstack-watcher | 03:23 | |
| *** thorst has quit IRC | 03:27 | |
| *** thorst has joined #openstack-watcher | 03:36 | |
| *** thorst_ has quit IRC | 03:39 | |
| *** harlowja has quit IRC | 03:43 | |
| *** thorst has quit IRC | 03:44 | |
| *** thorst has joined #openstack-watcher | 03:51 | |
| *** thorst has quit IRC | 03:56 | |
| *** thorst has joined #openstack-watcher | 03:59 | |
| *** thorst has quit IRC | 04:04 | |
| *** harlowja has joined #openstack-watcher | 04:21 | |
| *** yuanying has joined #openstack-watcher | 04:33 | |
| *** thorst has joined #openstack-watcher | 05:02 | |
| *** harlowja has quit IRC | 05:08 | |
| *** thorst has quit IRC | 05:08 | |
| openstackgerrit | licanwei proposed openstack/watcher: Get disk_capacity from the statistics https://review.openstack.org/410045 | 05:21 |
| *** eil397 has joined #openstack-watcher | 05:22 | |
| *** harlowja has joined #openstack-watcher | 05:56 | |
| *** thorst has joined #openstack-watcher | 06:06 | |
| *** yuanying has quit IRC | 06:12 | |
| *** yuanying has joined #openstack-watcher | 06:12 | |
| *** yuanying has joined #openstack-watcher | 06:13 | |
| *** eil397 has quit IRC | 06:13 | |
| *** thorst has quit IRC | 06:13 | |
| *** yuanying has quit IRC | 06:17 | |
| *** atuly has joined #openstack-watcher | 06:19 | |
| atuly | For https://bugs.launchpad.net/watcher/+bug/1647927 | 06:20 |
| openstack | Launchpad bug 1647927 in watcher "TypeError if no input_parameters added" [Undecided,New] | 06:20 |
| atuly | Should we raise an exception if Attribute type is none | 06:20 |
| atuly | define a New eception InvalidType | 06:20 |
| atuly | or Something like InvalidAttribute | 06:21 |
| atuly | Let me know your thoughts | 06:22 |
| *** thorst has joined #openstack-watcher | 07:11 | |
| *** dtardivel has joined #openstack-watcher | 07:14 | |
| *** thorst has quit IRC | 07:19 | |
| *** harlowja has quit IRC | 07:25 | |
| *** atuly has quit IRC | 07:45 | |
| *** atuly has joined #openstack-watcher | 07:47 | |
| hidekazu | hi, atuly. | 07:50 |
| *** yuanying has joined #openstack-watcher | 07:51 | |
| atuly | hi hidekazu | 07:52 |
| hidekazu | i reported https://bugs.launchpad.net/watcher/+bug/1647927 | 07:52 |
| openstack | Launchpad bug 1647927 in watcher "TypeError if no input_parameters added" [Undecided,New] | 07:52 |
| atuly | Yes | 07:52 |
| atuly | Are you working on it ? | 07:52 |
| hidekazu | No, i am working on company work :) | 07:53 |
| hidekazu | are you? | 07:53 |
| hidekazu | if you are interested in this bug, please work on. | 07:54 |
| atuly | Okay :) | 07:55 |
| hidekazu | this bug is actually edge case: only resource_id is given. | 07:55 |
| atuly | In that case will it be okay to raise exception ? | 07:56 |
| hidekazu | I have an idea. | 07:56 |
| hidekazu | before https://github.com/openstack/watcher/blob/master/watcher/decision_engine/solution/default.py#L45 | 07:56 |
| hidekazu | simply add input_parameters = {} | 07:56 |
| hidekazu | i am against to raise exception. | 07:58 |
| atuly | okay | 08:00 |
| hidekazu | this bug is occured such a case that: solution.add_action(action_type=xxx,resource_id=yyy). | 08:00 |
| hidekazu | In real case, solution.add_action(action_type=xxx,resource_id=yyy, input_parameters=parameters). | 08:01 |
| hidekazu | real case is not bug case. | 08:02 |
| hidekazu | "no input_parameters" means that. | 08:02 |
| hidekazu | i wrote very simple case and hit the bug.. | 08:03 |
| atuly | Yes i am also checking in case where we would have passed without input_parameters | 08:03 |
| atuly | but yes it should also be handled. | 08:03 |
| hidekazu | actually for this bug, i am writing the following now: solution.add_action(action_type=xxx,resource_id=yyy, input_parameters={}) | 08:05 |
| hidekazu | simply added input_parameters={} :( | 08:06 |
| atuly | for testing i guess it better to handled before passing | 08:09 |
| atuly | in that case we might not have to do any changes in code. or as a preventive check can be added in def add_action() | 08:11 |
| hidekazu | atuly: i image this is simply logical bug in add_action() method. | 08:12 |
| hidekazu | atuly, some bugs in ocata-2 are assigned to you,though. | 08:16 |
| *** thorst has joined #openstack-watcher | 08:16 | |
| *** thorst has quit IRC | 08:23 | |
| openstackgerrit | licanwei proposed openstack/watcher: Function call pass parameter error https://review.openstack.org/410010 | 08:24 |
| *** alexchadin has joined #openstack-watcher | 08:30 | |
| openstackgerrit | Alexander Chadin proposed openstack/watcher: New default planner https://review.openstack.org/406991 | 08:44 |
| openstackgerrit | Alexander Chadin proposed openstack/watcher: New default planner https://review.openstack.org/406991 | 08:46 |
| *** exploreshaifali has joined #openstack-watcher | 08:49 | |
| *** atuly has quit IRC | 08:55 | |
| *** alexchadin has quit IRC | 09:18 | |
| *** alexchadin has joined #openstack-watcher | 09:19 | |
| *** thorst has joined #openstack-watcher | 09:21 | |
| alexchadin | acabot: could you please approve it? https://blueprints.launchpad.net/watcher/+spec/parallel-applier | 09:22 |
| *** thorst has quit IRC | 09:29 | |
| *** alexchadin has quit IRC | 09:39 | |
| *** alexchadin has joined #openstack-watcher | 09:39 | |
| *** yuanying has quit IRC | 09:47 | |
| *** alexchadin has quit IRC | 09:57 | |
| *** alexchadin has joined #openstack-watcher | 09:58 | |
| *** alexchadin has quit IRC | 10:03 | |
| *** alexchadin has joined #openstack-watcher | 10:03 | |
| *** alexchadin has quit IRC | 10:08 | |
| *** thorst has joined #openstack-watcher | 10:27 | |
| *** thorst has quit IRC | 10:34 | |
| *** alexchadin has joined #openstack-watcher | 10:41 | |
| *** alexchadin has quit IRC | 10:59 | |
| *** alexchadin has joined #openstack-watcher | 11:00 | |
| openstackgerrit | Merged openstack/watcher: improve statistic_aggregation https://review.openstack.org/409668 | 11:02 |
| *** thorst has joined #openstack-watcher | 11:32 | |
| *** thorst has quit IRC | 11:38 | |
| *** thorst has joined #openstack-watcher | 11:48 | |
| *** thorst has quit IRC | 11:53 | |
| openstackgerrit | Merged openstack/watcher: Unnecessary exception https://review.openstack.org/408437 | 12:00 |
| *** alexchadin has quit IRC | 12:01 | |
| *** alexchadin has joined #openstack-watcher | 12:01 | |
| sballe_ | Morning | 12:17 |
| sballe_ | Thc for the comments and +1s on https://review.openstack.org/#/c/404972/6 and https://review.openstack.org/#/c/404972/6 | 12:18 |
| sballe_ | dtardivel: can you please +2 my patches assuming you like them | 12:18 |
| *** thorst has joined #openstack-watcher | 12:19 | |
| *** alexchadin has quit IRC | 12:24 | |
| *** alexchadin has joined #openstack-watcher | 12:25 | |
| *** alexchadin has quit IRC | 12:26 | |
| *** alexchadin has joined #openstack-watcher | 12:26 | |
| *** alexchadin has quit IRC | 12:58 | |
| *** alexchadin has joined #openstack-watcher | 12:58 | |
| *** alexchadin has quit IRC | 12:59 | |
| *** alexchadin has joined #openstack-watcher | 12:59 | |
| *** alexchadin has quit IRC | 12:59 | |
| *** alexchadin has joined #openstack-watcher | 13:00 | |
| *** alexchadin has quit IRC | 13:02 | |
| *** exploreshaifali has quit IRC | 13:02 | |
| *** alexchadin has joined #openstack-watcher | 13:02 | |
| *** alexchadin has quit IRC | 13:02 | |
| *** alexchadin has joined #openstack-watcher | 13:03 | |
| *** alexchadin has quit IRC | 13:03 | |
| *** alexchadin has joined #openstack-watcher | 13:04 | |
| *** alexchadin has quit IRC | 13:09 | |
| *** lamt has joined #openstack-watcher | 14:03 | |
| *** jwcroppe has quit IRC | 14:31 | |
| *** jwcroppe has joined #openstack-watcher | 14:42 | |
| *** jwcroppe has quit IRC | 14:44 | |
| *** michaelgugino has joined #openstack-watcher | 14:45 | |
| *** jwcroppe has joined #openstack-watcher | 15:00 | |
| *** alexchadin has joined #openstack-watcher | 15:18 | |
| openstackgerrit | Merged openstack/watcher: Specific exception for stale cluster state was added. https://review.openstack.org/399202 | 15:35 |
| *** jwcroppe has quit IRC | 15:51 | |
| *** alexchadin has quit IRC | 15:59 | |
| *** alexchadin has joined #openstack-watcher | 15:59 | |
| *** alexchad_ has joined #openstack-watcher | 16:02 | |
| *** alexchadin has quit IRC | 16:03 | |
| *** alexchad_ has quit IRC | 16:05 | |
| *** eil397 has joined #openstack-watcher | 16:49 | |
| openstackgerrit | Amy Fong proposed openstack/watcher: multinode devstack update for live-migration https://review.openstack.org/410334 | 17:32 |
| *** thorst has quit IRC | 17:37 | |
| *** thorst has joined #openstack-watcher | 17:37 | |
| *** thorst has quit IRC | 17:42 | |
| *** dtardivel has quit IRC | 17:54 | |
| *** thorst has joined #openstack-watcher | 19:06 | |
| *** dtardivel has joined #openstack-watcher | 19:38 | |
| dtardivel | pshedimb: hi | 19:39 |
| pshedimb | dtardivel, hi | 19:44 |
| *** thorst has quit IRC | 19:46 | |
| dtardivel | will you have time to work on https://review.openstack.org/#/c/403923/ ? we release ocata-2 tomorrow, and I would like to merge your changesets on config ;) | 19:49 |
| pshedimb | dtardivel, yes. I'm working on it now. I have a question on it. | 19:50 |
| pshedimb | Should we have auth options for each client, inside their client file (like watcher/conf/cinder_client will have its specific auth) | 19:51 |
| pshedimb | or a common clients_auth | 19:52 |
| pshedimb | I'm not sure if what I did in client_auth(https://review.openstack.org/#/c/403923/4/watcher/conf/clients_auth.py) is correct. | 19:53 |
| pshedimb | dtardivel, any suggestion? | 20:00 |
| dtardivel | pshedimb: sorry my internet connection is not stable tonight. | 20:02 |
| dtardivel | we should have a common client_auth. It is used to initialize an unique session used after by any clients | 20:04 |
| pshedimb | Also I have one more question. | 20:06 |
| dtardivel | pshedimb: did you have a look on Ironic project here : https://github.com/openstack/ironic/blob/master/ironic/conf/auth.py | 20:06 |
| dtardivel | ? | 20:06 |
| pshedimb | dtardivel, nope. I was seeing conf options for nova project | 20:08 |
| pshedimb | I'll take a look at it now | 20:08 |
| pshedimb | Also, dtardivel one more question. | 20:08 |
| pshedimb | in bp, Vincent said he took conifg options from nova | 20:09 |
| pshedimb | And for watcher/cmd/dbmanage.py | 20:10 |
| pshedimb | dbmanage has sub command opts | 20:10 |
| pshedimb | And nova left all sub command opts in their original files (did not move to nova/conf) | 20:10 |
| pshedimb | Sub command opts register in cli_opt from whatever I have seen | 20:11 |
| pshedimb | So you still want me to move them to the conf file? | 20:12 |
| pshedimb | Do* | 20:12 |
| dtardivel | no. it is not done in ironic as well | 20:14 |
| pshedimb | okay. | 20:18 |
| pshedimb | Then I will fix the client+auth and push it soon | 20:18 |
| dtardivel | pshedimb: thx a lot. I will review it tomorrow morning (for me). good luck :) | 20:20 |
| pshedimb | okay. dtardivel | 20:20 |
| pshedimb | dtardivel, one final question | 20:20 |
| pshedimb | conf/_opts.py all the test cases use that. I got a comment from Rong Han that it should be removed. | 20:21 |
| pshedimb | Do I do that now? | 20:21 |
| dtardivel | Why should it be removed ? | 20:26 |
| pshedimb | i think after centralizing config options, it is not required. That was there before doing all this | 20:31 |
| dtardivel | ok | 20:35 |
| dtardivel | you can remove it if it is not used now | 20:37 |
| *** diga has joined #openstack-watcher | 20:43 | |
| *** diga has quit IRC | 22:19 | |
| *** lamt has quit IRC | 22:31 | |
| *** lamt has joined #openstack-watcher | 22:33 | |
| *** dtardivel has quit IRC | 23:04 | |
| openstackgerrit | Prudhvi Rao Shedimbi proposed openstack/watcher: Implemented clients and auth config module https://review.openstack.org/403923 | 23:24 |
| openstackgerrit | Prudhvi Rao Shedimbi proposed openstack/watcher: Implemented clients and auth config module https://review.openstack.org/403923 | 23:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!