openstackgerrit | Merged openstack/watcher-dashboard master: Imported Translations from Zanata https://review.openstack.org/482487 | 00:23 |
---|---|---|
*** thorst has joined #openstack-watcher | 00:29 | |
*** jwcroppe has joined #openstack-watcher | 00:29 | |
*** thorst has quit IRC | 00:33 | |
*** jwcroppe has quit IRC | 00:33 | |
*** jwcroppe has joined #openstack-watcher | 00:33 | |
*** deep-book-gk_ has joined #openstack-watcher | 00:34 | |
*** deep-book-gk_ has left #openstack-watcher | 00:37 | |
*** thorst has joined #openstack-watcher | 00:59 | |
*** thorst has quit IRC | 01:07 | |
openstackgerrit | Merged openstack/watcher master: Remove all sphinx warnings https://review.openstack.org/486619 | 01:07 |
*** harlowja has quit IRC | 01:29 | |
*** nicolasbock has joined #openstack-watcher | 04:04 | |
openstackgerrit | aditi sharma proposed openstack/watcher master: Validation of states for actionplan delete https://review.openstack.org/486007 | 04:33 |
*** hidekazu has joined #openstack-watcher | 04:38 | |
*** harlowja has joined #openstack-watcher | 04:40 | |
*** thorst has joined #openstack-watcher | 05:04 | |
*** thorst has quit IRC | 05:10 | |
openstackgerrit | Hidekazu Nakamura proposed openstack/watcher master: [Doc] Add Configure Cinder Notifications https://review.openstack.org/487280 | 05:38 |
*** harlowja has quit IRC | 05:39 | |
adisky__ | hidekazu: hii | 05:44 |
hidekazu | adisky__: hi | 05:44 |
adisky__ | hidekazu: as you can see https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/action_plan.py#L452 | 05:45 |
adisky__ | https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/audit.py#L604 | 05:45 |
adisky__ | there is no vakdiation for state transitions in both audits and action plan | 05:45 |
adisky__ | *validation | 05:45 |
hidekazu | adisky__: you mean validation of delete method | 05:46 |
adisky__ | yes | 05:46 |
hidekazu | adisky__* at reviewing , i said only validation patch method.. | 05:47 |
hidekazu | adisky__* at the same time, i found https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/action_plan.py#L505 | 05:48 |
hidekazu | adisky__* but i do not know we can check state transition using jsonschema api validation smartly | 05:49 |
hidekazu | adisky__* old days i heard ironic created strong state checker using python decorator. | 05:50 |
adisky__ | hidekazu: ok i will check with ironic. | 05:51 |
adisky__ | hidekazu: i found no blueprint for 'watcher-api-validation' as mentioned in TODO | 05:52 |
hidekazu | adisky__* if we can use jsonschema api validation, that is the best approach. ithink. | 05:52 |
hidekazu | adisky__: please take https://bugs.launchpad.net/watcher/+bug/1659556 into consideration. | 05:53 |
openstack | Launchpad bug 1659556 in watcher "Action plan continues to be recommended after updating continuous audit to oneshot" [Medium,Triaged] - Assigned to aditi sharma (adi-sky17) | 05:53 |
adisky__ | hidekazu: Then i need to study, and file blueperint for that | 05:53 |
adisky__ | hidekazu: yes i will take it into account | 05:55 |
hidekazu | adisky__: yeah, before ptg, i thought jsonschema-validation spec is for api validation. but now we do not have. | 05:57 |
adisky__ | ok will register | 05:57 |
adisky__ | hidekazu: I saw many projects implemening that | 05:57 |
hidekazu | adisky__: yes yes | 05:57 |
hidekazu | adisky__: even state transition not possible by api validation, api validation using jsonschema should be implemented. | 05:58 |
adisky__ | hidekazu: ok, thanks for your inputs | 05:59 |
hidekazu | adisky__* i hope you will find good solution :) | 06:00 |
adisky__ | hidekazu: :) | 06:00 |
*** Yumeng has joined #openstack-watcher | 06:22 | |
openstackgerrit | Merged openstack/watcher-dashboard master: Updated from global requirements https://review.openstack.org/470567 | 06:26 |
*** thorst has joined #openstack-watcher | 06:29 | |
*** thorst has quit IRC | 06:33 | |
openstackgerrit | YumengBao proposed openstack/watcher master: Saving Energy Strategy https://review.openstack.org/476767 | 07:06 |
openstackgerrit | Wei Zheng proposed openstack/watcher master: Update the documention for doc migration https://review.openstack.org/486123 | 07:29 |
openstackgerrit | Hidekazu Nakamura proposed openstack/watcher master: [Doc] Add Configure Cinder Notifications https://review.openstack.org/487280 | 07:31 |
*** alexchadin has joined #openstack-watcher | 07:43 | |
Yumeng | hi all,I have a question: why watcher audit create cannot specify scope of an audit but only watcher audittemplate create can? | 07:43 |
Yumeng | what's the purpose of this? | 07:44 |
openstackgerrit | Alexander Chadin proposed openstack/watcher master: Add release notes for Pike https://review.openstack.org/486146 | 07:45 |
alexchadin | hi Yumeng | 07:45 |
Yumeng | alexchadin:hi | 07:45 |
alexchadin | Yumeng: Audit Template is base thing for Audit, and it should include things are going to achieve (goal), the way we use to achieve goal (strategy) and pool of resources where we want to achieve goal | 07:47 |
alexchadin | Yumeng: everything else is temporary and can be handle by Audit | 07:48 |
hidekazu | Yumeng: alexchadin: honestly i had a same question. i usually execute 'watcher audit create -g xxx -s yyy' | 07:50 |
alexchadin | hidekazu: will this command create audit template? | 07:51 |
Yumeng | alexchadin,hidekazu: yeah. that's my point. watcher audit create can create audit without audittemplate | 07:52 |
hidekazu | alexchadin: no, i do not use audittemplate usually. | 07:52 |
hidekazu | Yumeng: i do not know we can update scope dynamically. | 07:53 |
Yumeng | me either. seldom use audittemplate if using cli to create an audit | 07:53 |
Yumeng | IMHO, audittemplate is a thing that when we want to save and reuse it. if we don't want to reuse it, just create an audit. that's enough | 07:54 |
hidekazu | Yumeng: i think too. | 07:55 |
alexchadin | hidekazu, Yumeng https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/audit.py#L70 try to remove readonly flag, lines 99-113 should manage scope too | 07:57 |
Yumeng | so "watcher audit create" should also be able to specify the scope just like "watcher create audittemplate" can do. | 07:57 |
alexchadin | hidekazu, Yumeng let's see what it brings to us | 07:57 |
hidekazu | alexchadin: thanks, i understand audit scope can not be updated dynamically. | 08:00 |
openstackgerrit | Alexander Chadin proposed openstack/python-watcherclient master: Fix Audit Update functional test https://review.openstack.org/485488 | 08:09 |
*** brunograz has quit IRC | 08:20 | |
*** efoley has joined #openstack-watcher | 08:23 | |
*** efoley_ has joined #openstack-watcher | 08:24 | |
*** efoley has quit IRC | 08:24 | |
hidekazu | alexchadin: i have a question: 1. can we w+1 now even if we don't merge any specs until stable/pike branch is created? 2. feature freeze is thursday not 31st? | 08:24 |
alexchadin | hidekazu: 1. we can merge only pike-3 specs for now | 08:26 |
alexchadin | hidekazu: 2. Feature freeze is on Thursday, right | 08:26 |
hidekazu | alexchadin: 1. https://review.openstack.org/#/c/474865/ was w+1 today even though that is not for pike-3. | 08:29 |
hidekazu | alexchadin: 2. Thursday is tomorrow! ok.. | 08:30 |
*** thorst has joined #openstack-watcher | 08:30 | |
alexchadin | hidekazu: well, that's not good | 08:30 |
alexchadin | hidekazu: We may leave it as is, on an exceptional basis. | 08:31 |
hidekazu | alexchadin: ok, anyway that is not implemented. | 08:32 |
*** thorst has quit IRC | 08:34 | |
adisky__ | alexchadin: hi | 08:35 |
alexchadin | hi adisky__ | 08:35 |
*** efoley_ is now known as efoley | 08:35 | |
*** brunograz has joined #openstack-watcher | 08:36 | |
adisky__ | alexchadin: do you plan to review or merge https://review.openstack.org/#/c/482902/?? | 08:36 |
adisky__ | for pike cycle or it will got queens?? | 08:38 |
adisky__ | * go to | 08:38 |
*** hidekazu has left #openstack-watcher | 08:38 | |
*** hidekazu has joined #openstack-watcher | 08:39 | |
alexchadin | adisky__: It will go for Queens | 08:40 |
adisky__ | alexchadin: so i should not summit implementation for now?? | 08:41 |
alexchadin | adisky__: I will review your patch, but I'm leaving my workplace soon (hidekazu will hold meeting today). You absolutely may submit your implementation, we won't merge it until Pike release | 08:43 |
adisky__ | alexchadin: ok thanks | 08:43 |
*** hidekazu has quit IRC | 08:48 | |
openstackgerrit | Alexander Chadin proposed openstack/python-watcherclient master: Update .gitignore because of doc migration https://review.openstack.org/487325 | 08:59 |
openstackgerrit | YumengBao proposed openstack/watcher master: Saving Energy Strategy https://review.openstack.org/476767 | 09:30 |
*** alexchadin has quit IRC | 09:46 | |
*** dpawlik has joined #openstack-watcher | 09:52 | |
*** danpawlik has quit IRC | 09:54 | |
*** thorst has joined #openstack-watcher | 09:58 | |
*** thorst has quit IRC | 10:06 | |
*** thorst has joined #openstack-watcher | 10:07 | |
*** thorst has quit IRC | 10:11 | |
*** hidekazu has joined #openstack-watcher | 11:25 | |
*** hidekazu has quit IRC | 12:03 | |
*** hidekazu has joined #openstack-watcher | 12:07 | |
*** thorst has joined #openstack-watcher | 12:16 | |
openstackgerrit | Merged openstack/python-watcherclient master: Update .gitignore because of doc migration https://review.openstack.org/487325 | 12:26 |
*** efoley has quit IRC | 12:47 | |
*** efoley has joined #openstack-watcher | 12:50 | |
openstackgerrit | Hidekazu Nakamura proposed openstack/watcher master: [Doc] Add cinder to architecture diagram https://review.openstack.org/487402 | 12:52 |
hidekazu | meeting will be held one hour later. | 13:01 |
hidekazu | today alexchadin can not hold, so i will hold the meeting. | 13:02 |
*** jwcroppe has quit IRC | 13:08 | |
*** lakerzhou1 has joined #openstack-watcher | 13:25 | |
*** hidekazu has quit IRC | 13:46 | |
*** jwcroppe has joined #openstack-watcher | 13:52 | |
*** hidekazu has joined #openstack-watcher | 14:00 | |
hidekazu | we are meeting in #openstack-meeting-4 | 14:32 |
*** hidekazu has left #openstack-watcher | 14:58 | |
*** harlowja has joined #openstack-watcher | 16:15 | |
*** jwcroppe has quit IRC | 16:20 | |
*** harlowja has quit IRC | 17:46 | |
*** Yumeng has quit IRC | 18:33 | |
*** wootehfoot has joined #openstack-watcher | 18:55 | |
*** nicolasbock has quit IRC | 19:06 | |
*** harlowja has joined #openstack-watcher | 19:21 | |
*** harlowja has quit IRC | 19:25 | |
*** thorst has quit IRC | 20:50 | |
*** efoley has quit IRC | 21:24 | |
*** thorst has joined #openstack-watcher | 21:32 | |
*** lakerzhou1 has quit IRC | 21:36 | |
*** thorst has quit IRC | 21:37 | |
*** harlowja has joined #openstack-watcher | 22:00 | |
*** wootehfoot has quit IRC | 22:05 | |
*** thorst has joined #openstack-watcher | 22:25 | |
*** thorst has quit IRC | 22:26 | |
openstackgerrit | Hidekazu Nakamura proposed openstack/watcher-specs master: Spec for multi-datasource support https://review.openstack.org/467102 | 23:18 |
*** hidekazu has joined #openstack-watcher | 23:18 | |
*** thorst has joined #openstack-watcher | 23:27 | |
*** thorst has quit IRC | 23:32 | |
*** thorst has joined #openstack-watcher | 23:50 | |
*** thorst has quit IRC | 23:50 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!