hidekazu | adisky: hi | 00:06 |
---|---|---|
adisky | hidekazu: hi | 00:12 |
hidekazu | adisky: just now i returned comment. | 00:13 |
adisky | hidekazu: ok | 00:13 |
adisky | hidekazu: what does it mean, compute is noisy | 00:14 |
hidekazu | adisky: cdm-scoping and multi global indicator are both API body change. | 00:14 |
adisky | hidekazu: yea | 00:15 |
adisky | hidekazu: but there is no other option | 00:15 |
hidekazu | adisky: cdm-scoping is API request body change, global indicator is response body change. | 00:15 |
hidekazu | adisky: "compute" key is exist or not exist may be issue. | 00:16 |
adisky | hidekazu: it will not be a issue | 00:16 |
adisky | hidekazu: i had never used to at any place check of compute keys | 00:16 |
adisky | hidekazu: https://review.openstack.org/#/c/505109/ | 00:17 |
hidekazu | adisky: if get_global_efficacy_indicator method unchanged, error happen? | 00:17 |
hidekazu | adisky: i know > i had never used to at any place check of compute keys | 00:17 |
adisky | hidekazu: if get_global_efficacy_indicator method unchanged, error happen? you mean as previous?? | 00:18 |
hidekazu | adisky: yes | 00:19 |
adisky | hidekazu: you want it to keep it the same and only change in strategy which uses multiple indicators?? | 00:20 |
adisky | hidekazu: it is not good to do so, as if we will not be having a unified structure | 00:22 |
adisky | secondaly we need to use different parsing method for different strategies | 00:22 |
adisky | at python-watcherclient | 00:22 |
adisky | https://github.com/openstack/python-watcherclient/blob/master/watcherclient/v1/action_plan_shell.py#L28 | 00:22 |
hidekazu | adisky: hmm | 00:23 |
hidekazu | adisky: how about list of indicators? | 00:24 |
adisky | hidekazu: then how user will know, which indicator is for what?? | 00:25 |
hidekazu | adisky: indicator has name | 00:25 |
hidekazu | adisky: instead of 'compute' or 'storage' ... , use indicators name in python-watcherclient | 00:30 |
hidekazu | adisky: efficacy indicators are list, so global efficacy indicators will be list. https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/action_plan.py#L276-L290 | 00:32 |
*** thorst has joined #openstack-watcher | 00:34 | |
hidekazu | adisky: actually, zone migration has two global indicators about compute. if global indicator is dictionary, global indicator key and indicator name is almost same. | 00:35 |
adisky | hidekazu: its ok, we can have list also, but this does not solve our problem, api changes has to be there | 00:36 |
adisky | hidekazu: one more thing if we use list | 00:37 |
adisky | we need to change db as well | 00:38 |
adisky | https://github.com/openstack/watcher/blob/master/watcher/db/sqlalchemy/models.py#L200 | 00:38 |
hidekazu | adisky: efficacy indicator is its own object/table, global is in actionplan | 00:42 |
adisky | hidekazu: yes | 00:43 |
hidekazu | adisky: you can do | 00:47 |
adisky | hidekazu: advsntage?? | 00:48 |
adisky | *advantage | 00:48 |
*** dpawlik has joined #openstack-watcher | 00:50 | |
hidekazu | adisky: you wonder why there is multi global indicator, calculating from indicator seems to be enough.. | 00:50 |
adisky | hidekazu: yes, i think if it has to be same as Indicator then what is the need of it | 00:51 |
*** danpawlik has quit IRC | 00:51 | |
adisky | i think having too many global efficacy will not justify meaning of global efficacy | 00:51 |
hidekazu | adisky: yes, because we have already global indicator, we wanted to have multi global indicator | 00:52 |
adisky | hidekazu: so it is better to have, one indicator for one resources | 00:52 |
adisky | hidekazu: if we have multiple indicator for each resource, than whats the meaning of it, we can use efficacy indicator also | 00:53 |
hidekazu | adisky: because global is only simple calculation | 00:53 |
*** zhurong has joined #openstack-watcher | 00:54 | |
hidekazu | adisky: but someone want to know values before calculation | 00:54 |
*** nicolasbock has quit IRC | 00:55 | |
adisky | hidekazu: | 00:56 |
adisky | ok | 00:56 |
adisky | then finally you would like to have it as alist?? | 00:56 |
hidekazu | adisky: i think so | 00:59 |
adisky | hidekazu: okay!!!!!!!!!!!!!!!!!! | 00:59 |
adisky | hidekazu: but you agreed on that point, that we cant return different type of global efficacy from different strategy | 01:00 |
adisky | it has to be unified?? | 01:00 |
hidekazu | adisky: i agreed implementation should be unified. | 01:01 |
adisky | hidekazu: nice | 01:03 |
hidekazu | adisky: back to api body change | 01:03 |
adisky | hidekazu: came out of PTG hangover?? | 01:03 |
adisky | adisky: ohh!!!!!, that is remaining | 01:03 |
hidekazu | adisky: almost | 01:03 |
adisky | hidekazu: i saw your pics, nice | 01:04 |
hidekazu | adisky: dynamic description changed api body, but version has unchanged. | 01:04 |
hidekazu | adisky: only one. | 01:04 |
adisky | hidekazu: i discussed with alexchadin about api change | 01:04 |
adisky | hidekazu: He said, till now we are incorporating the changes on same version only | 01:05 |
adisky | and there is no big change to release a major version | 01:05 |
adisky | and we dont't have microversion | 01:05 |
hidekazu | adisky: maybe eternally unchanged :) | 01:06 |
adisky | adisky: haha, may be its better to have api microversioning, but it is along task | 01:06 |
adisky | * a long | 01:06 |
hidekazu | adisky: i have never seen microversion framework code | 01:07 |
adisky | hidekazu: nova, cinder they all use | 01:07 |
hidekazu | adisky: yeah, i am only user currently. | 01:07 |
adisky | adisky: yea, me too | 01:08 |
*** openstackgerrit has joined #openstack-watcher | 01:21 | |
openstackgerrit | Hidekazu Nakamura proposed openstack/watcher master: [WIP] Add cdm-scoping https://review.openstack.org/503171 | 01:31 |
openstackgerrit | aditi sharma proposed openstack/python-watcherclient master: [WIP ]Multiple global efficacy https://review.openstack.org/505472 | 02:25 |
openstackgerrit | Chenghui Yu proposed openstack/puppet-watcher master: Update openstackdocstheme to latest version https://review.openstack.org/505215 | 03:13 |
*** thorst has quit IRC | 03:30 | |
*** thorst has joined #openstack-watcher | 04:31 | |
*** thorst has quit IRC | 04:35 | |
*** zhurong has quit IRC | 04:53 | |
*** suzhengwei has joined #openstack-watcher | 05:08 | |
*** thorst has joined #openstack-watcher | 05:31 | |
*** thorst has quit IRC | 05:36 | |
openstackgerrit | Hidekazu Nakamura proposed openstack/watcher master: Add cdm-scoping https://review.openstack.org/503171 | 06:06 |
*** thorst has joined #openstack-watcher | 06:32 | |
*** thorst has quit IRC | 06:36 | |
*** zhurong has joined #openstack-watcher | 06:45 | |
*** openstackgerrit has quit IRC | 07:02 | |
*** thorst has joined #openstack-watcher | 07:33 | |
*** thorst has quit IRC | 07:39 | |
*** zhurong has quit IRC | 07:48 | |
*** alexchadin has joined #openstack-watcher | 08:02 | |
*** openstackgerrit has joined #openstack-watcher | 08:08 | |
openstackgerrit | LiChunlin proposed openstack/watcher master: Add a hacking rule for string interpolation at logging https://review.openstack.org/484329 | 08:08 |
*** alexchadin has quit IRC | 08:18 | |
*** alexchadin has joined #openstack-watcher | 08:23 | |
*** efoley has joined #openstack-watcher | 08:33 | |
*** thorst has joined #openstack-watcher | 08:35 | |
*** zhurong has joined #openstack-watcher | 08:44 | |
*** hidekazu has left #openstack-watcher | 08:47 | |
*** thorst has quit IRC | 09:02 | |
*** efoley has quit IRC | 09:30 | |
*** alexchadin has quit IRC | 10:06 | |
*** zhurong has quit IRC | 10:22 | |
*** nicolasbock has joined #openstack-watcher | 10:42 | |
*** nicolasbock has quit IRC | 10:46 | |
*** thorst has joined #openstack-watcher | 10:59 | |
*** nicolasbock has joined #openstack-watcher | 10:59 | |
*** efoley has joined #openstack-watcher | 11:04 | |
*** thorst has quit IRC | 11:04 | |
*** suzhengwei has quit IRC | 11:10 | |
*** alexchadin has joined #openstack-watcher | 11:47 | |
*** thorst has joined #openstack-watcher | 11:57 | |
*** alexchadin has quit IRC | 12:06 | |
*** alexchadin has joined #openstack-watcher | 12:07 | |
*** efoley has quit IRC | 12:38 | |
*** efoley has joined #openstack-watcher | 13:09 | |
*** efoley has quit IRC | 13:19 | |
*** alexchadin has quit IRC | 13:21 | |
*** efoley has joined #openstack-watcher | 13:28 | |
*** efoley has quit IRC | 13:33 | |
*** efoley has joined #openstack-watcher | 13:41 | |
*** suzhengwei has joined #openstack-watcher | 13:44 | |
*** alexchadin has joined #openstack-watcher | 13:46 | |
*** zhurong has joined #openstack-watcher | 13:55 | |
alexchadin | we will have meeting in 3 minutes on #openstack-meeting-4! | 13:57 |
*** suzhengwei has quit IRC | 13:59 | |
*** suzhengwei has joined #openstack-watcher | 14:00 | |
*** efoley has quit IRC | 14:02 | |
*** efoley has joined #openstack-watcher | 14:02 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/watcher-dashboard master: Updated from global requirements https://review.openstack.org/502769 | 14:02 |
*** efoley has quit IRC | 14:04 | |
*** efoley_ has joined #openstack-watcher | 14:04 | |
*** efoley_ has quit IRC | 14:44 | |
*** efoley_ has joined #openstack-watcher | 14:50 | |
*** efoley_ has quit IRC | 14:57 | |
*** efoley_ has joined #openstack-watcher | 15:02 | |
*** alexchadin has quit IRC | 15:02 | |
*** efoley_ has quit IRC | 15:05 | |
*** efoley_ has joined #openstack-watcher | 15:05 | |
*** zhurong has quit IRC | 15:05 | |
*** suzhengwei has quit IRC | 15:31 | |
*** efoley_ has quit IRC | 16:08 | |
*** efoley_ has joined #openstack-watcher | 16:19 | |
*** nicolasbock has quit IRC | 16:39 | |
*** vvargaszte has joined #openstack-watcher | 16:42 | |
*** vvargaszte has quit IRC | 16:42 | |
*** vvargaszte has joined #openstack-watcher | 17:04 | |
*** ianychoi_ has joined #openstack-watcher | 17:18 | |
openstackgerrit | Merged openstack/puppet-watcher master: Update openstackdocstheme to latest version https://review.openstack.org/505215 | 17:21 |
*** ianychoi has quit IRC | 17:22 | |
*** vvargaszte has quit IRC | 17:30 | |
*** efoley_ has quit IRC | 17:36 | |
*** efoley has joined #openstack-watcher | 18:42 | |
*** thorst has quit IRC | 21:03 | |
*** thorst has joined #openstack-watcher | 21:07 | |
*** thorst has quit IRC | 21:12 | |
*** efoley has quit IRC | 21:48 | |
*** efoley has joined #openstack-watcher | 22:04 | |
*** thorst has joined #openstack-watcher | 22:06 | |
*** thorst has quit IRC | 22:10 | |
*** thorst has joined #openstack-watcher | 22:33 | |
*** thorst has quit IRC | 22:38 | |
*** thorst has joined #openstack-watcher | 22:39 | |
*** efoley has quit IRC | 22:39 | |
*** thorst has quit IRC | 22:40 | |
*** ianychoi_ is now known as ianychoi | 22:52 | |
*** hidekazu has joined #openstack-watcher | 23:14 | |
*** thorst has joined #openstack-watcher | 23:41 | |
*** thorst has quit IRC | 23:46 |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!