| *** aspiers[m] has quit IRC | 00:09 | |
| *** suzhengwei has quit IRC | 02:11 | |
| *** jianhua has joined #openstack-watcher | 02:26 | |
| *** nicolasbock has quit IRC | 02:55 | |
| *** jianhua has quit IRC | 04:29 | |
| *** jianhua has joined #openstack-watcher | 05:05 | |
| *** hidekazu has joined #openstack-watcher | 05:36 | |
| *** hidekazu has quit IRC | 05:38 | |
| *** hidekazu has joined #openstack-watcher | 05:40 | |
| *** aspiers[m] has joined #openstack-watcher | 05:44 | |
| *** jianhua has quit IRC | 05:46 | |
| *** jianhua has joined #openstack-watcher | 05:47 | |
| *** jianhua has quit IRC | 05:55 | |
| *** jianhua has joined #openstack-watcher | 05:57 | |
| *** alexchadin has joined #openstack-watcher | 06:36 | |
| *** ianychoi has joined #openstack-watcher | 06:38 | |
| *** jianhua has quit IRC | 06:41 | |
| *** jianhua has joined #openstack-watcher | 06:42 | |
| adisky__ | alexchadin: hi | 06:54 |
|---|---|---|
| alexchadin | adisky__: hi | 06:54 |
| adisky__ | alexchadin: you pinged me yesterday | 06:55 |
| adisky__ | ?? | 06:55 |
| *** rajat has joined #openstack-watcher | 06:55 | |
| alexchadin | adisky__: yeap. is api validation spec ready for review? | 06:55 |
| alexchadin | adisky__: I've noticed it was probable published by your colleague | 06:55 |
| adisky__ | alexchadin: no, it is no ready yet | 06:56 |
| adisky__ | alexchadin: It will be ready in 1 or 2 days | 06:56 |
| adisky__ | alexchadin: yes, as I dont have 100% bandwidth on watcher, so we both will work together on api-validation bp | 06:57 |
| alexchadin | adisky__: thanks! | 06:57 |
| adisky__ | alexchadin: he is on irc with nickname rajat | 06:58 |
| alexchadin | rajat: hi | 06:58 |
| adisky__ | alexchadin: he also found one more ambigous thing in CLI | 06:59 |
| alexchadin | rajat: thank you for your contribution to Watcher | 06:59 |
| adisky__ | alexchadin: the command "actionplan create Create new audit." | 06:59 |
| adisky__ | its also unclear, what is your view on that?? | 06:59 |
| alexchadin | adisky__: yeah, we need to remove it | 06:59 |
| alexchadin | adisky__: only audit can create actionplan | 07:00 |
| adisky__ | alexchadin: yes its misleading | 07:00 |
| alexchadin | adisky__: actually, this command creates audit which is even worse, IMHO :) | 07:00 |
| adisky__ | alexchadin: ya, i just tried running it | 07:01 |
| alexchadin | adisky__: oh, there is one more thing to discuss | 07:02 |
| rajat | thanks for welcoming me, | 07:02 |
| alexchadin | adisky__: this if condition looks strange: https://github.com/openstack/python-watcherclient/blob/master/watcherclient/v1/action_plan.py#L96 | 07:03 |
| rajat | it is a good opportunity for me to contribute in watcher | 07:03 |
| alexchadin | hidekazu: thank you for your review! | 07:03 |
| rajat | alexchadin: ^^ | 07:03 |
| hidekazu | alexchadin: welcome :) | 07:04 |
| alexchadin | rajat: you're welcome :) I've also added you as reviewer to my spec | 07:04 |
| adisky__ | alexchadin: yea, this is beacause we dont have a seperate api for cancel | 07:04 |
| adisky__ | just like start | 07:05 |
| alexchadin | adisky__: https://review.openstack.org/#/c/558559/11/api-ref/source/watcher-api-v1-actionplans.inc line 150 | 07:06 |
| alexchadin | adisky__: It's pretty hard to use this opportunity | 07:06 |
| rajat | alexchadin: although I am not much aware about watcher but I'll try to review it | 07:07 |
| adisky__ | alexchadin: ya i got it, for CLI users they need not take care about this state change | 07:08 |
| adisky__ | i will try to refactor it too | 07:08 |
| adisky__ | and move the logic from python-watcherclient to watcher API | 07:08 |
| alexchadin | rajat: it's common and long-term issue with Watcher, I suppose it'd be pretty easy to review | 07:09 |
| alexchadin | adisky__: it'd be perfect | 07:10 |
| rajat | alexchadin: ok, great. | 07:11 |
| alexchadin | rajat: thanks | 07:11 |
| *** AlexeyAbashkin has joined #openstack-watcher | 07:31 | |
| *** alexchadin has quit IRC | 07:42 | |
| *** alexchadin has joined #openstack-watcher | 07:43 | |
| *** hidekazu has quit IRC | 07:46 | |
| *** ianychoi has quit IRC | 08:04 | |
| *** ianychoi has joined #openstack-watcher | 08:10 | |
| *** openstackgerrit has joined #openstack-watcher | 08:18 | |
| openstackgerrit | suzhengwei proposed openstack/watcher master: amend delete action policy https://review.openstack.org/561829 | 08:18 |
| openstackgerrit | licanwei proposed openstack/watcher-specs master: Enhance Watcher applier Engine https://review.openstack.org/551861 | 08:35 |
| *** suzhengwei has joined #openstack-watcher | 08:36 | |
| openstackgerrit | licanwei proposed openstack/watcher-specs master: Enhance Watcher applier Engine https://review.openstack.org/551861 | 08:48 |
| openstackgerrit | licanwei proposed openstack/watcher master: Enhance Watcher Applier Engine https://review.openstack.org/554765 | 08:56 |
| *** suzhengwei_ has joined #openstack-watcher | 09:09 | |
| *** jianhua_ has joined #openstack-watcher | 09:10 | |
| *** suzhengwei has quit IRC | 09:12 | |
| *** jianhua has quit IRC | 09:12 | |
| openstackgerrit | licanwei proposed openstack/watcher master: Enhance Watcher Applier Engine https://review.openstack.org/554765 | 09:24 |
| *** jianhua_ has quit IRC | 09:50 | |
| *** jianhua has joined #openstack-watcher | 09:51 | |
| *** suzhengwei_ has quit IRC | 10:04 | |
| *** nicolasbock has joined #openstack-watcher | 10:37 | |
| *** alexchadin has quit IRC | 10:52 | |
| *** alexchadin has joined #openstack-watcher | 10:59 | |
| *** AlexeyAbashkin has quit IRC | 11:07 | |
| *** alexchadin has quit IRC | 11:17 | |
| *** alexchadin has joined #openstack-watcher | 11:17 | |
| *** alexchadin has quit IRC | 11:17 | |
| *** alexchadin has joined #openstack-watcher | 11:18 | |
| *** alexchadin has quit IRC | 11:18 | |
| *** alexchadin has joined #openstack-watcher | 11:19 | |
| *** alexchadin has quit IRC | 11:19 | |
| *** alexchadin has joined #openstack-watcher | 11:19 | |
| *** alexchadin has quit IRC | 11:20 | |
| openstackgerrit | licanwei proposed openstack/watcher master: add unittest for execute_audit in audit/continuous.py https://review.openstack.org/559653 | 11:20 |
| *** alexchadin has joined #openstack-watcher | 11:20 | |
| *** alexchadin has quit IRC | 11:20 | |
| *** AlexeyAbashkin has joined #openstack-watcher | 11:28 | |
| openstackgerrit | aditi sharma proposed openstack/watcher master: Exclude Project By Audit Scope https://review.openstack.org/557681 | 11:39 |
| *** alexchadin has joined #openstack-watcher | 11:50 | |
| openstackgerrit | YumengBao proposed openstack/watcher master: Use jsonschema to validate efficacy indicators https://review.openstack.org/561182 | 11:53 |
| *** alexchadin has quit IRC | 11:55 | |
| *** alexchadin has joined #openstack-watcher | 11:59 | |
| openstackgerrit | YumengBao proposed openstack/watcher master: Use jsonschema to validate efficacy indicators https://review.openstack.org/561182 | 12:05 |
| openstackgerrit | YumengBao proposed openstack/watcher master: Use jsonschema to validate efficacy indicators https://review.openstack.org/561182 | 12:06 |
| *** alexchadin has quit IRC | 12:10 | |
| *** alexchadin has joined #openstack-watcher | 12:21 | |
| *** jianhua has quit IRC | 12:57 | |
| *** ianychoi_ has joined #openstack-watcher | 13:07 | |
| *** ianychoi has quit IRC | 13:10 | |
| *** alexchadin has quit IRC | 13:14 | |
| *** andreykurilin has joined #openstack-watcher | 13:20 | |
| *** adisky__ has quit IRC | 14:11 | |
| *** adisky__ has joined #openstack-watcher | 14:12 | |
| *** harlowja has joined #openstack-watcher | 16:23 | |
| *** harlowja has quit IRC | 16:52 | |
| *** harlowja has joined #openstack-watcher | 16:57 | |
| *** harlowja has quit IRC | 17:20 | |
| *** AlexeyAbashkin has quit IRC | 18:02 | |
| *** AlexeyAbashkin has joined #openstack-watcher | 19:25 | |
| *** AlexeyAbashkin has quit IRC | 19:34 | |
| *** harlowja has joined #openstack-watcher | 19:50 | |
| *** UC12CKgmh has joined #openstack-watcher | 22:05 | |
| *** UC12CKgmh has quit IRC | 22:07 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!