| *** openstackgerrit has joined #openstack-watcher | 01:32 | |
| openstackgerrit | licanwei proposed openstack/watcher-tempest-plugin master: Improve tempest https://review.openstack.org/600288 | 01:32 |
|---|---|---|
| *** nicolasbock has quit IRC | 02:18 | |
| openstackgerrit | Nguyen Hai proposed openstack/watcher-dashboard master: import zuul job settings from project-config https://review.openstack.org/593324 | 03:05 |
| openstackgerrit | Nguyen Hai proposed openstack/watcher-dashboard master: switch documentation job to new PTI https://review.openstack.org/593325 | 03:05 |
| openstackgerrit | licanwei proposed openstack/watcher-tempest-plugin master: [WIP]Improve tempest https://review.openstack.org/600288 | 03:33 |
| openstackgerrit | licanwei proposed openstack/watcher master: just for test https://review.openstack.org/600333 | 05:42 |
| *** alexchadin has joined #openstack-watcher | 06:54 | |
| *** alexchadin has quit IRC | 07:10 | |
| *** alexchadin has joined #openstack-watcher | 07:27 | |
| openstackgerrit | licanwei proposed openstack/watcher master: just for test https://review.openstack.org/600333 | 08:29 |
| *** alexchadin has quit IRC | 08:58 | |
| *** alexchadin has joined #openstack-watcher | 09:14 | |
| *** alexchadin has quit IRC | 09:24 | |
| openstackgerrit | Michal Arbet proposed openstack/watcher-dashboard master: Fix Invalid filter: parse_isotime https://review.openstack.org/600398 | 09:52 |
| *** nicolasbock has joined #openstack-watcher | 10:31 | |
| *** alexchadin has joined #openstack-watcher | 12:11 | |
| *** alexchadin has quit IRC | 12:41 | |
| kevko_home | Hi, can someone review this ? https://review.openstack.org/#/c/600398/ pep8 faiiled on F401 'filters' imported but unused <- but this is false positive , but patch is fixing bug #1791038 | 12:47 |
| openstack | bug 1791038 in watcher-dashboard "Invalid templates , Invalid filter: 'parse_isotime'" [Undecided,New] https://launchpad.net/bugs/1791038 | 12:47 |
| *** alexchadin has joined #openstack-watcher | 12:49 | |
| kevko_home | hmm ? :) | 12:50 |
| alexchadin | kevko_home: hi | 12:57 |
| alexchadin | kevko_home: have I missed something? :) | 12:57 |
| kevko_home | alexchadin: hi :) | 12:57 |
| kevko_home | alexchadin: Hi, can someone review this ? https://review.openstack.org/#/c/600398/ pep8 faiiled on F401 'filters' imported but unused <- but this is false positive , but patch is fixing bug #1791038 | 12:58 |
| openstack | bug 1791038 in watcher-dashboard "Invalid templates , Invalid filter: 'parse_isotime'" [Undecided,New] https://launchpad.net/bugs/1791038 - Assigned to Michal Arbet (michalarbet) | 12:58 |
| kevko_home | alexchadin: similar issue solved here in sahara-dashboard | 12:58 |
| kevko_home | alexchadin: https://review.openstack.org/#/c/299230/ | 12:58 |
| alexchadin | kevko_home: maybe we should mark this import as noqa? | 13:00 |
| kevko_home | alexchadin: what is noqa ..sorry don't know .. | 13:00 |
| kevko_home | alexchadin: something like ..no check :) ? | 13:00 |
| alexchadin | kevko_home: yeap, this keyword tells pep8 not to check appropriate line | 13:01 |
| kevko_home | alexchadin: oh, thank you | 13:01 |
| kevko_home | alexchadin: should i delete a comment from file directly ? | 13:01 |
| kevko_home | alexchadin: I only put here to prevent from removal in future if someone will see only one import not used in file | 13:02 |
| kevko_home | alexchadin: or better leave as is | 13:02 |
| alexchadin | kevko_home: are you author of https://review.openstack.org/#/c/600398/ ? | 13:02 |
| kevko_home | alexchadin: yes | 13:03 |
| kevko_home | alexchadin: that's me :) | 13:03 |
| alexchadin | kevko_home: then it's better to add noqa just after main line, like it's done here: https://review.openstack.org/#/c/299230/3/sahara_dashboard/content/data_processing/jobs/templatetags/__init__.py | 13:03 |
| kevko_home | alexchadin: so , should i remove the comment before import ? | 13:04 |
| kevko_home | alexchadin: i will add #noqa for sure .. | 13:05 |
| alexchadin | kevko_home: yeah, I suppose it'd be better to replace it with Apache license (just like every time) :) | 13:05 |
| kevko_home | alexchadin: ok :) | 13:05 |
| openstackgerrit | Michal Arbet proposed openstack/watcher-dashboard master: Fix Invalid filter: parse_isotime https://review.openstack.org/600398 | 13:08 |
| kevko_home | alexchadin: updated :) | 13:08 |
| kevko_home | alexchadin: thanks for your time | 13:08 |
| alexchadin | let's wait for zuul review and I'll +2CR +1W it | 13:08 |
| alexchadin | kevko_home: ^ | 13:09 |
| kevko_home | alexchadin: ok, thanks :) | 13:57 |
| openstackgerrit | Merged openstack/watcher master: Fix goal method in policy https://review.openstack.org/598069 | 14:39 |
| kevko_home | alexchadin: zuul posted a comment +1 :) | 14:46 |
| alexchadin | kevko_home: time to merge it! | 14:46 |
| openstackgerrit | Merged openstack/watcher-dashboard master: Fix Invalid filter: parse_isotime https://review.openstack.org/600398 | 15:00 |
| *** alexchadin has quit IRC | 15:38 | |
| *** ChanServ sets mode: -rf | 17:13 | |
| *** openstackgerrit has quit IRC | 18:05 | |
| *** nicolasbock has quit IRC | 20:34 | |
| *** nicolasbock has joined #openstack-watcher | 20:54 | |
Generated by irclog2html.py 2.15.3 by Marius Gedminas - find it at mg.pov.lt!