| marios | o/ | 06:38 |
|---|---|---|
| marios | sean-k-mooney: o/ hello did you already start working on the prometheus spec? i am catching up on yesterdays notes and would like to help if i can? i am looking at the formal datasource interface you linked as well as the grafana example. if you're already working there no worries, not sure how we could split that but i am mentioning it as you asked yesterday if someone wanted to join | 08:08 |
| marios | i can help with reviews in any case ;) | 08:09 |
| sean-k-mooney | i have not but normally i do that on an etherpad | 09:49 |
| sean-k-mooney | i got as far as finding thoses referencee but did not have time to fully read them mysef beyond skiming them | 09:50 |
| sean-k-mooney | marios: if you have time to work on this im happy to review instead | 09:50 |
| sean-k-mooney | im trying to do 3 things this week. work on pre-commit, review the open reviews and set up a 3 node devstack cluseter with watcher | 09:52 |
| marios | sean-k-mooney: ok I will dig there and see what i can do | 10:05 |
| sean-k-mooney | first thing we need to do is simeiple we need to copy the most recent spec template and create the relevent folder for specs for this cycle | 10:06 |
| sean-k-mooney | i can do that if you like or i can leave it to you. that a pretty non contoverial change | 10:07 |
| marios | ack we could just create that with the review when we are ready anyway | 10:07 |
| sean-k-mooney | we coudl yes | 10:07 |
| sean-k-mooney | marios: kopecmartin i created a review dashboard for watcher based on my nova one in case its of use to ye | 11:24 |
| sean-k-mooney | https://review.opendev.org/dashboard/?foreach=%28+project%3Aopenstack%2Fwatcher+OR%0Aproject%3Aopenstack%2Fpython-watcherclient+OR%0Aproject%3Aopenstack%2Fwatcher-specs+%29%0Astatus%3Aopen%0ANOT+owner%3Aself%0ANOT+label%3AWorkflow%3C%3D-1%0Alabel%3AVerified%3E%3D1%2Czuul%0ANOT+reviewedby%3Aself%0Abranch%3Amaster&title=Watcher+Review+Inbox&Small+patches=%28project%3Aopenstac | 11:24 |
| sean-k-mooney | k%2Fwatcher+OR+project%3Aopenstack%2Fpython-watcherclient%29+NOT+label%3ACode-Review%3E%3D2%2Cself+NOT+label%3ACode-Review%3C%3D-1%2Cwatcher-core+NOT+message%3A%22DNM%22+delta%3A%3C%3D10&Needs+final+%2B2=%28project%3Aopenstack%2Fwatcher+OR+project%3Aopenstack%2Fpython-watcherclient%29+NOT+label%3ACode-Review%3E%3D2%2Cself+label%3ACode-Review%3E%3D2+limit%3A50&Bug+fix%2C+Pas | 11:24 |
| sean-k-mooney | sed+Zuul%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2%2Cself+NOT+label%3ACode-Review%3C%3D-1%2Cwatcher-core+message%3A%22bug%3A+%22+limit%3A50&Wayward+Changes+%28Changes+with+no+code+review+in+the+last+two+days%29=NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D1+age%3A2d+limit%3A50&Needs+feedback+%28Changes+older+than+5+days+that+have+not+been+review | 11:24 |
| sean-k-mooney | ed+by+anyone%29=NOT+label%3ACode-Review%3C%3D-1+NOT+label%3ACode-Review%3E%3D1+age%3A5d+limit%3A50&Passed+Zuul%2C+No+Negative+Feedback=NOT+label%3ACode-Review%3E%3D2+NOT+label%3ACode-Review%3C%3D-1+limit%3A50&Needs+revisit+%28You+were+a+reviewer+but+haven%27t+voted+in+the+current+revision%29=reviewer%3Aself+limit%3A50&Specs=project%3Aopenstack%2Fwatcher-specs+status%3Aopen+ | 11:24 |
| sean-k-mooney | limit%3A20 | 11:24 |
| sean-k-mooney | ill put that soemwere else since that is not really usable | 11:24 |
| sean-k-mooney | https://tinyurl.com/2rfm4f8a | 11:25 |
| marios | thanks sean-k-mooney | 11:53 |
| marios | me trying to add enable watcher on my devstack box (just single node with https://docs.openstack.org/watcher/latest/contributor/devstack.html#gnocchi i.e. ceilo/gnocchi | 11:55 |
| sean-k-mooney | marios: there is a sample local.conf in tree | 11:57 |
| sean-k-mooney | two technially https://github.com/openstack/watcher/blob/master/devstack/local.conf.controller and https://github.com/openstack/watcher/blob/master/devstack/local.conf.compute | 11:57 |
| sean-k-mooney | i have not used them yet but hope to later today | 11:57 |
| marios | sean-k-mooney: so there are two but they are for example compute and controller i think multi host setup | 11:58 |
| sean-k-mooney | watcher does not run on the comptue | 11:58 |
| sean-k-mooney | its only on the contoler | 11:58 |
| sean-k-mooney | i think you just need https://github.com/openstack/watcher/blob/master/devstack/local.conf.controller#L28-L35 | 11:59 |
| marios | there was some required config on the compute in the devestup notes | 11:59 |
| sean-k-mooney | also the current example is wrong in that ceilometer-api has been remvoed i bleive | 11:59 |
| marios | and rerunning stack on the computes... which i thought explains the presence of those two local.conf one for cntrol one for compute | 12:00 |
| sean-k-mooney | thats for nova and ceilometer | 12:00 |
| marios | sure | 12:00 |
| sean-k-mooney | so nova need to have notificaiton enabled and ceilometer need to have the ceilometer-compute data collector | 12:00 |
| marios | the example has that set for nova | 12:01 |
| sean-k-mooney | yep | 12:01 |
| marios | i mean: [[post-config|$NOVA_CONF]] | 12:01 |
| marios | [DEFAULT] | 12:01 |
| marios | compute_monitors=cpu.virt_driver | 12:01 |
| sean-k-mooney | so there are no watcher compoent on the computes | 12:01 |
| marios | sure | 12:02 |
| marios | but still ther are two separate local.conf for devstack | 12:02 |
| sean-k-mooney | yep but you could do it all in one | 12:02 |
| sean-k-mooney | the onley reason multinode make more sense | 12:02 |
| marios | i am trying with just that config for now will see how it goes | 12:02 |
| sean-k-mooney | is almost all the watcher fucntionatly expect multiple nodes | 12:02 |
| marios | i mean the example given in https://docs.openstack.org/watcher/latest/contributor/devstack.html#gnocchi | 12:02 |
| marios | would be nice to enable prometheus in local.conf ;) | 12:03 |
| sean-k-mooney | ok that is proably a more uptodate example | 12:03 |
| sean-k-mooney | with that said the gnocci dep is somethign we will be activly swapping out so we shoudl proably include a prometus example in teh watcher repo as part of that work | 12:04 |
| sean-k-mooney | marios: untill we add that supprot to devstack you have 2 options | 12:04 |
| sean-k-mooney | the local.conf is actully source so you can litrally add `sudo apt get install prometheus -y` or you can create a local.sh beside the local.conf and put the install there | 12:05 |
| sean-k-mooney | what we actully will want to do in devstack is supprot installing all the prometheus compoents on the contoler and just the node-exporer on the computes | 12:06 |
| sean-k-mooney | the compute can use SERVICE_HOST as the prometious host or we can added a dedicated one when we do the devstack change | 12:07 |
| sean-k-mooney | marios: just one comment on the doc, nova has never required shared storage for live migration. | 12:10 |
| sean-k-mooney | if watcher does then thats a bug and we shoudl fix that but we can verify that later. | 12:11 |
| marios | ++/opt/stack/watcher-dashboard/devstack/plugin.sh:init_watcher_dashboard:16 python3 /opt/stack/hori | 12:11 |
| marios | ModuleNotFoundError: No module named 'django' | 12:11 |
| sean-k-mooney | this is proably related to the golbal virtual env | 12:12 |
| sean-k-mooney | my guess is the watcher-dashbaord devstack plugin does not supprot that properly | 12:12 |
| *** rlandy_ is now known as rlandy | 12:37 | |
| gmann | dansmith: to fix the grenade job, we need to merge this stable/2024.2 first https://review.opendev.org/c/openstack/watcher/+/933062 | 18:27 |
| dansmith | got it.. maybe we should wait for chenker to see it tonight, and if not, perhaps just ninja it in since it's just trivial infra? | 18:30 |
| dansmith | I certainly don't want to start flooding stuff in without earlier cores being okay with things | 18:30 |
| gmann | dansmith: ack | 18:31 |
| sean-k-mooney | i have not directly checked the patch yet but i can confirm with master watcher-db-manage is not aviabel outside the venv https://paste.opendev.org/show/b65Y9sFKEs5UehRRGMQp/ | 18:31 |
| sean-k-mooney | so that alines with creatign the symlink and the WATCHER_BIN_DIR prefix | 18:32 |
| sean-k-mooney | it also fixes the job but form my point of view this si a nice targeted fix | 18:33 |
| sean-k-mooney | with that said espicly ptg week we are not in a rush to merge this today | 18:33 |
| sean-k-mooney | so lets see if chenker has any concerns | 18:33 |
| gmann | yeah, grenade job passing with this can be seen in this change https://review.opendev.org/c/openstack/watcher/+/932963/5 | 18:33 |
| gmann | or I think I can make depens-on of stable/2024.1 on master change itself so that we do not need to recheck it again and it will be clear to know passing result | 18:34 |
| opendevreview | Ghanshyam proposed openstack/watcher master: Run watcher-db-manage in grenade testing from venv https://review.opendev.org/c/openstack/watcher/+/933046 | 18:34 |
| gmann | we should be able to see grenade job green in this only ^^ | 18:35 |
| sean-k-mooney | ah i see yo dropped the other depends on | 18:35 |
| sean-k-mooney | oh rahter you added it to the master version | 18:35 |
| sean-k-mooney | ya that will show it but you already demonstrated that here too https://review.opendev.org/c/openstack/watcher/+/932963/5 | 18:36 |
| sean-k-mooney | if we add `Depends-On: https://review.opendev.org/c/openstack/watcher/+/933062` to mater patches then the job passes | 18:36 |
| gmann | I will keep 932963 as separate because that will wait to merge until we are migrating CI to Noble and in case people want to see grenade passing on master on same change of GLOBAL_VENV change | 18:45 |
| sean-k-mooney | we likely need a simier change for the watcher-dashboard plugin | 19:22 |
| sean-k-mooney | im currently deploying iwthout that | 19:22 |
| sean-k-mooney | https://github.com/openstack/watcher-dashboard/blob/master/devstack/plugin.sh does not seam to have any change for the global venv | 19:24 |
| sean-k-mooney | marios django issue https://github.com/openstack/watcher-dashboard/blob/master/devstack/plugin.sh#L16 ithink s jsut because it snot using the vnenv | 19:26 |
| sean-k-mooney | the horrizon plugin is less of a prioarity in the shrot term but something we should eventually look into | 19:27 |
| sean-k-mooney | octivai is using $PYTHON https://github.com/openstack/octavia-dashboard/blob/master/devstack/plugin.sh#L11 as is heat | 19:31 |
| sean-k-mooney | devstack exports that properly into the env here https://github.com/openstack/devstack/blob/a1376e6f8cbc08cb7e0d37bdb8cfdeb8c5585e41/inc/python#L49-L52 | 19:34 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!