| opendevreview | Martin Kopec proposed openstack/watcher-tempest-plugin master: Switch devstack nodeset to Ubuntu 24.04 (Noble) https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/934296 | 08:06 |
|---|---|---|
| opendevreview | Martin Kopec proposed openstack/watcher-tempest-plugin master: Switch devstack nodeset to Ubuntu 24.04 (Noble) https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/934296 | 10:06 |
| sean-k-mooney | im making some slow progress on the py39 unit test issue | 13:12 |
| sean-k-mooney | watchers unit tests are not in a good state. they are invoking code that expects to be monkey patches but we dont monkey patch intentionaly | 13:13 |
| sean-k-mooney | i say intentionally because the test that import form the watcher.cmd modual do end up monkey patching the executor | 13:13 |
| marios | i need to look at the unit tests next :/ for the datasource client | 14:25 |
| marios | for memory my queries are looking like this: (just fyi if anyone is interested) | 14:26 |
| marios | >>> res=prometheus.query("(node_memory_MemTotal_bytes{instance='localhost:9100'} - avg_over_time(node_memory_MemAvailable_bytes{instance='localhost:9100'}[300s])) / 1024 / 1024") | 14:26 |
| marios | >>> res[0].value | 14:26 |
| marios | '7684.184765624999' | 14:26 |
| marios | so, take total, subtract avg over the given time (300s) and it needs to be expressed in mb | 14:26 |
| marios | and we can also do min and max | 14:26 |
| marios | >>> res=prometheus.query("(node_memory_MemTotal_bytes{instance='localhost:9100'} - max_over_time(node_memory_MemAvailable_bytes{instance='localhost:9100'}[300s])) / 1024 / 1024") # for MIN usage, take MAX available | 14:27 |
| marios | >>> res[0].value | 14:27 |
| marios | '7672.7109375' | 14:27 |
| marios | similar for the MAX usage with min_over_time for available | 14:27 |
| marios | comments welcome :) (i'll post a wip patch with these tomorrow at some point as well) | 14:30 |
| sean-k-mooney | watcher unfortineltly currently only has unit tests instead of unit and functional | 14:37 |
| sean-k-mooney | so when it comes to testing you should be mockign out all calls ot promeitous and the observablity operator | 14:37 |
| marios | yeah | 14:45 |
| kopecmartin | hey .. i went through the open reviews and found a few that need only the final +w , if any core is around, please, have a look | 16:28 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher-specs/+/933299 | 16:28 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher-specs/+/933300 | 16:28 |
| kopecmartin | ^ they're related, the top level one was already +2 by chenker | 16:29 |
| kopecmartin | they just need to be workflowed :) | 16:29 |
| kopecmartin | then i found these, mainly housekeeping changes, please review when you have a moment: | 16:30 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher/+/932264 | 16:30 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher/+/927281 | 16:30 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher/+/907803 | 16:30 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher/+/918533 | 16:30 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher/+/911362 | 16:30 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher/+/911373 | 16:30 |
| kopecmartin | https://review.opendev.org/c/openstack/watcher/+/911368 | 16:30 |
| kopecmartin | maybe dansmith: gmann ^^ .. whenever you have time, no rush | 16:31 |
| sean-k-mooney | i wasnt quite sure about the reno updates | 16:39 |
| sean-k-mooney | i was debating if we shoudl merge all of them or just have a single patch to get everythign up to date | 16:39 |
| sean-k-mooney | releasen notes and generated form master for the docs site | 16:40 |
| sean-k-mooney | so we technally dont need to backport any of those patches | 16:40 |
| opendevreview | sean mooney proposed openstack/watcher master: [tox] update tox.ini to enable debugging https://review.opendev.org/c/openstack/watcher/+/934352 | 17:10 |
| opendevreview | Ghanshyam proposed openstack/watcher-tempest-plugin master: Remove stable/2023.1 job from master gate https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/934267 | 17:47 |
| dansmith | sean-k-mooney: yeah a single patch seems much better to me | 17:50 |
| gmann | kopecmartin: dansmith sean-k-mooney: I volunteer to be added in watcher core earlier to help dansmith fixes to land but as I do not contribute/maintain it (and new team is forming now) I would like not to be in core list. That is why I hesitant to +2/+w on wacther changes. | 18:00 |
| gmann | I can help maintaining the watcher-tempest-plugin so being core there is ok and helpful. | 18:00 |
| gmann | kopecmartin: as watcher-tempest-plugin share the core group, maybe we can separate both and you can add me in watcher-tempest-plugin only https://github.com/openstack/project-config/blob/master/gerrit/projects.yaml#L5923 | 18:02 |
| sean-k-mooney | at some point i would like to be added to watcher core list but for now im ok to wait while i get to grips with the codebase and the bugs im finding related to eventlet. ill try and review what i can regardless | 18:03 |
| sean-k-mooney | my knowladge of horizon an tempest is much less the service proejcts so while i can review patches to either plugin i do not have the intution regarding what is correct sytyle to build from | 18:05 |
| gmann | sean-k-mooney: but in that case I think dansmith will be only core there and change might have issue of landing? | 18:05 |
| dansmith | chenker is still acore | 18:05 |
| gmann | that is why I was waiting for myself to be removed from list in case we need help in landing some urgent things | 18:05 |
| gmann | dansmith: ohk then all good. I will remove myself. | 18:06 |
| gmann | dansmith: are you ok with creating the separate core for watcher-tempest-plugin? | 18:06 |
| dansmith | I agree we need more than just me and chenker for sure though, but I think chenker said he wanted to onboard some people, IIRC | 18:06 |
| dansmith | not sure if and how that will happen | 18:07 |
| dansmith | gmann: sure, fine with me and makes sense to have you there for sure | 18:07 |
| sean-k-mooney | so i can be added but i think we have other better prostion to review watcher-tempest-plugin who are more familar with tempest. my tempest experince is mainly from whitebox | 18:07 |
| gmann | sean-k-mooney: ack | 18:07 |
| opendevreview | Merged openstack/watcher master: reno: Update master for unmaintained/wallaby https://review.opendev.org/c/openstack/watcher/+/911368 | 18:08 |
| dansmith | sean-k-mooney: I mean I think you know as much or more about the code as me at this point, but I think we should make sure chenker is on board, has a plan, etc | 18:09 |
| gmann | ++ that will be better | 18:11 |
| sean-k-mooney | dansmith: yep i was going to reach out to them in a week or two and see if they were on board with that or not | 18:21 |
| sean-k-mooney | gmann: as an fyi im basically starting the py3.1/eventlet compat patch form scratch. I can rebase your ubuntu 24.04 patch once im happy it working as intended. | 18:24 |
| sean-k-mooney | gmann: watcher is mixing native threads, eventlet and in somecase asynio all at once. the behaivor on python 3.9 and 3.12 is differnt | 18:25 |
| gmann | dansmith: sean-k-mooney kopecmartin https://review.opendev.org/c/openstack/project-config/+/934357 | 18:25 |
| sean-k-mooney | so im preparing/using a rocky9 and ubuntu 24.04 env to test with the extrames of python supprot | 18:26 |
| gmann | sean-k-mooney: ack, feel free to update if anything needed on my ubuntu 24.04 patch o | 18:26 |
| opendevreview | Bryan Fraschetti proposed openstack/watcher stable/2023.1: Fix watcher comment https://review.opendev.org/c/openstack/watcher/+/934367 | 19:18 |
| opendevreview | Bryan Fraschetti proposed openstack/watcher stable/2023.2: Do not merge: CI test https://review.opendev.org/c/openstack/watcher/+/934379 | 20:07 |
| opendevreview | sean mooney proposed openstack/watcher master: [pre-commit] fix typos and configure codespell https://review.opendev.org/c/openstack/watcher/+/933044 | 21:57 |
| opendevreview | sean mooney proposed openstack/watcher master: [tox] update tox.ini to enable debugging https://review.opendev.org/c/openstack/watcher/+/934352 | 21:57 |
| opendevreview | sean mooney proposed openstack/watcher master: [eventlet] Ensure unit tests are monkey patched https://review.opendev.org/c/openstack/watcher/+/934385 | 21:57 |
| opendevreview | sean mooney proposed openstack/watcher master: [pre-commit] Fix execute and shebang lines https://review.opendev.org/c/openstack/watcher/+/934386 | 21:57 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!