| marios | Hi sean-k-mooney when you get a few please check my comment at https://review.opendev.org/c/openstack/watcher/+/934423/comment/d4299ddf_564ef3ba/ | 10:05 |
|---|---|---|
| opendevreview | Marios Andreou proposed openstack/watcher master: WIP Add prometheus data source for watcher decision engine https://review.opendev.org/c/openstack/watcher/+/934423 | 11:20 |
| opendevreview | Marios Andreou proposed openstack/watcher master: WIP Add prometheus data source for watcher decision engine https://review.opendev.org/c/openstack/watcher/+/934423 | 11:21 |
| sean-k-mooney | ill try and loop back to that later today | 11:56 |
| marios | exit | 16:43 |
| sean-k-mooney | dansmith: i spent a hour or 3 today trying to come up with a unit test without my chagne to prove that the schduler is not monkey patched but all i eneded up proving was in my unit test env it was. | 17:08 |
| dansmith | right but even just running over it to make sure it parses is better than nothing right? | 17:09 |
| sean-k-mooney | so i dont have a repoducer fro the issues but ill rework them into general tests and see if i can just add tests that assert the new calls happen in the main loop | 17:09 |
| sean-k-mooney | yes | 17:09 |
| sean-k-mooney | i was tryign to come up with a clean repoducer but sicne i cant | 17:09 |
| sean-k-mooney | ill just add general testing | 17:09 |
| sean-k-mooney | i might not get that pushed today but ill do it tomrowo if i dont | 17:10 |
| sean-k-mooney | dansmith: just wanted to keep you in the loop | 17:11 |
| dansmith | ack | 17:14 |
| gmann | sean-k-mooney: dansmith openstack admin is owner of https://launchpad.net/~watcher-drivers | 18:00 |
| gmann | let me know what all you want to add there | 18:00 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!