| opendevreview | Joan Gilabert proposed openstack/watcher master: Set number of decimal digits in efficacy indicator https://review.opendev.org/c/openstack/watcher/+/945199 | 10:11 |
|---|---|---|
| opendevreview | Matthieu Huin proposed openstack/watcher master: [DNM] RDO Zuul check job https://review.opendev.org/c/openstack/watcher/+/945079 | 13:23 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: DNM Test1 https://review.opendev.org/c/openstack/watcher/+/945213 | 14:03 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: DNM Test2 https://review.opendev.org/c/openstack/watcher/+/945214 | 14:03 |
| opendevreview | Francisco Seruca Salgado proposed openstack/watcher master: [DNM] RDO Zuul check job https://review.opendev.org/c/openstack/watcher/+/945079 | 15:45 |
| opendevreview | Francisco Seruca Salgado proposed openstack/watcher master: [DNM] RDO Zuul check job https://review.opendev.org/c/openstack/watcher/+/945079 | 15:48 |
| opendevreview | Francisco Seruca Salgado proposed openstack/watcher master: [DNM] RDO Zuul check job https://review.opendev.org/c/openstack/watcher/+/945079 | 15:51 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Check expected actions included in plans when executing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945233 | 16:03 |
| amoralej | ^ first proposal for check actionplans, i'm keeping it simple and just checking that the expected action types are included in the plan, lemme know if you think that's enough or what else should we check | 16:09 |
| *** jgilaber__ is now known as jgilaber | 16:12 | |
| jgilaber | as a first approach seems ok, should we also check the number of actions? | 16:13 |
| jgilaber | right now for example it can't distinguish between an action plan with 2 or 3 migrations | 16:13 |
| jgilaber | I don't know right now for how many existing tests this could be relevant (if any) | 16:14 |
| amoralej | that would be a good improvement my doubt is that the same test may create different number of actions in different environments | 16:15 |
| amoralej | i.e. the number of migrations in a consolidation strategies may depend on the number of compute nodes | 16:16 |
| amoralej | so, we'd need to add logic for that | 16:16 |
| jgilaber | that's true, could be hard in some cases | 16:16 |
| amoralej | but definetively, it would improve the test coverage | 16:16 |
| jgilaber | I think as it is is already a good improvement | 16:17 |
| amoralej | we may implement "type": <number> , and have a special value for "any" | 16:17 |
| amoralej | i wanted to have it simple, but It may be worthy to complicate it, feedback is appreciated | 16:18 |
| amoralej | don't hesitate to comment on the review, thans | 16:18 |
| amoralej | thanks | 16:18 |
| opendevreview | Francisco Seruca Salgado proposed openstack/watcher master: [DNM] RDO Zuul check job https://review.opendev.org/c/openstack/watcher/+/945079 | 16:20 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Check expected actions included in plans when executing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945233 | 16:27 |
| opendevreview | Francisco Seruca Salgado proposed openstack/watcher master: [DNM] RDO Zuul check job https://review.opendev.org/c/openstack/watcher/+/945079 | 16:31 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!