| jneo8 | Hi Watcher team,... (full message at <https://matrix.org/oftc/media/v1/media/download/AQxrMkw85N8c6ZKVAsJ8Px-MmM710lKoMpxlg8Yllka8COq2Fvi2QU-i7CIcrDTQXZSNmeXzcVWy3dx-dJGLoEJCeWGFIm8QAG1hdHJpeC5vcmcvcXl1TllleWxkWWRrUWlBQ2lLY1lHb2F5>) | 02:12 |
|---|---|---|
| sean-k-mooney | jneo8: it currently how its desgined yes, one thing that may be able to help is using nova notificatoin with watcher. watcher has the ablity to consome notificaiton but i have not had time to see if they cna be used today to refresh the cache | 03:50 |
| jneo8 | I see, can I open an issue as follow up and we can discuss there? | 03:51 |
| sean-k-mooney | am sure. the default interval is 1 hour. we are overriedign that in our downstream to i think 15mins initally until we get some expricne with the load that cretes | 03:54 |
| sean-k-mooney | ya i set them to 900 seconds https://github.com/openstack-k8s-operators/watcher-operator/blob/main/templates/00-default.conf#L104-L111 | 03:55 |
| sean-k-mooney | in ci we reduce ti 120 second but i dont think that would be reasonable to production | 03:55 |
| sean-k-mooney | jneo8: its defintly on of the design choices that we need to revisit | 03:56 |
| sean-k-mooney | jneo8: this is the current notifcaiotn code https://github.com/openstack/watcher/blob/035e6584c78e2b23a3afef8aaa1ff7696ab9f684/watcher/decision_engine/model/notification/nova.py#L252-L363 | 04:00 |
| sean-k-mooney | that should update the chaced model when instnace are migrated and services are disabled | 04:01 |
| sean-k-mooney | but only if you have enabel notifcaions in nova and configure watcher to consume them | 04:01 |
| sean-k-mooney | i have nto had time to audit that code to ensure it still works however | 04:03 |
| sean-k-mooney | jneo8: that shoudl do what you want in theory by updating the cache as the move operations complete rather then waiting for the perodic to run | 04:04 |
| jneo8 | Thanks sean, very helpful instruction. | 05:39 |
| jneo8 | I open an [issue](https://bugs.launchpad.net/watcher/+bug/2104220) as follow up. | 05:39 |
| opendevreview | Joan F Gilabert proposed openstack/watcher master: Set number of decimal digits in efficacy indicator https://review.opendev.org/c/openstack/watcher/+/945199 | 09:45 |
| opendevreview | Joan F Gilabert proposed openstack/watcher master: Set number of decimal digits in efficacy indicator https://review.opendev.org/c/openstack/watcher/+/945199 | 10:36 |
| sean-k-mooney | jneo8: another option would be to tweak the action plan to flush or refersh the cache as part of the actions performed by the audit | 11:56 |
| sean-k-mooney | jneo8: i.e. trigger a selective refresh of the affected instances/hosts after the action plan is completed | 11:57 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Add deprecation about client_functional tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/943133 | 12:44 |
| chandankumar | sean-k-mooney: Hello, I need some help to add deprecation message in the watcher tempest plugin functional tests on this cr https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/943133 , I have added it but it does not appear during functional tempest test execution, please have a look, when free, thank you! | 13:15 |
| sean-k-mooney | ack | 13:16 |
| sean-k-mooney | i wonder if it has somethign to do with our default log config | 13:16 |
| sean-k-mooney | this uses the default warning framework in python instead of the logging module | 13:17 |
| sean-k-mooney | we may now be redirecting that to the same location by default | 13:17 |
| chandankumar | sean-k-mooney: you mean tempest.conf default logging? | 13:23 |
| chandankumar | default_log_levels = ['amqp=WARN', 'amqplib=WARN', 'boto=WARN', 'qpid=WARN', 'sqlalchemy=WARN', 'suds=INFO', 'oslo.messaging=INFO', 'oslo_messaging=INFO', 'iso8601=WARN', 'requests.packages.urllib3.connectionpool=WARN', 'urllib3.connectionpool=WARN', 'websocket=WARN', 'requests.packages.urllib3.util.retry=WARN', 'urllib3.util.retry=WARN', 'keystonemiddleware=WARN', 'routes.middleware=WARN', 'stevedore=WARN', 'taskflow=WARN' | 13:23 |
| chandankumar | 'keystoneauth=WARN', 'oslo.cache=INFO', 'oslo_policy=INFO', 'dogpile.core.dogpile=INFO'] | 13:23 |
| chandankumar | from tempest.conf https://a3fd8c27c0382f01ec6b-02618f010e74d581319c83aa0d27e1a8.ssl.cf5.rackcdn.com/openstack/bbed1a09d95b4bf591525cfe939536d6/controller/logs/tempest_log.txt | 13:23 |
| sean-k-mooney | no not tempest. this is the service log config | 13:24 |
| sean-k-mooney | well | 13:24 |
| sean-k-mooney | actully its the plugin | 13:24 |
| sean-k-mooney | so ya i guess it would be tempst | 13:25 |
| sean-k-mooney | it proably would be good to ask about this in #openstack-qa | 13:25 |
| chandankumar | sure | 13:25 |
| sean-k-mooney | if we look at https://docs.openstack.org/debtcollector/latest/user/usage.html#removing-a-class-classmethod-method-function | 13:28 |
| sean-k-mooney | we likely need to add import warnings | 13:28 |
| sean-k-mooney | warnings.simplefilter("once") | 13:28 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Check expected actions included in plans when executing strategies https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945233 | 13:28 |
| sean-k-mooney | i dont think python warnings are logged by default | 13:29 |
| sean-k-mooney | ah we can also do it via https://docs.python.org/3/library/logging.html#logging.captureWarnings | 13:30 |
| sean-k-mooney | so what we actully want to do is call logging.captureWarnings(True) | 13:30 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Ensure test_execute_workload_stabilization_strategy creates non-emtpy action nplan https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945325 | 13:32 |
| chandankumar | ok, let me try with logging.capturewarning | 13:32 |
| sean-k-mooney | we do that in many but not all projects the rest use warnings.simplefilter so i think either is fine | 13:33 |
| sean-k-mooney | warnings.simplefilter allwos you to trun on some but not all warnings | 13:34 |
| sean-k-mooney | so you can do warnings.simplefilter('once', DeprecationWarning) | 13:34 |
| sean-k-mooney | that might be cleaner | 13:34 |
| sean-k-mooney | https://opendev.org/openstack/nova/src/branch/master/nova/tests/fixtures/nova.py#L821 | 13:35 |
| sean-k-mooney | by using the warning filters we can contole what prints and what does not with more granularity | 13:36 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Add deprecation about client_functional tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/943133 | 13:43 |
| chandankumar | sure, let me try that | 13:43 |
| sean-k-mooney | you still need to bring DeprecationWarning in scope | 13:57 |
| sean-k-mooney | i belive its actully warnings.DeprecationWarning | 13:57 |
| sean-k-mooney | https://docs.python.org/3/library/exceptions.html#DeprecationWarning | 13:57 |
| sean-k-mooney | oh maybe not | 13:57 |
| sean-k-mooney | its oen of the based builting excption classes | 13:58 |
| sean-k-mooney | ok that should be in scope by default | 13:58 |
| sean-k-mooney | and ya that confirm the behavior | 13:58 |
| sean-k-mooney | """Ignored by the default warning filters, except in the __main__ module (PEP 565). Enabling the Python Development Mode shows this warning.""" | 13:58 |
| sean-k-mooney | so we are not running in developer mode when we exectue tempest | 13:59 |
| sean-k-mooney | so thsoe are ignored by default | 13:59 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Add deprecation about client_functional tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/943133 | 14:42 |
| chandankumar | sean-k-mooney: in the last run, it came like this https://paste.openstack.org/raw/bgUVgcAtJMl6cpnM7FKG/ | 14:44 |
| chandankumar | https://storage.gra.cloud.ovh.net/v1/AUTH_dcaab5e32b234d56b626f72581e3644c/zuul_opendev_logs_175/openstack/175578d652e44550b22f85b62e692291/job-output.txt | 14:44 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Add real-data scenario tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945613 | 14:45 |
| chandankumar | or we can go via this https://docs.python.org/3/library/warnings.html#temporarily-suppressing-warnings | 14:47 |
| sean-k-mooney | chandankumar: that looks like we would expect | 14:56 |
| sean-k-mooney | its printed twice webase we scan the test once to buidl the test cases for each worker | 14:57 |
| sean-k-mooney | then we run the tests in a sepreate interpertr | 14:57 |
| sean-k-mooney | so we expect ti to be print 1+n times where n is the number of tempest workers | 14:58 |
| sean-k-mooney | so this is working as expected. | 14:58 |
| sean-k-mooney | no need to change anything | 14:58 |
| sean-k-mooney | why did you upload v8 | 14:59 |
| sean-k-mooney | that looks incorect as it never going to actully log anything now | 14:59 |
| sean-k-mooney | we shoudl revert back to v7 | 15:00 |
| chandankumar | just wanted to check the message what it returns | 15:04 |
| chandankumar | I will revert back to v7 | 15:04 |
| sean-k-mooney | you remove the raising of the message | 15:07 |
| sean-k-mooney | v8 sets up a filter to remove the message it does not raise one | 15:08 |
| opendevreview | chandan kumar proposed openstack/watcher-tempest-plugin master: Add deprecation about client_functional tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/943133 | 15:08 |
| chandankumar | ah ok, thank you for explaining :-) | 15:09 |
| chandankumar | thank you sean-k-mooney for helping on the deprecation patch. :-) | 15:09 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add real-data based tests to experimental pipeline https://review.opendev.org/c/openstack/watcher/+/945627 | 15:43 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add real-data based tests to experimental pipeline https://review.opendev.org/c/openstack/watcher/+/945627 | 16:05 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Add real-data scenario tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945613 | 16:47 |
| opendevreview | Ghanshyam proposed openstack/watcher-tempest-plugin master: Add deprecation about client_functional tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/943133 | 17:53 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add real-data based tests to experimental pipeline https://review.opendev.org/c/openstack/watcher/+/945627 | 19:10 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!