| *** gmann is now known as gmann_pto | 01:16 | |
| opendevreview | Takashi Kajinami proposed openstack/watcher-tempest-plugin master: Add stable/2025.1 job https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/947170 | 01:18 |
|---|---|---|
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: Ensure test_execute_workload_stabilization_strategy creates non-emtpy action nplan https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945325 | 07:15 |
| amoralej | jgilaber, chandankumar I've sent https://review.rdoproject.org/r/c/openstack/watcher-distgit/+/57428 to fix the packaging issue introduced in https://review.opendev.org/c/openstack/watcher/+/946182/ | 07:32 |
| amoralej | Also, for better testing, it'd be good to test that with https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945325 or real-data test in experimental added in https://review.opendev.org/c/openstack/watcher/+/945627 | 07:37 |
| jgilaber | @amoralej: thanks, I replied to my comment, the pymysql requirement is probably too high, I checked other projects and they are using older versions | 07:56 |
| jgilaber | I tested locally with 0.8.0 and it works well, so I could change to that, wdyt? | 07:56 |
| amoralej | that'd be good if it works | 07:57 |
| amoralej | keeping minimal requirements as low as possible is good, while it works, ofc | 07:57 |
| amoralej | specially being only test req | 07:58 |
| amoralej | lemme check the rel notes | 07:58 |
| amoralej | https://github.com/PyMySQL/PyMySQL/blob/main/CHANGELOG.md#v100 | 07:59 |
| amoralej | those are the backward incompatible changes | 07:59 |
| amoralej | actually https://github.com/openstack/oslo.db/blob/master/setup.cfg#L28 | 08:03 |
| amoralej | we probably should actually depend on oslo.db[mysql] instead of directly PyMySQL as in https://opendev.org/openstack/keystone/src/branch/master/test-requirements.txt#L7-L8 | 08:06 |
| amoralej | we don't import PyMySQL directly, so it'd be better to depend on the oslo.db with the mysql extra | 08:07 |
| jgilaber | that makes sense let me update the patch with the dependency to oslo.db and see if it works | 08:07 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add test for EfficacyIndicator value in mysql https://review.opendev.org/c/openstack/watcher/+/946182 | 08:07 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Set number of decimal digits in efficacy indicator https://review.opendev.org/c/openstack/watcher/+/945199 | 08:07 |
| amoralej | jgilaber, I just commented, oslo-db[fixtures] does not exist since long time ago and oslo-db[postgresql] is actually not required as we are testing only with mysql | 08:31 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add test for EfficacyIndicator value in mysql https://review.opendev.org/c/openstack/watcher/+/946182 | 08:50 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Set number of decimal digits in efficacy indicator https://review.opendev.org/c/openstack/watcher/+/945199 | 08:50 |
| jgilaber | thanks @amoralej fixed | 08:50 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher-tempest-plugin master: DNM test https://review.opendev.org/c/openstack/watcher/+/945199 https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/947207 | 10:03 |
| chandankumar | sean-k-mooney, Hello, these reviews https://review.opendev.org/c/openstack/watcher/+/943136 https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945009 and https://review.opendev.org/c/openstack/devstack-plugin-prometheus/+/946254 need one more +2, are good to go. Please add it to your queue, thank you! | 12:45 |
| sean-k-mooney | those all look fine. they shoudl merge shortly | 12:49 |
| chandankumar | sean-k-mooney, ++ thank you :-) | 12:49 |
| opendevreview | Merged openstack/watcher master: Replace watcherclient functional job with python-watcherclient-functional https://review.opendev.org/c/openstack/watcher/+/943136 | 13:32 |
| opendevreview | Merged openstack/watcher-tempest-plugin master: Drop watcherclient-tempest-functional job https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945009 | 13:32 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add real-data based tests to experimental and weekly pipelines https://review.opendev.org/c/openstack/watcher/+/945627 | 14:11 |
| opendevreview | Takashi Kajinami proposed openstack/puppet-watcher master: Stop overriding install_command https://review.opendev.org/c/openstack/puppet-watcher/+/947253 | 14:24 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Set number of decimal digits in efficacy indicator https://review.opendev.org/c/openstack/watcher/+/945199 | 15:07 |
| sean-k-mooney | tkajinam: do you know if the puppet folks actully maintain puppet-watcher any more? | 16:08 |
| sean-k-mooney | tripleo id defunt, packstack kind of exist but its not very active. puppet watch can be used stand alone but it might be worth asking if it shoudl be retired going forward | 16:10 |
| sean-k-mooney | tkajinam: unless you personally are interested in maintianing it we likely coudl deprecated it this cycle and remove it in 2026.2 if no one is using it | 16:11 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: skip metric injection when not needed https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/940171 | 16:20 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Ensure test_execute_workload_stabilization_strategy creates non-emtpy action nplan https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/945325 | 16:20 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: DNM test https://review.opendev.org/c/openstack/watcher/+/945199 https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/947207 | 16:20 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add test for EfficacyIndicator value in mysql https://review.opendev.org/c/openstack/watcher/+/946182 | 16:50 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Set number of decimal digits in efficacy indicator https://review.opendev.org/c/openstack/watcher/+/945199 | 16:50 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Always report standard deviation in workload_stabilization https://review.opendev.org/c/openstack/watcher/+/947267 | 16:50 |
| opendevreview | Douglas Viroel proposed openstack/watcher-specs master: Update 2025.2 spec directory and move spec implemented in 2025.1 https://review.opendev.org/c/openstack/watcher-specs/+/947271 | 17:56 |
| opendevreview | Douglas Viroel proposed openstack/watcher-specs master: Update 2025.2 spec directory and move spec implemented in 2025.1 https://review.opendev.org/c/openstack/watcher-specs/+/947271 | 18:14 |
| opendevreview | Douglas Viroel proposed openstack/watcher-specs master: Update 2025.2 spec directory and move spec implemented in 2025.1 https://review.opendev.org/c/openstack/watcher-specs/+/947271 | 19:31 |
| opendevreview | Douglas Viroel proposed openstack/watcher-specs master: Update 2025.2 spec directory and move spec implemented in 2025.1 https://review.opendev.org/c/openstack/watcher-specs/+/947271 | 19:33 |
| opendevreview | Douglas Viroel proposed openstack/watcher-specs master: Adds spec for extend compute model attributes https://review.opendev.org/c/openstack/watcher-specs/+/947282 | 19:51 |
| sean-k-mooney | dviroel: thanks doug ill take a look at those tomorrow | 20:24 |
Generated by irclog2html.py 2.17.3 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!