| opendevreview | Merged openstack/watcher-tempest-plugin master: Skip execute_workload_balance_strategy_cpu|ram due to known bug https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/955302 | 03:20 |
|---|---|---|
| amoralej | jgilaber, wrt https://review.opendev.org/c/openstack/watcher/+/954745 it's breaking your test _pre_upgrade_15f7375ca737 as it can not create an audit without the status_message column so fails in https://github.com/openstack/watcher/blob/master/watcher/tests/db/test_migrations.py#L152 | 08:20 |
| amoralej | dunno how to manage that, any idea? | 08:20 |
| amoralej | logs in https://zuul.opendev.org/t/openstack/build/996305808f4e44dab264c0a9ae177d6e | 08:20 |
| jgilaber | amoralej, the problem comes a discrepancy between the db model and the db schema at the point I guess | 08:28 |
| amoralej | exactly | 08:29 |
| amoralej | it expects audit to have a status_message field but the column does not exist yet | 08:29 |
| amoralej | same would happen when creating an actionplan or an action | 08:29 |
| jgilaber | right, when I added the test, I had the same problem but only with the efficacy indicator | 08:33 |
| jgilaber | as a workaround I created a function that would "manually" create it in the database without using the model | 08:34 |
| jgilaber | https://github.com/openstack/watcher/blob/374750847f3ca2284b455792c414808a55e181ff/watcher/tests/db/test_migrations.py#L117 | 08:34 |
| jgilaber | one option would be to do the same for audits and action plans | 08:35 |
| amoralej | what does that code? | 08:35 |
| jgilaber | that reads the existing schema from the db | 08:36 |
| jgilaber | and inserts a test object with that schema | 08:36 |
| jgilaber | it doesn't follow the db model from watcher, but the db schema at that point in time | 08:36 |
| jgilaber | I can give it a try if you want | 08:37 |
| amoralej | but, it's inserting a value into a pre-existing column? | 08:38 |
| amoralej | that's not what we need | 08:38 |
| jgilaber | in this particular case it would not insert a status_message, since when that test is running that does not exist in the schema yet | 08:39 |
| jgilaber | since your allembic migration has not been applied | 08:39 |
| amoralej | so, here is where the object is created https://github.com/openstack/watcher/blob/master/watcher/tests/objects/utils.py#L235-L245 iiuc | 08:40 |
| jgilaber | nop, it's using this one | 08:41 |
| jgilaber | https://github.com/openstack/watcher/blob/374750847f3ca2284b455792c414808a55e181ff/watcher/tests/db/utils.py#L313 | 08:41 |
| jgilaber | confusing, I know | 08:41 |
| amoralej | yeah, the first calls the second | 08:41 |
| amoralej | i see it now | 08:41 |
| amoralej | so, we could use https://github.com/openstack/watcher/blob/master/watcher/tests/db/utils.py#L82-L109 | 08:43 |
| amoralej | actually, i wonder if i should add status_message to those :) | 08:45 |
| jgilaber | yes, we should keep it up to date | 08:48 |
| jgilaber | I'm trying to test my idea locally, but need a few minutes to setup the db | 08:48 |
| amoralej | sure, no problem, no rush | 08:49 |
| amoralej | thanks! | 08:49 |
| jgilaber | amoralej, I got it to pass locally with this patch https://etherpad.opendev.org/p/db_migration_test_patch | 09:24 |
| amoralej | should i include it in my patch or do a separate one only for that an rebase? | 09:27 |
| jgilaber | I think that the change is small enough to keep it in the same patch | 09:44 |
| amoralej | ok, lemme send an update | 09:48 |
| opendevreview | David proposed openstack/watcher master: Disable real metrics on devstack injected data jobs https://review.opendev.org/c/openstack/watcher/+/955281 | 09:57 |
| opendevreview | David proposed openstack/watcher master: Disable real metrics on devstack injected data jobs https://review.opendev.org/c/openstack/watcher/+/955281 | 10:05 |
| opendevreview | David proposed openstack/watcher master: Disable real metrics on devstack injected data jobs https://review.opendev.org/c/openstack/watcher/+/955281 | 10:30 |
| opendevreview | David proposed openstack/watcher master: Disable real metrics on devstack injected data jobs https://review.opendev.org/c/openstack/watcher/+/955281 | 10:31 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: [WIP] Enable listing storage model https://review.opendev.org/c/openstack/watcher/+/955365 | 11:40 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume retype with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954625 | 11:42 |
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add custom flavor and dynamic threshold to workload_balance tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/953853 | 12:37 |
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add custom flavor and dynamic threshold to workload_balance tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/953853 | 12:42 |
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add custom flavor and dynamic threshold to workload_balance tests https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/953853 | 13:17 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add status_message fields to audit, action and actionplan https://review.opendev.org/c/openstack/watcher/+/954745 | 13:44 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Skip actions automatically based on pre_condition results https://review.opendev.org/c/openstack/watcher/+/954746 | 13:44 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: [WIP] Enable listing storage model https://review.opendev.org/c/openstack/watcher/+/955365 | 14:26 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume retype with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/954625 | 14:26 |
| *** haleyb is now known as haleyb|out | 18:33 | |
| -opendevstatus- NOTICE: The Gerrit service on review.opendev.org will be offline briefly for a configuration and version update, but should return to service momentarily | 20:07 | |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!