| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add support for passing parameters while creating audit https://review.opendev.org/c/openstack/watcher-dashboard/+/957535 | 07:46 |
|---|---|---|
| opendevreview | Merged openstack/watcher master: Rename confusing query timeout options https://review.opendev.org/c/openstack/watcher/+/958507 | 09:26 |
| opendevreview | David proposed openstack/watcher master: Update aetos fake data job to disable real metrics https://review.opendev.org/c/openstack/watcher/+/958760 | 10:48 |
| opendevreview | David proposed openstack/watcher master: Update aetos fake data job to disable real metrics https://review.opendev.org/c/openstack/watcher/+/958760 | 10:51 |
| dviroel | hi all o/ | 11:50 |
| dviroel | watcher weekly meeting will start in 9 | 11:51 |
| dviroel | https://etherpad.opendev.org/p/openstack-watcher-irc-meeting#L25 | 11:51 |
| rlandy | o/ | 12:00 |
| dviroel | #startmeeting watcher | 12:00 |
| opendevmeet | Meeting started Thu Aug 28 12:00:57 2025 UTC and is due to finish in 60 minutes. The chair is dviroel. Information about MeetBot at http://wiki.debian.org/MeetBot. | 12:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 12:00 |
| opendevmeet | The meeting name has been set to 'watcher' | 12:00 |
| dviroel | hi all o/ | 12:01 |
| chandankumar | \o | 12:01 |
| dviroel | who's around today? | 12:01 |
| morenod | o/ | 12:01 |
| jgilaber | o/ | 12:01 |
| dviroel | courtesy ping: amoralej sean-k-mooney | 12:02 |
| sean-k-mooney | o/ | 12:02 |
| dviroel | amoralej is out today.. | 12:02 |
| dviroel | lets start | 12:02 |
| dviroel | today's meeting agenda | 12:02 |
| dviroel | #link https://etherpad.opendev.org/p/openstack-watcher-irc-meeting#L30 (Meeting agenda) | 12:02 |
| dviroel | feel free to add your own topics to the agenda | 12:02 |
| dviroel | first one | 12:03 |
| dviroel | #topic Flamingo Feature Freeze | 12:03 |
| dviroel | we reach the flamingo feature freeze | 12:03 |
| dviroel | #link https://releases.openstack.org/flamingo/schedule.html | 12:03 |
| dviroel | which means that no feature should be landed after this deadline, unless your explicit require an exception | 12:04 |
| dviroel | but I don't think that is the case of watcher this cycle :) | 12:04 |
| sean-k-mooney | techinally its end of day | 12:04 |
| dviroel | right | 12:04 |
| sean-k-mooney | so the only "feautre" i think we may merge woudl be the watcher client update | 12:05 |
| sean-k-mooney | for the skip change | 12:05 |
| dviroel | if we check our etherpad | 12:05 |
| sean-k-mooney | althogh i have not reviewed that properly yet | 12:05 |
| dviroel | #link https://etherpad.opendev.org/p/watcher-flamingo-status | 12:05 |
| dviroel | Host Maintenance Strategy - Disable Migration [MERGED] | 12:05 |
| dviroel | main patch merged, we only have tempest plugin change to merge, which is fine | 12:05 |
| dviroel | but requires some attention from the owner | 12:06 |
| dviroel | i will send a comment in the patch later today | 12:06 |
| sean-k-mooney | yep that can merge at any time once ready | 12:06 |
| dviroel | Add Skip Actions [MERGED] | 12:06 |
| dviroel | as sean-k-mooney mentioned, we still have the client to review/merge | 12:07 |
| dviroel | the main patches landed | 12:07 |
| dviroel | I alredy did a review in the client, looks good, just added a comment about default microversion | 12:07 |
| sean-k-mooney | i see your +1 on the tempest change and chandankumar is +2 | 12:07 |
| sean-k-mooney | do we want to proceed with is as is | 12:08 |
| dviroel | maybe chandankumar can also take a look and help us with a follow up if needed | 12:08 |
| sean-k-mooney | and extend in a folow up? | 12:08 |
| dviroel | sean-k-mooney: works for me, not a blocker | 12:08 |
| sean-k-mooney | your main concern was adding senario tests in addtion to the api tests right | 12:08 |
| dviroel | yes | 12:09 |
| dviroel | it is kind of hidden there | 12:09 |
| chandankumar | dviroel: I am working on updating python-watcherclient patch | 12:09 |
| dviroel | but it is at least validating the implementation | 12:09 |
| sean-k-mooney | i woudl like to get some coverage in sooner rather then later so given alfredo will be on pto for a while i think we can proceed with this as a baselien if no one objects | 12:09 |
| dviroel | chandankumar: thanks! | 12:09 |
| dviroel | sean-k-mooney: agree | 12:09 |
| dviroel | we didn't have too much time do discuss that | 12:10 |
| dviroel | but it is better to merge as is, and have the tests running | 12:10 |
| chandankumar | dviroel: dashboard one is almost ready, I am working on adding status_field to the action info | 12:10 |
| dviroel | chandankumar: ok, I haven't look at that yet | 12:10 |
| sean-k-mooney | im partly open to the idea of a feature freeze exception if its ready by the end of day tomorrow | 12:11 |
| sean-k-mooney | for the dashbaord pices | 12:12 |
| sean-k-mooney | but after that i would prefer to adress this next cycle | 12:12 |
| sean-k-mooney | that assume we get the clinet change landed today | 12:12 |
| dviroel | i am ok with that too | 12:13 |
| sean-k-mooney | and can do a relase this week. | 12:13 |
| sean-k-mooney | i said this last cycle by the way | 12:13 |
| sean-k-mooney | but the general rule of thumb is if its +2w by FF you are allowed to recheck it up until the next monday to get it landed | 12:14 |
| sean-k-mooney | after that the grace perod has ended but i dont think we will have that problem | 12:14 |
| sean-k-mooney | we dont have a lot of patches pending | 12:14 |
| dviroel | chandankumar: ok, so we count on you for updating those, let us know if you need help with something | 12:14 |
| opendevreview | chandan kumar proposed openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 12:15 |
| dviroel | oh, you are fast :) | 12:15 |
| chandankumar | dviroel: ^^ | 12:15 |
| dviroel | ok, sean-k-mooney will also need to look at the client and we can see if is really ready | 12:16 |
| dviroel | tks chandankumar | 12:16 |
| dviroel | I will check the dashboard later | 12:16 |
| dviroel | anything else for this feature? | 12:17 |
| dviroel | next one is | 12:17 |
| dviroel | Extend Compute Model Attributes [MERGED] | 12:17 |
| dviroel | we discussed in previous meetings the limitatio of the max api version in the novaclient | 12:17 |
| dviroel | which limited us to a smaller set of attributes added in the model | 12:18 |
| dviroel | we merged the feature based on that | 12:18 |
| dviroel | a spec updated is open for review | 12:18 |
| dviroel | #link https://review.opendev.org/c/openstack/watcher-specs/+/955921 | 12:19 |
| dviroel | which address these concerns | 12:19 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add option to SKIP Actions https://review.opendev.org/c/openstack/watcher-dashboard/+/958209 | 12:19 |
| dviroel | with that, the api microversion 1.6 should be the max microversion for this cycle | 12:19 |
| dviroel | the changes that we miss to land are the tempest plugin ones too | 12:20 |
| dviroel | which cover some tests to data_model list (1.3) | 12:20 |
| dviroel | and the extended attributes (1.6) | 12:20 |
| dviroel | no changes are expected in the client | 12:20 |
| dviroel | the data model list in the client already display a limited list of attributes | 12:21 |
| dviroel | only the most important ones like, host and server uuids, states, etc. | 12:21 |
| sean-k-mooney | ack, again on the tempest changes we can merge those up to rc1, we done branch the plugin so we can merge after rc 1 as well but we may want to sablise the plugin whiel the final release is happening | 12:22 |
| sean-k-mooney | we can dicuss tha as we go | 12:22 |
| dviroel | ack | 12:22 |
| sean-k-mooney | ya im not entirly sure what to do about this api in general and the client support for it | 12:22 |
| sean-k-mooney | this si one of the api that i think was a mistake in the past to expsoe in the rest api | 12:23 |
| dviroel | right, and tbh I think that today is only useful for tempest tests | 12:23 |
| sean-k-mooney | we coudl continue to supprot it but if we want to ever run more then 1 decsion enghine we need to refactor how we store the datamodel | 12:23 |
| sean-k-mooney | so for now im not worreied about the divergace betwen the api respocne and the cli view | 12:24 |
| sean-k-mooney | because as you said its already a subset | 12:24 |
| dviroel | correct | 12:25 |
| sean-k-mooney | but i do think we want to think about this before adding https://review.opendev.org/c/openstack/watcher/+/955365 | 12:25 |
| jgilaber | yes, as dviroel said, the only use for this is in tempest tests | 12:26 |
| sean-k-mooney | basicly do we want to remove it in a new microversoin effectivly freezing the api respocne to what is in 1.6 | 12:26 |
| dviroel | ack, we need to discuss more about that | 12:26 |
| sean-k-mooney | or continue to extned it in which case we need to prioritize making it scaleable | 12:26 |
| jgilaber | and notifications solve the problem without it | 12:26 |
| dviroel | this may be a good topic for another meeting or ptg | 12:27 |
| sean-k-mooney | yep | 12:27 |
| sean-k-mooney | ill add it to the ptg list if its not already there | 12:28 |
| dviroel | ack, thanks sean-k-mooney | 12:28 |
| dviroel | ok, that's it for this feature | 12:28 |
| dviroel | the other 2 we already covered in last week's meeting | 12:28 |
| dviroel | Eventlet Removal and Aetos datasource are done for this cycle | 12:29 |
| dviroel | with CI jobs already in place | 12:29 |
| dviroel | anything else that we should discuss about FF? | 12:29 |
| sean-k-mooney | on thing | 12:30 |
| * dviroel waits | 12:30 | |
| sean-k-mooney | tthe monasca client patch | 12:30 |
| dviroel | oh | 12:30 |
| sean-k-mooney | https://review.opendev.org/c/openstack/watcher/+/956968 | 12:30 |
| sean-k-mooney | ill be rebaseing this today | 12:31 |
| sean-k-mooney | but i woudl like to treat that as a bugfix not a feature | 12:31 |
| sean-k-mooney | which is why i filed abug so assuming there is no objection | 12:31 |
| dviroel | ack | 12:31 |
| sean-k-mooney | then that can merge up until rc1 | 12:31 |
| sean-k-mooney | so just callign out that im not expecting this to be blocked by FF unless there i an objection | 12:32 |
| sean-k-mooney | i should get it rebased in an hour or so anyway | 12:32 |
| sean-k-mooney | but that was all i had | 12:32 |
| dviroel | is there any objections on sean-k-mooney proposal? | 12:32 |
| jgilaber | +1 from me to consider it a bug, since the project is retired | 12:32 |
| sean-k-mooney | i guess there is a followup but ill also need input form the stable team | 12:33 |
| sean-k-mooney | the followup being once we are happy with it do we want to backport it or not | 12:33 |
| sean-k-mooney | this si not normlaly something we would backport | 12:33 |
| sean-k-mooney | but again its now retired and monascal has not had a release since 2023.1 | 12:34 |
| dviroel | right, it has some upgrade impact | 12:34 |
| sean-k-mooney | so i woudl like to get input form the stable team on that | 12:34 |
| dviroel | thanks sean-k-mooney - lets us know how it goes | 12:34 |
| dviroel | ok, so I will move to the next topic | 12:34 |
| dviroel | #topic Elections for PTL/TC are open | 12:35 |
| dviroel | a reminder that elections for PTL/TC are open | 12:35 |
| dviroel | #link https://lists.openstack.org/archives/list/openstack-discuss@lists.openstack.org/thread/5WLCZVX7VSIVQDWOSH6KTHM62275WIQW/ | 12:35 |
| dviroel | if you are eligible to vote, please check your email, you should receive a link to the voting pool | 12:36 |
| dviroel | and watcher will go with DPL model once again | 12:37 |
| dviroel | the current model proposal is here | 12:38 |
| dviroel | #link https://review.opendev.org/c/openstack/governance/+/958085 | 12:38 |
| dviroel | i think that we are just missing dan approval there | 12:38 |
| dviroel | to proceed | 12:38 |
| dviroel | I may ping him later today to get his attention to this patch | 12:39 |
| dviroel | any question or concerns? | 12:39 |
| dviroel | #topic Reviews | 12:40 |
| dviroel | in general, i would propose you to add your patches to the review list | 12:40 |
| dviroel | https://etherpad.opendev.org/p/watcher-flamingo-status#L41 | 12:40 |
| dviroel | i already start reviewing some of them from there | 12:40 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add option to SKIP Actions https://review.opendev.org/c/openstack/watcher-dashboard/+/958209 | 12:40 |
| dviroel | anyone wants to bring any specific change for review? | 12:41 |
| dviroel | ok, as mentioned before, we have until rc1 to merge bugfixes, so the focus next will be these changes | 12:41 |
| dviroel | next topic | 12:41 |
| dviroel | #topic Bug Triage | 12:42 |
| dviroel | #link https://bugs.launchpad.net/watcher/+bug/2121147 (Storage model assumes 'total_volumes' is reported by all drivers) | 12:42 |
| dviroel | already covered last week | 12:42 |
| dviroel | but we are missing some triage there | 12:42 |
| dviroel | jgilaber: it doesn't affect any strategy for now right? | 12:43 |
| jgilaber | I think that can be considered low/medium, it does not cause the audits to fail | 12:43 |
| jgilaber | just pollute the logs | 12:43 |
| dviroel | ack, i would vote for low then | 12:43 |
| dviroel | jgilaber: feel free to upgrade for medium if you find that it affect more than initially expected | 12:44 |
| dviroel | next is | 12:44 |
| sean-k-mooney | ya if it does not fail i woudl not set it above medium | 12:44 |
| jgilaber | ack | 12:44 |
| sean-k-mooney | low sound ok | 12:44 |
| dviroel | #link https://bugs.launchpad.net/watcher/+bug/2120666 (Errors appear in decision-engine logs when cinder, notifications and storage collector are enabled) | 12:44 |
| dviroel | also covered last week | 12:44 |
| jgilaber | this is similar imo | 12:45 |
| jgilaber | the model builds find, just logs an exception without enough context | 12:45 |
| dviroel | not sure if it affects how the model is built | 12:45 |
| jgilaber | I meant to say the model builds fine | 12:46 |
| dviroel | or if just ignore the error and continues | 12:46 |
| dviroel | ack | 12:46 |
| dviroel | so we set to Low as the previous | 12:46 |
| jgilaber | +1 | 12:46 |
| dviroel | if we identify that it affects more, we increase the importance | 12:46 |
| dviroel | nice | 12:47 |
| dviroel | next | 12:47 |
| dviroel | #link https://bugs.launchpad.net/watcher/+bug/2121384 (Watcher docs have an incorrect way of configuring cinder notifications) | 12:47 |
| dviroel | this is a new one | 12:47 |
| dviroel | thanks jgilaber for reporting the issue | 12:47 |
| sean-k-mooney | yep this came out of a conversation i had with jgilaber | 12:47 |
| jgilaber | I opened this one when I tried to follow to docs to enable cinder notifications | 12:47 |
| dviroel | so this is already in progress, and it is a doc update right | 12:48 |
| jgilaber | I improved the patch with suggestions from sean-k-mooney | 12:48 |
| sean-k-mooney | the patch is not linked to the bug by hte way | 12:48 |
| jgilaber | now it also fixes the default values for the notification topics that watcher listens to | 12:48 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/957668 | 12:48 |
| jgilaber | ^this is the patch, not sure why is not being linked to the bug | 12:49 |
| dviroel | oh, so it is not doc only | 12:49 |
| jgilaber | initially I thought it would be doc only, but it grew slightly in scope | 12:49 |
| jgilaber | the patch itself is really small though | 12:50 |
| sean-k-mooney | so it should have a release note | 12:50 |
| sean-k-mooney | but im debating | 12:50 |
| sean-k-mooney | if we want to keep listing to the watcher topic as well | 12:50 |
| sean-k-mooney | or replace it as you have | 12:50 |
| sean-k-mooney | long term the replacement is correct | 12:50 |
| jgilaber | ack, I'll add the release note | 12:51 |
| sean-k-mooney | short term its a trivial but still precense upgrade impact | 12:51 |
| opendevreview | chandan kumar proposed openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 12:51 |
| sean-k-mooney | what i would personally do is have 2 patches | 12:51 |
| dviroel | jgilaber: i think that because needs to be "Closes-Bug: #1234567" | 12:51 |
| sean-k-mooney | the fisrt woudl jsut add the new topic | 12:51 |
| jgilaber | I'm fine adding the openstack.notification and removing the wtacher one in next cycle | 12:51 |
| sean-k-mooney | the second would remove the old one | 12:51 |
| sean-k-mooney | we would backprot the first patch but not the second | 12:52 |
| dviroel | +1 | 12:52 |
| jgilaber | ok, sounds good, I can do that | 12:52 |
| sean-k-mooney | cool | 12:52 |
| dviroel | should we stay with that bug as Low? | 12:53 |
| sean-k-mooney | so this is a docs/defaulitng but | 12:53 |
| sean-k-mooney | *bug but you can workaround it manually so ya low | 12:53 |
| jgilaber | dviroel, I can try that but other patches like https://review.opendev.org/c/openstack/watcher/+/951323/15//COMMIT_MSG worked without the '#' | 12:53 |
| dviroel | jgilaber: yeah right, it was a guess | 12:53 |
| sean-k-mooney | the bot might be picker | 12:53 |
| dviroel | yep | 12:53 |
| sean-k-mooney | the link rednerign in gerrit is sperate form the bot that adds the links ot launchpad | 12:54 |
| jgilaber | maybe it's because of the docs tag? | 12:54 |
| sean-k-mooney | no that wont affect anything | 12:54 |
| sean-k-mooney | the other posiblity is its becasue you didnt add it in v1 | 12:55 |
| sean-k-mooney | in any case it tivial to add a liknk as a comment in the bug | 12:55 |
| sean-k-mooney | but try the # | 12:55 |
| dviroel | yeah | 12:55 |
| sean-k-mooney | if that does not work can you just add the link in a comment on lauhcpad | 12:55 |
| jgilaber | yes, I think that's right, I forgot it in the first PS | 12:55 |
| dviroel | ok, anything else on this bug? otherwise I will move to the next topic | 12:55 |
| jgilaber | all good for me | 12:56 |
| dviroel | #topic release stuff | 12:56 |
| dviroel | sean-k-mooney: want to highlight that one? | 12:56 |
| sean-k-mooney | ya this will be short | 12:56 |
| dviroel | #link https://review.opendev.org/c/openstack/releases/+/958468 | 12:56 |
| sean-k-mooney | so i just summerised what need to get done in the next 3 weeks | 12:56 |
| sean-k-mooney | so today we releaed all the stable branches with the security fix | 12:56 |
| sean-k-mooney | next week we need to start workign on the cycle highlight and release note prelude | 12:57 |
| sean-k-mooney | the week after we prepare RC1 | 12:57 |
| opendevreview | Merged openstack/watcher-tempest-plugin master: Add api test for skip action https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/955775 | 12:57 |
| sean-k-mooney | and once that is relased master will reopen for 2026.1 | 12:57 |
| sean-k-mooney | at rc1 stable 2025.2 will be created | 12:58 |
| sean-k-mooney | and there are a few bot propospoed patches we need to merge | 12:58 |
| sean-k-mooney | so if folks want to knwo more i put more links in the ether pad | 12:58 |
| dviroel | nice, thanks sean-k-mooney | 12:58 |
| dviroel | thanks for the release liason work during these last cycles | 12:59 |
| chandankumar | sean-k-mooney: can you summarize realse tasks for next release in a etherpad so that Joan and I can pick up. | 12:59 |
| jgilaber | thanks for the info sean-k-mooney! | 12:59 |
| dviroel | chandankumar: https://docs.openstack.org/watcher/latest/contributor/release-guide.html | 12:59 |
| dviroel | there is a lot of info here too ^ | 13:00 |
| sean-k-mooney | chandankumar: ya so we are at https://docs.openstack.org/watcher/latest/contributor/release-guide.html#week-following-milestone-3 | 13:00 |
| chandankumar | dviroel: thanks! | 13:00 |
| sean-k-mooney | and we need to complete the next few sections in order | 13:00 |
| sean-k-mooney | after RC1 ships we start the hand of to the new release liasons | 13:00 |
| dviroel | chandankumar: jgilaber: if you find that some info is missing, we can update this official doc then | 13:01 |
| jgilaber | ack, thanks | 13:01 |
| chandankumar | thanks! | 13:01 |
| dviroel | jgilaber: chandankumar tks for taking this role | 13:02 |
| sean-k-mooney | by the way we have to do this for all our delibvier not just watcher core | 13:02 |
| sean-k-mooney | i.e. the release note prelue ectra although we only really need 1 cycle highlishts | 13:02 |
| jgilaber | that's the client and dashboard but not the tempest plugin, correct? | 13:02 |
| sean-k-mooney | mostly correct | 13:02 |
| sean-k-mooney | https://docs.openstack.org/watcher/latest/contributor/release-guide.html#project-context | 13:02 |
| sean-k-mooney | we do not branch the tempest plugin and its release with the other tempest plugins following there timeline | 13:03 |
| * dviroel time check | 13:03 | |
| sean-k-mooney | and watcher-specs is not released at all | 13:03 |
| jgilaber | ah, right | 13:03 |
| sean-k-mooney | but ya read over that doc it has the details | 13:03 |
| dviroel | thanks morenod for volunteering for next meeting chair | 13:04 |
| dviroel | let's wrap up for today | 13:04 |
| dviroel | thank you all for participating | 13:04 |
| dviroel | #endmeeting | 13:04 |
| opendevmeet | Meeting ended Thu Aug 28 13:04:34 2025 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 13:04 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/watcher/2025/watcher.2025-08-28-12.00.html | 13:04 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/watcher/2025/watcher.2025-08-28-12.00.txt | 13:04 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/watcher/2025/watcher.2025-08-28-12.00.log.html | 13:04 |
| sean-k-mooney | jgilaber: chandankumar we can proably improve the formatign of that doc a bit but if there is anything ye want to knwo reach out. ill add ye as reviewers to all the relevent patches i am creating for this cycle | 13:05 |
| chandankumar | dviroel: All the comments addressed for python-watcherclient skip action: https://review.opendev.org/c/openstack/python-watcherclient/+/956911 Do let me know If I missed anything | 13:06 |
| chandankumar | dviroel: sean-k-mooney Skip action watcher-dashboard cr https://review.opendev.org/c/openstack/watcher-dashboard/+/958209 ready for review. pre/post screenshots: https://review.opendev.org/c/openstack/watcher-dashboard/+/958209/3#message-74415af2453e3909716acc70e11d570a37da563b | 13:07 |
| chandankumar | thank you! | 13:07 |
| dviroel | chandankumar: one comment in the client, the implementation sets --state as mandatory, because it is the only possible update | 13:14 |
| dviroel | but this will not be true once we include more operations to the update | 13:14 |
| sean-k-mooney | if we do that | 13:16 |
| sean-k-mooney | but yes it am not sure it should be mandatory today | 13:16 |
| sean-k-mooney | aslo im not sure i agree with usign --reason | 13:17 |
| sean-k-mooney | i need to review it proprly | 13:17 |
| sean-k-mooney | but im conflicted beween keepign it close too the api field "status_messsage" and keeping it short i.e. --message | 13:18 |
| opendevreview | chandan kumar proposed openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 13:19 |
| sean-k-mooney | the filed was previsoulsy called reason in the spec but we changed it before it merged and i think that | 13:19 |
| chandankumar | dviroel: yes, done1 | 13:20 |
| sean-k-mooney | -1 on what you just changed | 13:20 |
| chandankumar | sean-k-mooney: sorry did not get that, is it for python-watcherclient patch update? | 13:22 |
| sean-k-mooney | yes | 13:23 |
| sean-k-mooney | the change you made are incorerct | 13:23 |
| sean-k-mooney | i was in the middel of repsonding ot doug on gerrit when you pushed them | 13:23 |
| chandankumar | this is what we have from cli https://paste.openstack.org/raw/b9w6CBLJJw2HbrGHPX3r/ | 13:24 |
| chandankumar | last update I made was based on that before doug's comment | 13:24 |
| sean-k-mooney | you moved --state into positional arguments | 13:25 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Fix doc section to enable cinder notifications https://review.opendev.org/c/openstack/watcher/+/957668 | 13:25 |
| sean-k-mooney | which it is not | 13:25 |
| sean-k-mooney | also the client change is requriing it to be passed which is incorrect | 13:25 |
| sean-k-mooney | it shoudl be optional as you shoudl be able to update the status_message without updating the state if its in skiped | 13:26 |
| dviroel | sean-k-mooney: i think that the client is following the main patch | 13:28 |
| dviroel | which also blocks status_message from updating without a state change | 13:29 |
| sean-k-mooney | if it is then we have a bug in the api | 13:29 |
| dviroel | don't remember if was discussed in the spec | 13:29 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Remove watcher_notifications from default value https://review.opendev.org/c/openstack/watcher/+/958766 | 13:29 |
| sean-k-mooney | dviroel: ah here https://github.com/openstack/watcher/blob/master/watcher/api/controllers/v1/action.py#L445-L450 | 13:29 |
| sean-k-mooney | ya so that defintly a bug that we shoudl fix before RC1 | 13:30 |
| sean-k-mooney | we can limit changing the status_message to the skipped state | 13:30 |
| sean-k-mooney | but currenlty if you make a typo you could never fix it | 13:30 |
| dviroel | yeah right | 13:31 |
| sean-k-mooney | so the api check shoudl check for the skipped state instead of changed | 13:32 |
| sean-k-mooney | and the client shoudl not do any check and have the arge be optional | 13:32 |
| sean-k-mooney | we woudl return a 409 conflict if it was not in the correct state | 13:32 |
| dviroel | from client pov we can fix now, to support both updates | 13:33 |
| sean-k-mooney | ya we can | 13:33 |
| dviroel | we don't need to store too much logic in client side | 13:34 |
| sean-k-mooney | ya in general we shoudl keep the client simple | 13:34 |
| sean-k-mooney | im going to grab a coffee then rebase my monasca client patch | 13:34 |
| sean-k-mooney | once i have that doen i can file a bug and fix the api error | 13:35 |
| dviroel | chandankumar: are you ok with that update ^ | 13:35 |
| sean-k-mooney | assumign someoen esle does not get to it before then | 13:35 |
| opendevreview | chandan kumar proposed openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 13:35 |
| chandankumar | dviroel: yes | 13:36 |
| dviroel | sean-k-mooney: does it requieres a bug? if was not yet released? | 13:36 |
| chandankumar | I was also checking dashboard patch, action can be skipped without reason. and Status Message | 13:36 |
| chandankumar | Action skipped by user.like this. | 13:36 |
| dviroel | it is good to document the issue anyways, so I am fine with file a LP | 13:37 |
| dviroel | chandankumar: it is not mandatory to provide a message | 13:39 |
| dviroel | the default message today is: https://github.com/openstack/watcher/blob/848cde3606fc15d7975d42b888c672fb4aabef90/watcher/api/controllers/v1/action.py#L441 | 13:40 |
| dviroel | which is being set in the api, which may not be correct too imho | 13:40 |
| dviroel | we can update the status_message once the Action is really skipped | 13:40 |
| dviroel | something to cover in the fix | 13:40 |
| chandankumar | some cli examples : https://paste.openstack.org/raw/bsuUWrpR8vKiXO1i28Bj/ | 13:41 |
| chandankumar | dviroel: you mean should drop 'Action skipped by user' from dashboard when action is skipped without reason? | 13:43 |
| chandankumar | you can see the above cli examples for skip with and without reason | 13:44 |
| dviroel | chandankumar: you don't need to do anything in the dashboard, the logic is on watcher side, which we will fix next | 13:44 |
| chandankumar | ack!, yes got it | 13:44 |
| sean-k-mooney | dviroel: technially we coudl not file one but that takes 2 seconds to do | 13:48 |
| dviroel | ack | 13:48 |
| sean-k-mooney | if we had released then fixing this would need a new microverion however | 13:49 |
| opendevreview | Merged openstack/python-watcherclient master: Drop explicit dependency on python-subunit https://review.opendev.org/c/openstack/python-watcherclient/+/952259 | 15:07 |
| opendevreview | sean mooney proposed openstack/watcher master: Allow status_message updates for actions in SKIPPED state https://review.opendev.org/c/openstack/watcher/+/958778 | 15:17 |
| sean-k-mooney | dviroel: so ^ that should fix the api issue | 15:18 |
| sean-k-mooney | we shoudl have ci restulst in 90-120 mins ish | 15:18 |
| dviroel | ack, thanks! | 15:19 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: [WIP] Add some debug logs to storage model https://review.opendev.org/c/openstack/watcher/+/958781 | 15:50 |
| opendevreview | Douglas Viroel proposed openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 15:51 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 15:52 |
| opendevreview | Douglas Viroel proposed openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 15:57 |
| opendevreview | sean mooney proposed openstack/watcher master: Make Monasca client optional and lazy-load https://review.opendev.org/c/openstack/watcher/+/956968 | 16:02 |
| opendevreview | Douglas Viroel proposed openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 17:44 |
| dviroel | sean-k-mooney: client updated ^ if you are still around | 18:01 |
| sean-k-mooney | yep for about anohter hour | 18:06 |
| sean-k-mooney | im just finsihng reviewing the sev serise in nova so ill be done with that shortly | 18:06 |
| dviroel | ack | 18:12 |
| sean-k-mooney | dviroel: im looking at the client patch now but are you happy to proceed with https://review.opendev.org/c/openstack/watcher/+/956968 | 19:04 |
| sean-k-mooney | i saw you reveiwed the api fix so ill +w that before i leave | 19:04 |
| dviroel | sean-k-mooney: with monasca patch? yes | 19:09 |
| sean-k-mooney | ya the monsasca patch. i your happy with the rebase mind reapplying your +2 and adding w | 19:10 |
| dviroel | done | 19:11 |
| sean-k-mooney | i see possibly 2 testing issues with https://review.opendev.org/c/openstack/python-watcherclient/+/956911 but im reluctant to ask you to repine to fix them | 19:18 |
| sean-k-mooney | im willing to see if https://review.opendev.org/c/openstack/python-watcherclient/+/956911/comment/426a1b24_67b7ed3f/ is stable | 19:19 |
| sean-k-mooney | if it is it will give us a ci speedup by only creating the audit once | 19:19 |
| sean-k-mooney | im just not sure we actully need or want that | 19:19 |
| sean-k-mooney | https://review.opendev.org/c/openstack/python-watcherclient/+/956911/comment/6988ca03_2ac6805c/ is my other testing comment | 19:20 |
| sean-k-mooney | that a minor thign we can ignore | 19:20 |
| sean-k-mooney | dviroel: are you ok with proceedign with this patch as it is and possibel fixing it if the test is unstable? | 19:21 |
| sean-k-mooney | it should not impact users either way | 19:21 |
| dviroel | yes, i am ok with that | 19:22 |
| sean-k-mooney | ok then the watcher client change, api fix and monasca client change are all appoved | 19:24 |
| dviroel | nice | 19:25 |
| dviroel | do you think that we need to update client max version? | 19:25 |
| sean-k-mooney | we can do a releasae tonight or more reaslitcly in the morning for the watcher client and we can decied what to do about watcher-dashboard | 19:25 |
| sean-k-mooney | dviroel: we proably shoudl but i dont htink we need to exeactly | 19:26 |
| dviroel | yeah, it would be just the bump, to align with the api | 19:26 |
| sean-k-mooney | 1.5 is gong to be needed by watcher dash-board | 19:26 |
| sean-k-mooney | but 1.6 wont be used for anything yet so we can do that when we have more time if we want too | 19:27 |
| dviroel | ack | 19:27 |
| sean-k-mooney | if we add sdk support for watcher next cycle | 19:29 |
| sean-k-mooney | we coudl deprecate the python binding | 19:29 |
| sean-k-mooney | and hten we woudl no really use that anymore | 19:29 |
| sean-k-mooney | we dont need to do that but we can | 19:29 |
| dviroel | ack | 19:29 |
| sean-k-mooney | its just a matter of priorties | 19:29 |
| dviroel | watcherclient's gate don't run any functional tests :( | 19:32 |
| sean-k-mooney | ... i guess we can add that to the list | 19:33 |
| sean-k-mooney | they ran on check at least and there is only one patch in gate so it will be fine | 19:34 |
| sean-k-mooney | but ya.. | 19:34 |
| opendevreview | Merged openstack/watcher master: Make Monasca client optional and lazy-load https://review.opendev.org/c/openstack/watcher/+/956968 | 19:34 |
| sean-k-mooney | between FF and RC1 is a good time to fix this so we might want to just put up zuul patches to get everyting that is voting in check in gate next week | 19:34 |
| dviroel | +1 | 19:35 |
| sean-k-mooney | we can tweak the regexs seperatly but we dont need to wait for the ptg to start clsoing these gaps | 19:35 |
| dviroel | yep, I don't think that anyone disagree with that | 19:36 |
| opendevreview | Merged openstack/python-watcherclient master: Add action update command to support skipping actions manually https://review.opendev.org/c/openstack/python-watcherclient/+/956911 | 19:37 |
| dviroel | sean-k-mooney: are you going to update the client release patch? | 19:40 |
| dviroel | or -1 | 19:40 |
| sean-k-mooney | if its precated ill update it now and +1 | 19:40 |
| sean-k-mooney | do you have the link | 19:40 |
| sean-k-mooney | ah https://review.opendev.org/c/openstack/releases/+/958421 | 19:41 |
| dviroel | https://review.opendev.org/c/openstack/releases/+/958421 | 19:41 |
| dviroel | :) | 19:41 |
| sean-k-mooney | looks like my release right might already be gon. normally that does nto happen until after RC1 ... | 19:45 |
| sean-k-mooney | so we are going to need joan or cahndan to +1 that | 19:46 |
| sean-k-mooney | that will reuslt in the bot adding PTL+1 | 19:47 |
| dviroel | ack, the DPL patch merged | 19:47 |
| sean-k-mooney | thats fine ill get them to review my changes but dont actullly want to do the hand off untile RC1 is out | 19:48 |
| dviroel | ack | 19:50 |
| opendevreview | Merged openstack/watcher master: Allow status_message updates for actions in SKIPPED state https://review.opendev.org/c/openstack/watcher/+/958778 | 20:04 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!