| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add support for passing parameters while creating audit https://review.opendev.org/c/openstack/watcher-dashboard/+/957535 | 07:50 |
|---|---|---|
| chandankumar | sean-k-mooney: Hello, for this review https://review.opendev.org/c/openstack/watcher-dashboard/+/957232/10/watcher_dashboard/api/watcher.py Can you share one example on how to properly define and pass microversion? I was following this https://github.com/openstack/manila-ui/blob/master/manila_ui/api/manila.py#L31 | 09:55 |
| sean-k-mooney | chandankumar: manila is also doing it incorrectly which is not surprising an must poeple do not use microversion correctly. | 10:23 |
| sean-k-mooney | to interact with a service that uses micoverions you need fo have some infrastucture in place. like this https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L103-L189 | 10:24 |
| sean-k-mooney | to be able to get teh min and max verions supported by a rest api | 10:24 |
| sean-k-mooney | your client wrapper needs to have a default micoverion but it shoul take the microversion as a paramter to the client https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L222-L277 | 10:25 |
| sean-k-mooney | ideally we will move to the sdk in the future which has slightly better ways to do this | 10:25 |
| sean-k-mooney | then th function that uses the new api will set the micovertion when constructign the client https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L970-L974 | 10:26 |
| sean-k-mooney | so reimage_volume uses 3.68 | 10:27 |
| sean-k-mooney | where as attachment_delete use 3.44 https://github.com/openstack/nova/blob/master/nova/volume/cinder.py#L925-L945 | 10:27 |
| sean-k-mooney | that is the correct way to use micoverion every call to a clinet shoudl pass the verion the function expect. and ideally check if its supproted. if not they need to fall back. we remove the checks after the upgrade window has lapsts i.e. they are nolonger in stable/* | 10:28 |
| chandankumar | ah ok, the same thing I am already doing in skip patch. | 10:29 |
| chandankumar | thank you!, will fix that | 10:29 |
| chandankumar | sean-k-mooney: one more thing, Please have a look at screenshot for parameters patch https://review.opendev.org/c/openstack/watcher-dashboard/+/957535/8/watcher_dashboard/content/audits/forms.py#144 thank you! | 10:31 |
| sean-k-mooney | chandankumar: what people get wrong wabout micoverion is they dont know what micro means, they assomin it means minor versoin. what it actully means is each api endpoin has its on version that it supprot and the micoverion only applies the the api behvior that was change in that version | 10:32 |
| sean-k-mooney | that looks good over all. i talked to stephenfin about htis a little too. so the parma_spec you are using for th docs is actully a jsonschema so we can impvoe those in the future to spcivify addtional validation taht cna be applie both on the server and on the ui in the future | 10:34 |
| sean-k-mooney | for exampel for parallel total we can specifiy min and max version in the schmea i.e. min=1 max=10 | 10:35 |
| sean-k-mooney | we do not need to do that now but we can in the future. | 10:35 |
| sean-k-mooney | lets see what others think fo the ux | 10:36 |
| chandankumar | perfect! | 10:39 |
| chandankumar | Let me work on other crs! | 10:39 |
| opendevreview | Merged openstack/watcher-specs master: Update extend compute model attributes spec https://review.opendev.org/c/openstack/watcher-specs/+/955921 | 13:52 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Fix source_node value in host maintenance strategy migrate action https://review.opendev.org/c/openstack/watcher/+/959889 | 17:56 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Add a Action Revert scenario test https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/959570 | 17:57 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!