| opendevreview | David proposed openstack/watcher master: [DNM] Testing nodeset with three nodes (two computes + 1 controller) https://review.opendev.org/c/openstack/watcher/+/967331 | 10:36 |
|---|---|---|
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add test for skipped actions https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/966860 | 10:59 |
| sean-k-mooney | jgilaber: would you mind taking a look at https://review.opendev.org/c/openstack/watcher/+/966710 again when you have time | 11:36 |
| jgilaber | sure, I +wed it, I thought I already did last week | 11:39 |
| sean-k-mooney | no worries i just saw that takashi responede to my question so i said i woudl ping you to take a look again | 11:45 |
| sean-k-mooney | jgilaber: while you here can you appove https://review.opendev.org/c/openstack/watcher/+/966849 to unblock the ci | 11:46 |
| sean-k-mooney | not super urgent but i need to back port that to all stabel brnahces | 11:46 |
| jgilaber | sure, done | 11:48 |
| sean-k-mooney | thanks, the implemention of the requirements check job changes about a week ago. im not entirly sure if/when it will break stable but for such a trivial change there is no reason to wait to backport it IMO | 11:50 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Consolidate and improve Zuul CI job definitions https://review.opendev.org/c/openstack/watcher/+/966942 | 11:58 |
| opendevreview | Merged openstack/watcher master: ruff: Use more specific name to enable pyupgrade rule https://review.opendev.org/c/openstack/watcher/+/966710 | 12:12 |
| opendevreview | Merged openstack/watcher stable/2025.2: use the correct package name for microversion-parse https://review.opendev.org/c/openstack/watcher/+/966849 | 12:26 |
| opendevreview | sean mooney proposed openstack/watcher stable/2025.1: use the correct package name for microversion-parse https://review.opendev.org/c/openstack/watcher/+/967360 | 13:05 |
| dviroel | sean-k-mooney: hey, not sure what to do with this patch after: https://review.opendev.org/c/openstack/watcher/+/966226/4#message-84a20635258bb9b696a84145700784e0553957c4 | 13:33 |
| dviroel | maybe investigate a bit more, or proceed with mergind and considering this threading job as non-voting for now | 13:33 |
| opendevreview | David proposed openstack/watcher master: [DNM] Testing nodeset with three nodes (two computes + 1 controller) https://review.opendev.org/c/openstack/watcher/+/967331 | 13:41 |
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add test for skipped actions https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/966860 | 13:46 |
| sean-k-mooney | dviroel the threading job seams stable | 13:50 |
| sean-k-mooney | dviroel: the greade job is the one that is failing | 13:50 |
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add test for skipped actions https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/966860 | 13:50 |
| dviroel | sean-k-mooney: i think that you are mixing, I am talking about the eventlet patch | 13:51 |
| dviroel | openstack-tox-py312-threading https://zuul.opendev.org/t/openstack/build/2165a83bfad74dd79aecf53291329721 : FAILURE in 5m 23s | 13:51 |
| sean-k-mooney | oh ya i clicked on the wrong link | 13:52 |
| sean-k-mooney | so test_execute_with_action_plan_cancel is faling is it alwasy that tes?t | 13:53 |
| sean-k-mooney | looks like you had at least one clean run but that looks like the same nested db connection issue | 13:54 |
| dviroel | acually this is the first time that it fails after we moved to serial engine in taskflow | 13:55 |
| sean-k-mooney | sqlite3.OperationalError: cannot commit - no transaction is active | 13:56 |
| sean-k-mooney | so we had to many and now to few | 13:56 |
| sean-k-mooney | this is coming form the test fixture | 13:57 |
| sean-k-mooney | well maybe | 13:58 |
| sean-k-mooney | oslo_db.exception.DBNonExistentTable: (sqlite3.OperationalError) no such table: action_plans | 13:58 |
| dviroel | hum slightly different | 13:58 |
| sean-k-mooney | so it looks like the test fixture tried to use the cached scheme | 13:58 |
| dviroel | yeap | 13:58 |
| sean-k-mooney | and that failed in setup but we still tried to use the db connection | 13:58 |
| sean-k-mooney | so we ened up trying to use an empty db | 13:59 |
| sean-k-mooney | so this to me looks liek we have a bug in how we are creatin ght db in the fixture in threaded mode | 13:59 |
| sean-k-mooney | lets see of we can repoduce that reliable locally if so we can likely fix that | 14:00 |
| dviroel | ack, maybe this time is actually from unit test side, let me try it locally | 14:04 |
| sean-k-mooney | it passed intially but i have it running in a loop with tox -e py3-threading -- --until-failure | 14:18 |
| sean-k-mooney | ok it failed on loop 4 | 14:19 |
| sean-k-mooney | this time in a diffent test watcher.tests.applier.workflow_engine.test_default_workflow_engine.TestDefaultWorkFlowEngine.test_execute_with_two_actions | 14:20 |
| sean-k-mooney | sqlite3.OperationalError: not an error ... ok then why did you raise :) | 14:20 |
| dviroel | lol | 14:21 |
| dviroel | yeah, in a loop, it failed on test_execute_with_one_action for me | 14:21 |
| dviroel | but not fixture setUp error mention | 14:21 |
| sean-k-mooney | so its the same root cause npot table found sqlite3.OperationalError: no such table: action_plans | 14:22 |
| dviroel | yes | 14:22 |
| sean-k-mooney | i have not seen the transaction error yt | 14:22 |
| sean-k-mooney | but its proably there too | 14:22 |
| sean-k-mooney | so all our unit test that need db access (which make htenm not really unit tests...) use https://github.com/openstack/watcher/blob/master/watcher/tests/db/base.py | 14:26 |
| sean-k-mooney | nova has its onw fixtre because of legacy but looking at placmente ther eare once form oslo deb that we can use https://github.com/openstack/placement/blob/master/placement/tests/fixtures.py#L30 | 14:28 |
| sean-k-mooney | https://github.com/openstack/oslo.db/blob/master/oslo_db/sqlalchemy/test_fixtures.py#L350 | 14:30 |
| sean-k-mooney | dviroel: it looks liek that supprot schea caching nativly | 14:31 |
| sean-k-mooney | im going to quickly jsut try swappign to that and see fi that is enough | 14:31 |
| *** haleyb|out is now known as haleyb | 14:32 | |
| * dviroel looking | 14:33 | |
| sean-k-mooney | im going to leave that running while i get coffee but i think its working. this woudl be a nice tech debt reduction anyway so i my rebase this on master and submit it sepreeatly | 14:51 |
| sean-k-mooney | dviroel: i cant prove a nevitive but its still runing after 10 mins so ill give it 20-30 and push that if it is still good | 15:00 |
| dviroel | sean-k-mooney: ack, thanks, I will take a look then | 15:00 |
| * dviroel lunch in meantime | 15:01 | |
| opendevreview | David proposed openstack/watcher master: [DNM] Testing nodeset with three nodes (two computes + 1 controller) https://review.opendev.org/c/openstack/watcher/+/967331 | 15:19 |
| opendevreview | sean mooney proposed openstack/watcher master: Adds support for threading mode in applier https://review.opendev.org/c/openstack/watcher/+/966226 | 15:21 |
| opendevreview | sean mooney proposed openstack/watcher master: [DB] adopt the AdHocDbFixture from oslo https://review.opendev.org/c/openstack/watcher/+/967390 | 15:21 |
| sean-k-mooney | im going to continue leaving that run in the background during my next meeting but no failure after 20 mins so looking good. we can see how it does in ci | 15:22 |
| opendevreview | David proposed openstack/watcher-tempest-plugin master: Add test for skipped actions https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/966860 | 15:32 |
| opendevreview | sean mooney proposed openstack/watcher master: [DB] adopt the AdHocDbFixture from oslo https://review.opendev.org/c/openstack/watcher/+/967390 | 16:47 |
| opendevreview | sean mooney proposed openstack/watcher master: Adds support for threading mode in applier https://review.opendev.org/c/openstack/watcher/+/966226 | 16:47 |
| sean-k-mooney | fixed the pep8 issue | 16:48 |
| dviroel | ack | 16:50 |
| opendevreview | Merged openstack/watcher-specs master: Add functional test infrastructure spec https://review.opendev.org/c/openstack/watcher-specs/+/963299 | 19:39 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!