| opendevreview | Douglas Viroel proposed openstack/watcher stable/2025.2: Consolidate and improve Zuul CI job definitions https://review.opendev.org/c/openstack/watcher/+/968779 | 12:11 |
|---|---|---|
| chandankumar | sean-k-mooney: dviroel Hello, Please revisit this review https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/956004 when you get time, thank you! | 12:26 |
| dviroel | ack | 12:40 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add tests for get_dst_pool_and_type method https://review.opendev.org/c/openstack/watcher/+/964717 | 14:23 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Fix zone migration dest pool and type selection https://review.opendev.org/c/openstack/watcher/+/964718 | 14:23 |
| dviroel | is gerrit also slow at your side? | 14:36 |
| jgilaber | I pushed the patch and the UI seems ok for me, what are you seeing? | 14:40 |
| dviroel | taking longer than usual to load changes... | 14:45 |
| dviroel | going to try other isp then | 14:47 |
| opendevreview | Joan Gilabert proposed openstack/watcher-specs master: Add zone migration parameter rename spec https://review.opendev.org/c/openstack/watcher-specs/+/965943 | 14:53 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Fix zone migration dest pool and type selection https://review.opendev.org/c/openstack/watcher/+/964718 | 15:08 |
| opendevreview | Merged openstack/watcher master: Fix zone migration to accept dst_pool or dst_type https://review.opendev.org/c/openstack/watcher/+/964776 | 15:18 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Fix zone migration to accept dst_pool or dst_type https://review.opendev.org/c/openstack/watcher/+/968817 | 15:23 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Fix zone migration to accept dst_pool or dst_type https://review.opendev.org/c/openstack/watcher/+/968818 | 15:27 |
| dviroel | sean-k-mooney: this 2 changes you kind already reviewed, but there were some small updates on them: https://review.opendev.org/c/openstack/watcher/+/966942 and https://review.opendev.org/c/openstack/watcher/+/966226 | 17:14 |
| dviroel | there is a XS change here too: https://review.opendev.org/c/openstack/watcher/+/967769 | 17:14 |
| sean-k-mooney | dviroel: thanks | 17:16 |
| opendevreview | Douglas Viroel proposed openstack/watcher stable/2025.2: Consolidate and improve Zuul CI job definitions https://review.opendev.org/c/openstack/watcher/+/968779 | 17:23 |
| sean-k-mooney | dviroel: so +2w on https://review.opendev.org/c/openstack/watcher/+/966942 | 17:30 |
| dviroel | ack, thanks, already answered ther comments there too | 17:32 |
| sean-k-mooney | dviroel: for https://review.opendev.org/c/openstack/watcher/+/968779 you shoudl either have the cherry-picked form line or you shoudl be adding [stable-only] to the show that htis is not a cherry pick. | 17:33 |
| dviroel | ah yeah, I forgot to put that in the commit msg | 17:34 |
| opendevreview | Douglas Viroel proposed openstack/watcher stable/2025.2: Consolidate and improve Zuul CI job definitions https://review.opendev.org/c/openstack/watcher/+/968779 | 17:35 |
| sean-k-mooney | dviroel: im also ok with https://review.opendev.org/c/openstack/watcher/+/966226 | 17:41 |
| dviroel | great! | 17:41 |
| sean-k-mooney | i have abandoned https://review.opendev.org/c/openstack/watcher/+/966690 since you folded it in | 17:42 |
| sean-k-mooney | we shoudl sepreatly descided if we want to continue with https://review.opendev.org/c/openstack/watcher/+/966759/2 | 17:42 |
| sean-k-mooney | but that not urgent so it can wait | 17:44 |
| sean-k-mooney | als +2w on https://review.opendev.org/c/openstack/watcher/+/967769 | 17:44 |
| sean-k-mooney | it shoudl not be required but it good to be explcit | 17:45 |
| sean-k-mooney | dviroel: once all those merged i think you have sucssfully made watcher itself optionaly able to run without eventlet - the mass integration | 17:45 |
| sean-k-mooney | dviroel: do you have plans for your next steps? | 17:46 |
| dviroel | I would like to at least test a change with real eventlet-removal code, even if we don't plan to merge it right now. | 17:48 |
| sean-k-mooney | as in a patch to rip out eventlet form watcher entirly. sure sound good to validate we didnt miss anything else | 17:48 |
| dviroel | and there are some gaps to work, the CDM collector timeout and investigate the issue in applier with taskflow parallel engine | 17:49 |
| sean-k-mooney | ya i was wonderign if you would move on teo the serial limitaiton next | 17:50 |
| sean-k-mooney | we are not done for sure | 17:50 |
| sean-k-mooney | but i think this is a improant milestone | 17:50 |
| dviroel | yeah, we may get more folks involved with this limitation | 17:50 |
| sean-k-mooney | chandankumar: i have apprvoed https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/956004 as well thanks for updating it | 17:56 |
| sean-k-mooney | dviroel: as an aside we may want to yoink nova's backport checker script and job https://github.com/openstack/nova/blob/master/tools/check-cherry-picks.sh https://github.com/openstack/nova/blob/master/.zuul.yaml#L836C10-L837 https://github.com/openstack/nova/blob/master/tox.ini#L176-L184 | 17:59 |
| sean-k-mooney | it runs with voting false in check so you dont have to recheck it if you propsoe all the backports at once | 18:01 |
| sean-k-mooney | but its voting in gate | 18:01 |
| dviroel | interesting, didn't know about that script/job | 18:01 |
| sean-k-mooney | its a nova specific thing | 18:01 |
| sean-k-mooney | you are ment to enforce it in code review when backporting but its nice to automate | 18:01 |
| sean-k-mooney | some teams dont actully enfoce the cherrypick lines | 18:02 |
| dviroel | yeah, we enforce all cherrypick lines in manila too, and in the correct order | 18:02 |
| dviroel | but we don't have any job to check, iirc | 18:02 |
| sean-k-mooney | ya its techinanly part of stable policy | 18:02 |
| sean-k-mooney | but not all team follow that properly | 18:03 |
| dviroel | right | 18:05 |
| opendevreview | Merged openstack/watcher master: Disable eventlet patching for api service in threading job https://review.opendev.org/c/openstack/watcher/+/967769 | 19:35 |
| opendevreview | Merged openstack/watcher-tempest-plugin master: Improved continuous audit api test coverage https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/956004 | 19:36 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!