| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Make VM migrations timeout configurable and apply reasonable defaults https://review.opendev.org/c/openstack/watcher/+/967693 | 07:39 |
|---|---|---|
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Make VM migrations timeout configurable and apply reasonable defaults https://review.opendev.org/c/openstack/watcher/+/967693 | 07:45 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Make VM resize timeout configurable with migration defaults https://review.opendev.org/c/openstack/watcher/+/968610 | 07:45 |
| amoralej | dviroel, I lost your vote in https://review.opendev.org/c/openstack/watcher/+/967693 after rebasing | 10:25 |
| dviroel | jgilaber: sean-k-mooney: while refactoring the jobs in 2025.1, it is failing in zone_migration tests. we have lots of backports to land in 2025.2 and 2025.1 (there are a few that merged before 2025.2) | 12:12 |
| dviroel | what about getting a list of all and work on merging them? | 12:12 |
| sean-k-mooney | let plan ot do a stable review day or something this/next week | 12:13 |
| sean-k-mooney | and perhaps do a round of staable release afterwords | 12:13 |
| sean-k-mooney | with that said your refactorign shoudlnot need test changes or backports | 12:14 |
| sean-k-mooney | that would indeicate either we have incorectly writen tests or we broke the api contract | 12:15 |
| sean-k-mooney | well or tha twe are running test that shoudl not be run on older brnahces btu our tepest test are intened to run on all supproted branches | 12:16 |
| dviroel | it is running against a new test, and others that were modified | 12:35 |
| dviroel | and it is failing probably because of the missing bugfix | 12:35 |
| dviroel | I guess that they were not even running before | 12:35 |
| dviroel | we would need to skip them in stable branches and after merging backports, revert the skip | 12:36 |
| dviroel | but indeed, we have lot of backports to merge | 12:37 |
| opendevreview | David proposed openstack/watcher master: [DNM] Testing nodeset with three nodes (two computes + 1 controller) https://review.opendev.org/c/openstack/watcher/+/967331 | 12:38 |
| sean-k-mooney | well my point is we generally shoudl not merge tempest test aht depend on bugfixes until after they are backported to all stable branches | 12:41 |
| sean-k-mooney | we likely merged that test in error becuase we were not running the senario tests on the stable branhces | 12:41 |
| dviroel | correct, we could protect the test with a config option in this case, or hold the merge | 12:55 |
| dviroel | the plan is to fix the CI to help us with that | 12:55 |
| dviroel | chandankumar: hi, I see that watcher_tempest_plugin.tests.api.admin.test_audit.TestShowListAudit.test_list_with_limit is failing a lot in CI. Can this be related to the recent refactoring? | 13:00 |
| dviroel | e.g.: https://6ea1e5c767255dedcd22-80b58333ad170242388e8ae016218703.ssl.cf1.rackcdn.com/openstack/16f4fec4f4ac481cab08dc455cbe81ce/testr_results.html | 13:00 |
| dviroel | "Details: {'error_message': '{"faultcode": "Client", "faultstring": "Couldn\'t delete when state is \'ONGOING\'.", "debuginfo": null}'}" | 13:00 |
| chandankumar | dviroel: I have seen this failure coming mostly after refactoring patch got merged | 13:01 |
| chandankumar | after recheck, it vanishes | 13:02 |
| chandankumar | the test is now flaky | 13:02 |
| jgilaber | reading back, was eating, +1 to have some review time for stable branches we got quite a backlog | 13:05 |
| jgilaber | dviroel, can you share some details on the failure? or a link to the failure | 13:06 |
| dviroel | jgilaber: np, check the CI results in https://review.opendev.org/c/openstack/watcher/+/969137 (stable/2025.1) | 13:10 |
| jgilaber | ok so the problem there seems to be that we don't have notifications because we're missing https://review.opendev.org/c/openstack/watcher/+/959176 | 13:17 |
| jgilaber | however, even with that I'm not sure if the zone migration tempests tests will work, I'll push a patch to put them behind a config option | 13:18 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add config flags to control zone migration test execution https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/969244 | 13:46 |
| jgilaber | ^^ should unblock the stable branch | 13:47 |
| jgilaber | once merged I'll push the patch to master to enable the tests | 13:47 |
| dviroel | jgilaber: we can create a new config, but you would need to add as default to False (never run) and update master and stable/2025.2 to enable it. | 14:05 |
| dviroel | another option is to skip the tests in the affected branches, until we merge the backports | 14:05 |
| jgilaber | oh right, I forgot to add the config option | 14:17 |
| dviroel | chandankumar: yeah, we could wait in the test, for all to move to a finished state before it ends. Or improve the delete audit function, to wait for ONESHOT audits to move to a finished state too. | 14:33 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add config flags to control zone migration test execution https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/969244 | 14:34 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!