| opendevreview | chandan kumar proposed openstack/watcher-specs master: Add spec for improving watcher-dashboard testing https://review.opendev.org/c/openstack/watcher-specs/+/970220 | 06:50 |
|---|---|---|
| opendevreview | Ivan Anfimov proposed openstack/watcher master: Remove url tags from README https://review.opendev.org/c/openstack/watcher/+/970339 | 07:17 |
| opendevreview | Ivan Anfimov proposed openstack/watcher master: Remove url tags from README https://review.opendev.org/c/openstack/watcher/+/970339 | 07:19 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 10:14 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 10:15 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 10:17 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 10:19 |
| opendevreview | David proposed openstack/watcher master: [DNM] Move real data jobs nodeset to three nodes (two computes + 1 controller) https://review.opendev.org/c/openstack/watcher/+/967331 | 10:37 |
| opendevreview | David proposed openstack/watcher master: Move real data jobs nodeset to three nodes (two computes + 1 controller) https://review.opendev.org/c/openstack/watcher/+/967331 | 10:38 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add tests for get_dst_pool_and_type method https://review.opendev.org/c/openstack/watcher/+/964717 | 10:39 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Fix zone migration dst pool and type selection https://review.opendev.org/c/openstack/watcher/+/964718 | 10:39 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 10:43 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 10:45 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 11:11 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add tests for get_dst_pool_and_type method https://review.opendev.org/c/openstack/watcher/+/964717 | 11:24 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Fix zone migration dst pool and type selection https://review.opendev.org/c/openstack/watcher/+/964718 | 11:24 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 12:07 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 12:29 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 12:52 |
| sean-k-mooney | dviroel: jgilaber so regarding https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 is there a patch to get teh senario test enbaled on teh stable jobs for the tempest plugin | 13:05 |
| dviroel | sean-k-mooney: we need to merge the watcher backports first | 13:06 |
| dviroel | https://review.opendev.org/c/openstack/watcher/+/968779 | 13:07 |
| dviroel | and 2025.1 i need to check if we fixed the issue: https://review.opendev.org/c/openstack/watcher/+/969137 | 13:07 |
| dviroel | 2025.1 we can recheck after https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/969244 merges (in gates now)] | 13:08 |
| sean-k-mooney | why is the job consolation backprot needed to chagne the defiontion of the *fucntional-2025-2 job on master | 13:08 |
| sean-k-mooney | im specificly asking about htese jobs https://opendev.org/openstack/watcher-tempest-plugin/src/branch/master/.zuul.yaml#L29-L45 | 13:09 |
| sean-k-mooney | they use the master definition of the job | 13:10 |
| dviroel | they don't because of the override-checkout | 13:10 |
| sean-k-mooney | so we can update them to use watcher-tempest-prometheus or watcher-tempest-gnocchi | 13:10 |
| sean-k-mooney | that applie to the code not the zuul job defintion if im not mistaken | 13:11 |
| dviroel | it will be a noop | 13:11 |
| dviroel | i already tried in the watcher-tempest-plugin patch to confirm | 13:11 |
| dviroel | let me check the PS | 13:11 |
| sean-k-mooney | ack | 13:11 |
| jgilaber | sean-k-mooney, no I don't have a patch to enable those test, I was waiting on feedback in https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/969244 | 13:12 |
| jgilaber | now that the patch is merging I'll push a patch to enable those tests on master only | 13:12 |
| dviroel | in PS1 https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/968247/1/.zuul.yaml | 13:12 |
| dviroel | ah there is no zuul report for ps1 | 13:13 |
| dviroel | I can send a DNM with that change | 13:13 |
| sean-k-mooney | just send it as a real patch it will fail if we need the backports | 13:14 |
| sean-k-mooney | if it does we can test the backprot with a depend on for each branch | 13:14 |
| sean-k-mooney | and proceed with them | 13:14 |
| dviroel | ack | 13:14 |
| sean-k-mooney | jgilaber: assuming ^ works we shoudl rebase your change on it to get new ci results and see if the test breaks without the backport | 13:15 |
| jgilaber | you mean rebase https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 right? | 13:17 |
| sean-k-mooney | yep | 13:17 |
| jgilaber | ack, sure | 13:17 |
| sean-k-mooney | the logs are gone so i cant check the old job results but we are not runign that test either | 13:17 |
| sean-k-mooney | so we need to fix that first | 13:18 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Consolidate and improve Zuul CI jobs for stable branches https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378 | 13:18 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 13:20 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 13:24 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Test zone migration volume and compute migrations https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/962702 | 13:24 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add extra checks to zone migration retype test https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/963559 | 13:24 |
| jgilaber | ^^ I rebase my patches on top of dviroel one | 13:24 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Enable extra zone migration tests on master branch https://review.opendev.org/c/openstack/watcher/+/970381 | 13:25 |
| opendevreview | Douglas Viroel proposed openstack/watcher stable/2024.2: [stable-only] Consolidate and improve Zuul CI job definitions https://review.opendev.org/c/openstack/watcher/+/970385 | 13:39 |
| dviroel | hey sean-k-mooney: https://zuul.opendev.org/t/openstack/status?change=970378 | 13:42 |
| dviroel | only 2024.2 is running because I didn't replace the parent properly | 13:42 |
| dviroel | I will send a new PS with all depends-on | 13:42 |
| sean-k-mooney | ack well we just need any exectuion of a non master version right | 13:43 |
| sean-k-mooney | to see if this will work | 13:44 |
| sean-k-mooney | oh so its rungin watcher-tempest-gnocchi-2024-2 because its the only one where it could see the partent job | 13:46 |
| sean-k-mooney | and it skiped the rest becaues the backprot of the jobs was not doen | 13:46 |
| sean-k-mooney | ok so the overried checkout at the job level is also impacting the version of the job used becasue its defeind in a differnt repo | 13:46 |
| sean-k-mooney | if hte just was in htis repo it would not be impacted by that which explian the delta in behavior | 13:47 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Consolidate and improve Zuul CI jobs for stable branches https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378 | 13:49 |
| dviroel | trying now with all depends-on patches | 13:50 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 13:55 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Consolidate and improve Zuul CI jobs for stable branches https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378 | 14:03 |
| sean-k-mooney | on of those apprently has a config error | 14:05 |
| sean-k-mooney | dviroel: you might need to turn o nthe pipeline debuging ot see why | 14:06 |
| dviroel | i enabled the debug here: https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378/3/.zuul.yaml#9 | 14:06 |
| dviroel | is there other debug flag? | 14:06 |
| sean-k-mooney | no i think that is the one i was thinkign of | 14:07 |
| sean-k-mooney | i was expecting mroe then "This change depends on a change with an invalid configuration." | 14:08 |
| dviroel | i may try to remove each dependency to see if helps | 14:08 |
| sean-k-mooney | https://zuul-ci.org/docs/zuul/latest/config/project.html#attr-project.%3Cpipeline%3E.debug | 14:08 |
| sean-k-mooney | ack the jobs do seeam to be running on the backports. | 14:10 |
| sean-k-mooney | maybe we have hit a limitaion on how speculitive the sepculitive execution is | 14:10 |
| dviroel | yep | 14:11 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add option to filter action plans by hostname from db connection https://review.opendev.org/c/openstack/watcher/+/970396 | 14:11 |
| opendevreview | Merged openstack/watcher-tempest-plugin master: Add config flags to control zone migration test execution https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/969244 | 14:18 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Consolidate and improve Zuul CI jobs for stable branches https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378 | 14:20 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Consolidate and improve Zuul CI jobs for stable branches https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378 | 14:22 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Consolidate and improve Zuul CI jobs for stable branches https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378 | 14:26 |
| dviroel | sean-k-mooney: still can't run with only a single depends-on, we may want to try merging the stable/2025.2 backport to see if helps | 14:30 |
| sean-k-mooney | ack we can merge this first thats fine | 14:36 |
| dviroel | https://review.opendev.org/c/openstack/watcher/+/968779 | 14:36 |
| dviroel | jgilaber: ^ pls take a look | 14:37 |
| jgilaber | ack dviroel looking | 14:39 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: ruff: Enable E5 check https://review.opendev.org/c/openstack/watcher/+/970440 | 17:06 |
| opendevreview | Takashi Kajinami proposed openstack/watcher-dashboard master: ruff: Enable E5 check https://review.opendev.org/c/openstack/watcher-dashboard/+/970446 | 17:08 |
| sean-k-mooney | tkajinam: so we are not using ruff for formating yet | 17:22 |
| sean-k-mooney | tkajinam: we have rufh check but we are using autopep8 for formating at the moment | 17:22 |
| tkajinam | sean-k-mooney, ok. yeah I see. | 17:24 |
| sean-k-mooney | i do want to eventully use ruff for both but we are taking that slowly | 17:24 |
| tkajinam | sean-k-mooney, a question is whether we accept some exceptions implicitly applied by the formater (for better structure these tools believe) or we want that limit rule strict. As the change for watcher indicates autopep8 does not strictly wrap lines at 79 chars | 17:24 |
| tkajinam | sean-k-mooney, I've seen ruff has its own exception rule internally so we may consider the same question even if we replace autopep8 by ruff | 17:25 |
| * tkajinam is still trying to find out options to enable strict limit but have failed to enable it, with some options described so in some articles | 17:26 | |
| sean-k-mooney | for watcher i want to be pragmatic and just use what the tool supprots | 17:26 |
| sean-k-mooney | if the only way to auto formating is to force strict 79 colum checkign then in other project im ok with it being srtict | 17:27 |
| sean-k-mooney | i personaly am not a fan of the strcit enforcement of 79 columns but i know others are | 17:28 |
| sean-k-mooney | i woudl personally prefer to enforce formating entirly via the tooling so humans can focus on the logic | 17:28 |
| sean-k-mooney | tkajinam: my only reservatrio nwith you rpatch curretnly si what happens if the two conflict | 17:29 |
| sean-k-mooney | https://github.com/openstack/watcher/blob/master/tox.ini#L139 | 17:29 |
| tkajinam | I agree with the idea of relying on toolings but I still find some long comment lines left by these annoying. | 17:29 |
| sean-k-mooney | this is why those are not lenght enforced right now by the way | 17:30 |
| sean-k-mooney | se exclude the alembic migration for some historical reason but we proably shoudl just remove that | 17:30 |
| tkajinam | ahh ok | 17:30 |
| sean-k-mooney | lets see whtat other think, if i remember ill bring it up in the irc metting tomrrow | 17:31 |
| sean-k-mooney | i have no reall issue with adding E5 to the checks i was not aware we currently excluded the migraiton form flake checking | 17:32 |
| sean-k-mooney | its the same for the docs extention too | 17:32 |
| sean-k-mooney | ruff is not reading that exclude line | 17:32 |
| tkajinam | yeah I noticed the same (ruff is not reading that exclude line) | 17:33 |
| sean-k-mooney | it might if you dont have a pyproject.toml section | 17:33 |
| sean-k-mooney | we should move our config over eventully | 17:33 |
| sean-k-mooney | i know stephen started doing that in alot of project | 17:34 |
| opendevreview | Takashi Kajinami proposed openstack/watcher master: ruff: Enable E5 check https://review.opendev.org/c/openstack/watcher/+/970440 | 17:35 |
| tkajinam | ^^^ I've updated pyproject.toml to ignore E5 for these files. Probably it's better ^^^ | 17:35 |
| tkajinam | maintaining excludes in these two places is ugly but is not too bad with selective exclude atm | 17:35 |
| sean-k-mooney | ack. i guess we shoudl burn down the list of exclude at some point but i think that is ok for now | 17:36 |
| sean-k-mooney | tkajinam: what i effectivly agreed witht he tema at the last ptg was to continue adding ruff check to all teh watcher repos this cycle adn resovlign any issues found | 17:38 |
| sean-k-mooney | and next cycle we were going to revisit if we woudl use ruff for formating as well | 17:38 |
| sean-k-mooney | the logic being at that point there hsould not need to be any logic change just formating when we adopt it | 17:38 |
| sean-k-mooney | so step one fix the lint issues, step 2 adopt it for formating | 17:39 |
| tkajinam | sounds good | 17:39 |
| sean-k-mooney | i orgially propsoed doing both together in epoxy and it was basiclly unreviable | 17:40 |
| sean-k-mooney | it was just too big of a patch | 17:40 |
| tkajinam | Stephen has been extending usage of ruff in oslo (and sdk) and we may have more experience from these projects, too, at that point | 17:40 |
| tkajinam | yeah | 17:40 |
| sean-k-mooney | i think keystone has adopted it and i know neutron/ironic at least use ruff check | 17:40 |
| sean-k-mooney | so ya its becoming the defualt in and outside of the openstack comunityity | 17:41 |
| tkajinam | I agree | 17:45 |
| tkajinam | we probably have to tune it for a while but hopefully agree with the common good baseline in 1~2 cycles. | 17:45 |
| opendevreview | Douglas Viroel proposed openstack/watcher stable/2025.2: Consolidate and improve Zuul CI job definitions https://review.opendev.org/c/openstack/watcher/+/968779 | 18:36 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Fix experimental job names after refactoring watcher jobs https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970472 | 18:48 |
| opendevreview | Douglas Viroel proposed openstack/watcher-tempest-plugin master: Consolidate and improve Zuul CI jobs for stable branches https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/970378 | 18:52 |
| opendevreview | Douglas Viroel proposed openstack/watcher stable/2025.2: Consolidate and improve Zuul CI job definitions https://review.opendev.org/c/openstack/watcher/+/968779 | 19:11 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!