| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 08:48 |
|---|---|---|
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 09:32 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: [poc]Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 09:50 |
| jgilaber | Hi! IRC meeting will start in approximately 45 minutes, feel free to add topics to the agenda https://etherpad.opendev.org/p/openstack-watcher-irc-meeting | 11:17 |
| jgilaber | #starmeeting | 12:00 |
| jgilaber | #startmeeting | 12:01 |
| opendevmeet | jgilaber: Error: A meeting name is required, e.g., '#startmeeting Marketing Committee' | 12:01 |
| jgilaber | #startmeeting Watcher | 12:01 |
| opendevmeet | Meeting started Thu Jan 15 12:01:14 2026 UTC and is due to finish in 60 minutes. The chair is jgilaber. Information about MeetBot at http://wiki.debian.org/MeetBot. | 12:01 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 12:01 |
| opendevmeet | The meeting name has been set to 'watcher' | 12:01 |
| amoralej | o/ | 12:01 |
| jgilaber | hello all - who is around today? | 12:01 |
| chandankumar | o/ | 12:01 |
| morenod | o/ | 12:02 |
| rlandy | o/ | 12:02 |
| jgilaber | courtesy ping: dviroel sean-k-mooney | 12:02 |
| sean-k-mooney | o/ | 12:02 |
| jgilaber | I think we can start with the agenda, feel free to add last minute topics | 12:03 |
| jgilaber | #link https://etherpad.opendev.org/p/openstack-watcher-irc-meeting | 12:03 |
| jgilaber | #topic patch with many merge conflicts | 12:03 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/967502 | 12:03 |
| jgilaber | amoralej, do you want to take this topic? | 12:04 |
| amoralej | that's mine | 12:04 |
| amoralej | this is the first step for the functional tests we discussed on ptg | 12:04 |
| amoralej | I don't know what's the best way to coordinate the merge of that as it will affect many other patches | 12:04 |
| amoralej | I'd be good if we can look for a time where there are no many inflight patches, as it will force to rebase | 12:05 |
| sean-k-mooney | i think we couold jut merge it qickly | 12:05 |
| sean-k-mooney | we just need to agree to say do it tommorrow | 12:05 |
| sean-k-mooney | we just should not keep putting it an the other in merge conflict and fight over the merge order | 12:06 |
| chandankumar | +1 to merge as soon as possible | 12:06 |
| amoralej | if there are patches close to merge, i'd be happy to wait for them | 12:06 |
| jgilaber | +1 I would do it asap and take it out of the way | 12:06 |
| jgilaber | I don't think there are many patches about to merge rn | 12:06 |
| amoralej | it will affect https://review.opendev.org/q/project:openstack/watcher+file:tests+status:open+branch:master | 12:07 |
| amoralej | there are some patches with 1 +2 | 12:08 |
| sean-k-mooney | it will alway saffect somethighnn | 12:08 |
| sean-k-mooney | if you want i can do a review pass on the ones with +2s | 12:08 |
| amoralej | that'd be great | 12:09 |
| sean-k-mooney | lets try to merge it on monday | 12:09 |
| sean-k-mooney | and todya.tomorrow we can try and lannd the current patches that are close | 12:09 |
| jgilaber | sounds good | 12:09 |
| amoralej | ok, on monday i will rebase and preapre a new PS fixing your comments too | 12:09 |
| sean-k-mooney | cool | 12:10 |
| amoralej | that was it from me, thanks | 12:10 |
| jgilaber | ok, moving to next topic | 12:10 |
| jgilaber | #topic add specs folders for next release | 12:10 |
| jgilaber | since we're past the spec freeze, yesterday I opened a patch with the folders for specs for the next release | 12:11 |
| jgilaber | #link add specs folders for next release | 12:11 |
| jgilaber | sorry | 12:11 |
| sean-k-mooney | spec freeze was last week | 12:11 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher-specs/+/973265 | 12:12 |
| sean-k-mooney | but ya in either case around m2 is when we should create that | 12:12 |
| jgilaber | yes, I believe we've shared this before but we have a document with the different release tasks to follow | 12:13 |
| jgilaber | #link https://docs.openstack.org/watcher/latest/contributor/release-guide.html#milestone-2 | 12:13 |
| jgilaber | I just wanted to mention that it's done, if there is no other questions/comments we can move on to the next topic | 12:13 |
| sean-k-mooney | +1 | 12:14 |
| jgilaber | #topic release of the stable branches | 12:14 |
| jgilaber | another thing we're supposed to do around milestone 2 is to make relaeses of the stable branches | 12:14 |
| sean-k-mooney | yep. i think if we are goign to do a master review push today/tomorow we shoudl do the same for the stable branches | 12:15 |
| jgilaber | but in our case we don't have any patcher other than the ci changes that dviroel made | 12:15 |
| chandankumar | there is no backport in python-watcherclient and watcher-dashboard for stable/2025.2 | 12:15 |
| sean-k-mooney | we have a number of backprots we have done in the stabe branches that have not been released | 12:15 |
| jgilaber | so we should probably setup some kind of review day for the stable to go through the backlog and release with what is merged | 12:16 |
| chandankumar | for watcher https://review.opendev.org/q/project:openstack/watcher+branch:stable/2025.2 we have fews apart from ci changes which needs another +2 +2 | 12:16 |
| chandankumar | +w | 12:16 |
| sean-k-mooney | chandankumar: are you loging at the open review or the merged changes sinc ethe last release | 12:16 |
| chandankumar | https://review.opendev.org/q/project:openstack/watcher+branch:stable/2025.2+status:open | 12:17 |
| chandankumar | these are the open reviews | 12:17 |
| sean-k-mooney | its been 5 months since we last released stable epoxy so any backprots that have merged since then are unreleased | 12:18 |
| sean-k-mooney | ok that currently only 1 patch | 12:19 |
| sean-k-mooney | https://github.com/openstack/watcher/compare/024815af711553739b4627cb520f66886060db3f...stable/2025.1 | 12:19 |
| jgilaber | thanks sean-k-mooney I was trying to pull that up | 12:19 |
| sean-k-mooney | but i feel like we have done more then 1 bugfix in the last 5 months so i was expecting more | 12:20 |
| jgilaber | we have, and we have many backports proposed, but we haven't merged any | 12:20 |
| sean-k-mooney | flamingo https://github.com/openstack/watcher/compare/61cca16dcdec1f09f3dd05206c4ffacb0a8b93a0...stable/2025.2 | 12:20 |
| jgilaber | https://review.opendev.org/q/project:openstack/watcher+status:open+branch:stable/2025.1 | 12:21 |
| sean-k-mooney | so we dont have a lot pending but | 12:21 |
| sean-k-mooney | we have a number of backprot pendign review so it would be nice to spend some time next week on that | 12:21 |
| sean-k-mooney | or the week after might work out better to give use tiem to work through it | 12:22 |
| jgilaber | do we want to cover the backports in the irc meeting? | 12:22 |
| sean-k-mooney | we could i dont have a stong opipion either way | 12:22 |
| amoralej | We book a time slot to go through stable branches next week | 12:23 |
| amoralej | we may book ... i meant | 12:23 |
| sean-k-mooney | lets do that after the unit test refactor patch has landed | 12:24 |
| sean-k-mooney | but sure we could do it after the meeting next week for example | 12:24 |
| chandankumar | can we use the next meeting for stable reviews on video call? | 12:24 |
| amoralej | i think it's better to do it different that standaard meeting | 12:25 |
| sean-k-mooney | im not sure if doing ti synconusly will help | 12:25 |
| amoralej | actually, i like after the meeting | 12:25 |
| amoralej | i'd expect irc to be good enough | 12:25 |
| chandankumar | +1 after meeting would be good | 12:25 |
| jgilaber | +1 to that as well | 12:26 |
| sean-k-mooney | its more a case of when we merge a patch and it cause a conflict with another we need to be prepared to rebase it | 12:26 |
| jgilaber | so next week after the meeting we go through them, please everyone try to make some time for reviews before hand | 12:27 |
| jgilaber | unless there are more comments, I think we can move to the next topic | 12:27 |
| jgilaber | #topic reviews | 12:28 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/970614 | 12:28 |
| jgilaber | amoralej, looks like the first two are yours | 12:28 |
| amoralej | yes, those are reviews to implement some approved blueprints | 12:29 |
| amoralej | for that one i have some reviews already, thanks jgilaber | 12:29 |
| amoralej | just asking for reviews | 12:29 |
| jgilaber | yes, I went through the first series, I've added the second to my review list | 12:30 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/973274 | 12:30 |
| amoralej | actually, i should have use the topic link https://review.opendev.org/q/topic:%22blueprint-monitor-failed-appliers%22 | 12:30 |
| jgilaber | #link https://review.opendev.org/q/topic:%22blueprint-monitor-failed-appliers%22 | 12:30 |
| amoralej | for second one, I sent it recently, given that it affects the eventlet removal code, it'd probably be good to get Doug review too | 12:31 |
| amoralej | but good to get reviews, anyway :) | 12:31 |
| jgilaber | ack, if there are no further comments, I've also added a series to review | 12:32 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/972912 | 12:32 |
| amoralej | nothing from my side | 12:32 |
| jgilaber | thanks amoralej | 12:32 |
| jgilaber | this patch and the next are in preparation for the work to move the nova_helper to use the openstacksdk | 12:32 |
| jgilaber | I've added classes that wrap the objects that novaclient returns | 12:32 |
| jgilaber | they are fairly large patches | 12:33 |
| jgilaber | the first one adds the classes | 12:33 |
| amoralej | I'd like to ask about https://review.opendev.org/c/openstack/watcher/+/972912/ , just to make sure, we don't need to treat those as WatcherObjects under watcher/objects, right? | 12:33 |
| sean-k-mooney | so we could | 12:33 |
| jgilaber | no, they are only internal representations | 12:33 |
| sean-k-mooney | currently they are not OVOs | 12:33 |
| sean-k-mooney | so no | 12:33 |
| amoralej | I'm not clear when using WatcherObjets are actually required | 12:34 |
| sean-k-mooney | they are required if it will be sent over rpc | 12:34 |
| amoralej | ohk, then in this case, it's not needed | 12:34 |
| sean-k-mooney | they should be used for anythign that will be serislied and stored in the db | 12:34 |
| amoralej | got it | 12:34 |
| sean-k-mooney | btu if its just in memory it dose not need to be versioned | 12:34 |
| jgilaber | the second patch in the series | 12:35 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/972913/3 | 12:35 |
| amoralej | I started looking at it, jgilaber, i understand you got the fields from the existing ones in the novaclient objects? | 12:35 |
| jgilaber | yes, I think I've added properties for all the fields that are used in the code base | 12:36 |
| sean-k-mooney | jgilaber: so my ai code review is compaling about hashing and a few other thigns. you should make these dataclases and it will provide default impls for hash and some other magic methods | 12:36 |
| jgilaber | sean-k-mooney, yep I can do that | 12:36 |
| jgilaber | I added __eq__ for easier testing, I don't remember if dataclasses will provide that as well | 12:37 |
| sean-k-mooney | it can | 12:37 |
| jgilaber | but I'll look it up and update the patches | 12:37 |
| sean-k-mooney | but it depend on how you decorate the class | 12:37 |
| sean-k-mooney | https://docs.python.org/3/library/dataclasses.html#dataclasses.dataclass | 12:38 |
| jgilaber | ack, thanks, I'll give it a read | 12:38 |
| jgilaber | that's it from me, I'll update the patches using dataclasses and we can discuss further in the reviews | 12:39 |
| jgilaber | next patch is from chandankumar | 12:39 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher-specs/+/970220 | 12:39 |
| chandankumar | I have question about this spec, Do we want to add the selenium/playwright poc results after the spec merged? or is it ok to include it in current one. | 12:40 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 12:40 |
| jgilaber | ^^ for the playwright poc | 12:40 |
| sean-k-mooney | well we are pas spec freeze so this will not get pushed to next cycle | 12:41 |
| jgilaber | do we want to make the selenium/playwright before or after the spec if finished? | 12:41 |
| sean-k-mooney | what i think we shoudl do is reprose it in the new folder and start on the impelation based on the outcoem of the poc | 12:41 |
| sean-k-mooney | well chandankumar has already dont eh poc of both | 12:42 |
| sean-k-mooney | its been a while since i looked but the playwright version looked cleaner to me | 12:42 |
| sean-k-mooney | i sughest we spend soem time next week reviewing it in detail and decied what to proceed with in the next irc meeting | 12:42 |
| jgilaber | right, I've read the spec and skimmed the poc and playwright seems like it has some advantages | 12:42 |
| jgilaber | +1, I'll try to give it some more time | 12:43 |
| opendevreview | Merged openstack/watcher stable/2025.1: use the correct package name for microversion-parse https://review.opendev.org/c/openstack/watcher/+/967360 | 12:43 |
| jgilaber | chandankumar, does that sound good to you? do you need anything else? | 12:43 |
| chandankumar | nope, I will repropose in the new folder once 2026.2 patch merges. | 12:43 |
| chandankumar | sorry yes | 12:44 |
| jgilaber | ack, thanks | 12:44 |
| chandankumar | all good here | 12:44 |
| sean-k-mooney | cool you can stilll start building out tests in the choosen framwrok but we likely wont merge them until after rc1 at this point | 12:44 |
| sean-k-mooney | perhas some non invasive changes could be started | 12:44 |
| chandankumar | sounds good | 12:45 |
| sean-k-mooney | we can appove the spec for the next cycle before that as well we just need to reviw and agree on the direction | 12:45 |
| sean-k-mooney | rc1 is march 9 by the way soin like 8 ish weeks | 12:46 |
| sean-k-mooney | FF is in 6 weeks | 12:46 |
| jgilaber | so that is the end of the reviews we had for today, any last minute topic? | 12:47 |
| jgilaber | if not, we can move to the last one | 12:48 |
| jgilaber | #topic Volunteers to chair next meeting | 12:48 |
| chandankumar | I can take it | 12:48 |
| jgilaber | thanks chandankumar | 12:48 |
| jgilaber | that's it for today, if we don't have anything else we can give everyone 10 minutes back | 12:49 |
| jgilaber | thanks everyone! | 12:50 |
| jgilaber | #endmeeting | 12:50 |
| opendevmeet | Meeting ended Thu Jan 15 12:50:21 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 12:50 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/watcher/2026/watcher.2026-01-15-12.01.html | 12:50 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/watcher/2026/watcher.2026-01-15-12.01.txt | 12:50 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/watcher/2026/watcher.2026-01-15-12.01.log.html | 12:50 |
| amoralej | thanks for chairing jgilaber++ | 12:50 |
| morenod | thanks jgilaber++ | 12:50 |
| chandankumar | jgilaber++ thank you for chairing! | 12:51 |
| *** user is now known as Guest35932 | 12:58 | |
| opendevreview | Merged openstack/watcher master: Add documentation section for actions https://review.opendev.org/c/openstack/watcher/+/968025 | 13:09 |
| sean-k-mooney | amoralej: can you rebase https://review.opendev.org/c/openstack/watcher/+/969950/1 | 13:17 |
| amoralej | sure | 13:17 |
| amoralej | lemme check | 13:17 |
| sean-k-mooney | it was based on an older revisoin of the doc patch so it went into merge conflcith when that landed | 13:18 |
| amoralej | yep, working on it | 13:18 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Skip stop actions in pre_condition phase https://review.opendev.org/c/openstack/watcher/+/969950 | 13:22 |
| amoralej | sean-k-mooney, ^ done | 13:22 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Refactor service monitor for decision-engine https://review.opendev.org/c/openstack/watcher/+/970612 | 14:46 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Assign hostname to ActionPlan when picked-up https://review.opendev.org/c/openstack/watcher/+/970613 | 14:48 |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add service monitor for the Applier service https://review.opendev.org/c/openstack/watcher/+/970614 | 14:49 |
| opendevreview | Merged openstack/watcher master: Skip migrate actions in pre_condition phase https://review.opendev.org/c/openstack/watcher/+/966699 | 14:53 |
| opendevreview | Merged openstack/watcher master: Add option to filter action plans by hostname from db connection https://review.opendev.org/c/openstack/watcher/+/970396 | 14:55 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add wrapper classes for novaclient objects https://review.opendev.org/c/openstack/watcher/+/972912 | 16:24 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Use wrapper classes for novaclient objects https://review.opendev.org/c/openstack/watcher/+/972913 | 16:24 |
| *** gmaan is now known as gmaan_afk | 16:33 | |
| opendevreview | Alfredo Moralejo proposed openstack/watcher master: Add service monitor for the Applier service https://review.opendev.org/c/openstack/watcher/+/970614 | 16:42 |
| *** gmaan_afk is now known as gmaan | 17:46 | |
| opendevreview | Merged openstack/watcher master: Refactor service monitor for decision-engine https://review.opendev.org/c/openstack/watcher/+/970612 | 18:10 |
| opendevreview | Merged openstack/watcher master: Assign hostname to ActionPlan when picked-up https://review.opendev.org/c/openstack/watcher/+/970613 | 18:12 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add wrapper classes for novaclient objects https://review.opendev.org/c/openstack/watcher/+/972912 | 19:20 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Use wrapper classes for novaclient objects https://review.opendev.org/c/openstack/watcher/+/972913 | 19:20 |
| opendevreview | Merged openstack/watcher master: Skip stop actions in pre_condition phase https://review.opendev.org/c/openstack/watcher/+/969950 | 21:30 |
Generated by irclog2html.py 4.0.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!