| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Add tests for get_dst_pool_and_type method https://review.opendev.org/c/openstack/watcher/+/979120 | 09:07 |
|---|---|---|
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Fix zone migration dst pool and type selection https://review.opendev.org/c/openstack/watcher/+/979121 | 09:07 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Add tests for get_dst_pool_and_type method https://review.opendev.org/c/openstack/watcher/+/979122 | 09:08 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Fix zone migration dst pool and type selection https://review.opendev.org/c/openstack/watcher/+/979123 | 09:08 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Add tests for get_dst_pool_and_type method https://review.opendev.org/c/openstack/watcher/+/979124 | 09:09 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Fix zone migration dst pool and type selection https://review.opendev.org/c/openstack/watcher/+/979125 | 09:09 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Fix check for volume type in cinder helper migrate https://review.opendev.org/c/openstack/watcher/+/979128 | 09:30 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.2: Fix small issues in cinder_helper unit test https://review.opendev.org/c/openstack/watcher/+/979129 | 09:30 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Fix check for volume type in cinder helper migrate https://review.opendev.org/c/openstack/watcher/+/979132 | 09:44 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2025.1: Fix small issues in cinder_helper unit test https://review.opendev.org/c/openstack/watcher/+/979133 | 09:44 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Fix check for volume type in cinder helper migrate https://review.opendev.org/c/openstack/watcher/+/979134 | 09:45 |
| opendevreview | Joan Gilabert proposed openstack/watcher stable/2024.2: Fix small issues in cinder_helper unit test https://review.opendev.org/c/openstack/watcher/+/979135 | 09:45 |
| opendevreview | chandan kumar proposed openstack/watcher master: Add watcher-grenade-skip-level-always job https://review.opendev.org/c/openstack/watcher/+/979137 | 10:41 |
| opendevreview | chandan kumar proposed openstack/watcher master: Add watcher-grenade-skip-level-always job https://review.opendev.org/c/openstack/watcher/+/979137 | 10:43 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 11:25 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Test zone migration volume and compute migrations https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/962702 | 11:25 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add extra checks to zone migration retype test https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/963559 | 11:25 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 12:02 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Test zone migration volume and compute migrations https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/962702 | 12:02 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add extra checks to zone migration retype test https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/963559 | 12:02 |
| opendevreview | OpenStack Release Bot proposed openstack/python-watcherclient stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/python-watcherclient/+/979183 | 13:22 |
| opendevreview | OpenStack Release Bot proposed openstack/python-watcherclient stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/python-watcherclient/+/979184 | 13:22 |
| opendevreview | chandan kumar proposed openstack/watcher master: Add watcher-grenade-skip-level-always job https://review.opendev.org/c/openstack/watcher/+/979137 | 14:07 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Add test for zone migration audit without dst_type https://review.opendev.org/c/openstack/watcher/+/979275 | 14:29 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Ensure zone migration creates the correct action https://review.opendev.org/c/openstack/watcher/+/979276 | 14:29 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 14:31 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Test zone migration volume and compute migrations https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/962702 | 14:31 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add extra checks to zone migration retype test https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/963559 | 14:31 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add test for volume migrate with zone migration https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 14:54 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Test zone migration volume and compute migrations https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/962702 | 14:54 |
| opendevreview | Joan Gilabert proposed openstack/watcher-tempest-plugin master: Add extra checks to zone migration retype test https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/963559 | 14:54 |
| jgilaber | sean-k-mooney, dviroel hi! after we landed the bug fix for the cinder helper volume type check I respined the patches to add tempest testing for volume migrations https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 16:42 |
| jgilaber | unfortunately, that surfaced yet another bug in zone migration. This one seems to be on me, after the last change to the schema I missed to add testing for the cases where there was not 'dst_type' in the input | 16:43 |
| jgilaber | the fix is trivial https://review.opendev.org/c/openstack/watcher/+/979276 and I added the patch as depends-on in the tempest plugin patch which has validated the fix | 16:44 |
| jgilaber | in https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/958644 | 16:44 |
| jgilaber | sorry wanted to link the buildset https://zuul.opendev.org/t/openstack/buildset/4392e497d9fd434491f0050e5f20b3fb | 16:44 |
| jgilaber | please add to your review list, I'm not looking to get it merged immediately, the CI is still failing on the tox-cover job with the 'AttributeError: 'Parsed' object has no attribute 'config_format'' error | 16:45 |
| dviroel | ack jgilaber i will take a look, we should be able to merge once ci is healthy again | 17:10 |
| sean-k-mooney | the tox pin merged a few minutes ago | 17:38 |
| sean-k-mooney | so that shoudl be healty if that what failed before | 17:38 |
| sean-k-mooney | looks like the lst run was green | 17:39 |
| sean-k-mooney | im going to finsih at the top of the hour but ill take a look before i go | 17:39 |
| sean-k-mooney | actully it looks like that depend on https://review.opendev.org/c/openstack/watcher/+/979276 | 17:40 |
| jgilaber | thank you! yes, that is the fix for the bug I found today | 17:40 |
| sean-k-mooney | is this a regression intoduced this cycle | 17:42 |
| jgilaber | yes actually, this a consequence of https://review.opendev.org/c/openstack/watcher/+/964776 which we merged in November | 17:42 |
| jgilaber | 'dst_type' was a required field before that patch, but it changed it to optional, but I did not update the strategy code to account for that fact | 17:45 |
| opendevreview | Merged openstack/python-watcherclient stable/2026.1: Update .gitreview for stable/2026.1 https://review.opendev.org/c/openstack/python-watcherclient/+/979183 | 17:50 |
| sean-k-mooney | https://review.opendev.org/c/openstack/watcher/+/979276 is perhaps not a complete fix | 17:51 |
| sean-k-mooney | do we ahve validation that you provided at least one of a dest pool or dest type | 17:51 |
| sean-k-mooney | i think you may have done that in the schema | 17:51 |
| sean-k-mooney | but have you validated that | 17:51 |
| sean-k-mooney | i say that becaus warning logs are ment to be somethign actionable by the operator | 17:52 |
| opendevreview | Merged openstack/python-watcherclient stable/2026.1: Update TOX_CONSTRAINTS_FILE for stable/2026.1 https://review.opendev.org/c/openstack/python-watcherclient/+/979184 | 17:53 |
| jgilaber | hmm I thought we had a unit test for that but we don't. I've test it locally and the schema validation catches if neither dst_pool nor dst_type are passed | 17:54 |
| jgilaber | I can add the test to the patch | 17:55 |
| sean-k-mooney | lets add that in a follow up patch | 17:55 |
| jgilaber | ack | 17:55 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Test zone migration audit without destination https://review.opendev.org/c/openstack/watcher/+/979326 | 17:58 |
| sean-k-mooney | jgilaber: doug and i both commented on the log message for diffent reason https://review.opendev.org/c/openstack/watcher/+/979276/1/watcher/decision_engine/strategy/strategies/zone_migration.py | 17:59 |
| sean-k-mooney | so maybe we shoudl just update the patch | 17:59 |
| sean-k-mooney | its up to you | 17:59 |
| jgilaber | yes, makes sense, let me update it | 18:00 |
| dviroel | yeah, i was not sure about both dst_ as None there, but the method that returns both dst_* can return (None, None) | 18:01 |
| jgilaber | yes, in theory it should never happen that both are None | 18:02 |
| jgilaber | since the schema would reject the audit | 18:02 |
| jgilaber | well, maybe it could happen if the user would migrate the volume directly with cinder | 18:02 |
| jgilaber | or another audit does it | 18:03 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Ensure zone migration creates the correct action https://review.opendev.org/c/openstack/watcher/+/979276 | 18:11 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Test zone migration audit without destination https://review.opendev.org/c/openstack/watcher/+/979326 | 18:11 |
| jgilaber | thanks for taking a look! I have to go now, if there is any other comment we can address it on Monday, I don't think we need to merge it | 18:12 |
| opendevreview | Merged openstack/watcher master: Add test for zone migration audit without dst_type https://review.opendev.org/c/openstack/watcher/+/979275 | 18:12 |
| sean-k-mooney | im gong to call it a day i think we will have to come back to that on monday or after we create rc1 | 18:43 |
| dviroel | we can sync on moday yes | 18:56 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!