| *** haleyb|out is now known as haleyb | 12:53 | |
| dviroel | sean-k-mooney: wrt to audit pipeline spec review... most of the things make sense and I will update the spec soon. Some of the open questions: | 14:41 |
|---|---|---|
| dviroel | 1. API hygiene: PUT over PATCH: I'm okay with implementing PUT instead of extending PATCH, so from the new microversion user would need to use PUT instead of PATCH to update default_parameters (and other parameters) | 14:41 |
| dviroel | but keep both for audit_template, and only PUT for Audit Pipeline. | 14:41 |
| sean-k-mooney | ack. we coudl do the put VS patch cleanup later | 14:45 |
| sean-k-mooney | but since we are modifying the api i just wanted to raise it | 14:46 |
| sean-k-mooney | and ya for older microverison we woudl still need to supprot patch regadless | 14:46 |
| sean-k-mooney | but the idea woudl be to prefer PUT going forward | 14:46 |
| dviroel | I am ok with putting PUT on both (audit_template and audit pipeline. | 14:47 |
| sean-k-mooney | the main gaps for me when i reviewd the spec were the datatype for the colums i nthe db, the rpc and notificaton impact and i was a littel concernd with the scope i.e. finisigin it all in one cycle | 14:50 |
| sean-k-mooney | we may want ot also do continus audits in the mvp | 14:50 |
| sean-k-mooney | i dont think that will add much | 14:50 |
| sean-k-mooney | in terms fo time | 14:50 |
| sean-k-mooney | but i am kind of leaving that up to you in terms of what you think the achiveable mvp is | 14:51 |
| dviroel | I am also considering adding only ONESHOT in the spec. There is a testing effort to be considered by including CONTINUOUS mode. Once ONESHOT is functional, we can consider CONTINUOUS. | 14:59 |
| dviroel | I think that I will also consider the Stage object, considering future extensions to the functionality | 15:00 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!