| chandankumar | sean-k-mooney: Hello, Can I take over this patch https://review.opendev.org/c/openstack/watcher-dashboard/+/978304/5#message-25d95223dbb7fa9d941c9117b6e139800d1d9ae2 to address the dviroel comment? | 11:33 |
|---|---|---|
| sean-k-mooney | 5u | 11:34 |
| sean-k-mooney | oh sure | 11:34 |
| sean-k-mooney | it was on my todolist for this sprint but it would likelybe anouther day or so before i got to it | 11:35 |
| * dviroel trying to remember whats going on | 11:35 | |
| sean-k-mooney | if you want i can do it now | 11:35 |
| sean-k-mooney | dviroel: i reverted to test instead of tests in one of the scripts by mistake | 11:35 |
| sean-k-mooney | chandankumar: give me 2 secs and ill do it now | 11:36 |
| chandankumar | sean-k-mooney: sure, thank you! | 11:36 |
| dviroel | oh ok | 11:36 |
| sean-k-mooney | dviroel: that the selenium removal patch but its a head fo the playwritch series | 11:36 |
| dviroel | ack. Gerrit is pretty slow on my side | 11:39 |
| dviroel | it is that is not only on my side | 11:40 |
| dviroel | s/it is/it seems | 11:41 |
| opendevreview | sean mooney proposed openstack/watcher-dashboard master: test: remove Selenium and integration tests https://review.opendev.org/c/openstack/watcher-dashboard/+/978304 | 11:41 |
| sean-k-mooney | same for me | 11:41 |
| opendevreview | sean mooney proposed openstack/watcher-dashboard master: test: strengthen error-path tests and suppress log noise https://review.opendev.org/c/openstack/watcher-dashboard/+/978303 | 11:49 |
| opendevreview | sean mooney proposed openstack/watcher-dashboard master: test: fix efficacy_specifications fixture to be a list https://review.opendev.org/c/openstack/watcher-dashboard/+/978305 | 11:55 |
| opendevreview | sean mooney proposed openstack/watcher-dashboard master: refactor: centralise Django settings access in config.py https://review.opendev.org/c/openstack/watcher-dashboard/+/978301 | 11:55 |
| sean-k-mooney | dviroel: gerrit seams ot be less sad now | 11:56 |
| dviroel | yes! | 11:56 |
| sean-k-mooney | chandankumar: i think those are all the ones in front of the playwrite serise yes? | 11:56 |
| chandankumar | yes | 11:57 |
| sean-k-mooney | cool we can ignore the reset of the service layere serise as those are mostly still wrok in progress | 11:57 |
| sean-k-mooney | if i proceed withthem isll rework them before i do | 11:57 |
| chandankumar | ok | 11:59 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Fix releasenotes tox environment missing dependencies https://review.opendev.org/c/openstack/watcher-dashboard/+/992448 | 13:04 |
| chandankumar | dviroel: sean-k-mooney ^^ will fix the release notes job on watcher-dashboard. | 13:05 |
| sean-k-mooney | sure looks fine to me | 13:06 |
| sean-k-mooney | with that said reno | 13:06 |
| sean-k-mooney | is not actully reuqired at runtime ingenral | 13:06 |
| sean-k-mooney | its only used to create the template | 13:06 |
| sean-k-mooney | at least i think that is true | 13:07 |
| sean-k-mooney | anywya nova include it and so do a few other so i have no issue iwth adding it | 13:07 |
| chandankumar | ok | 13:07 |
| sean-k-mooney | we dont tent od ahve release notes for the tempest plugin repo in general so its easy to miss | 13:08 |
| sean-k-mooney | oh that whas the dashbvaord repo | 13:08 |
| sean-k-mooney | sorry | 13:08 |
| sean-k-mooney | that makes more sense | 13:08 |
| * dviroel looking.. | 13:16 | |
| opendevreview | Merged openstack/watcher-dashboard master: Fix releasenotes tox environment missing dependencies https://review.opendev.org/c/openstack/watcher-dashboard/+/992448 | 13:32 |
| opendevreview | chandan kumar proposed openstack/watcher-dashboard master: Add Playwright-based E2E testing framework https://review.opendev.org/c/openstack/watcher-dashboard/+/970353 | 13:49 |
| *** jgilaber_ is now known as jgilaber | 14:01 | |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Remove nova_helper retries for openstacksdk params https://review.opendev.org/c/openstack/watcher/+/975498 | 14:53 |
| chandankumar | amoralej: dviroel https://review.opendev.org/c/openstack/watcher-dashboard/+/978304 https://review.opendev.org/c/openstack/watcher-dashboard/+/978303/6 https://review.opendev.org/c/openstack/watcher-dashboard/+/978305/6 https://review.opendev.org/c/openstack/watcher-dashboard/+/978301/5 are good to land | 14:59 |
| chandankumar | Once merges, I will rebase the playwright patches tomorrow | 15:00 |
| chandankumar | thank you! | 15:00 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Remove nova_helper retries for openstacksdk params https://review.opendev.org/c/openstack/watcher/+/975498 | 15:05 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!