| *** Gues__________________________ is now known as mmagr | 08:05 | |
| opendevreview | David proposed openstack/watcher-dashboard master: Add Playwright tests for filter functionality https://review.opendev.org/c/openstack/watcher-dashboard/+/998131 | 08:14 |
|---|---|---|
| dviroel | sean-k-mooney: hey o/ - can you give me more details on what is missing here https://review.opendev.org/c/openstack/watcher/+/996849/3..17/watcher/objects/audit_pipeline.py#b72 ? - i recently added "stages" there, but you mentioned that is missing yet. | 14:40 |
| sean-k-mooney | oh i may have mised that or had a preiov versoin open | 14:53 |
| sean-k-mooney | that looks ok | 14:53 |
| sean-k-mooney | we somethime defien expclit list version fo the classes | 14:54 |
| sean-k-mooney | so we can define the get by * function on the colletion | 14:54 |
| sean-k-mooney | so we have Flavor and FlavorLiost https://github.com/openstack/nova/blob/master/nova/objects/flavor.py#L657 | 14:55 |
| sean-k-mooney | so i was expcting AuditPipelineStage and AuditPipelineStageList | 14:56 |
| dviroel | sorry, forgot to get back here | 15:06 |
| sean-k-mooney | i think we can proceed with it as is | 15:08 |
| opendevreview | Merged openstack/watcher master: Add metric query methods to BaseStrategy https://review.opendev.org/c/openstack/watcher/+/999716 | 15:08 |
| dviroel | yeah, it also makes sense for sure | 15:08 |
| sean-k-mooney | the extra class while useful can be added later | 15:08 |
| dviroel | yep | 15:08 |
| sean-k-mooney | for now any list type function cna live on the indivgeal object | 15:09 |
| sean-k-mooney | in nova we need the extra class becasue we have agents without db access | 15:09 |
| sean-k-mooney | in watcher each process has direct db access | 15:09 |
| sean-k-mooney | so we never need to serialise collections | 15:09 |
| dviroel | oh ok | 15:10 |
| sean-k-mooney | we have ListOfObjectsField field in nova too | 15:11 |
| sean-k-mooney | but only for things that are nver queried on there own i think | 15:12 |
| sean-k-mooney | by the way im not a super fan of how the egager flag is being propeosed | 15:13 |
| sean-k-mooney | but we can also refien tha tlater | 15:13 |
| sean-k-mooney | the way im more used to seeign this doen is for object where we want to supprot lazy loading | 15:14 |
| sean-k-mooney | the normal interface to eagerly loading them im used too | 15:14 |
| sean-k-mooney | is passign a list fo the extra files to load by name | 15:14 |
| sean-k-mooney | https://github.com/openstack/nova/blob/master/nova/objects/instance.py#L55-L81 | 15:15 |
| sean-k-mooney | i think the bool approch is ok for now but we shoudl move to somethign more flexible later | 15:16 |
| dviroel | i see, nova objects really have much more content to be loaded, so it supports passing the columns to be loaded | 15:29 |
| sean-k-mooney | i feel like https://review.opendev.org/c/openstack/watcher/+/996849/17 is tryign to do more then shoudl be in one comeit | 16:28 |
| sean-k-mooney | the db and obejct parts proably shoudl have been split | 16:28 |
| sean-k-mooney | dviroel: and yes in genreally we try to have all data loading via the object itnerface | 16:29 |
| sean-k-mooney | we try to aovid one off funcitons to load part of the obejcts and isntead if we deam the filed will be rarely used we make ti optional and load it only when requested ro lazy load it | 16:30 |
| dviroel | i will take a look on your comments | 16:39 |
| opendevreview | sean mooney proposed openstack/watcher master: Migrate package metadata to pyproject.toml https://review.opendev.org/c/openstack/watcher/+/981604 | 17:51 |
| opendevreview | sean mooney proposed openstack/watcher master: Raise minimum Python to 3.11 for 2026.2 runtime https://review.opendev.org/c/openstack/watcher/+/981607 | 17:51 |
| opendevreview | sean mooney proposed openstack/watcher master: Make openstack-tox-py314 voting in check and gate https://review.opendev.org/c/openstack/watcher/+/981609 | 17:51 |
| sean-k-mooney | updated ^ that was indeded for early in the cycle... | 17:51 |
| sean-k-mooney | ah i have some pendign coment to adress to | 17:53 |
| opendevreview | sean mooney proposed openstack/watcher master: Migrate package metadata to pyproject.toml https://review.opendev.org/c/openstack/watcher/+/981604 | 18:16 |
| opendevreview | sean mooney proposed openstack/watcher master: Raise minimum Python to 3.11 for 2026.2 runtime https://review.opendev.org/c/openstack/watcher/+/981607 | 18:16 |
| opendevreview | sean mooney proposed openstack/watcher master: Make openstack-tox-py314 voting in check and gate https://review.opendev.org/c/openstack/watcher/+/981609 | 18:16 |
| sean-k-mooney | updated | 18:16 |
| dviroel | ack, i will take a look | 18:20 |
| sean-k-mooney | i have an issue in the secon dpatch i need to revert one of my changes | 18:24 |
| sean-k-mooney | we need multi node so i cant use openstack-single-node-noble | 18:25 |
| sean-k-mooney | actully lookign again | 18:26 |
| sean-k-mooney | we were not testign multi node in the greade josb ebfore | 18:27 |
| sean-k-mooney | we shoudl have been but we were not | 18:28 |
| sean-k-mooney | openstack-two-node-noble would work or i coudl leave it on the single node cofnig | 18:29 |
| sean-k-mooney | i feel like 2 node is more correct for watcher but i can drop it if other disagree | 18:31 |
| opendevreview | sean mooney proposed openstack/watcher master: Raise minimum Python to 3.11 for 2026.2 runtime https://review.opendev.org/c/openstack/watcher/+/981607 | 18:32 |
| opendevreview | sean mooney proposed openstack/watcher master: Make openstack-tox-py314 voting in check and gate https://review.opendev.org/c/openstack/watcher/+/981609 | 18:32 |
| sean-k-mooney | ok ill leave those for now | 18:33 |
| sean-k-mooney | and we can see what ci says | 18:34 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Audit Pipeline Object and DBAPI https://review.opendev.org/c/openstack/watcher/+/996849 | 21:59 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add AuditPipeline lifecycle notifications https://review.opendev.org/c/openstack/watcher/+/999891 | 21:59 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add AuditPipeline execution handler and cascade execution mode https://review.opendev.org/c/openstack/watcher/+/1000031 | 21:59 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add efficacy indicators for Audit Pipeline action plans https://review.opendev.org/c/openstack/watcher/+/1001009 | 21:59 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Add Audit Pipeline REST API endpoints https://review.opendev.org/c/openstack/watcher/+/997427 | 21:59 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Consolidate strategy metric-query params behind get_ methods https://review.opendev.org/c/openstack/watcher/+/1002694 | 21:59 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!