| opendevreview | Ho Minh Quang Ngo proposed openstack/watcher-tempest-plugin master: Pass Tempest client defaults to Watcher clients https://review.opendev.org/c/openstack/watcher-tempest-plugin/+/1016433 | 08:35 |
|---|---|---|
| opendevreview | Victoria Martinez de la Cruz proposed openstack/grian-ui master: Add shared helpers for the Telemetry dashboards https://review.opendev.org/c/openstack/grian-ui/+/1016314 | 10:01 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/grian-ui master: Add compute host health dashboard https://review.opendev.org/c/openstack/grian-ui/+/1016445 | 10:06 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Fix Hypervisor attribute access in saving_energy https://review.opendev.org/c/openstack/watcher/+/999387 | 11:51 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Deprecate Ironic integration https://review.opendev.org/c/openstack/watcher/+/1016211 | 11:51 |
| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher-specs master: Add Preemptible Instances spec for 2027.1 cycle https://review.opendev.org/c/openstack/watcher-specs/+/1014252 | 12:49 |
| dviroel | heads up team, watcher meeting will start in 5 | 12:55 |
| dviroel | #startmeeting watcher | 13:00 |
| opendevmeet | Meeting started Thu Nov 19 13:00:09 2026 UTC and is due to finish in 60 minutes. The chair is dviroel. Information about MeetBot at http://wiki.debian.org/MeetBot. | 13:00 |
| opendevmeet | Useful Commands: #action #agreed #help #info #idea #link #topic #startvote. | 13:00 |
| opendevmeet | The meeting name has been set to 'watcher' | 13:00 |
| jgilaber | o/ | 13:00 |
| dviroel | hi o/ - who is around for today's meeting? | 13:00 |
| morenod | o/ | 13:00 |
| dviroel | courtesy ping: amoralej sean-k-mooney chandankumar | 13:01 |
| dviroel | let's start with today's meeting agenda | 13:01 |
| dviroel | #link https://etherpad.opendev.org/p/openstack-watcher-irc-meeting#L29 (Meeting agenda) | 13:01 |
| dviroel | feel free | 13:02 |
| dviroel | to add your own topics to the agenda | 13:02 |
| amoralej__ | o/ | 13:02 |
| dviroel | lets start with | 13:02 |
| dviroel | #topic Started working on ironic deprecation | 13:02 |
| dviroel | nice, jgilaber has some updates to share | 13:02 |
| winiciusallan[m] | o/ | 13:03 |
| dviroel | #link https://review.opendev.org/c/openstack/watcher/+/1016211 (1016211: Deprecate Ironic integration) | 13:03 |
| dviroel | if we deprecate in 2027.1 | 13:03 |
| dviroel | we could remove in 2027.2 | 13:03 |
| dviroel | since indri is a slurp release | 13:04 |
| jgilaber | yes, amoralej__ pointed that out in the patch | 13:04 |
| jgilaber | I originally did not set any removal version | 13:04 |
| amoralej__ | that was also my understanding, the requirement is to deprecate it in at least one slurp, right? | 13:04 |
| dviroel | yes | 13:05 |
| jgilaber | yes, deprecation should go in a slurp (current), so removal can be in next one | 13:05 |
| dviroel | since deployments could skip the non-slurp one | 13:05 |
| dviroel | and miss the deprecation notice | 13:05 |
| amoralej__ | I'm also fine if we prefer not to announce removal release, just wondering if there is any specific reason to not | 13:05 |
| amoralej__ | in this particular case, actually, that is for a experimental feature that we know have bugs | 13:06 |
| amoralej__ | I wouldn't be conservative about removing it tbh | 13:06 |
| jgilaber | not that I can think of, I just did not put it in the spec so the llm did not add it to the patch :) | 13:06 |
| amoralej__ | ;) | 13:06 |
| dviroel | we can just announce the removal in 2027.2 and later check if is viable to really remove | 13:06 |
| dviroel | since it would remove strategies/actions together with it | 13:07 |
| jgilaber | speaking of bugs, I chained the deprecation patch with a bug fix | 13:07 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/999387 | 13:07 |
| amoralej__ | specially know that we now how watcher behaves on removals :) | 13:07 |
| jgilaber | wanted to get your thougts on if you think it's worth fixing it | 13:08 |
| jgilaber | I've proposed because it's a relatively small patch | 13:08 |
| jgilaber | but I've tried to be cautious since testing coverage is almost non-existent | 13:08 |
| dviroel | yes, i think we should fix | 13:08 |
| jgilaber | thanks for looking btw amoralej__ | 13:08 |
| dviroel | it is going to be deprecated but, we don't know the future | 13:09 |
| amoralej__ | +1 to fix it | 13:09 |
| jgilaber | ack, that settles it then, thanks | 13:09 |
| jgilaber | another point is, do we want to announce this deprecation together with the strategies | 13:10 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/1006323 | 13:10 |
| jgilaber | or send separate announcements? | 13:10 |
| dviroel | hum | 13:11 |
| amoralej__ | i think an announcement for all deprecations in this release is fine | 13:11 |
| dviroel | we need to deprecate the strategies affected by ironic integratin, for sure | 13:11 |
| dviroel | if the team agree with deprecation all mention, fine by me | 13:11 |
| dviroel | we may need to also deprecate the Action? | 13:11 |
| jgilaber | yes, the action is deprecated in my patch as well | 13:12 |
| dviroel | ah ok, good | 13:12 |
| dviroel | +1 | 13:12 |
| * dviroel didn't check any ironic deprecation patch | 13:12 | |
| * dviroel yet | 13:12 | |
| jgilaber | dviroel, if you want I can send the announcement to the ML for your patch and mine | 13:13 |
| amoralej__ | we agreed in deprecating the other non-supported in ptg? | 13:13 |
| dviroel | jgilaber: yes please | 13:13 |
| amoralej__ | i think so | 13:13 |
| jgilaber | I think so too | 13:13 |
| amoralej__ | in ether | 13:14 |
| dviroel | i don't really remember if we agree or not | 13:14 |
| amoralej__ | in ptg etherpad it's "investigate airflow, temperature, host power metrics are available in current supported datasources/exporters" | 13:14 |
| amoralej__ | i'm also not sure, tbh | 13:14 |
| dviroel | it is not in the Agreed list | 13:14 |
| amoralej__ | wait, that's from previous | 13:14 |
| dviroel | #link https://etherpad.opendev.org/p/watcher-2027.1-ptg#L420 | 13:15 |
| opendevreview | Douglas Viroel proposed openstack/watcher master: Deprecate untested strategies and refresh status matrix https://review.opendev.org/c/openstack/watcher/+/1006323 | 13:15 |
| amoralej__ | it rings me a bell that we agreed, tbh, but i'm not totally sure | 13:15 |
| jgilaber | yeah I was looking for that, it's not explicitely listed | 13:15 |
| dviroel | We can vote directly in the change then | 13:16 |
| dviroel | i just removed the W-1 and rebased | 13:16 |
| amoralej__ | wfm | 13:16 |
| jgilaber | +1, I'll send the announcement later today | 13:16 |
| dviroel | thanks jgilaber | 13:16 |
| jgilaber | so final thing on this topic, just an fyi I've also started working on adding watcher to the sdk | 13:17 |
| jgilaber | #link https://review.opendev.org/c/openstack/openstacksdk/+/1016448 | 13:17 |
| jgilaber | I will submit a series of patches | 13:17 |
| jgilaber | the first one adds the base infr and Goals | 13:17 |
| jgilaber | getting familiar with the sdk idioms and layout | 13:17 |
| dviroel | cool | 13:17 |
| dviroel | that's a great start | 13:18 |
| jgilaber | I will ping in the future for a sanity check from watcher side | 13:18 |
| dviroel | +1 | 13:18 |
| dviroel | great, any questions wrt to jgilaber's topic? | 13:18 |
| jgilaber | I've already checked with the sdk team and their process is simple, just submit (no blueprints) | 13:18 |
| dviroel | ++ | 13:19 |
| jgilaber | they are quite fast with review ime | 13:19 |
| jgilaber | that is all I had for this, thanks | 13:19 |
| amoralej__ | there is no specs repo iirc in openstacksdk :) | 13:19 |
| amoralej__ | thanks for taking care jgilaber | 13:19 |
| dviroel | ++ | 13:20 |
| dviroel | ok, so moving to the next topic | 13:20 |
| dviroel | #topic Proposal for splitting AZ Drain spec | 13:20 |
| dviroel | the AZ drain spec is getting bigger | 13:21 |
| dviroel | with the az drain functionality + zone migration improvements | 13:21 |
| dviroel | so I started a new spec to isolate the zone migration improvements | 13:21 |
| dviroel | #link https://review.opendev.org/c/openstack/watcher-specs/+/1016360 | 13:21 |
| dviroel | which are: unlimited counter and counter's deprecation | 13:22 |
| dviroel | volume migration between volume-types (src_type, dst_type) | 13:22 |
| dviroel | attached-only volumes option, | 13:22 |
| amoralej__ | one question about counter's deprecation | 13:22 |
| dviroel | and disable source node service for src/dest host entry | 13:22 |
| dviroel | amoralej__: | 13:22 |
| dviroel | yes | 13:22 |
| amoralej__ | i'm total +1 to unlimited and disable hosts in the split | 13:23 |
| amoralej__ | about counters, i always felt that the capacity of limiting the size is a nice feature, although poorly implemented in zone_migration | 13:23 |
| amoralej__ | ideally, I'd propose to change default values to unlimited instead and deprecating/removing it only once we have an implementation of limits that can be common to all strategies | 13:24 |
| amoralej__ | we discussed that in the past, i think | 13:24 |
| amoralej__ | wdyt? | 13:24 |
| jgilaber | IIRC the proposal is to set to unlimited and deprecate it | 13:25 |
| dviroel | yeah, I do think that it should be implemented outside the strategy, in the base one | 13:25 |
| jgilaber | doesn't mean we need to remove it next cycle | 13:25 |
| amoralej__ | yep, with its own parameters out of the strategy parameter | 13:25 |
| jgilaber | we can keep it around until we implement a better solution | 13:25 |
| amoralej__ | ack, wfm | 13:25 |
| jgilaber | is that correct dviroel? | 13:26 |
| dviroel | yes, we can discuss the removal again in the next ptg | 13:26 |
| amoralej__ | +1 then | 13:26 |
| dviroel | so the new spec just move these parts out of Az Drain one (which I will update once you folks agree) | 13:27 |
| dviroel | if you already read the az drain one, you will see that are similar | 13:27 |
| dviroel | with that i would create a new bp too | 13:28 |
| dviroel | to link these patches | 13:28 |
| jgilaber | ack, sounds good to have a second spec, I'll try to review it tomorrow, it should be quick | 13:28 |
| dviroel | do you folks think that is reasonable? | 13:28 |
| amoralej__ | wrt the policy stuff in the az_drain one | 13:28 |
| dviroel | and yeah, we would discuss more Az drain, pinning azs and policy in the az drain spec... | 13:28 |
| amoralej__ | you update also that? | 13:28 |
| dviroel | i can update, not sure if we all agree in the etherpad | 13:29 |
| dviroel | but it also depends on the Nova side atm | 13:29 |
| dviroel | so not sure if I will update until they agree | 13:29 |
| amoralej__ | ok | 13:29 |
| dviroel | if nova will or not handle the pinning on their side | 13:29 |
| dviroel | just in case someone is now aware | 13:30 |
| dviroel | the az drain depends directly on https://review.opendev.org/c/openstack/nova-specs/+/1013094 | 13:30 |
| amoralej__ | i think that applying new parameters include-az and policy to host based only when moving to different az is a good solution | 13:30 |
| dviroel | which implements the --availability_zone parameter as destination for migrate | 13:30 |
| dviroel | and others missing.. | 13:30 |
| jgilaber | makes sense to wait until the nova spec, their spec freeze is usually before M2 | 13:30 |
| amoralej__ | ok | 13:31 |
| dviroel | amoralej__: ack, i think that we all agreed with that then | 13:31 |
| dviroel | #link https://etherpad.opendev.org/p/watcher-migrate-pin-policy | 13:31 |
| dviroel | this is the etherpad that we have been discussing the pinning policy... | 13:31 |
| dviroel | FYI | 13:31 |
| sean-k-mooney | o/ | 13:31 |
| amoralej__ | my only doubt is if we could have better config option names that makes it more clear, but i feel that's a good way to manage it | 13:32 |
| amoralej__ | and documenting it properly will also work with current names | 13:32 |
| dviroel | amoralej__: ack, yeah, long config names are also complicated to ready in the end, but we shall document it properly, and add some examples to the strategy docs.. | 13:33 |
| jgilaber | ok so the proposal is to have one default value, and document that the options will be ignored in some cases | 13:33 |
| amoralej__ | not exactly ignored | 13:33 |
| jgilaber | i.e host based audits within the same AZ | 13:33 |
| amoralej__ | it's the actual meaning of the config option :) | 13:33 |
| amoralej__ | but yeah | 13:33 |
| sean-k-mooney | parmater | 13:33 |
| sean-k-mooney | its not a config option | 13:33 |
| dviroel | yeah, parameter | 13:33 |
| amoralej__ | yes, sorry, parameter | 13:34 |
| dviroel | config option is the watcher.conf stuff | 13:34 |
| dviroel | sean-k-mooney: so i proposed a new spec with zone_migration improvements only, not realted to the az drain | 13:35 |
| jgilaber | so tldr the defaults are 'include_az_*=True', 'az_pinning_policy=auto' | 13:35 |
| amoralej__ | but include_az... actually means allow_pinned_instances_cross_az_migrations | 13:36 |
| amoralej__ | so for the host-based in the same az, it's not that we need to ignore that, it simply does not apply to it | 13:36 |
| amoralej__ | no need to have different defaults | 13:36 |
| dviroel | also note that, the Action itself defaults to None. So other strategies will continue to not change the pin. | 13:37 |
| amoralej__ | yep | 13:38 |
| dviroel | alright, any other question in this topic, we need to cover the next ones | 13:39 |
| dviroel | #action dviroel will create a new blueprint for zone migration improvements | 13:39 |
| dviroel | ok, we can move to reviews then | 13:40 |
| dviroel | #topic Reviews | 13:40 |
| dviroel | I added the one that we didn't covered last week | 13:40 |
| dviroel | Add Preemptible Instances spec for 2027.1 cycle | 13:40 |
| dviroel | #link https://review.opendev.org/c/openstack/watcher-specs/+/1014252 | 13:40 |
| dviroel | which we already started reviewing | 13:40 |
| dviroel | and winiciusallan[m] updated based on comments | 13:41 |
| dviroel | I think that we just need to revisit and merge it | 13:41 |
| dviroel | after the meeting | 13:41 |
| dviroel | fine? | 13:41 |
| amoralej__ | yes | 13:41 |
| jgilaber | +1 | 13:41 |
| dviroel | ack | 13:41 |
| winiciusallan[m] | amoralej__: I pushed a new patch this morning if you want to take another look :) | 13:41 |
| winiciusallan[m] | there is no major change, just addressing doug's comments | 13:42 |
| dviroel | winiciusallan[m]: so you will be probably good to continue with the implementation :) | 13:42 |
| amoralej__ | i did right before the meeting, just waiting for the ci | 13:42 |
| winiciusallan[m] | awesome! so will start in the next days | 13:42 |
| dviroel | ++ | 13:43 |
| dviroel | ok, so any other review to cover? | 13:43 |
| dviroel | i know that there are others open in gerrit | 13:44 |
| dviroel | we should get back to them when possible | 13:44 |
| jgilaber | I have a couple minor ones | 13:44 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/1011300 | 13:44 |
| jgilaber | #link https://review.opendev.org/c/openstack/watcher/+/1011633 | 13:44 |
| jgilaber | they are CI changes that we already covered in the past | 13:44 |
| sean-k-mooney | dviroel: cool soory was responed to a ping in a diffenrt channel | 13:45 |
| sean-k-mooney | ill review that once im done wiht amoralej__ spec | 13:45 |
| jgilaber | not critical, but would be good to merge I think | 13:45 |
| dviroel | jgilaber: ack, i will check the logs of the aetos job and proceed with it yeah | 13:45 |
| dviroel | it was in my list | 13:45 |
| jgilaber | thanks! | 13:46 |
| sean-k-mooney | jgilaber: speaking of bugs/reviews i was talking to stephenfin this morning about the api issue we have with version headers in watcher | 13:46 |
| dviroel | we really need to discuss max_microversion at some point, maybe together with new features like az drain | 13:46 |
| sean-k-mooney | and ya we shoudl eb remvoing ^ eventually | 13:47 |
| sean-k-mooney | jgilaber: i see you mentioned adding watcher to the sdk above | 13:48 |
| jgilaber | yes, I started on that | 13:48 |
| sean-k-mooney | but i dont see any mention of the microvsions header issue | 13:48 |
| sean-k-mooney | have you filed a bug for that | 13:48 |
| jgilaber | no, which issue exactly? | 13:49 |
| sean-k-mooney | watchers api does not supprot the standard microversion header | 13:49 |
| jgilaber | ah, I thought we had a bug for that | 13:50 |
| sean-k-mooney | it currently requires the legay project specific hearders | 13:50 |
| sean-k-mooney | maybe but we will need to fix that before the sdk work is merged | 13:50 |
| jgilaber | hmm I will double check, launchpad is not loading for me | 13:51 |
| sean-k-mooney | i think its dwon again | 13:51 |
| sean-k-mooney | from talkign to stephen microverion parse | 13:51 |
| dviroel | working on my side | 13:51 |
| sean-k-mooney | can handel this for us we just need to tell it the name of the legacy hearder | 13:51 |
| dviroel | at least this side of the ocean :) | 13:51 |
| sean-k-mooney | its working for me as well | 13:52 |
| sean-k-mooney | iu do not see a bug for it | 13:52 |
| amoralej__ | it works, but pretty slow ... | 13:52 |
| sean-k-mooney | i see https://bugs.launchpad.net/watcher/+bug/2161911 for the X-Show-Deleted header | 13:53 |
| sean-k-mooney | but i dont see any for the microverion, i think you might be thinking fo the cybrog bug that i fixed last cycle | 13:53 |
| jgilaber | I don't think we have one | 13:53 |
| jgilaber | it might be that | 13:53 |
| jgilaber | I'll look into it this afternoon and create one | 13:53 |
| dviroel | +1 | 13:54 |
| dviroel | thanks for raising this issue sean-k-mooney | 13:54 |
| amoralej__ | i wasn't aware of that ... | 13:54 |
| sean-k-mooney | ya so watcher is techinially not compliete with the api-sig spec on how microversion should work | 13:54 |
| sean-k-mooney | since it never adopted the standard header that is ment to be common to all services | 13:55 |
| amoralej__ | yep, make sense to fix that | 13:55 |
| sean-k-mooney | that means the sdk woudl need special handelign and there are keyston auth implciation too | 13:55 |
| sean-k-mooney | its simpler for use to jsut add the supprot and backprot it if we care too | 13:55 |
| jgilaber | this is the cyborg commmit https://github.com/openstack/cyborg/commit/7faf80e098f189e6220ccbe5bfc9d179f482fa76 | 13:55 |
| sean-k-mooney | and for the sdk just assume its tehre | 13:55 |
| amoralej__ | +1 | 13:55 |
| sean-k-mooney | jgilaber: yep cybrog had supprot for the header just incoroect supprot | 13:56 |
| sean-k-mooney | for watcher its a larger issue | 13:56 |
| sean-k-mooney | but the change will be similar | 13:56 |
| sean-k-mooney | just use microverion-parse to handel it | 13:56 |
| sean-k-mooney | and ther is a paremter fo the legacy project specifc header name | 13:56 |
| jgilaber | will dig into that, thanks | 13:56 |
| dviroel | +1 | 13:57 |
| dviroel | lets try to cover the bugs topic in these last 3 minutes | 13:57 |
| dviroel | #topic Bugs | 13:57 |
| dviroel | #link https://bugs.launchpad.net/watcher/+bug/2174411 | 13:57 |
| dviroel | "Audit scope: add exclusion by flavor (or flavor extra specs) to keep GPU / large instances out of optimization" | 13:57 |
| amoralej__ | that's an interesting one ... | 13:57 |
| dviroel | not an bug, but a rfe | 13:58 |
| amoralej__ | yes | 13:58 |
| dviroel | but indeed something that i would like to have in scope | 13:58 |
| dviroel | more options for filtering based on extra_specs | 13:58 |
| jgilaber | yes, valid use case, we can keep it as wishlist | 13:58 |
| amoralej__ | exclussions would be OR, right? | 13:59 |
| dviroel | we would not need to exlucde gpus from scope if we implement the strategy filters | 13:59 |
| dviroel | since we know that these would be invalid from watcher point of view | 13:59 |
| dviroel | but still, the flavor exclusion is a use case | 13:59 |
| sean-k-mooney | that is not a bug | 14:00 |
| sean-k-mooney | its a feature | 14:00 |
| dviroel | should we keep it as a RFE? | 14:00 |
| sean-k-mooney | if we do it we will likely need a spec | 14:00 |
| sean-k-mooney | we coudl keep it as a whishlist bug as a rfe tracker | 14:01 |
| dviroel | right, maybe the reporter has a plan to implement it | 14:01 |
| dviroel | I can comment in the bug too | 14:01 |
| amoralej__ | let's request to follow the new feature process | 14:01 |
| dviroel | and let they know that this would require an spec | 14:01 |
| amoralej__ | he may want to start working on it | 14:02 |
| dviroel | yeah | 14:02 |
| dviroel | we would need to agree on how to model that in the existing scope | 14:02 |
| sean-k-mooney | for something that woudl affect the behvior of every stragiy it defintely needs a spec to discuss the potial upgrade impacts adn makign sure this work with the pipeline feature and the change too the syncer | 14:02 |
| dviroel | +1 | 14:02 |
| sean-k-mooney | scopes are also not plugable | 14:03 |
| sean-k-mooney | so arguable this shoudl be part fo the microverison contract | 14:03 |
| * dviroel we are out of time | 14:04 | |
| sean-k-mooney | that said we coudl allow parmater to be added to the scope without a microversion but scopes are not something that are implemtne by the stragey | 14:04 |
| amoralej__ | are in the collectors actually | 14:04 |
| amoralej__ | iirc | 14:04 |
| dviroel | while you folks discuss that, let me see if | 14:05 |
| dviroel | #topic Volunteer to chair next week | 14:05 |
| dviroel | someone wants to chair next one? | 14:05 |
| dviroel | otherwise I can take it | 14:05 |
| jgilaber | I can take it | 14:05 |
| dviroel | jgilaber++ | 14:05 |
| dviroel | thanks | 14:05 |
| dviroel | alright | 14:05 |
| dviroel | we are out of time | 14:05 |
| dviroel | we can continue discussing it here or in the launchpad | 14:06 |
| dviroel | thanks all for joining | 14:06 |
| dviroel | we will meet again next week | 14:06 |
| dviroel | #endmeeting | 14:06 |
| opendevmeet | Meeting ended Thu Nov 19 14:06:22 2026 UTC. Information about MeetBot at http://wiki.debian.org/MeetBot . (v 0.1.4) | 14:06 |
| opendevmeet | Minutes: https://meetings.opendev.org/meetings/watcher/2026/watcher.2026-11-19-13.00.html | 14:06 |
| opendevmeet | Minutes (text): https://meetings.opendev.org/meetings/watcher/2026/watcher.2026-11-19-13.00.txt | 14:06 |
| opendevmeet | Log: https://meetings.opendev.org/meetings/watcher/2026/watcher.2026-11-19-13.00.log.html | 14:06 |
| jgilaber | sean-k-mooney, I did a quick check before going for lunch, and it seems in Watcher we already use microversion_parse https://github.com/openstack/watcher/blob/28e511b7f6a05ea6bfa66e3cc8e65c08b1a93fe0/watcher/api/controllers/base.py#L97 for the header | 14:08 |
| jgilaber | just that we use the 'infra-optim' alias | 14:08 |
| amoralej__ | also, it'd be great if we could close https://review.opendev.org/q/topic:%22blueprint-functional-test-infrastructure%22+status:open ... | 14:08 |
| amoralej__ | both have 1 +2 | 14:08 |
| jgilaber | it would not be too hard to change and keep 'infra-optim' as fallback so it's backportable | 14:09 |
| jgilaber | am I missing something else? I remember we talked about this a while ago | 14:09 |
| jgilaber | in my initial patch to the sdk I have a workaround for that, I haven't yet tested it | 14:09 |
| dviroel | amoralej__: ack, lets see if jgilaber can take a look on those and merge them. We can provide follow ups if needed too | 14:10 |
| dviroel | jgilaber: sorry, this is about https://review.opendev.org/q/topic:%22blueprint-functional-test-infrastructure%22+status:open | 14:10 |
| jgilaber | amoralej__, they are on my list, I had given priority to the specs | 14:10 |
| sean-k-mooney | so infra-optim | 14:10 |
| jgilaber | but I think I might be able to review them next week | 14:10 |
| sean-k-mooney | is teh offcial name in the service athority i belive | 14:10 |
| amoralej__ | sure, no problem, thanks in advance jgilaber | 14:11 |
| sean-k-mooney | oh no | 14:11 |
| sean-k-mooney | https://github.com/openstack/service-types-authority/blob/master/service-types.yaml#L34-L37 | 14:11 |
| jgilaber | https://github.com/openstack/os-service-types/blob/master/os_service_types/data/service-types.json#L147 | 14:11 |
| sean-k-mooney | your right its resocue-optimization | 14:11 |
| jgilaber | oh thanks I forgot the exact repo name | 14:11 |
| sean-k-mooney | jgilaber: one is generated form the other | 14:12 |
| jgilaber | yes, I rememember I check that and filed a bug at some point, but it might have been downstream | 14:12 |
| sean-k-mooney | i dont actully recall which one is the souce | 14:12 |
| sean-k-mooney | so what we need to fix i think is makign sure both names work | 14:12 |
| jgilaber | ok, yes I can do that before we merge the sdk changes | 14:13 |
| jgilaber | I'll file a bug once launchpad lets me | 14:14 |
| jgilaber | thanks for looking | 14:14 |
| amoralej__ | that rings me a bell, we reported something related to that | 14:14 |
| jgilaber | yes, I'm sure I did, but maybe not upstream | 14:15 |
| *** jgilaber is now known as jgilaber|lunch | 14:16 | |
| sean-k-mooney | jgilaber: so i just asked ^ about the actull issue | 14:16 |
| jgilaber|lunch | ack thanks I'll read back in a bit | 14:16 |
| amoralej__ | yes, it was downstream issue, probably a different one | 14:16 |
| sean-k-mooney | tldr wathcer shoudl accpet both the offial name and the alias | 14:16 |
| sean-k-mooney | but it need the alias today | 14:16 |
| stephenfin | jgilaber|lunch: I don't have the scrollback but this is what I was discussing with sean-k-mooney https://review.opendev.org/c/openstack/service-types-authority/+/1016452 | 14:16 |
| sean-k-mooney | ^ is a workaround for now | 14:17 |
| sean-k-mooney | but really we shoudl jsut fix watcher to accpet resource-optimization as well | 14:18 |
| sean-k-mooney | eventully that is also what we shoudl docuemtn as the service type to use when isntalling/configuring watchers serview type in the keystone endpoint | 14:18 |
| sean-k-mooney | which would need changes to our downstream installer and devstack | 14:19 |
| sean-k-mooney | but that can come later | 14:19 |
| sean-k-mooney | amoralej__: im +1 on https://review.opendev.org/c/openstack/watcher-specs/+/1012696 see questions inline | 14:30 |
| sean-k-mooney | nothing major but just want to confirm a few things before merging | 14:30 |
| dviroel | ok, so jgilaber|lunch should file a bug fopr that, we indeed need to fix and accept the oficial name | 14:30 |
| *** jgilaber|lunch is now known as jgilaber | 14:36 | |
| jgilaber | reading back, ok so it seems I understood the problem correctly, I'll file a bug and submit a fix, should not be too hard | 14:38 |
| jgilaber | launchpad is back for me, I filed https://bugs.launchpad.net/watcher/+bug/2175053 | 15:38 |
| amoralej__ | sean-k-mooney, i will update the spec, thanks for your review. A question just came to my mind.What about AuditTemplates? they may also have parameters that are removed or renamed i.e. that would need to be upgraded. should we run upgrade_parameters on them? | 16:35 |
| amoralej__ | dviroel, jgilaber ^ wrt https://review.opendev.org/c/openstack/watcher-specs/+/1012696 | 16:35 |
| amoralej__ | for default_parameters | 16:36 |
| jgilaber | do we need to? Wouldn't the paramaters be upgraded once they are used to create an audit? | 16:37 |
| amoralej__ | not if the default_parameters has an non longer valid parameter | 16:37 |
| amoralej__ | i actually will fail to create the Audit, i think | 16:37 |
| amoralej__ | it wouldn't affect the audits previously created from the AuditTemplate | 16:38 |
| amoralej__ | those will be updated | 16:38 |
| amoralej__ | but for the AT itself, if a new Audit is created from it, it'd fail i think | 16:38 |
| sean-k-mooney | default_parmaters is used to initalise pamters and hten you merge any actual auit parmater into that | 16:40 |
| sean-k-mooney | i dont htink we need to upgrade the audit template | 16:40 |
| sean-k-mooney | the expction | 16:40 |
| jgilaber | I was thinking the same, we don't validate the default parameters right? | 16:40 |
| sean-k-mooney | woudl be the remvoal of a parmater form the relevent stragy | 16:41 |
| sean-k-mooney | but we coudl do that when we are cretaign the actual audit form the templaste | 16:41 |
| amoralej__ | so, i create an AT with parameter param1: foo. The strategy renames param1 to param2. An attempt to create the Audit would fail | 16:41 |
| sean-k-mooney | and the admin coudl update the audit template default_parmaters after/beofre upgrade | 16:41 |
| sean-k-mooney | well no | 16:41 |
| sean-k-mooney | because create an audit with parm1 shoudl still work after the rename | 16:42 |
| sean-k-mooney | because the upgrade on parmaters shoudl rename it right | 16:42 |
| amoralej__ | well, in that case no migration is needed at all, that'd be a backwards compatible change | 16:42 |
| amoralej__ | The whole point of the upgrade_parameters() is to cover non-backwards compatible changes | 16:43 |
| amoralej__ | and would be only executed at upgrade (restart), not at audit creation | 16:43 |
| amoralej__ | so, i rename param1 -> param2 (full rename, removing old name). Then i create an upgrade_parameters which renames param1 to param2 in the parameters dict of existing audits | 16:44 |
| amoralej__ | on next restart | 16:45 |
| sean-k-mooney | ya so we will do soemthing like a = Autidt(parmaters=template.default_parmaters().update(request.parmaters) | 16:45 |
| sean-k-mooney | a.upgrade_paramaters | 16:45 |
| sean-k-mooney | () | 16:45 |
| amoralej__ | yes | 16:45 |
| sean-k-mooney | well wee need to make a copy since that would do bad things as written | 16:45 |
| sean-k-mooney | but i think we agree over all | 16:45 |
| amoralej__ | yes, but i'm not sure about AuditTemplates | 16:46 |
| sean-k-mooney | i dont think we need to modify audit templates, we could | 16:46 |
| amoralej__ | so, admins would need to update the AT, right? | 16:47 |
| sean-k-mooney | but the point is that we are snapshoting the inputs wehn we are creating the audit | 16:47 |
| sean-k-mooney | yes | 16:47 |
| sean-k-mooney | they woudl need to update it everntully | 16:47 |
| amoralej__ | wfm | 16:47 |
| sean-k-mooney | if we were changign a name we shoudl suprot both for some period of time | 16:47 |
| amoralej__ | yeah, that was just an example of non-backwards compatible change, which is like a last-resort | 16:48 |
| sean-k-mooney | we can provide a helper method to migrate them as a watcher-db-manage commend if we want to | 16:48 |
| amoralej__ | default policy is being backwards compatible ... | 16:48 |
| sean-k-mooney | or they can manuallyupdate the template before upgrading to the version that does not supprot hte deprecated name | 16:48 |
| amoralej__ | I'll be explicit in the spec | 16:49 |
| sean-k-mooney | the audit parmaters actully have 3 levels of inputs for the snapshot | 16:49 |
| sean-k-mooney | the lowest precendent is the stragey default | 16:49 |
| sean-k-mooney | then the audit template default_parmaters | 16:49 |
| sean-k-mooney | and then what ever you pass in the audit create request | 16:50 |
| amoralej__ | yes | 16:50 |
| amoralej__ | bad a wrong parameter in the AT will make the audit creation to fail, unless you are overriding that parameter in the audit | 16:50 |
| sean-k-mooney | we could (not sure we should) recored the version of the stragey the template was created agasint | 16:51 |
| amoralej__ | s/bad/but/ | 16:51 |
| sean-k-mooney | but i dont know if we need that | 16:51 |
| amoralej__ | yeah, it's a extreme case tbh | 16:51 |
| sean-k-mooney | so it shoudl not | 16:51 |
| amoralej__ | it does | 16:51 |
| amoralej__ | well, i can test it, but that's my expectation | 16:51 |
| sean-k-mooney | that woudl be a bug | 16:51 |
| amoralej__ | why? | 16:52 |
| sean-k-mooney | because the templates are version less and you are provideign an upgrade method | 16:52 |
| sean-k-mooney | it shoudl only cause a failure if we removed the supprot | 16:52 |
| sean-k-mooney | which woudl need a deprecation period | 16:52 |
| amoralej__ | yes, yes | 16:52 |
| amoralej__ | i always mean in the context of non-backwards compatible chagnes, for the context of this conversation | 16:52 |
| sean-k-mooney | do we currently validate and reject unknown parmater in a stragy today | 16:53 |
| amoralej__ | yes, but if you upgrade the strategy and the parameter is not longer valid, that's the case i meant | 16:53 |
| sean-k-mooney | ok well in a non backwared compatable chagne | 16:53 |
| sean-k-mooney | the process i described above was create teh obejct, set the parmaters filed and call upgrade_paramters before saving it | 16:54 |
| amoralej__ | yes, but in the spec, i only do that for existing Audits in upgrace | 16:54 |
| amoralej__ | so, pre-existing Audits will be fine | 16:55 |
| sean-k-mooney | if we recored teh version of the stragey in teh audit templeate when its created we could include that in the parmater so the upgrade_parmateres use it to uplevel it | 16:55 |
| amoralej__ | my question was about new Audits being created from the AT which is now outdated | 16:55 |
| amoralej__ | yes, that was my question, if we would want to implement the exact same approach for AT default_parameters | 16:55 |
| sean-k-mooney | i think the larger question is shoudl it only happne on upgrade or shoudl it happen on all future autid creatison as well | 16:55 |
| amoralej__ | yeah, that's the other approach | 16:56 |
| sean-k-mooney | we could allow you to optioanlly pass the version in teh parmaters | 16:57 |
| sean-k-mooney | and then alwasy upgrade it perhaps if tis older then the server supprots | 16:57 |
| sean-k-mooney | but i dont knwo if we are over thinking it | 16:57 |
| amoralej__ | probably :) | 16:57 |
| sean-k-mooney | i think for now we could punt on this (AT migration) | 16:58 |
| amoralej__ | given that that case won't affect to existing running Audits | 16:58 |
| amoralej__ | which is the critical case | 16:58 |
| sean-k-mooney | and just docuemnt that you shoudl update the template when we are droping supprot for a parmater | 16:58 |
| amoralej__ | it's probably good to let it fail and document properly + deprecation period, etc... | 16:58 |
| sean-k-mooney | when we have a non backportabel change we can then dicsuss if we provide tooling to automate that for you | 16:58 |
| amoralej__ | actually, it may have very tricky corner cases when mixing versions | 16:59 |
| sean-k-mooney | how do you mean? | 16:59 |
| amoralej__ | I'm thinking ... | 16:59 |
| sean-k-mooney | here is a concreate example, we are thinking of removing the limits on action form the az migtion | 17:00 |
| amoralej__ | actually, storing the strategy version in the default_parameters in AT, we should be able to do it | 17:00 |
| sean-k-mooney | we are adding supprot for -1 for unlimited | 17:00 |
| sean-k-mooney | we may then change the default | 17:00 |
| sean-k-mooney | if we want to remvoe the parmater however that woudl be backwared incompataible | 17:00 |
| amoralej__ | that is the case i was thinking of. Rename param1 to param2 | 17:01 |
| sean-k-mooney | but in that case we woudl be removing the ablity to limit it via that approch. unless we have a replacment for the limit teh automated fix woudl be to drop the limits | 17:01 |
| sean-k-mooney | for the rename case old_name -> new_name its tricky only if we reuse old_name | 17:02 |
| sean-k-mooney | if we dont then we can order the upgrades by version | 17:02 |
| sean-k-mooney | form oldest to newest | 17:03 |
| sean-k-mooney | and even if you later rename new_name to new_name_2 | 17:03 |
| sean-k-mooney | you can determisticly upgrade form old_name->new_name_2 | 17:03 |
| amoralej__ | i was thinking in the case where we have an AT with param1=X and in the Audit we set param2=Y (where Param2 is rename of param1). The upgrade_parameter should rename param1 to param2, if we do that in the AT and then merge, it'd be fine | 17:03 |
| amoralej__ | so yeah | 17:04 |
| amoralej__ | but we'd need to apply the upgrade in the default_parameters before merge with audit parameters | 17:04 |
| amoralej__ | so, it's doable | 17:04 |
| sean-k-mooney | ack i think this is imprant but likely soemting we can resolve wehn we need too | 17:04 |
| amoralej__ | but i doubt we need to do it now | 17:04 |
| amoralej__ | ok +1 | 17:05 |
| amoralej__ | btw, i replied some of your questions in https://review.opendev.org/c/openstack/watcher-specs/+/1012696 | 17:05 |
| amoralej__ | the main two ones are https://review.opendev.org/c/openstack/watcher-specs/+/1012696/comment/7dde3736_732b27b0/ and https://review.opendev.org/c/openstack/watcher-specs/+/1012696/comment/490c9157_8b122b36/ | 17:05 |
| opendevreview | Joan Gilabert proposed openstack/watcher master: Accept resource-optimization API service type https://review.opendev.org/c/openstack/watcher/+/1016524 | 17:07 |
| dviroel | amoralej__: hey, i was at lunch, and reading back now... | 17:23 |
| amoralej__ | np | 17:24 |
| dviroel | I think that for AT we can just let if fail at Audit creation for now. AT is a stateless resource, and user will receive a failure when creating a new Audit from an outdated AT | 17:24 |
| amoralej__ | yeah, i think we are good with that | 17:24 |
| amoralej__ | jgilaber, given that you +2 that in previous PS and last update was just a couple of agreed changes,I'm merging https://review.opendev.org/c/openstack/watcher-specs/+/1014252 | 17:35 |
| opendevreview | Victoria Martinez de la Cruz proposed openstack/grian-ui master: Add instance health dashboard https://review.opendev.org/c/openstack/grian-ui/+/1016531 | 17:37 |
| jgilaber | amoralej__, yes that's fine, I looked at it briefly and it's ok | 17:43 |
| opendevreview | Merged openstack/watcher-specs master: Add Preemptible Instances spec for 2027.1 cycle https://review.opendev.org/c/openstack/watcher-specs/+/1014252 | 17:58 |
| opendevreview | Merged openstack/watcher master: Remove compute max_microversion set in ci https://review.opendev.org/c/openstack/watcher/+/1011300 | 18:55 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!