| opendevreview | Winicius Allan Bezerra da Silva proposed openstack/watcher-specs master: [WIP] Add spec for Preemptible Instances feature https://review.opendev.org/c/openstack/watcher-specs/+/987171 | 14:15 |
|---|---|---|
| winiciusallan[m] | morning watcher o/ I've just pushed the initial part of the proposed change ^ | 14:16 |
| dviroel | winiciusallan[m]: thanks, i will take a look afterwards | 14:18 |
| winiciusallan[m] | dviroel: thanks! | 14:22 |
| sean-k-mooney | dviroel: i finally got around to fully finishing my spec review the bones of your spec are good but there are a number of areas i think that need more detail but lets chat about that when you have more time | 18:35 |
| dviroel | sean-k-mooney: thanks sean, i saw that you reviewed, I will take a look in your comments | 18:35 |
| sean-k-mooney | sorry in advance | 18:36 |
| sean-k-mooney | i notice you had no dicssion of the rpc notificoan or obejct changes in your spec | 18:36 |
| sean-k-mooney | among a few other things | 18:36 |
| sean-k-mooney | i also wanted to dicuss if we shoudl adny more api using PATCH or if we shoudl take the time to start moving to PUT for update | 18:37 |
| sean-k-mooney | we can defer tha tbut im not a huge fan of new apis using PATCH | 18:37 |
| sean-k-mooney | anyway we can chat later once you have tiem to diges and see what you think we shoudl incorpeat and what we shoudl not | 18:38 |
| dviroel | ack, some details might be missing yeah, thanks for that. Let me review all coments and we can sync tomorrow | 18:46 |
Generated by irclog2html.py 4.1.0 by Marius Gedminas - find it at https://mg.pov.lt/irclog2html/!