| openstackgerrit | Jeffrey Zhang proposed a change to openstack/python-zaqarclient: CLI support for queue existence and metadata operations https://review.openstack.org/120797 | 00:04 |
|---|---|---|
| *** jeffrey4l__ has joined #openstack-zaqar | 00:04 | |
| *** jeffrey4l_ has quit IRC | 00:08 | |
| openstackgerrit | Jeffrey Zhang proposed a change to openstack/python-zaqarclient: CLI support for queue existence and metadata operations https://review.openstack.org/120797 | 00:10 |
| *** alcabrera is now known as alcabrera|afk | 00:56 | |
| *** jeffrey4l__ has quit IRC | 01:16 | |
| *** jeffrey4l has joined #openstack-zaqar | 01:19 | |
| *** cpallares has joined #openstack-zaqar | 01:19 | |
| *** kgriffs|afk has quit IRC | 01:36 | |
| *** malini has quit IRC | 01:36 | |
| *** sriram1 has quit IRC | 01:47 | |
| *** alcabrera|afk is now known as alcabrera | 01:55 | |
| *** sgotliv has quit IRC | 02:12 | |
| *** vkmc has quit IRC | 02:37 | |
| *** flwang1 has quit IRC | 03:00 | |
| openstackgerrit | Jeffrey Zhang proposed a change to openstack/python-zaqarclient: CLI support for message CRUD operations https://review.openstack.org/120966 | 03:03 |
| openstackgerrit | A change was merged to openstack/zaqar: Fix the help string https://review.openstack.org/118269 | 03:09 |
| *** echevemaster has joined #openstack-zaqar | 03:15 | |
| *** prashanthr_ has joined #openstack-zaqar | 03:24 | |
| *** echevemaster has quit IRC | 03:29 | |
| *** jimhoagland has joined #openstack-zaqar | 03:43 | |
| jeffrey4l | Is any body can explain the ttl and age for the messages? In my understanding, when the age >= ttl + 60 , the message will be removed from the queue. But in my test( use sqlalchemy as backend driver), the message is still exist. | 03:45 |
| jeffrey4l | When get the list of the message, I get following line. Is it reasonable? | 03:45 |
| jeffrey4l | +----------+------+-------+ | 03:46 |
| jeffrey4l | | _id | ttl | age | | 03:46 |
| jeffrey4l | +----------+------+-------+ | 03:46 |
| jeffrey4l | | 5c693a52 | 300 | 11901 | | 03:46 |
| *** flwang has quit IRC | 03:47 | |
| wpf | jeffrey4l: age is the now -created | 03:50 |
| wpf | and when ttl<=age , then the messages are expired | 03:50 |
| wpf | for sqlalchemy, only when you post some new messages , the expired messages will be removed from the database , but anyway, as long as it expired ,then you will not be able to get it | 03:51 |
| jeffrey4l | So 1) if I use mongo as backend driver, the message will be remove automatically, right? | 03:52 |
| wpf | yes | 03:52 |
| *** echevemaster has joined #openstack-zaqar | 03:53 | |
| jeffrey4l | 2) In my case ( use sqlalchemy as driver), after create some new message, I still can get the expired message like above table. Is it a bug or ? | 03:54 |
| wpf | prashanthr_: ping | 03:54 |
| wpf | jeffrey4l: really, I thought my patch had been merged, let me check it again | 03:55 |
| wpf | jeffrey4l: https://review.openstack.org/#/c/110543/4/zaqar/queues/storage/sqlalchemy/messages.py , it had been merged, | 03:55 |
| wpf | are you using the latest master branch ? | 03:56 |
| jeffrey4l | wpf, Yes. I checked my local repo just now. It is contains you patch. | 03:57 |
| *** flwang has joined #openstack-zaqar | 03:57 | |
| jeffrey4l | I will debug it and try to explain why. | 03:58 |
| wpf | jeffrey4l: oops, I have a test case to verify it , | 03:59 |
| wpf | jeffrey4l: Thanks | 03:59 |
| * wpf out for lunch | 04:02 | |
| *** alcabrera is now known as alcabrera|afk | 04:13 | |
| *** prashanthr_1 has joined #openstack-zaqar | 04:21 | |
| *** prashanthr_ has quit IRC | 04:21 | |
| *** jeffrey4l has quit IRC | 04:26 | |
| *** prashanthr_1 has left #openstack-zaqar | 04:28 | |
| *** jimhoagland has quit IRC | 04:37 | |
| *** jeffrey4l has joined #openstack-zaqar | 04:44 | |
| *** jimhoagland has joined #openstack-zaqar | 05:12 | |
| *** reed has quit IRC | 05:18 | |
| *** jimhoagland has quit IRC | 05:30 | |
| *** echevemaster has quit IRC | 06:02 | |
| *** sgotliv has joined #openstack-zaqar | 06:05 | |
| *** flaper87|afk is now known as flaper87 | 06:18 | |
| openstackgerrit | Peng Fei Wang proposed a change to openstack/zaqar: Not permitted to delete pools which are used by flavor https://review.openstack.org/117706 | 06:25 |
| flaper87 | o/ | 06:25 |
| flaper87 | wpf: jeffrey4l are you guys testing zaqar on myqsl/postgresql ? | 06:30 |
| jeffrey4l | flaper87, Actually, I test the zaqar with sqlite. | 06:32 |
| flaper87 | jeffrey4l: oh ok | 06:32 |
| jeffrey4l | ;p | 06:32 |
| jeffrey4l | I just meet a bug exist on sqlite. But it is not exist on mysql. I notice that the sqlalchemy driver will be remove in the future. Should we speed time to fix the bug? | 06:33 |
| jeffrey4l | flaper87, I just meet a bug exist on sqlite. But it is not exist on mysql. I notice that the sqlalchemy driver will be remove in the future. Should we speed time to fix the bug? | 06:35 |
| flaper87 | jeffrey4l: re removing the sqla driver, that's yet to be discussed in the next TC meeting | 06:40 |
| flaper87 | some new things have come up and it might end with us not removing it | 06:40 |
| jeffrey4l | Got it. | 06:40 |
| flaper87 | As of now, the idea is to remove it | 06:40 |
| flaper87 | so, whatever we find, we should fix it | 06:40 |
| flaper87 | :D | 06:40 |
| jeffrey4l | I will try. | 06:40 |
| *** prashanthr_1 has joined #openstack-zaqar | 06:47 | |
| *** amitgandhinz has joined #openstack-zaqar | 06:57 | |
| wpf | prashanthr_1: ping | 06:59 |
| prashanthr_1 | wpf: Hello good morning :) | 06:59 |
| * prashanthr_1 wonders if he has wished right :) | 06:59 | |
| wpf | it's afternoon :P | 07:00 |
| jeffrey4l | ah. no for here. it's afternoon, too. | 07:00 |
| wpf | prashanthr_1: would you please check/own this one since it's related with your Redis PS | 07:00 |
| wpf | https://bugs.launchpad.net/zaqar/+bug/1363811 | 07:00 |
| prashanthr_1 | wpf: Aah okay :) Bonjour is better actually :P | 07:01 |
| prashanthr_1 | Sure will check it | 07:01 |
| prashanthr_1 | now | 07:01 |
| jeffrey4l | wpf, I think I found the root cause. There is a bug(or wire thing) exist in sqlite. | 07:01 |
| prashanthr_1 | wpf: can you give me 30 mins. I will look into this and get back to you ? | 07:02 |
| wpf | jeffrey4l: awesome! | 07:02 |
| wpf | prashanthr_1: sure | 07:02 |
| wpf | jeffrey4l: what's the problem | 07:02 |
| jeffrey4l | try this in sqlite: select DATETIME('now') - DATETIME('now', "+1 month"); | 07:02 |
| jeffrey4l | select DATETIME('now', "+1 month") - DATETIME('now'); | 07:03 |
| jeffrey4l | this one. It suppose to return 30*3600 , but it return 0; | 07:03 |
| jeffrey4l | this one. It is expected to return 30*3600 , but it return 0; | 07:03 |
| wpf | jeffrey4l: do we use such clause in the code ? what I saw is only 'now - created' | 07:05 |
| jeffrey4l | and_stmt = sa.and_(tables.Messages.c.ttl <= | 07:06 |
| jeffrey4l | sfunc.now() - tables.Messages.c.created, | 07:06 |
| jeffrey4l | tables.Messages.c.qid == qid) | 07:06 |
| jeffrey4l | Your code doesn't work as expected. | 07:06 |
| jeffrey4l | No. it is my test code. | 07:06 |
| wpf | jeffrey4l: I am curious that why my test case passed , :P | 07:09 |
| jeffrey4l | the first message (ttl=0) is the bug. | 07:10 |
| jeffrey4l | 0 <= sfunc.now() - tables.Messages.c.created = 0 | 07:11 |
| wpf | ^_^ | 07:11 |
| jeffrey4l | got it? | 07:11 |
| wpf | yes | 07:11 |
| wpf | what's the stupid bug of sqllite, | 07:12 |
| jeffrey4l | Yep | 07:12 |
| jeffrey4l | wpf, are u going to fix this? | 07:13 |
| *** prashanthr_ has joined #openstack-zaqar | 07:13 | |
| wpf | jeffrey4l: you can move forward to fix it if you can | 07:14 |
| jeffrey4l | OK. I will. | 07:14 |
| wpf | thanks | 07:14 |
| *** prashanthr_1 has quit IRC | 07:15 | |
| *** sgotliv has quit IRC | 07:44 | |
| *** sgotliv has joined #openstack-zaqar | 07:49 | |
| *** jeffrey4l is now known as jeffrey4l|afk | 07:54 | |
| *** jeffrey4l|afk is now known as jeffrey4l | 07:55 | |
| prashanthr_ | wpf: Can you explain to me a little bit about succeeded_ids ? | 08:00 |
| wpf | prashanthr_: sorry, I can't , seems that only partial of the actions finished due to some conflicts, | 08:02 |
| wpf | I only try to fix the 'succeeded_ids' itself, | 08:02 |
| * flaper87 wonders if there's anything he can help with | 08:04 | |
| *** prashanthr_1 has joined #openstack-zaqar | 08:06 | |
| *** prashanthr_ has quit IRC | 08:08 | |
| *** prashanthr_1 has quit IRC | 08:11 | |
| *** prashanthr_ has joined #openstack-zaqar | 08:13 | |
| *** prashanthr_ has quit IRC | 08:17 | |
| *** prashanthr_ has joined #openstack-zaqar | 08:21 | |
| prashanthr_ | wpf: Sorry for the late response :( Sure I will find out more :) | 08:26 |
| wpf | maybe flaper87 can explain more , :P | 08:31 |
| *** amitgandhinz has quit IRC | 08:44 | |
| *** amitgandhinz has joined #openstack-zaqar | 08:44 | |
| *** sgotliv has quit IRC | 08:45 | |
| *** amitgandhinz has quit IRC | 08:49 | |
| *** prashanthr_1 has joined #openstack-zaqar | 08:51 | |
| *** prashanthr_ has quit IRC | 08:53 | |
| flaper87 | wpf: what are we talking about? :P | 08:53 |
| openstackgerrit | Prashanth Raghu proposed a change to openstack/zaqar: Redis driver does not failover to slave when master fails https://review.openstack.org/121045 | 10:05 |
| prashanthr_1 | Finally a patch after 3 weeks :) | 10:05 |
| *** amitgandhinz has joined #openstack-zaqar | 10:07 | |
| *** AAzza_afk is now known as AAzza | 10:19 | |
| *** amitgandhinz has quit IRC | 10:27 | |
| *** amitgandhinz has joined #openstack-zaqar | 10:28 | |
| *** amitgandhinz has quit IRC | 10:32 | |
| flaper87 | prashanthr_1: w000000000000000000t | 11:01 |
| prashanthr_1 | flaper87: Ha ha :) | 11:01 |
| AAzza | flaper87: Hello) | 11:05 |
| flaper87 | AAzza: helloooooooooooo | 11:07 |
| openstackgerrit | A change was merged to openstack/zaqar: Remove extraneous created_iso property https://review.openstack.org/120256 | 11:21 |
| * AAzza forgot that wrote to irc (shy) | 11:22 | |
| AAzza | flaper87: so lets finish that api-v1.1-response changes | 11:23 |
| flaper87 | AAzza: sure thing | 11:23 |
| flaper87 | what's missing? | 11:23 |
| flaper87 | as far as I can see, there's just 1 item missing | 11:23 |
| flaper87 | and it's the "extraneous path thing" | 11:23 |
| flaper87 | IIRC | 11:23 |
| AAzza | flaper87: yes, that one is defenitely left | 11:23 |
| flaper87 | kurt mentioned that one was no really important | 11:24 |
| flaper87 | I don't even remember what was that about | 11:24 |
| AAzza | yes, he mentioned that we can left it. it is about to form relative urls even more relative :) | 11:24 |
| AAzza | actually, I saw you set about claim_id field in the message is done. it is not that true - it is not about adding it to the url, but about adding it to the message doc itself. | 11:27 |
| flaper87 | AAzza: is the `updating docs` the only thing missing for claim_id ? | 11:28 |
| AAzza | flaper87: yes, i suppose. in the example in the wiki it looks strange actually - https://wiki.openstack.org/wiki/Zaqar/specs/api/v1.1#List_Messages the second message in the response contan claim field with id and client_id fields... not sure what was the reasoning there | 11:32 |
| AAzza | flaper87: as for me, maybe it is better to left the state as it is, since we are are not in after-freeze mode. If it is not that important, better not to break the code. Add the claim_id to the doc is not that difficult, but other this clint_id... | 11:35 |
| flaper87 | you're recommending to leave it as Done, did I understand correctly? | 11:36 |
| flaper87 | I was hoping to mark that blueprint as implemented today | 11:36 |
| flaper87 | As for the docs, lemme take a look | 11:36 |
| flaper87 | AAzza: that client_id is a custom field from the user | 11:37 |
| flaper87 | it's part of the message body | 11:37 |
| flaper87 | wait no | 11:37 |
| * flaper87 confused now | 11:37 | |
| flaper87 | forget what I said | 11:38 |
| flaper87 | are we still returning the client_id ? | 11:38 |
| AAzza | flaper87: hmm, I don't know. I know nothing about client_id, but storage doesn't return it (if we need, we should change the storage layer), it is not in the response now and I have no idea how it is related to claims. | 11:40 |
| flaper87 | AAzza: then it's an old thing | 11:40 |
| flaper87 | I remember we returned it before | 11:40 |
| flaper87 | while you are at it, if you can, could you make sure the response examples match what we return today? | 11:41 |
| flaper87 | it'd be amazing if you could do that | 11:41 |
| AAzza | flaper87: yes, sure, will do this. | 11:42 |
| AAzza | flaper87: so we decide stop implementing? no more commits? | 11:43 |
| flaper87 | no more commits, lets ignore the extraneous thing | 11:43 |
| flaper87 | and clear out what that is for | 11:43 |
| flaper87 | I'll mark the bp as implemented and ask kurt for feedback there | 11:43 |
| *** vkmc has joined #openstack-zaqar | 11:44 | |
| *** vkmc has quit IRC | 11:44 | |
| *** vkmc has joined #openstack-zaqar | 11:44 | |
| vkmc | good morning! | 11:45 |
| AAzza | flaper87: agreed then, will update the wiki today) | 11:45 |
| flaper87 | vkmc: goooooooooooooooooooooooooooooooood morning | 11:56 |
| vkmc | hiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiiii flaper87 o/ | 11:56 |
| *** cpallares has joined #openstack-zaqar | 12:04 | |
| *** alcabrera|afk is now known as alcabrera | 12:05 | |
| alcabrera | good morning. :) | 12:06 |
| cpallares | good morning alcabrera! | 12:07 |
| vkmc | hey alcabrera, cpallares o/ | 12:08 |
| alcabrera | heya cpallares, vkmc! how are you all doing? :D | 12:08 |
| cpallares | hey vkmc :D | 12:08 |
| cpallares | alcabrera: I'm sleepy | 12:08 |
| cpallares | alcabrera: Zzzzz | 12:08 |
| alcabrera | get some sleep, cpallares - or is it too late for that? :P | 12:09 |
| alcabrera | (early morning nap?) | 12:09 |
| vkmc | alcabrera, good, a bit tired as well but happy because the weekend is around the corner :) | 12:13 |
| vkmc | alcabrera, and you? | 12:13 |
| vkmc | nap++ | 12:13 |
| alcabrera | I'm slightly sleepy, mostly happy, vkmc! | 12:18 |
| vkmc | goooood to hear :) | 12:18 |
| cpallares | alcabrera: haha too late for that :P | 12:20 |
| * alcabrera offers cpallares coffee | 12:20 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 12:29 | |
| sebasmagri | There is some interesting stuff here TBC http://nsq.io/overview/features_and_guarantees.html :-) | 12:31 |
| flaper87 | you all wake up right now | 12:43 |
| flaper87 | >.> | 12:43 |
| alcabrera | flaper87: <3 | 12:44 |
| * alcabrera goes to take a nap | 12:44 | |
| flaper87 | sebasmagri: ah yeah, I've read about NSQ before. | 12:44 |
| flaper87 | alcabrera: <3 yo yo, how ya doing? | 12:44 |
| flaper87 | need some supoer energetic tea? | 12:44 |
| flaper87 | super* | 12:44 |
| flaper87 | re NSQ: "messages received are un-ordered" | 12:44 |
| alcabrera | I'll take some super energetic tea | 12:45 |
| flaper87 | when I read about NSQ it seemed to be it was very similar to kafka | 12:45 |
| flaper87 | in some areas | 12:45 |
| *** jimhoagland has joined #openstack-zaqar | 12:52 | |
| vkmc | it looks like Kafka yep | 12:58 |
| *** sriram1 has joined #openstack-zaqar | 12:59 | |
| alcabrera | go:nsq :: scala:kafka | 13:01 |
| *** cpallares has quit IRC | 13:18 | |
| *** jchai has joined #openstack-zaqar | 13:21 | |
| vkmc | flaper87, I remember having this conversation before... should we stick with json or simplejson? | 13:34 |
| flaper87 | vkmc: json | 13:34 |
| vkmc | flaper87, k | 13:35 |
| flaper87 | vkmc: json is basically simplejson :) | 13:35 |
| flaper87 | it's actually simplejson | 13:35 |
| vkmc | of course | 13:35 |
| flaper87 | I mean, literally | 13:35 |
| vkmc | some compatibility differences | 13:35 |
| flaper87 | python's json was created from simplejson | 13:35 |
| vkmc | cool | 13:36 |
| vkmc | thx | 13:36 |
| *** alcabrera is now known as alcabrera|afk | 13:41 | |
| AAzza | flaper87: I was fixing wiki, and remember, that there should be separate patch for adding 'id' to messages in claims. I will propose it asap (in an hour I think), based on the vkmc's patch. Will do the same - extract format_message_v1_1 and use it also for claims | 13:54 |
| flaper87 | AAzza: sounds good, thanks for catching that | 13:54 |
| vkmc | cool! thanks AAzza | 13:55 |
| flaper87 | can someone help me confirm whether we have a test for `get-message-by-id` ? | 13:57 |
| flaper87 | I.... can't find one. | 13:57 |
| flaper87 | transport test, btw | 13:58 |
| flaper87 | we do have for the storage | 13:58 |
| vkmc | flaper87, sure, I'm checking | 13:59 |
| prashanthr_1 | Good morning Team Zaqar :) | 14:00 |
| flaper87 | prashanthr_1: what's uuuuuuuuuuuuuuuuuuuuup ? | 14:00 |
| flaper87 | vkmc: thanks :) | 14:00 |
| prashanthr_1 | flaper87: the weekend is waiting for me :) | 14:00 |
| prashanthr_1 | ;) | 14:00 |
| flaper87 | prashanthr_1: I believe you're waiting for it :P | 14:01 |
| vkmc | flaper87, doesn't look like we have a test for get_by_id only, but the feature is used in several places | 14:01 |
| prashanthr_1 | flaper87: ROFL We have a contract with each other :) | 14:01 |
| vkmc | prashanthr_1, yoooo | 14:01 |
| flaper87 | vkmc: is it? | 14:01 |
| prashanthr_1 | vkmc: Hello :) | 14:01 |
| flaper87 | I just removed it from the API and nothing broke | 14:02 |
| flaper87 | am I missing something? | 14:02 |
| flaper87 | could you point me to the tests that are using it? | 14:02 |
| vkmc | yup | 14:02 |
| flaper87 | vkmc: note that I'm only talking about the transport | 14:02 |
| flaper87 | I couldn't even find a use in the message lifecycle | 14:03 |
| flaper87 | prashanthr_1: lol | 14:03 |
| vkmc | flaper87, https://github.com/openstack/zaqar/blob/master/zaqar/queues/transport/wsgi/v1_0/messages.py#L52 | 14:03 |
| flaper87 | vkmc: ah yeah, but that's a collection | 14:03 |
| flaper87 | mmh, actually, that'd go away too | 14:03 |
| vkmc | oh you are thinkin about get_by_id item wise | 14:04 |
| flaper87 | yes | 14:04 |
| flaper87 | vkmc: I hate it when you find things that give me more work | 14:04 |
| vkmc | let me keep looking then | 14:04 |
| flaper87 | you should know by now that I prefer to procrastinate | 14:04 |
| flaper87 | and yet, you keep finding things that make me work more | 14:04 |
| flaper87 | >.> | 14:04 |
| vkmc | flaper87, I don't want you to get bored :/ | 14:04 |
| vkmc | flaper87, https://github.com/openstack/zaqar/blob/master/zaqar/queues/transport/wsgi/v1_0/messages.py#L202 | 14:05 |
| vkmc | OH wait | 14:05 |
| flaper87 | LOL | 14:05 |
| flaper87 | you said it, not me | 14:05 |
| flaper87 | :D | 14:05 |
| vkmc | shh | 14:05 |
| vkmc | I'm passing you the wrong links | 14:05 |
| vkmc | well, bulk get is here https://github.com/openstack/zaqar/blob/master/zaqar/tests/queues/transport/wsgi/v1/test_messages.py#L131 | 14:06 |
| vkmc | and for items... | 14:06 |
| flaper87 | yeah, bulk get is definitely used | 14:07 |
| *** ametts has joined #openstack-zaqar | 14:07 | |
| vkmc | at first sight, this test seems to be using get_by_id https://github.com/openstack/zaqar/blob/master/zaqar/tests/queues/transport/wsgi/v1/test_messages.py#L449 | 14:09 |
| vkmc | I'll keep looking | 14:10 |
| prashanthr_1 | vkmc, flaper87: Is there any bug you would like me to help you with ? | 14:13 |
| flaper87 | vkmc: that's fine, you've done more than enough :) | 14:14 |
| flaper87 | thanks a lot | 14:14 |
| vkmc | flaper87, np, are you working on removing the get_by_id endpoint? (I guess so) | 14:17 |
| *** jimhoagland has quit IRC | 14:18 | |
| openstackgerrit | Nataliia Uvarova proposed a change to openstack/zaqar: V1.1: Add id property to messages in claims https://review.openstack.org/121133 | 14:26 |
| prashanthr_1 | flaper87: Can you explain me a little bit about https://bugs.launchpad.net/zaqar/+bug/1363811 | 14:29 |
| prashanthr_1 | ? | 14:29 |
| *** amitgandhinz has joined #openstack-zaqar | 14:29 | |
| flaper87 | prashanthr_1: mmh, seems like that attribute was removed from the exception | 14:31 |
| prashanthr_1 | Okay sure I will look into this | 14:32 |
| flaper87 | prashanthr_1: thanks | 14:32 |
| *** sgotliv has joined #openstack-zaqar | 14:35 | |
| *** AAzza is now known as AAzza_afk | 14:47 | |
| openstackgerrit | Flavio Percoco proposed a change to openstack/zaqar: Fork API v1.1 into v2 https://review.openstack.org/121140 | 14:53 |
| openstackgerrit | Flavio Percoco proposed a change to openstack/zaqar: Remove `get-message-by-id` https://review.openstack.org/121141 | 14:53 |
| *** reed_ has joined #openstack-zaqar | 14:54 | |
| *** kgriffs has joined #openstack-zaqar | 14:58 | |
| *** malini|afk has joined #openstack-zaqar | 14:59 | |
| *** malini|afk is now known as malini | 14:59 | |
| *** reed_ has quit IRC | 15:00 | |
| *** reed_ has joined #openstack-zaqar | 15:00 | |
| *** jeffrey4l_ has quit IRC | 15:01 | |
| *** jimhoagland has joined #openstack-zaqar | 15:02 | |
| *** AAzzal has joined #openstack-zaqar | 15:06 | |
| *** AAzzal is now known as AAzza | 15:07 | |
| flaper87 | kgriffs: morning :) | 15:07 |
| flaper87 | hope you're doing great | 15:07 |
| flaper87 | kgriffs: whenever you've time, could you take a look at the client patches? | 15:08 |
| *** AAzzal has joined #openstack-zaqar | 15:08 | |
| *** AAzza_afk has quit IRC | 15:09 | |
| kgriffs | I'll see what I can do today. I'm being pulled in several different directions at work right now. :p | 15:10 |
| *** AAzza has quit IRC | 15:11 | |
| *** AAzzal is now known as AAzza | 15:11 | |
| flaper87 | kgriffs: don't worry, it's not urgent. We can review them next week | 15:12 |
| flaper87 | I just want to make sure we get them in before the 18th | 15:12 |
| flaper87 | we still have 1 more week | 15:12 |
| kgriffs | kk | 15:12 |
| flaper87 | and it's friday | 15:12 |
| flaper87 | we should forbid people to do reviews on friday's | 15:12 |
| kgriffs | heh | 15:12 |
| flaper87 | it's like: "yeah yeah whatver +2, it's beer time" | 15:12 |
| kgriffs | true dat | 15:13 |
| *** mpanetta has joined #openstack-zaqar | 15:13 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 15:18 | |
| ametts | +2 for beer | 15:18 |
| *** mpanetta has quit IRC | 15:20 | |
| *** mpanetta has joined #openstack-zaqar | 15:20 | |
| *** reed_ is now known as reed | 15:21 | |
| *** reed has quit IRC | 15:21 | |
| *** reed has joined #openstack-zaqar | 15:21 | |
| *** mpanetta has quit IRC | 15:21 | |
| *** mpanetta has joined #openstack-zaqar | 15:22 | |
| *** mpanetta has quit IRC | 15:27 | |
| vkmc | kgriffs, flaper87 there are some changes on the v1.0 CLI too, it would be nice to have them for the 18th as well | 15:27 |
| *** mpanetta has joined #openstack-zaqar | 15:27 | |
| flaper87 | vkmc: will review them asap | 15:28 |
| vkmc | I already noticed some nits but an extra review would be awesome | 15:29 |
| vkmc | thx :) | 15:29 |
| vkmc | regarding those patches, what's the meaning of the _ in the tuples? what am I missing? | 15:32 |
| flaper87 | vkmc: i18n ? | 15:33 |
| flaper87 | that's actually a funtion called `_` | 15:33 |
| flaper87 | unless I'm misunderstanding your question | 15:33 |
| vkmc | flaper87, nope, it doesn't follow the syntax | 15:33 |
| vkmc | because it's within the string | 15:34 |
| flaper87 | mmh, what patches are we talking about ? :D | 15:34 |
| vkmc | _('i18n') | 15:34 |
| vkmc | '_noti18n' | 15:34 |
| vkmc | for instance, https://review.openstack.org/#/c/120797/3/zaqarclient/queues/v1/cli.py | 15:35 |
| flaper87 | vkmc: aaaaaaaaaaaaaaaaaaahhhhhhhhhhhhh yeah, that's a cliff thing | 15:35 |
| flaper87 | I don't remember exactly why I had to do that but I remember there was a reason | 15:36 |
| vkmc | oh, I'll google that | 15:36 |
| vkmc | thanks fla | 15:37 |
| *** jeffrey4l_ has quit IRC | 15:41 | |
| *** jeffrey4l_ has joined #openstack-zaqar | 15:42 | |
| flaper87 | vkmc: let me know if I can help, I should have given you a more precise answer | 15:44 |
| vkmc | flaper87, it's ok! I'm trying to determine if it's still needed, for the current code | 15:45 |
| vkmc | I coudln't find it in the Cliff docs yet | 15:46 |
| vkmc | couldn't* | 15:46 |
| *** jeffrey4l_ has quit IRC | 16:00 | |
| flaper87 | vkmc: I remember now | 16:03 |
| flaper87 | vkmc: it's because the name attribute in the queue is private | 16:03 |
| flaper87 | that is, it's `queue._name` | 16:03 |
| flaper87 | so, in order for https://github.com/openstack/python-openstackclient/blob/master/openstackclient/common/utils.py#L95 to find it, I had to put a `_` there | 16:04 |
| flaper87 | it's a hack, we shouldn't have `_Name` | 16:04 |
| vkmc | flaper87, makes sense | 16:07 |
| vkmc | so, does that still applies? | 16:07 |
| flaper87 | as in, should we keep it that way? | 16:08 |
| flaper87 | I'd say no | 16:08 |
| flaper87 | but we can fix them all together | 16:08 |
| flaper87 | I mean, I wouldn't block that patch on this thing | 16:08 |
| vkmc | k :) | 16:08 |
| vkmc | most of my comments on that patch are nits though | 16:09 |
| vkmc | it looks good | 16:09 |
| vkmc | off to lunch | 16:14 |
| * vkmc nom nom nom | 16:14 | |
| flaper87 | vkmc: enjoy | 16:17 |
| *** jchai is now known as jchai_afk | 16:20 | |
| *** jchai_afk is now known as jchai | 16:32 | |
| *** earnThis has joined #openstack-zaqar | 16:49 | |
| *** earnThis has quit IRC | 17:27 | |
| * vkmc lurks | 17:43 | |
| *** prashanthr_1 has quit IRC | 17:44 | |
| *** sgotliv has quit IRC | 17:57 | |
| *** cpallares has joined #openstack-zaqar | 18:18 | |
| *** cpallares has quit IRC | 18:18 | |
| *** earnThis has joined #openstack-zaqar | 19:05 | |
| *** mpanetta has quit IRC | 19:07 | |
| *** mpanetta has joined #openstack-zaqar | 19:08 | |
| *** echevemaster has joined #openstack-zaqar | 19:26 | |
| *** jchai is now known as jchai_afk | 19:36 | |
| *** jchai_afk is now known as jchai | 19:39 | |
| *** ametts has quit IRC | 19:51 | |
| *** AAzza is now known as AAzza_afk | 20:27 | |
| *** sriram1 has quit IRC | 20:39 | |
| *** fifieldt_ has joined #openstack-zaqar | 20:50 | |
| *** fifieldt has quit IRC | 20:54 | |
| *** sgotliv has joined #openstack-zaqar | 20:58 | |
| boris-42 | kgriffs ping | 21:03 |
| boris-42 | kgriffs what's up? | 21:03 |
| *** sgotliv has quit IRC | 21:08 | |
| *** jchai has quit IRC | 21:14 | |
| *** flaper87 is now known as flaper87|afk | 21:36 | |
| *** kgriffs is now known as kgriffs|afk | 21:38 | |
| *** echevemaster has quit IRC | 21:45 | |
| *** amitgandhinz has quit IRC | 22:08 | |
| *** mpanetta has quit IRC | 22:09 | |
| *** earnThis has quit IRC | 22:20 | |
| *** boris-42_ has joined #openstack-zaqar | 22:22 | |
| *** openstack has joined #openstack-zaqar | 23:37 | |
| *** sendak.freenode.net sets mode: -o flwang | 23:42 | |
| -sendak.freenode.net- *** Notice -- TS for #openstack-zaqar changed from 1410565038 to 1406891974 | 23:42 | |
| *** sendak.freenode.net sets mode: +ct-s | 23:42 | |
| *** ekarlso- has joined #openstack-zaqar | 23:42 | |
| *** openstackgerrit has joined #openstack-zaqar | 23:42 | |
| *** AAzza has joined #openstack-zaqar | 23:42 | |
| *** reed has joined #openstack-zaqar | 23:42 | |
| *** mpanetta has joined #openstack-zaqar | 23:42 | |
| *** vipul has joined #openstack-zaqar | 23:42 | |
| *** wpf has joined #openstack-zaqar | 23:42 | |
| *** boris-42 has joined #openstack-zaqar | 23:42 | |
| *** jeffrey4l has joined #openstack-zaqar | 23:42 | |
| *** malini has joined #openstack-zaqar | 23:42 | |
| *** kgriffs|afk has joined #openstack-zaqar | 23:42 | |
| *** flaper87|afk has joined #openstack-zaqar | 23:42 | |
| *** dmitryme has joined #openstack-zaqar | 23:42 | |
| *** alcabrera|afk has joined #openstack-zaqar | 23:42 | |
| *** sebasmagri has joined #openstack-zaqar | 23:42 | |
| *** notmyname has joined #openstack-zaqar | 23:42 | |
| *** dguerri has joined #openstack-zaqar | 23:42 | |
| *** lifeless has joined #openstack-zaqar | 23:42 | |
| *** sendak.freenode.net changes topic to "OpenStack Queuing and Notification Service || Smile :D || Meetings every Monday @ 21:00 UTC/15:00 UTC || Wiki: https://wiki.openstack.org/wiki/Zaqar || Paste: http://paste.openstack.org/ || Send messages and make some noise :D" | 23:42 | |
| *** AAzza_afk has joined #openstack-zaqar | 23:44 | |
| *** AAzza_afk has quit IRC | 23:44 | |
| ekarlso- | so is zaqar gonna switch to pecan ? | 23:47 |
| *** jimhoagland has joined #openstack-zaqar | 23:54 | |
| *** fifieldt has joined #openstack-zaqar | 23:54 | |
| *** tmu has joined #openstack-zaqar | 23:54 | |
| *** flaper87|afk has quit IRC | 23:56 | |
| *** flaper87|afk has joined #openstack-zaqar | 23:56 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!