| *** openstack has joined #openstack-zaqar | 08:56 | |
| *** tmu has joined #openstack-zaqar | 08:56 | |
| *** openstackstatus has joined #openstack-zaqar | 08:57 | |
| *** ChanServ sets mode: +v openstackstatus | 08:57 | |
| *** jeffrey4l has joined #openstack-zaqar | 09:09 | |
| *** openstack has joined #openstack-zaqar | 09:11 | |
| *** openstackstatus has joined #openstack-zaqar | 09:12 | |
| *** ChanServ sets mode: +v openstackstatus | 09:12 | |
| *** openstackgerrit has joined #openstack-zaqar | 09:15 | |
| openstackgerrit | Jeffrey Zhang proposed a change to openstack/zaqar: Capture the stdout and stderr based on environment https://review.openstack.org/124273 | 09:18 |
|---|---|---|
| *** openstackgerrit has quit IRC | 09:34 | |
| *** openstackgerrit has joined #openstack-zaqar | 09:35 | |
| *** exploreshaifali has joined #openstack-zaqar | 09:38 | |
| exploreshaifali | hello jeffrey4l, please can you help me in understanding bug https://bugs.launchpad.net/python-zaqarclient/+bug/1358889 | 09:49 |
| jeffrey4l | exploreshaifali, sure. | 09:50 |
| jeffrey4l | i noticed this bug before. | 09:50 |
| exploreshaifali | jeffrey4l, bug is talking about file https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/transport/response.py | 09:51 |
| jeffrey4l | the root cause is that the server return a not valid json object( may be a standard html file), but the client does not validate it and call `json.loads` directly | 09:52 |
| jeffrey4l | yep | 09:52 |
| exploreshaifali | jeffrey4l, I am a bit new to openstack, want to contribute and thought here I will be needed to handle an excelption | 09:54 |
| jeffrey4l | the right direction should be, checking the http status code and the Content Type in the header before using `json.loads` method. | 09:54 |
| jeffrey4l | I don't think so. | 09:54 |
| exploreshaifali | jeffrey4l, but in that file I am not getting where should I put try except block | 09:54 |
| jeffrey4l | just handle the exception is not a good solution. | 09:55 |
| jeffrey4l | the right direction should be, checking the http status code and the Content Type in the header before using `json.loads` method. | 09:55 |
| jeffrey4l | if the status code != 200 or content-type != application/json , then raise exception. | 09:56 |
| exploreshaifali | amm okay but ypu mentioned before using json.load, where it is used? | 09:57 |
| jeffrey4l | u means the `json.loads` method? OR? | 09:58 |
| exploreshaifali | yes `json.load` method | 09:58 |
| jeffrey4l | https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/transport/response.py#L46 | 09:59 |
| jeffrey4l | at line 46 | 10:00 |
| exploreshaifali | okay | 10:00 |
| exploreshaifali | so that method call should be in try block? | 10:01 |
| jeffrey4l | no. | 10:01 |
| exploreshaifali | jeffrey4l, is this is the wiki page for zaqar client https://wiki.openstack.org/wiki/Python_Client_Library_%28Marconi%29 | 10:03 |
| jeffrey4l | exploreshaifali, the right way should be like http://paste.openstack.org/show/129547/ | 10:03 |
| jeffrey4l | gtg, brb | 10:03 |
| exploreshaifali | jeffrey4l, ok Thanks :) | 10:04 |
| *** jeffrey4l has quit IRC | 10:08 | |
| *** jeffrey4l has joined #openstack-zaqar | 10:13 | |
| *** exploreshaifali has quit IRC | 10:15 | |
| *** exploreshaifali has joined #openstack-zaqar | 10:41 | |
| *** jeffrey4l has quit IRC | 11:04 | |
| *** exploreshaifali has quit IRC | 11:39 | |
| *** openstackgerrit has quit IRC | 11:47 | |
| *** boris-42_ has joined #openstack-zaqar | 12:01 | |
| *** boris-42_ has quit IRC | 12:08 | |
| *** exploreshaifali has joined #openstack-zaqar | 12:12 | |
| *** jeffrey4l has joined #openstack-zaqar | 12:14 | |
| *** boris-42_ has joined #openstack-zaqar | 12:56 | |
| *** boris-42_ has quit IRC | 13:30 | |
| *** boris-42_ has joined #openstack-zaqar | 13:56 | |
| *** sriram has joined #openstack-zaqar | 14:00 | |
| *** jchai has joined #openstack-zaqar | 14:08 | |
| *** mpanetta has joined #openstack-zaqar | 14:21 | |
| *** exploreshaifali has quit IRC | 14:25 | |
| *** mpanetta_ has joined #openstack-zaqar | 14:33 | |
| *** mpanetta has quit IRC | 14:33 | |
| *** mpanetta_ is now known as mpanetta | 14:52 | |
| *** boris-42_ has quit IRC | 14:53 | |
| *** malini|afk is now known as malini_znc | 15:02 | |
| *** malini_znc has left #openstack-zaqar | 15:03 | |
| *** malini_znc has joined #openstack-zaqar | 15:03 | |
| *** malini_znc is now known as malini|afk | 15:04 | |
| *** malini has joined #openstack-zaqar | 15:04 | |
| *** boris-42_ has joined #openstack-zaqar | 15:10 | |
| *** boris-42_ has quit IRC | 15:21 | |
| riveter | in queues/storage/base.py, is there a reason that Queue.{get,set}_metadata are not marked as abstract methods? | 15:47 |
| *** malini has quit IRC | 15:50 | |
| *** malini has joined #openstack-zaqar | 15:51 | |
| *** malini has quit IRC | 15:53 | |
| *** malini has joined #openstack-zaqar | 15:57 | |
| *** jchai has quit IRC | 16:29 | |
| *** jeffrey4l has quit IRC | 16:31 | |
| *** jeffrey4l has joined #openstack-zaqar | 16:34 | |
| *** exploreshaifali has joined #openstack-zaqar | 16:38 | |
| *** boris-42_ has joined #openstack-zaqar | 16:44 | |
| *** boris-42_ has quit IRC | 16:47 | |
| *** boris-42_ has joined #openstack-zaqar | 17:05 | |
| *** boris-42_ has quit IRC | 17:23 | |
| *** mpanetta_ has joined #openstack-zaqar | 18:41 | |
| *** mpanetta has quit IRC | 18:42 | |
| *** mpanetta_ has quit IRC | 18:45 | |
| *** mpanetta has joined #openstack-zaqar | 18:45 | |
| *** malini1 has joined #openstack-zaqar | 19:08 | |
| *** malini has quit IRC | 19:09 | |
| *** ametts has joined #openstack-zaqar | 19:20 | |
| riveter | kgriffs, flaper87: https://review.openstack.org/#/c/132907/ | 20:21 |
| *** malini1 has quit IRC | 21:02 | |
| exploreshaifali | jeffrey4l, I want to play with zaqarclient following wiki https://wiki.openstack.org/wiki/Python_Client_Library_%28Marconi%29#Workflow | 21:12 |
| exploreshaifali | I have installed zaqarclient with command `pip install --upgrade python-zaqarclient` | 21:13 |
| exploreshaifali | jeffrey4l, now when I try to import zaqarclient.connection in python command promt it gives *Import error* | 21:14 |
| exploreshaifali | no module named connection | 21:14 |
| exploreshaifali | please can you provide any guidence on how will I able to play wiht zaqrclient | 21:15 |
| *** exploreshaifali has quit IRC | 21:24 | |
| *** echevemaster has joined #openstack-zaqar | 22:13 | |
| *** echevemaster has quit IRC | 22:13 | |
| *** echevemaster has joined #openstack-zaqar | 22:13 | |
| *** sriram has quit IRC | 22:17 | |
| *** mpanetta has quit IRC | 22:37 | |
| *** yfujioka has joined #openstack-zaqar | 23:26 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!