openstackgerrit | Merged openstack/zaqar: Add instructions on generating sample config https://review.openstack.org/136072 | 00:02 |
---|---|---|
*** kgriffs|afk is now known as kgriffs | 00:03 | |
vkmc | o/ kgriffs | 00:04 |
*** X019 has quit IRC | 00:12 | |
*** kgriffs is now known as kgriffs|afk | 00:12 | |
*** jeffrey4l_ has joined #openstack-zaqar | 00:49 | |
*** flwang1 has quit IRC | 01:05 | |
*** vkmc has quit IRC | 01:17 | |
*** malini has quit IRC | 01:17 | |
*** kgriffs|afk is now known as kgriffs | 01:40 | |
*** jeffrey4l_ has quit IRC | 01:46 | |
*** vkmc has joined #openstack-zaqar | 01:55 | |
*** vkmc has joined #openstack-zaqar | 01:55 | |
*** jeffrey4l_ has joined #openstack-zaqar | 01:58 | |
*** X019 has joined #openstack-zaqar | 02:07 | |
*** kgriffs is now known as kgriffs|afk | 02:13 | |
*** vkmc has quit IRC | 03:17 | |
*** kgriffs|afk is now known as kgriffs | 04:09 | |
*** kgriffs is now known as kgriffs|afk | 04:19 | |
*** yfujioka has joined #openstack-zaqar | 05:27 | |
*** exploreshaifali has joined #openstack-zaqar | 05:28 | |
*** jeffrey4l_ has quit IRC | 06:17 | |
*** echevemaster has joined #openstack-zaqar | 06:24 | |
*** davideagnello has quit IRC | 06:31 | |
*** jeffrey4l_ has joined #openstack-zaqar | 06:39 | |
*** AAzza_afk has joined #openstack-zaqar | 07:07 | |
*** AAzza_afk is now known as AAzza | 07:07 | |
*** X019 has quit IRC | 07:33 | |
*** achanda has quit IRC | 07:38 | |
*** bradjones has quit IRC | 07:40 | |
*** bradjones has joined #openstack-zaqar | 07:41 | |
*** AAzza is now known as AAzza_afk | 07:43 | |
*** jeffrey4l_ has quit IRC | 08:03 | |
*** reed has joined #openstack-zaqar | 08:22 | |
*** reed_ has joined #openstack-zaqar | 08:37 | |
*** reed_ has quit IRC | 08:38 | |
*** achanda has joined #openstack-zaqar | 08:38 | |
*** achanda_ has joined #openstack-zaqar | 08:40 | |
*** achanda has quit IRC | 08:40 | |
*** achanda_ is now known as achanda | 08:41 | |
*** exploreshaifali has quit IRC | 08:45 | |
*** exploreshaifali has joined #openstack-zaqar | 08:54 | |
*** exploreshaifali has quit IRC | 09:22 | |
*** achanda has quit IRC | 09:33 | |
*** exploreshaifali has joined #openstack-zaqar | 10:47 | |
*** exploreshaifali has quit IRC | 10:57 | |
*** yfujioka has quit IRC | 11:05 | |
*** malini|afk is now known as malini_znc | 11:28 | |
*** malini has joined #openstack-zaqar | 11:28 | |
*** vkmc has joined #openstack-zaqar | 11:44 | |
vkmc | helloooo | 11:45 |
ekarlso- | vkmc: up early ? :) | 11:47 |
vkmc | ekarlso-, hehe not so early :) | 11:47 |
flaper87 | vkmc: hello hello | 11:52 |
vkmc | flaper87, hi fla, how are you? | 11:54 |
kragniz | is it just me, or is this Ian guy a time traveler? | 11:57 |
kragniz | https://review.openstack.org/#/c/135941/ | 11:57 |
flaper87 | vkmc: I'm doing great, you? | 11:57 |
kragniz | >.> | 11:57 |
kragniz | also, morning all | 11:57 |
*** X019 has joined #openstack-zaqar | 11:58 | |
flaper87 | kragniz: ahahhaaha | 11:58 |
vkmc | flaper87, good good! | 11:58 |
vkmc | kragniz, lol | 11:58 |
kragniz | I'm hoping nothing bad happens to me in around half an hour, when he posts that comment | 11:59 |
vkmc | naah | 12:00 |
flaper87 | If I stop writing things on the channel for more than 30 mins, please ping me. Something bad might have happened to me... This nova code is.... | 12:03 |
* kragniz hands flaper87 a dead mans switch | 12:04 | |
*** malini_znc has left #openstack-zaqar | 12:05 | |
vkmc | why are you coding in nova? haha | 12:06 |
flaper87 | vkmc: cleaning up the shit^Wmess they have w.r.t glanceclient | 12:07 |
flaper87 | FOR EXAMPLE: | 12:07 |
flaper87 | https://github.com/openstack/python-glanceclient/blob/master/glanceclient/common/http.py#L55-L61 | 12:07 |
flaper87 | That's the only place and the only thing done with the identity_headers | 12:07 |
flaper87 | now | 12:07 |
kragniz | haha | 12:07 |
flaper87 | check this out | 12:07 |
flaper87 | https://github.com/openstack/nova/blob/master/nova/image/glance.py#L109-L117 | 12:08 |
flaper87 | what are all those other keys for? | 12:08 |
flaper87 | I mean, seriously: "status: Confirmed" WTF ? | 12:08 |
vkmc | LOL | 12:08 |
flaper87 | I wonder if there's a bug in glanceclient | 12:09 |
kragniz | flaper87: if you need any monkey work^W^Whelp, let me know | 12:09 |
vkmc | its like a NASA mission or something like that | 12:09 |
flaper87 | there could be, after the python-requests refactor | 12:09 |
vkmc | launching the image... status: CONFIRMED | 12:09 |
kragniz | vkmc: haha | 12:09 |
flaper87 | kragniz: awesome, thanks. | 12:09 |
vkmc | well, maybe they are using it for some kind of control | 12:09 |
vkmc | I hope | 12:09 |
flaper87 | kragniz: a quick task if you don't mind me asking you to do this would be figuring out if the migration to python requests caused the above | 12:09 |
kragniz | flaper87: sure, I'll try to figure it out! | 12:10 |
flaper87 | kragniz: if it's always been like that, then I'd get rid of that identity_whatever_who_knows_why_it_exists | 12:11 |
flaper87 | seriously, I try hard not to rant but damn, this software makes that hard | 12:11 |
* kragniz uses git log -S | 12:12 | |
* kragniz finds it not very effective | 12:12 | |
kragniz | flaper87: that function was added jul 2013 | 12:13 |
kragniz | "xenapi: send identity headers from glance plugin" | 12:14 |
flaper87 | ok, it's dead to me | 12:18 |
flaper87 | kragniz: lets move this discussion to os-glance | 12:18 |
kragniz | rip | 12:18 |
kragniz | flaper87: good idea | 12:18 |
vkmc | something I was thinking yesterday about this spec https://review.openstack.org/#/c/126531/2/specs/kilo/storage-capabilities.rst | 12:49 |
vkmc | capabilities are not going to change, flavors are | 12:49 |
vkmc | I mean, if a storage backend supports a set of capabilities... then if you use them or not, is a choice | 12:50 |
vkmc | we better document this in the deployment guides | 12:52 |
vkmc | (ignore me my previous comments, that is what it has been discussed before) | 12:53 |
vkmc | flaper87, whenever you have a moment, could you please take a look to the specs for persistent transport and osprofiler? | 13:02 |
vkmc | so we can start working on those next week | 13:02 |
vkmc | https://review.openstack.org/135612 | 13:02 |
vkmc | https://review.openstack.org/134567 | 13:02 |
vkmc | bbl | 13:03 |
flaper87 | vkmc: sure thing, I'll review them now | 13:05 |
flaper87 | vkmc: not sure I understood what you said re capabilities but you said that I should ignore what you said, which I don't like to do :P | 13:06 |
flaper87 | so please, feel free to bring it up again | 13:06 |
vkmc | haha nono, I was chasing my tail with something we have already discussed :) | 13:08 |
*** X019 has quit IRC | 13:10 | |
*** cpallares has joined #openstack-zaqar | 13:26 | |
flaper87 | http://s.f87.me/1F8dBXH | 13:36 |
kragniz | flaper87: hahaha | 13:37 |
kragniz | US news stations are funny | 13:37 |
*** X019 has joined #openstack-zaqar | 13:40 | |
*** cpallares has quit IRC | 13:41 | |
*** cpallares has joined #openstack-zaqar | 13:43 | |
*** sriram has joined #openstack-zaqar | 14:01 | |
*** jchai has joined #openstack-zaqar | 14:05 | |
*** malini has quit IRC | 14:12 | |
cpallares | o/ | 14:14 |
*** dynarro has joined #openstack-zaqar | 14:14 | |
cpallares | \o | 14:14 |
*** dynarro_ has joined #openstack-zaqar | 14:15 | |
cpallares | \o/ | 14:15 |
kragniz | cpallares: I'm glad you found your arms in the end | 14:15 |
cpallares | kragniz: ¯\_(ツ)_/¯ | 14:17 |
kragniz | cpallares: I think you have some utf characters in there | 14:19 |
kragniz | I get a mystery man | 14:20 |
kragniz | ?\_(?)_/? | 14:20 |
*** AAzza_afk is now known as AAzza | 14:21 | |
*** mpanetta has joined #openstack-zaqar | 14:26 | |
cpallares | kragniz: I think you mean, mystery woman. | 14:27 |
kragniz | :( | 14:27 |
kragniz | sorry | 14:27 |
cpallares | kragniz: If it was a mystery man, it would have a bow tie as all masculine representations of things do. | 14:28 |
cpallares | kragniz: :P | 14:28 |
kragniz | no beard? | 14:29 |
cpallares | kragniz: I'm not sure if a beard is universally applicable. | 14:37 |
cpallares | Female goats have beards. | 14:37 |
cpallares | How can you tell the male and female goats apart? | 14:37 |
cpallares | You hope one has a bow tie otherwise it is impossible to know. | 14:37 |
kragniz | this is very true | 14:38 |
cpallares | I know because I took a biology class once. | 14:38 |
cpallares | I pretty much became an expert on all things biology. | 14:40 |
*** dynarro has quit IRC | 14:40 | |
*** dynarro_ has quit IRC | 14:40 | |
mpanetta | I thought time lords wore bowties? | 14:41 |
kragniz | cpallares: can you send me the DNA for bowties | 14:41 |
kragniz | I am in need of it | 14:41 |
cpallares | mpanetta: Are you a Dr. Who fan? :) | 14:44 |
cpallares | kragniz: The Human Genome Project is on it. Great science they're doing over there. Hope to see it done within our lifetimes. | 14:44 |
mpanetta | cpallares: Pretty much. Mostly the original series, since I'm old :P | 14:44 |
kragniz | cpallares: I look forward to it | 14:45 |
cpallares | mpanetta: I've never watched any of the old episodes. Are they any good? | 14:49 |
mpanetta | I like them. They are of course kind of campy and bad special effects, but what do you expect from something the BBC made in the 60's-80's ;) | 14:50 |
kragniz | cpallares: I hear they're good | 14:50 |
kragniz | if a little dated | 14:51 |
cpallares | mpanetta: Oohhh I love campy bad special effects. | 14:51 |
cpallares | I probably should torture my friends in the near future and have a marathon then | 14:51 |
mpanetta | cpallares: Yes! | 14:53 |
mpanetta | You should download all 200G of Doctor Who ;) | 14:53 |
cpallares | mpanetta: lol | 14:53 |
kragniz | ouch, that's a lot | 14:53 |
mpanetta | Well, it went for like 30 years | 14:54 |
cpallares | All 26 seasons | 14:54 |
cpallares | I'll bbl o/ | 14:55 |
kragniz | \o | 14:56 |
mpanetta | Ok :) | 14:56 |
* vkmc lurks | 14:57 | |
mpanetta | mornin vkmc :) | 14:59 |
kragniz | what is twitter trying to do when you type something like $variable? | 15:00 |
mpanetta | Donno, I don't have a twitter account. | 15:00 |
kragniz | vkmc: morning | 15:00 |
* kragniz doesn't know much about twitter | 15:01 | |
vkmc | hey mpanetta, kragniz :) | 15:02 |
kragniz | I haven't heard anything from flaper87 for over 30 minutes | 15:03 |
kragniz | I suspect nova's stolen him already | 15:03 |
*** malini has joined #openstack-zaqar | 15:03 | |
*** kgriffs|afk is now known as kgriffs | 15:03 | |
vkmc | kragniz, oh noes... we should call the cops | 15:04 |
*** exploreshaifali has joined #openstack-zaqar | 15:14 | |
*** a_ has joined #openstack-zaqar | 15:15 | |
*** a_ has quit IRC | 15:15 | |
*** kgriffs is now known as kgriffs|afk | 15:17 | |
*** amitgandhinz has joined #openstack-zaqar | 15:19 | |
exploreshaifali | flaper87, around? | 15:21 |
*** kgriffs|afk is now known as kgriffs | 15:28 | |
*** wpf has quit IRC | 15:41 | |
*** wpf has joined #openstack-zaqar | 15:50 | |
*** achanda has joined #openstack-zaqar | 15:56 | |
*** achanda has quit IRC | 16:02 | |
exploreshaifali | hey vkmc | 16:09 |
flaper87 | exploreshaifali: hey hey :) | 16:09 |
flaper87 | how are you doing? | 16:10 |
exploreshaifali | flaper87, understanding test cases | 16:10 |
exploreshaifali | flaper87, I need help in same | 16:10 |
exploreshaifali | flaper87, https://etherpad.openstack.org/p/exploreshaifali-opw-split-layers | 16:10 |
exploreshaifali | flaper87, we have created two db_groups and two option variables now | 16:11 |
exploreshaifali | so how will we put them in unit test cases | 16:12 |
exploreshaifali | in place of single db_group and option variable | 16:12 |
*** yograterol has joined #openstack-zaqar | 16:22 | |
flaper87 | exploreshaifali: lemme check | 16:22 |
exploreshaifali | ok :) | 16:23 |
flaper87 | exploreshaifali: ok, you'll mostly need the messges database | 16:23 |
flaper87 | the only moment you'll need the management db is when you're testing flavors/pools | 16:23 |
flaper87 | however, as a good practice to follow what a normal production deployment would do, I'd say we should always create an instance of both dbs | 16:24 |
flaper87 | exploreshaifali: using a hex for each database name is fin | 16:25 |
flaper87 | fine* | 16:25 |
flaper87 | Just for the record, The last season of White Collar is up and episodes are coming out each week | 16:26 |
flaper87 | too bad it's the last season | 16:26 |
flaper87 | :( | 16:26 |
kragniz | what's White Collar? | 16:26 |
exploreshaifali | flaper87, aam... okay, so as you said in last we should create an instance of both db--- means in SetupMixin we will create two instances; as we modified code | 16:27 |
exploreshaifali | and for rest only flavors/pools will need management db | 16:28 |
flaper87 | kragniz: http://en.wikipedia.org/wiki/White_Collar_%28TV_series%29 | 16:28 |
kragniz | aha | 16:28 |
flaper87 | exploreshaifali: right | 16:28 |
flaper87 | exploreshaifali: but both instances will always be available | 16:28 |
flaper87 | exploreshaifali: TBH, this is in preparation for a future work too | 16:28 |
flaper87 | exploreshaifali: we've been talking about making pools a requirement | 16:29 |
exploreshaifali | flaper87, okay! | 16:29 |
flaper87 | kragniz: I like that serie, it's quite nice and also fun | 16:29 |
exploreshaifali | flaper87, pools a requirement? | 16:29 |
flaper87 | exploreshaifali: as in, you will always need to create a pool | 16:29 |
flaper87 | exploreshaifali: instead of having a way to deploy zaqar without using pools | 16:30 |
flaper87 | exploreshaifali: does that make sense? | 16:30 |
exploreshaifali | flaper87, yes :) | 16:30 |
flaper87 | kragniz: Sometimes it's a bit un-realistic but hey, it's a tv serie after all | 16:30 |
exploreshaifali | flaper87, Thanks! | 16:30 |
kragniz | flaper87: it sounds good | 16:32 |
*** AAzza is now known as AAzza_afk | 16:35 | |
*** AAzza_afk is now known as AAzza | 16:51 | |
*** AAzza has left #openstack-zaqar | 16:55 | |
*** exploreshaifali has quit IRC | 17:07 | |
*** amitgandhinz has quit IRC | 17:11 | |
*** amitgandhinz has joined #openstack-zaqar | 17:12 | |
*** amitgandhinz has quit IRC | 17:16 | |
*** exploreshaifali has joined #openstack-zaqar | 17:21 | |
*** X019 has quit IRC | 17:45 | |
*** X019 has joined #openstack-zaqar | 17:45 | |
*** jchai is now known as jchai_afk | 17:59 | |
*** jchai_afk is now known as jchai | 17:59 | |
*** achanda has joined #openstack-zaqar | 18:18 | |
*** achanda has quit IRC | 18:19 | |
*** achanda has joined #openstack-zaqar | 18:19 | |
*** exploreshaifali has quit IRC | 18:23 | |
*** achanda_ has joined #openstack-zaqar | 18:26 | |
*** echevemaster has quit IRC | 18:27 | |
*** achanda has quit IRC | 18:30 | |
openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/134803 | 18:34 |
*** achanda_ is now known as achanda | 18:34 | |
*** reed has quit IRC | 18:36 | |
*** flwang has quit IRC | 18:46 | |
*** flwang has joined #openstack-zaqar | 18:50 | |
boris-42 | flaper87: https://review.openstack.org/#/c/135132/ woot | 19:01 |
boris-42 | vkmc: ^ | 19:01 |
vkmc | :D boris-42 | 19:03 |
boris-42 | vkmc: ) | 19:05 |
boris-42 | vkmc: woot job is already add to zaqar* | 19:06 |
boris-42 | vkmc: hm NOT_REGISTERED not so fast=) | 19:07 |
vkmc | yeaaaah thats super cool | 19:07 |
boris-42 | vkmc: btw in tempest jobs are you installing only zaqar? | 19:08 |
boris-42 | vkmc: keystone + zaqar? | 19:08 |
*** AAzza_afk has joined #openstack-zaqar | 19:09 | |
boris-42 | vkmc: probably we will need to update rally job to make it faster | 19:09 |
*** AAzza_afk is now known as AAzza | 19:09 | |
vkmc | boris-42, IIRC yes, lemme check that | 19:09 |
*** AAzza has left #openstack-zaqar | 19:09 | |
boris-42 | vkmc: cause rally jobs for zaqar will take about 15 minutes | 19:10 |
boris-42 | vkmc: which will be bottlneck =( | 19:10 |
boris-42 | vkmc: ah no this works for a quite long amount of time check-tempest-dsvm-mongodb-zaqar: =) | 19:11 |
vkmc | boris-42, yes | 19:14 |
vkmc | boris-42, all right then :) | 19:14 |
boris-42 | vkmc: ya | 19:15 |
boris-42 | =) | 19:15 |
vkmc | boris-42, thanks again for working on that | 19:15 |
*** amitgandhinz has joined #openstack-zaqar | 19:15 | |
*** amitgandhinz has quit IRC | 19:29 | |
*** cpallares has quit IRC | 19:53 | |
*** jchai is now known as jchai_afk | 20:12 | |
boris-42 | vkmc: around? | 20:23 |
vkmc | boris-42, here | 20:24 |
boris-42 | vkmc: I run 2k iterations | 20:25 |
boris-42 | vkmc: and some of iterations failed lol | 20:25 |
boris-42 | vkmc: results will be in moment | 20:26 |
vkmc | boris-42, boo | 20:26 |
vkmc | boris-42, lemme know where are the logs later so I can debug | 20:26 |
boris-42 | vkmc: sure tempest job is slower =) | 20:29 |
vkmc | boris-42, k :) | 20:29 |
boris-42 | vkmc: so go here https://review.openstack.org/#/c/135134/ | 20:30 |
boris-42 | vkmc: click on rally job | 20:30 |
boris-42 | vkmc: then click on HTML report | 20:31 |
vkmc | kewl | 20:31 |
boris-42 | vkmc: go to failures* | 20:31 |
boris-42 | vkmc: oh keystone died* | 20:31 |
vkmc | so... yeah | 20:31 |
vkmc | keystone | 20:31 |
vkmc | Error AuthorizationFailure: Authorization Failed: Unable to establish connection to http://127.0.0.1:5000/v2.0/tokens | 20:31 |
vkmc | damn you keystone | 20:31 |
boris-42 | vkmc: lol I am killing every day a lot of installations of keysotne | 20:32 |
boris-42 | vkmc: in Mirnatis we have scale lab lol | 20:32 |
boris-42 | =) | 20:32 |
vkmc | boris-42, hahaha keystone's worst nightmare | 20:32 |
boris-42 | vkmc: seems like I'll need to reduce load* | 20:32 |
vkmc | yeah... 1k? 1.5k? | 20:33 |
vkmc | go easy on them :P | 20:33 |
vkmc | its weird, it should fail with that load though | 20:34 |
boris-42 | vkmc: lol | 20:34 |
boris-42 | vkmc: ya keystone can't handle such load* | 20:34 |
boris-42 | vkmc: 2k authentications is too much | 20:34 |
vkmc | boris-42, thats ok | 20:35 |
*** achanda has quit IRC | 20:41 | |
openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar-specs: Add a persistent transport alternative https://review.openstack.org/134567 | 20:48 |
openstackgerrit | Victoria Martínez de la Cruz proposed openstack/zaqar-specs: Add a persistent transport alternative https://review.openstack.org/134567 | 20:52 |
openstackgerrit | Boris Pavlovic proposed openstack/zaqar: Add rally job related files https://review.openstack.org/135134 | 20:59 |
boris-42 | vkmc: ^ done | 20:59 |
boris-42 | vkmc: I am talking with keystone guys about fixing that issue | 20:59 |
vkmc | boris-42, great | 21:00 |
vkmc | thanks :) | 21:00 |
boris-42 | vkmc: so now ur turn =) | 21:00 |
boris-42 | vkmc: more benchmarks=) | 21:00 |
* vkmc hides | 21:00 | |
vkmc | haha | 21:01 |
vkmc | I think I'll add those now... I was going to refactor some tests in Zaqar but honestly I have to discuss this with someone else | 21:01 |
vkmc | so... let's Rally things up | 21:01 |
boris-42 | vkmc: ok =) | 21:02 |
vkmc | flaper87, you are probably not around... well, I hope so | 21:02 |
* boris-42 lol | 21:02 | |
*** jchai_afk is now known as jchai | 21:02 | |
vkmc | :D | 21:02 |
vkmc | he probably is drinking tequila somewhere | 21:03 |
vkmc | just like kragniz | 21:03 |
boris-42 | vkmc: =) | 21:05 |
vkmc | boris-42, you are in my tz... more or less... right? | 21:06 |
vkmc | its 6pm here | 21:06 |
boris-42 | vkmc: where are u now?) | 21:06 |
boris-42 | vkmc: it's midnight =) | 21:06 |
boris-42 | here | 21:06 |
vkmc | in the world's bottom, south in Argentina | 21:06 |
vkmc | with the penguins | 21:06 |
vkmc | lol | 21:07 |
vkmc | so you are not in the US | 21:07 |
*** davideagnello has joined #openstack-zaqar | 21:09 | |
*** malini has quit IRC | 21:13 | |
kragniz | vkmc: how could you tell! | 21:18 |
* kragniz looks around for vkmc's spy devices | 21:18 | |
*** amitgandhinz has joined #openstack-zaqar | 21:18 | |
vkmc | lol | 21:19 |
vkmc | +1 kragniz | 21:19 |
flaper87 | vkmc: of course I'm around | 21:20 |
vkmc | whaaaaaaaaaaaaaat? | 21:21 |
vkmc | dud go away, have fun | 21:21 |
flaper87 | https://www.youtube.com/watch?v=fowBDdLGBlU | 21:22 |
* flaper87 is having fun :P | 21:22 | |
flaper87 | and from that you can totally asume I stopped coding in nova | 21:24 |
vkmc | hahaha | 21:24 |
vkmc | well that looks interesting | 21:25 |
vkmc | ok I have some stuff to discuss about functional testing | 21:25 |
vkmc | but we can do it on Monday | 21:25 |
vkmc | :) | 21:25 |
flaper87 | vkmc: fuck no, we can do it today :D | 21:26 |
* flaper87 will start writing a new blog post in a bit | 21:26 | |
flaper87 | no idea about what | 21:26 |
vkmc | about writting blog posts | 21:26 |
kragniz | vkmc: +1 teach me your ways, flaper87 | 21:27 |
vkmc | oh, good idea, make it about tequila flaper87 | 21:27 |
vkmc | regarding functional tests -> https://bugs.launchpad.net/zaqar/+bug/1395191 | 21:28 |
flaper87 | vkmc: I think there was another bug tracking tests refactor, wasn't there? | 21:28 |
vkmc | flaper87, nope, it was a tiny refactor thing for another suite | 21:28 |
flaper87 | vkmc: ok | 21:28 |
vkmc | you asked for feedback on that yesterday I think | 21:29 |
flaper87 | vkmc: I did that same diff the other day | 21:29 |
flaper87 | to see if we could merge them somehow | 21:29 |
vkmc | here https://bugs.launchpad.net/zaqar/+bug/1342177 | 21:29 |
vkmc | unit | 21:29 |
flaper87 | the thing is that diff already contains some bits that are not compatible | 21:29 |
vkmc | for example...? | 21:29 |
flaper87 | I mean, the small changes in those tests are because of changes in the API | 21:29 |
vkmc | I see | 21:29 |
flaper87 | < self.assertEqual(result.status_code, 204) | 21:30 |
flaper87 | --- | 21:30 |
flaper87 | > self.assertEqual(result.status_code, 200) | 21:30 |
flaper87 | The return code changed | 21:30 |
flaper87 | or when we send the project-id always | 21:30 |
flaper87 | there was another one | 21:30 |
flaper87 | wait | 21:30 |
flaper87 | ah, the queue in v1.1 is lazy | 21:31 |
flaper87 | messages in v1.1 are always an array | 21:31 |
flaper87 | they are small changes but they're specific to the API | 21:31 |
flaper87 | the duplicated code is still way too much | 21:31 |
flaper87 | but I think there's no much we can do about it | 21:31 |
flaper87 | I may be wrong | 21:31 |
flaper87 | but I couldn't come up with a good idea to fix it | 21:32 |
vkmc | I'm lazy, don't judge me | 21:32 |
vkmc | https://www.diffchecker.com/h31wqlym | 21:32 |
flaper87 | I mean, the ideas were all related to doing dark python magic | 21:32 |
vkmc | coudln't we pass, somehow, the codes? | 21:32 |
flaper87 | vkmc: what file is that again? | 21:32 |
vkmc | test_messages | 21:33 |
flaper87 | Could you do the same with the queues? | 21:33 |
flaper87 | for the unit test | 21:33 |
vkmc | sure | 21:33 |
vkmc | there should be a way to factor those out | 21:34 |
vkmc | something that worries me | 21:34 |
vkmc | if that we would need to inherit from two classes | 21:34 |
vkmc | that.. I don't like | 21:34 |
flaper87 | yeah, I started "fixing" the problem with something like that | 21:34 |
vkmc | yup | 21:34 |
flaper87 | then I started trembling and stopped | 21:34 |
*** achanda has joined #openstack-zaqar | 21:35 | |
vkmc | you want the diff for this ones, right? | 21:35 |
vkmc | https://github.com/openstack/zaqar/tree/master/tests/unit/queues/transport/wsgi | 21:35 |
vkmc | https://www.diffchecker.com/pg7b0q4r | 21:36 |
vkmc | if so, there it its | 21:36 |
flaper87 | vkmc: mmh, nope... lemme find it | 21:40 |
flaper87 | 2 secs | 21:40 |
vkmc | that is kurt's bug report | 21:41 |
* kgriffs shrugs | 21:42 | |
vkmc | speaking of the devil | 21:42 |
vkmc | kuuuuuuuuuuuuuuuuuuuuuuuuuurt :D | 21:43 |
* kgriffs saws off horns | 21:43 | |
* kgriffs puts on hat | 21:43 | |
kgriffs | who, me? | 21:43 |
kgriffs | you must be talking about someone else | 21:43 |
vkmc | lool | 21:43 |
flaper87 | https://www.diffchecker.com/u37v6l58 | 21:43 |
flaper87 | There may be a way to deal with all that.I guess my point is that I'd rather keep that code duplicated instead of introducing magic to our test suite | 21:45 |
flaper87 | not sure how much sense that makes | 21:45 |
vkmc | I see | 21:45 |
vkmc | yeah | 21:45 |
vkmc | one thing is for sure... code will be smaller, but harder to understand | 21:45 |
flaper87 | vkmc: right, I'm not sure that's what we want for our test suite | 21:46 |
flaper87 | we need to be able to read it easily to make sure it's consistent | 21:46 |
-openstackstatus- NOTICE: gating is going offline while we deal with a broken block device, eta unknown | 21:46 | |
*** ChanServ changes topic to "gating is going offline while we deal with a broken block device, eta unknown" | 21:46 | |
vkmc | certainly is not something good | 21:46 |
vkmc | all right | 21:47 |
vkmc | :) | 21:47 |
flaper87 | lets think this through a bit more | 21:47 |
flaper87 | kgriffs: btw, do you think you'll be able to go through the specs one more time ? | 21:47 |
flaper87 | I'd like to approve some on monday | 21:48 |
flaper87 | to kick coding off | 21:48 |
vkmc | something that doesn't feel natural is having two different locations for tests | 21:48 |
flaper87 | vkmc: what locations are you referring to? | 21:48 |
vkmc | tests/ and zaqar/tests | 21:48 |
flaper87 | vkmc: that's explained here: http://blog.flaper87.com/post/test-concepts-and-python/ | 21:49 |
flaper87 | :) | 21:49 |
vkmc | I understand why it is like that | 21:49 |
flaper87 | The reason is that we don't want to ship our tests | 21:49 |
vkmc | I'm just wondering if there is a way to put everything together | 21:49 |
flaper87 | but we want to ship our test suite | 21:49 |
flaper87 | so that others can test their transports and storage drivers | 21:49 |
kgriffs | i get the separation of tests | 21:50 |
kgriffs | but it seems like it is a little off balance right now | 21:50 |
vkmc | oh ok, so it has an stronger reason :) | 21:50 |
kgriffs | like we push a bunch of logic into base classes that aren't really base | 21:50 |
kgriffs | i would have to go look | 21:51 |
flaper87 | kgriffs: right, we need to identify those and clean that up | 21:51 |
flaper87 | kgriffs: please do :P | 21:51 |
flaper87 | I'll do the same | 21:51 |
flaper87 | I mean, on mondau | 21:51 |
flaper87 | monday | 21:51 |
kgriffs | but I remember seeing code that should probably move to zaqar/tests | 21:51 |
flaper87 | :D | 21:51 |
kgriffs | re specs, if you have a sec let me just mention a few things now and I can try to look more on monday if I have time | 21:52 |
kgriffs | first, regarding notifications | 21:52 |
kgriffs | I think having templates defined could be an additive feature, and could go in its own spec. | 21:53 |
flaper87 | kgriffs: +1 | 21:53 |
boris-42 | flaper87: btw can you remove -2 from https://review.openstack.org/#/c/135134/ =) | 21:53 |
kgriffs | My concern is just that if we don't have it in mind now and socialize the idea, people might try to do less elegant solutions, but idk. Just something to keep in mind | 21:54 |
flaper87 | boris-42: done :) | 21:54 |
kgriffs | it also may not be the best solution to the issue, but I'd like us to keep noodling on it | 21:54 |
flaper87 | boris-42: thanks for working on that | 21:54 |
flaper87 | kgriffs: the only thing that worries me about doing that feature now is time and focus | 21:54 |
kgriffs | yes, right | 21:54 |
boris-42 | flaper87: ya that actually work something went wron with gates | 21:55 |
boris-42 | =) | 21:55 |
kgriffs | perhaps we have a wishlist wiki page or something? | 21:55 |
flaper87 | but other than that, I love the idea | 21:55 |
flaper87 | kgriffs: +2, although I think the spec would be a good thing too. | 21:55 |
flaper87 | I'm thinking we should have an kilo/{approved, rejected} dirs | 21:55 |
flaper87 | then we can move the spec to L if we can't make it | 21:55 |
kgriffs | oh, I see | 21:55 |
kgriffs | that would work | 21:56 |
flaper87 | lets add done to that list | 21:56 |
flaper87 | so we can move specs that have been implemented | 21:56 |
kgriffs | +1 | 21:56 |
flaper87 | or we just mark them as done | 21:56 |
* flaper87 shrugs | 21:56 | |
vkmc | brb | 21:57 |
flaper87 | vkmc: you stay right there | 21:57 |
kgriffs | gotta run for a minute | 21:57 |
flaper87 | vkmc: ok, now you can go | 21:57 |
flaper87 | kgriffs: thanks for your thoughts | 21:58 |
flaper87 | kgriffs: just so you know, we miss you here | 21:58 |
kgriffs | want to reopen the idea of using socketio | 21:58 |
flaper87 | :) | 21:58 |
kgriffs | yeah, I miss being around as much too | 21:58 |
*** kgriffs is now known as kgriffs|afk | 21:58 | |
*** sriram has quit IRC | 22:08 | |
*** AAzza_afk has joined #openstack-zaqar | 22:09 | |
*** AAzza_afk is now known as AAzza | 22:09 | |
*** jchai has quit IRC | 22:18 | |
*** kgriffs|afk is now known as kgriffs | 22:19 | |
*** AAzza is now known as AAzza_afk | 22:20 | |
*** X019 has quit IRC | 22:22 | |
*** amitgandhinz has quit IRC | 22:38 | |
kgriffs | so, probably too late in the day to discuss websocket/socketio | 22:40 |
kgriffs | we can circle back on it for monday | 22:41 |
*** achanda has quit IRC | 22:53 | |
*** kgriffs is now known as kgriffs|afk | 22:53 | |
*** achanda has joined #openstack-zaqar | 22:54 | |
*** vkmc has quit IRC | 23:01 | |
*** mpanetta has quit IRC | 23:24 | |
*** achanda has quit IRC | 23:48 | |
*** achanda has joined #openstack-zaqar | 23:53 | |
*** amalagon has joined #openstack-zaqar | 23:53 | |
*** yograterol has quit IRC | 23:54 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!