| *** amitgandhinz has joined #openstack-zaqar | 00:26 | |
| *** amitgandhinz has quit IRC | 00:31 | |
| *** boris-42 has quit IRC | 02:03 | |
| *** fifieldt has quit IRC | 05:02 | |
| *** reed has quit IRC | 05:02 | |
| *** fifieldt has joined #openstack-zaqar | 05:15 | |
| *** sgotliv has joined #openstack-zaqar | 05:25 | |
| *** exploreshaifali has joined #openstack-zaqar | 05:26 | |
| *** exploreshaifali has quit IRC | 05:52 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Imported Translations from Transifex https://review.openstack.org/143775 | 06:05 |
|---|---|---|
| *** sgotliv has quit IRC | 06:14 | |
| *** exploreshaifali has joined #openstack-zaqar | 06:30 | |
| *** achanda has joined #openstack-zaqar | 06:39 | |
| openstackgerrit | Zhi Yan Liu proposed openstack/zaqar: Integrate OSprofiler with Zaqar https://review.openstack.org/141356 | 06:50 |
| *** exploreshaifali has quit IRC | 06:57 | |
| *** achanda has quit IRC | 07:06 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:10 | |
| exploreshaifali | kragniz, if you are not much busy can you please help me in understanding the problem in my changed code | 07:18 |
| kragniz | exploreshaifali: I'd love to, but I'm going to bed now | 07:25 |
| kragniz | 7:25 am is a bit too late for me! | 07:25 |
| exploreshaifali | kragniz, yea sure Good Night | 07:26 |
| *** achanda has joined #openstack-zaqar | 07:44 | |
| *** sgotliv has joined #openstack-zaqar | 07:47 | |
| *** achanda has quit IRC | 08:01 | |
| *** exploreshaifali has quit IRC | 08:07 | |
| *** sgotliv has quit IRC | 08:24 | |
| *** achanda has joined #openstack-zaqar | 08:31 | |
| *** achanda has quit IRC | 08:36 | |
| *** achanda has joined #openstack-zaqar | 08:47 | |
| *** achanda has quit IRC | 09:13 | |
| *** pcaruana has joined #openstack-zaqar | 09:24 | |
| *** sgotliv has joined #openstack-zaqar | 09:44 | |
| *** boris-42 has joined #openstack-zaqar | 09:50 | |
| *** flwang has joined #openstack-zaqar | 09:56 | |
| flwang | flaper87: ping | 09:56 |
| *** bradjones has quit IRC | 10:12 | |
| *** bradjones has joined #openstack-zaqar | 10:14 | |
| *** exploreshaifali has joined #openstack-zaqar | 10:38 | |
| *** achanda has joined #openstack-zaqar | 10:53 | |
| *** achanda has quit IRC | 11:19 | |
| *** achanda has joined #openstack-zaqar | 11:33 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Implement mongodb driver for notifications https://review.openstack.org/139792 | 11:34 |
| *** vkmc has joined #openstack-zaqar | 11:35 | |
| *** sgotliv has quit IRC | 11:37 | |
| vkmc | morning! | 11:37 |
| exploreshaifali | vkmc, gooooooood morning :D | 11:46 |
| vkmc | exploreshaifali, hi there, I'm checking out your patch | 11:47 |
| exploreshaifali | vkmc, yes yes.... I am also trying to understand the problem there :) | 11:47 |
| exploreshaifali | here is the output of tox -e py27 http://dpaste.com/1A78RRV | 11:48 |
| vkmc | well, its a design problem | 11:51 |
| vkmc | abstract classes shouldn't be instantiated | 11:51 |
| vkmc | they are only intented to work as interfaces | 11:51 |
| exploreshaifali | but DataDriver is not an abstract class | 11:51 |
| vkmc | queue_create is abstract | 11:51 |
| vkmc | sorry, create_queue | 11:51 |
| exploreshaifali | queue_create is an abstract method in DataDriverBase and that is overrided in DataDriver | 11:52 |
| exploreshaifali | as like previously queue_controller() method was | 11:52 |
| exploreshaifali | am I wrong ? | 11:53 |
| vkmc | let me finish reviewing the code | 11:54 |
| exploreshaifali | ok :) | 11:55 |
| *** sgotliv has joined #openstack-zaqar | 11:59 | |
| vkmc | exploreshaifali, so, why you need the create_queue method? | 12:01 |
| exploreshaifali | vkmc, basically we want to access QueueController.create() method in order to facilitate create and delete queue | 12:02 |
| exploreshaifali | as here https://github.com/openstack/zaqar/blob/master/zaqar/storage/base.py#L154 | 12:02 |
| exploreshaifali | previously queue_controller method was doing it | 12:03 |
| exploreshaifali | but now since that mentod is in ControlDriver | 12:03 |
| exploreshaifali | we need a method to access that method of ControlDriver | 12:04 |
| vkmc | ok | 12:05 |
| vkmc | so, there should be another way to access it | 12:05 |
| vkmc | because I suspect that is what its causing you trouble | 12:05 |
| exploreshaifali | ok | 12:05 |
| exploreshaifali | another option is as you said | 12:06 |
| exploreshaifali | without crete_queue mentod | 12:06 |
| exploreshaifali | we can directly make an instance of ControlDriver and call its method there | 12:06 |
| exploreshaifali | right | 12:06 |
| exploreshaifali | but since its an abstract class we will surely need an abstract method which will do this stuff | 12:07 |
| exploreshaifali | vkmc, I am not getting why we are having error message "TypeError: Can't instantiate abstract class DataDriver with abstract methods create_queue" | 12:08 |
| exploreshaifali | though there is no abstract method in DataDriver | 12:08 |
| vkmc | so... you didn't remove the queue_controller from the datadriver class in pipeline.py https://github.com/openstack/zaqar/blob/master/zaqar/storage/pipeline.py#L109 | 12:14 |
| *** flwang has quit IRC | 12:16 | |
| vkmc | so when it tries to instantiate it... | 12:16 |
| exploreshaifali | vkmc, yes yes.... thanks a looot | 12:18 |
| exploreshaifali | that is the problem I think | 12:18 |
| exploreshaifali | now I need to add create_queue there instead | 12:18 |
| vkmc | sure | 12:19 |
| vkmc | I should use pdb to follow the flow | 12:19 |
| vkmc | so you are certain of what is happening there | 12:19 |
| exploreshaifali | vkmc, I tried to use pdb but it didn't worked for me | 12:20 |
| exploreshaifali | I have put three set_trace() at the places above where I made changes | 12:20 |
| vkmc | you have to follow this https://wiki.openstack.org/wiki/Testr#Debugging_.28pdb.29_Tests | 12:20 |
| vkmc | try it and let me know | 12:21 |
| exploreshaifali | vkmc, ok :) and there is no pipelining kind of thing for ControllDriver ? | 12:21 |
| exploreshaifali | why we need it for DataDriver ? | 12:22 |
| vkmc | flaper87 would be able to clarify more about this | 12:26 |
| vkmc | because I just assumed that what I understood was ok :P | 12:26 |
| vkmc | what I understood about the usage of the pipeline though, is that you need to maintain an ordering for the entities | 12:27 |
| vkmc | queues, messages and claims | 12:27 |
| vkmc | when the server receives many requests, you have to make sure the requests are processed in order and that you don't lose any of them | 12:28 |
| vkmc | something that is not needed for control features | 12:28 |
| vkmc | like pooling or flavors | 12:28 |
| vkmc | does that make sense? | 12:28 |
| *** pcaruana has quit IRC | 12:36 | |
| exploreshaifali | yes it makes sense :) | 12:42 |
| exploreshaifali | reading that debugging wiki | 12:42 |
| *** achanda has quit IRC | 12:45 | |
| *** pcaruana has joined #openstack-zaqar | 12:47 | |
| *** openstack has joined #openstack-zaqar | 13:07 | |
| *** achanda has joined #openstack-zaqar | 13:09 | |
| *** exploreshaifali has quit IRC | 13:30 | |
| zhiyan | vkmc: hey! i saw currently zaqarclient-dsvm-functional job always down, it blocks my client side patch for zaqar profiling change, when you ok would you like take a look https://review.openstack.org/#/c/144416/ ? it's a straightforward way, to enable pooling in devstack. pls let me know if i miss anything, thanks. | 13:33 |
| vkmc | zhiyan, hi there! sure, I'll take a look | 13:33 |
| zhiyan | vkmc: btw, all things a read there for zaqar profiling, i listed them in commit msg at https://review.openstack.org/#/c/141356/ , have a try please when you ok :) | 13:35 |
| zhiyan | i tried it locally, everything is fine. | 13:35 |
| vkmc | zhiyan, that's great! thanks for that, I'll try it this afternoon | 13:39 |
| zhiyan | vkmc: THANKS! | 13:39 |
| *** achanda has quit IRC | 13:46 | |
| *** achanda has joined #openstack-zaqar | 13:47 | |
| *** fifieldt has quit IRC | 13:48 | |
| *** achanda has quit IRC | 13:52 | |
| *** fifieldt has joined #openstack-zaqar | 14:01 | |
| *** dynarro has joined #openstack-zaqar | 14:06 | |
| *** mpanetta has joined #openstack-zaqar | 14:27 | |
| *** mpanetta has quit IRC | 14:29 | |
| *** mpanetta has joined #openstack-zaqar | 14:31 | |
| *** exploreshaifali has joined #openstack-zaqar | 14:53 | |
| *** dynarro has quit IRC | 15:07 | |
| *** dynarro has joined #openstack-zaqar | 15:07 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:09 | |
| *** dynarro has quit IRC | 15:12 | |
| *** achanda has joined #openstack-zaqar | 15:14 | |
| *** cpallares has joined #openstack-zaqar | 15:33 | |
| *** sgotliv has quit IRC | 16:04 | |
| *** amitgandhinz has quit IRC | 17:16 | |
| *** achanda_ has joined #openstack-zaqar | 17:21 | |
| *** achanda_ has quit IRC | 17:22 | |
| *** achanda_ has joined #openstack-zaqar | 17:22 | |
| *** achanda has quit IRC | 17:24 | |
| *** flwang1 has quit IRC | 17:26 | |
| *** achanda_ has quit IRC | 17:32 | |
| *** achanda has joined #openstack-zaqar | 17:33 | |
| *** achanda_ has joined #openstack-zaqar | 17:35 | |
| *** achanda has quit IRC | 17:36 | |
| *** flwang has joined #openstack-zaqar | 17:39 | |
| *** achanda_ has quit IRC | 17:41 | |
| *** achanda has joined #openstack-zaqar | 17:42 | |
| *** achanda has quit IRC | 17:46 | |
| *** reed has joined #openstack-zaqar | 17:50 | |
| *** exploreshaifali has quit IRC | 18:07 | |
| *** dynarro has joined #openstack-zaqar | 18:08 | |
| *** amitgandhinz has joined #openstack-zaqar | 18:18 | |
| *** achanda has joined #openstack-zaqar | 18:35 | |
| *** pcaruana has quit IRC | 19:00 | |
| * vkmc lurks | 19:07 | |
| vkmc | (o/ | 19:07 |
| *** yfujioka has joined #openstack-zaqar | 19:20 | |
| *** flwang1 has joined #openstack-zaqar | 19:36 | |
| * kragniz twerks | 19:41 | |
| kragniz | I've made the worst thing ever | 19:42 |
| kragniz | https://github.com/kragniz/json-sempai | 19:42 |
| * vkmc clicks | 19:42 | |
| vkmc | that is magical | 19:43 |
| *** exploreshaifali has joined #openstack-zaqar | 20:17 | |
| *** exploreshaifali has quit IRC | 20:20 | |
| *** exploreshaifali has joined #openstack-zaqar | 20:20 | |
| cpallares | kragniz: nice disclaimer | 20:22 |
| kragniz | cpallares: it needed to be said | 20:22 |
| cpallares | kragniz: did you code this while drinking tequila? | 20:23 |
| kragniz | cpallares: black raspberry liqueur, actually | 20:25 |
| *** flwang1 has quit IRC | 20:25 | |
| *** dynarro has quit IRC | 20:31 | |
| *** dynarro has joined #openstack-zaqar | 20:34 | |
| cpallares | lol | 20:38 |
| *** exploreshaifali has quit IRC | 20:52 | |
| *** dynarro has quit IRC | 20:53 | |
| *** sgotliv has joined #openstack-zaqar | 21:07 | |
| *** achanda has quit IRC | 21:13 | |
| *** cpallares has quit IRC | 21:27 | |
| *** flwang1 has joined #openstack-zaqar | 21:31 | |
| *** vkmc has quit IRC | 21:56 | |
| *** mpanetta has quit IRC | 22:03 | |
| *** flwang2 has joined #openstack-zaqar | 22:26 | |
| *** flwang1 has quit IRC | 22:26 | |
| *** sgotliv has quit IRC | 22:39 | |
| *** amitgandhinz has quit IRC | 23:19 | |
| *** flwang2 has quit IRC | 23:21 | |
| *** flwang1 has joined #openstack-zaqar | 23:21 | |
| *** flwang1 has quit IRC | 23:47 | |
| *** bradjones_ has joined #openstack-zaqar | 23:50 | |
| *** bradjones has quit IRC | 23:51 | |
| *** bradjones_ is now known as bradjones | 23:51 | |
| *** bradjones has joined #openstack-zaqar | 23:51 | |
| *** flwang1 has joined #openstack-zaqar | 23:59 | |
| *** bradjones has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!