*** achanda has quit IRC | 00:03 | |
*** JAHoagie has quit IRC | 00:11 | |
*** kgriffs is now known as kgriffs|afk | 01:18 | |
*** amalagon has joined #openstack-zaqar | 02:02 | |
*** achanda has joined #openstack-zaqar | 02:37 | |
*** achanda has quit IRC | 02:53 | |
*** achanda has joined #openstack-zaqar | 02:56 | |
*** chandankumar has joined #openstack-zaqar | 03:15 | |
*** achanda has quit IRC | 03:24 | |
*** chandankumar has quit IRC | 03:25 | |
*** chandankumar has joined #openstack-zaqar | 03:25 | |
*** achanda has joined #openstack-zaqar | 03:32 | |
*** achanda has quit IRC | 03:41 | |
*** achanda has joined #openstack-zaqar | 03:43 | |
*** achanda has quit IRC | 03:53 | |
*** achanda has joined #openstack-zaqar | 03:59 | |
*** chandankumar has quit IRC | 04:52 | |
*** chandankumar has joined #openstack-zaqar | 04:54 | |
*** JAHoagie has joined #openstack-zaqar | 04:58 | |
*** chandankumar has quit IRC | 05:04 | |
*** reed has quit IRC | 05:26 | |
*** boris-42 has quit IRC | 05:28 | |
*** chandankumar has joined #openstack-zaqar | 05:38 | |
*** JAHoagie has quit IRC | 06:03 | |
*** achanda has quit IRC | 06:15 | |
*** pcaruana has quit IRC | 06:41 | |
*** fesp has quit IRC | 06:54 | |
*** akanksha has joined #openstack-zaqar | 07:07 | |
*** fesp has joined #openstack-zaqar | 07:24 | |
*** fesp has quit IRC | 07:35 | |
akanksha | vkmc, ping? | 08:58 |
---|---|---|
*** flwang1 has joined #openstack-zaqar | 09:14 | |
flwang1 | vkmc: ping | 09:14 |
flaper87 | flwang1: ping | 09:19 |
flwang1 | flaper87: yes sir | 09:19 |
flaper87 | flwang1: how are you doing ? | 09:19 |
flwang1 | flaper87: busy to die | 09:19 |
flaper87 | flwang1: that's good and bad :D | 09:20 |
flaper87 | flwang1: have you been able to work on the notification thing for redis ? | 09:20 |
flwang1 | my parents in law have back to China | 09:20 |
flwang1 | flaper87: i'm stilling working on that, will upload a new patch set today or tomorrow | 09:20 |
flwang1 | https://review.openstack.org/164893 | 09:21 |
flwang1 | btw, TBH, i'm not familiar with redis, so it's little bit frustrating to work on that | 09:21 |
flaper87 | flwang1: do you want me to help? | 09:21 |
akanksha | Hello everyone. I want to work on some easy bugs that can help me get familiarised with zaqar in general. I am an applicant for Outreachy. Can someone suggest some tasks that I can manage? | 09:22 |
flwang1 | flaper87: it would be lovely, if you can start review it, though it's ugly now | 09:23 |
flwang1 | i have implemented the 'create' method, and will implement the 'list' and 'get' soon | 09:23 |
flwang1 | btw, should I send an official FFE in mail list? | 09:24 |
flwang1 | akanksha: welcome to zaqar? | 09:24 |
akanksha | flwang: Thanks. :) I have been around for a while and I submitted fixes for two low hanging fruit bugs. I have been in contact with vkmc. She reviewed my proposal and all. She doesnt seem to be around for a while. | 09:26 |
flaper87 | flwang1: I'll do that right away so you'll have material to work on | 09:26 |
flaper87 | akanksha: welcome :D | 09:26 |
akanksha | So in the meanwhile I was hoping to work a bit more. | 09:26 |
flwang1 | flaper87: it would be awesome | 09:27 |
flwang1 | flaper87: as for the webhook driver, do you think we need to improve the performance for now? | 09:27 |
flwang1 | or you think it's "OK"? | 09:27 |
flwang1 | flaper87: i just wanna confirm if there is any other big change except the redis driver? | 09:28 |
flwang1 | I think we need to complete all the work before 19 Apr, right? | 09:28 |
flaper87 | flwang1: The more we can do the better. However, I think performance issues are electable for backports so, whenever we find one, we can simply backport it | 09:28 |
flaper87 | flwang1: yes, we should've cut K-3 last week but I was traveling | 09:29 |
flaper87 | I've to talk with ttx | 09:29 |
flwang1 | flaper87: so should I send out a FFE request? | 09:29 |
flaper87 | flwang1: let me cut K-3 first and I'll let you know | 09:30 |
flwang1 | flaper87: ok, cool | 09:30 |
flaper87 | akanksha: ping | 09:31 |
flaper87 | akanksha: you worked on this patch, right? https://review.openstack.org/#/c/165632/ | 09:31 |
akanksha | flaper87: Yeah | 09:32 |
flaper87 | akanksha: ok, first and foremost, thanks! | 09:39 |
flaper87 | now, I wanted to ask you if you could re-write that decorator in a way it does not have to introspect function arguments | 09:39 |
flaper87 | while that works, it adds some magic in the code that I'd honestly rather not have | 09:39 |
flaper87 | The reasons are that if we ever change the position or name of one of those arguments, this code will break | 09:39 |
flaper87 | It'd be probably better to just have an utility function that is call at the beginning of every functions | 09:40 |
flaper87 | Also, there are other places outside the redis driver that need this kind of `uuid` checks, would you mind extending your patch for those cases too? | 09:40 |
*** achanda has joined #openstack-zaqar | 09:51 | |
akanksha | flaper87, my decorator can be extended to any sort of function. What it essentially does is that it first makes a dictionary of all the function parameter names and the values passed to it in a particular call. This way all we need to do is update the name of the parameter in the list of parameters that i made which is of type uuid and it will check it. | 09:56 |
akanksha | Therefore the position or name does not matter according to me. | 09:56 |
*** achanda has quit IRC | 09:56 | |
akanksha | I'll try and find some other way to do it nonetheless. | 09:56 |
openstackgerrit | Merged openstack/zaqar: Fix common misspellings https://review.openstack.org/166848 | 09:57 |
flaper87 | akanksha: it matters because you need to keep that list of parameters updated which means you're mixing arguments introspection with hard-coded names | 09:58 |
akanksha | flaper87: Hmmm. Yeah that is dirty way of doing it perhaps. I had a discussion with kgriffs prior to implementing the decorator and he'd asked me to model it around pyvalid accept decorator http://pydoc.net/Python/pyvalid/0.0.2/setup/ | 09:59 |
akanksha | flaper87: I'll try and come up with a solution to the hardcoding. | 09:59 |
akanksha | perhaps something that will identify that the argument given in the call is meant to be a uuid. | 10:00 |
akanksha | Umm. I think we can do that utility function thing. | 10:01 |
flaper87 | akanksha: what about just having a `validate_uuid` function that we call in the method's body for the arguments that need to be validated? | 10:01 |
akanksha | Yeah. That would be easy to do. | 10:01 |
akanksha | Let me implement that. | 10:01 |
openstackgerrit | Merged openstack/zaqar: Update json schema for API v1_1 https://review.openstack.org/148414 | 10:32 |
*** chandankumar_ has joined #openstack-zaqar | 10:44 | |
*** chandankumar has quit IRC | 10:46 | |
*** exploreshaifali has joined #openstack-zaqar | 11:20 | |
*** exploreshaifali has quit IRC | 11:23 | |
*** flwang1 has quit IRC | 11:49 | |
*** boris-42 has joined #openstack-zaqar | 12:07 | |
*** chandankumar_ has quit IRC | 12:18 | |
*** exploreshaifali has joined #openstack-zaqar | 12:51 | |
*** chandankumar has joined #openstack-zaqar | 12:57 | |
vkmc | hi guys! | 13:29 |
*** chandankumar has quit IRC | 13:35 | |
*** dynarro has joined #openstack-zaqar | 13:39 | |
*** chandankumar has joined #openstack-zaqar | 13:41 | |
*** sriram1 has joined #openstack-zaqar | 13:41 | |
openstackgerrit | Merged openstack/zaqar: Updated from global requirements https://review.openstack.org/166482 | 13:48 |
*** amitgandhinz has joined #openstack-zaqar | 13:48 | |
flaper87 | vkmc: HELLOOOOOOOOOOOOOOOOOOOOOOO! | 13:49 |
*** mpanetta has joined #openstack-zaqar | 13:49 | |
vkmc | flaper87, HIIIIIIIIII | 13:49 |
flaper87 | vkmc: shhhhh, there's people sleeping here | 13:49 |
flaper87 | vkmc: my oneplus one got home | 13:49 |
flaper87 | w000t | 13:49 |
* flaper87 happy | 13:49 | |
flaper87 | fucking phone is bigger than the nexus but oh well | 13:50 |
vkmc | lol | 13:50 |
vkmc | wow, I didn't know you were getting a phone | 13:50 |
vkmc | the one plus is the sexiest thing ever in the smartphone land | 13:50 |
*** achanda has joined #openstack-zaqar | 13:55 | |
flaper87 | vkmc: I wasn't until someone sent me an invite. I just couldn't resist | 13:56 |
*** cpallares has joined #openstack-zaqar | 14:00 | |
*** achanda has quit IRC | 14:00 | |
*** chandankumar has quit IRC | 14:09 | |
*** kgriffs|afk is now known as kgriffs | 14:30 | |
*** achanda has joined #openstack-zaqar | 14:32 | |
*** mpanetta_ has joined #openstack-zaqar | 14:34 | |
*** mpanetta has quit IRC | 14:34 | |
*** akanksha has quit IRC | 14:37 | |
*** reed has joined #openstack-zaqar | 14:41 | |
*** achanda has quit IRC | 14:42 | |
*** achanda has joined #openstack-zaqar | 15:06 | |
*** achanda has quit IRC | 15:06 | |
*** mpanetta has joined #openstack-zaqar | 15:12 | |
*** mpanetta_ has quit IRC | 15:12 | |
*** cpallares has quit IRC | 15:23 | |
*** cpallares has joined #openstack-zaqar | 15:24 | |
*** exploreshaifali has quit IRC | 15:30 | |
*** chandankumar has joined #openstack-zaqar | 15:36 | |
*** bradjones has quit IRC | 15:51 | |
*** bradjones has joined #openstack-zaqar | 15:51 | |
*** bradjones has quit IRC | 15:51 | |
*** bradjones has joined #openstack-zaqar | 15:51 | |
*** wpf has quit IRC | 16:21 | |
*** dynarro has quit IRC | 16:39 | |
*** wpf has joined #openstack-zaqar | 16:42 | |
*** exploreshaifali has joined #openstack-zaqar | 16:54 | |
*** chandankumar has quit IRC | 16:58 | |
*** chandankumar has joined #openstack-zaqar | 17:10 | |
*** chandankumar has quit IRC | 17:27 | |
*** achanda has joined #openstack-zaqar | 17:28 | |
*** exploreshaifali has quit IRC | 17:53 | |
*** exploreshaifali has joined #openstack-zaqar | 18:09 | |
*** reed has quit IRC | 18:24 | |
*** achanda has quit IRC | 18:28 | |
*** reed has joined #openstack-zaqar | 18:34 | |
*** achanda has joined #openstack-zaqar | 18:57 | |
*** achanda has quit IRC | 19:00 | |
*** achanda has joined #openstack-zaqar | 19:00 | |
*** achanda has quit IRC | 19:42 | |
*** exploreshaifali has quit IRC | 19:44 | |
*** akanksha has joined #openstack-zaqar | 20:12 | |
*** achanda has joined #openstack-zaqar | 20:35 | |
*** reed has quit IRC | 20:42 | |
*** openstackgerrit has quit IRC | 21:07 | |
*** openstackgerrit has joined #openstack-zaqar | 21:07 | |
*** amitgandhinz has quit IRC | 21:14 | |
*** reed has joined #openstack-zaqar | 21:20 | |
*** sriram1 has quit IRC | 21:34 | |
openstackgerrit | Merged openstack/zaqar: Use generate_uuid() from oslo.utils https://review.openstack.org/165466 | 21:52 |
*** mpanetta has quit IRC | 21:59 | |
*** achanda_ has joined #openstack-zaqar | 22:04 | |
*** achanda has quit IRC | 22:08 | |
*** AAzza_afk has joined #openstack-zaqar | 22:23 | |
*** AAzzal has joined #openstack-zaqar | 22:24 | |
*** AAzza has quit IRC | 22:25 | |
*** AAzzal is now known as AAzza | 22:25 | |
*** AAzza_afk has quit IRC | 22:28 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!