*** achanda_ has joined #openstack-zaqar | 00:05 | |
*** kgriffs|afk is now known as kgriffs | 00:05 | |
*** achanda has quit IRC | 00:07 | |
*** achanda_ has quit IRC | 00:09 | |
*** kgriffs is now known as kgriffs|afk | 00:15 | |
*** kgriffs|afk is now known as kgriffs | 00:24 | |
*** kgriffs is now known as kgriffs|afk | 00:34 | |
*** davideagnello has quit IRC | 00:34 | |
*** davideagnello has joined #openstack-zaqar | 00:34 | |
*** davideagnello has quit IRC | 00:38 | |
*** davideagnello has joined #openstack-zaqar | 00:38 | |
*** davideagnello has quit IRC | 00:41 | |
*** davideag_ has joined #openstack-zaqar | 00:41 | |
*** kgriffs|afk is now known as kgriffs | 00:42 | |
jasondotstar | EmilienM: no worries. | 00:50 |
---|---|---|
*** kgriffs is now known as kgriffs|afk | 01:10 | |
*** mpanetta has quit IRC | 01:13 | |
*** kgriffs|afk is now known as kgriffs | 01:18 | |
*** kgriffs is now known as kgriffs|afk | 01:28 | |
*** kgriffs|afk is now known as kgriffs | 01:37 | |
*** davideag_ has quit IRC | 01:41 | |
*** kgriffs is now known as kgriffs|afk | 01:47 | |
*** kgriffs|afk is now known as kgriffs | 01:55 | |
*** kgriffs is now known as kgriffs|afk | 02:05 | |
*** kgriffs|afk is now known as kgriffs | 02:22 | |
*** achanda has joined #openstack-zaqar | 02:23 | |
*** kgriffs is now known as kgriffs|afk | 02:32 | |
*** kgriffs|afk is now known as kgriffs | 02:41 | |
*** kgriffs is now known as kgriffs|afk | 04:31 | |
*** kgriffs|afk is now known as kgriffs | 04:40 | |
*** diga has joined #openstack-zaqar | 04:49 | |
*** kgriffs is now known as kgriffs|afk | 04:49 | |
*** kgriffs|afk is now known as kgriffs | 05:07 | |
*** kgriffs is now known as kgriffs|afk | 05:17 | |
*** kgriffs|afk is now known as kgriffs | 05:26 | |
*** achanda has quit IRC | 05:43 | |
*** achanda has joined #openstack-zaqar | 05:47 | |
*** openstackgerrit_ has joined #openstack-zaqar | 06:42 | |
*** dguerri` is now known as dguerri | 07:13 | |
*** jyuso1 has joined #openstack-zaqar | 07:14 | |
*** dguerri is now known as dguerri` | 07:16 | |
*** jyuso1 has quit IRC | 07:17 | |
*** dguerri` is now known as dguerri | 07:24 | |
*** dguerri is now known as dguerri` | 07:32 | |
*** dguerri` is now known as dguerri | 07:32 | |
*** achanda has quit IRC | 07:33 | |
*** kgriffs is now known as kgriffs|afk | 07:33 | |
*** kgriffs|afk is now known as kgriffs | 07:34 | |
*** exploreshaifali has joined #openstack-zaqar | 07:36 | |
*** dguerri is now known as dguerri` | 07:39 | |
*** kgriffs is now known as kgriffs|afk | 07:43 | |
*** bradjones has quit IRC | 07:53 | |
*** bradjones has joined #openstack-zaqar | 07:56 | |
*** bradjones has joined #openstack-zaqar | 07:56 | |
*** kgriffs|afk is now known as kgriffs | 08:01 | |
*** kgriffs is now known as kgriffs|afk | 08:10 | |
*** diga has quit IRC | 08:27 | |
*** diga has joined #openstack-zaqar | 08:27 | |
*** kgriffs|afk is now known as kgriffs | 08:28 | |
*** exploreshaifali has quit IRC | 08:29 | |
*** kgriffs is now known as kgriffs|afk | 08:38 | |
*** kgriffs|afk is now known as kgriffs | 08:47 | |
*** kgriffs is now known as kgriffs|afk | 08:57 | |
*** kgriffs|afk is now known as kgriffs | 09:05 | |
*** kgriffs is now known as kgriffs|afk | 09:15 | |
*** jyuso1 has joined #openstack-zaqar | 09:23 | |
*** kgriffs|afk is now known as kgriffs | 09:33 | |
*** kgriffs is now known as kgriffs|afk | 09:42 | |
*** kgriffs|afk is now known as kgriffs | 09:51 | |
*** exploreshaifali has joined #openstack-zaqar | 10:12 | |
*** jyuso1 has quit IRC | 10:13 | |
*** dynarro has joined #openstack-zaqar | 10:17 | |
*** diga has quit IRC | 10:25 | |
*** kgriffs is now known as kgriffs|afk | 10:26 | |
*** kgriffs|afk is now known as kgriffs | 10:28 | |
*** kgriffs is now known as kgriffs|afk | 10:38 | |
*** exploreshaifali has quit IRC | 10:43 | |
*** kgriffs|afk is now known as kgriffs | 10:46 | |
*** AAzza_ has joined #openstack-zaqar | 11:00 | |
*** AAzza- has joined #openstack-zaqar | 11:01 | |
*** AAzza has quit IRC | 11:02 | |
*** AAzza has joined #openstack-zaqar | 11:05 | |
*** AAzza_ has quit IRC | 11:05 | |
*** AAzza- has quit IRC | 11:06 | |
*** exploreshaifali has joined #openstack-zaqar | 11:13 | |
*** kgriffs is now known as kgriffs|afk | 11:14 | |
*** kgriffs|afk is now known as kgriffs | 11:22 | |
*** diga has joined #openstack-zaqar | 11:23 | |
flaper87 | therve: vkmc I'm here when you are | 11:30 |
therve | flaper87, Yay! | 11:31 |
therve | flaper87, So if you have some time to quick look at https://review.openstack.org/206080 that would help | 11:31 |
*** diga has quit IRC | 11:32 | |
*** kgriffs is now known as kgriffs|afk | 11:32 | |
therve | I think I followed the spirit of what we talked about, but there is definitely some trickiness involved | 11:32 |
flaper87 | therve: ok, let me look at that first | 11:33 |
vkmc | flaper87, therve, hi! | 11:34 |
therve | Hey vkmc | 11:35 |
therve | One of the problem I encountered is solved by https://review.openstack.org/207501 | 11:36 |
therve | Currently using taskflow in the pipeline blocks message storage, which I thought was a bad idea | 11:36 |
flaper87 | mmh, do you think removing taskflow entirely is a good idea? One reason we added it was to have a way to offload tasks to workers | 11:41 |
flaper87 | if we remove it, we won't be able to do that | 11:41 |
flaper87 | the reason it's probably blocking is because it's using the serial executor | 11:42 |
flaper87 | rather than eventlet/multiprocessing/etc | 11:42 |
therve | I don't think so | 11:43 |
therve | When you run the engine then it's blocking the thread it's running in | 11:43 |
flaper87 | mmh, good point. | 11:44 |
flaper87 | ok, I guess we can leave taskflow for later | 11:45 |
* flaper87 is trying to wrap his head around the patch | 11:48 | |
*** kgriffs|afk is now known as kgriffs | 11:50 | |
vkmc | I don't follow exactly why the storage is blocked when using taskflow | 11:50 |
flaper87 | vkmc: it's more like the whole thread is blocked because taskflow initializes the engine, executes the tasks and then exits | 11:51 |
vkmc | I mean, you load and run the engine from the notification driver | 11:51 |
flaper87 | Rather than putting the task in a separate greenthread and moving on | 11:51 |
therve | vkmc, AFAIU, the notifier is executed in a stage during storage | 11:51 |
flaper87 | therve: so, in that notifications patch, does it notify "connected" endpoints when messages are pushed to Zaqar? | 11:52 |
vkmc | flaper87, thx | 11:53 |
* flaper87 can't find this in the code | 11:53 | |
vkmc | therve, yeah, its a stage in the pipe, I see | 11:53 |
therve | flaper87, It does. It uses the same webhook executor as before | 11:53 |
flaper87 | vkmc: I think taskflow is what we'll eventually want but we can think it through a bit better in Mitaka (if you agree) | 11:53 |
vkmc | flaper87, sure thing yes | 11:54 |
vkmc | I need to understand it more first heh | 11:54 |
flaper87 | therve: ok, but the notification must be sent from the Zaqar node that the client is connected to, right? | 11:54 |
flaper87 | Or does the zaqar node initialize a new ws connection to the client ? | 11:55 |
therve | flaper87, The former | 11:55 |
flaper87 | ok | 11:55 |
flaper87 | (just trying to clarify what I got from the patch) | 11:55 |
therve | flaper87, That's what the NotificationProtocol does | 11:56 |
flaper87 | one more question: What happens if the message is published in Zaqar1 but there are websocket clients connected to Zaqar2 ? | 11:56 |
flaper87 | how is that being handled (assuming it is)? | 11:56 |
therve | flaper87, zaqar1 sends a http request to zaqar2 | 11:57 |
flaper87 | ahhhhh right right | 11:58 |
flaper87 | what endpoint does it send it too? | 11:58 |
* flaper87 reads again the patch with all that in mind | 11:59 | |
*** kgriffs is now known as kgriffs|afk | 11:59 | |
therve | flaper87, If you look at Driver.listen, there is a new create_server for that endpoint | 12:01 |
flaper87 | therve: ok, no more questions :D | 12:02 |
flaper87 | therve: fwiw, I think the logic makes sense | 12:02 |
flaper87 | it follows, IIRC, what we discussed the last time | 12:02 |
therve | Cool :) | 12:02 |
flaper87 | and it'll allow us to start somewhere that we can improve from | 12:02 |
vkmc | if we are adding notifications, we should update websocket support for v2.0 directly | 12:05 |
vkmc | subscriptions* | 12:05 |
vkmc | looks very good, trying to understand the workflow better :) | 12:06 |
flaper87 | I'm a bit worried about the current versioning mess we have, TBH :P | 12:06 |
flaper87 | we've websocket in v1.1 but pre-signed URL just in v2 | 12:06 |
therve | Yeah that's definitely an issue | 12:07 |
flaper87 | I'm starting to think that we should probably backport pre-signed URL to v1.1 for now and then move websocket to v2 during Mitaka | 12:07 |
vkmc | yeah | 12:07 |
flaper87 | but then we don't have notifications in v1_1 anyway | 12:08 |
vkmc | we should move websocket to v2 | 12:08 |
vkmc | it shouldn't be a problem | 12:08 |
*** kgriffs|afk is now known as kgriffs | 12:09 | |
vkmc | it only requires moving endpoints.py to v2 in zaqar/api | 12:09 |
flaper87 | vkmc: what about the API and endpoints that exist/don't exist in v2 ? | 12:09 |
flaper87 | vkmc: would that be hard to do? | 12:09 |
flaper87 | I'd rather do that than backporting stuff | 12:10 |
vkmc | flaper87, the only added endpoint is subscriptions | 12:10 |
vkmc | and the removed endpoints is just removing a few functions and fixing the tests | 12:11 |
vkmc | get message by id and remove messages by id IIRC | 12:11 |
flaper87 | vkmc: coolio, when can you get that done? | 12:11 |
flaper87 | websocket is experimental so, I'm not worried about moving it around | 12:11 |
vkmc | oki | 12:11 |
vkmc | I could do it for friday | 12:13 |
vkmc | so we can test it properly | 12:13 |
vkmc | but we should move forward the subscriptions patch | 12:13 |
vkmc | flaper87, ^ | 12:15 |
flaper87 | vkmc: we can rebase it if needed | 12:17 |
vkmc | k | 12:17 |
vkmc | will do that then | 12:18 |
vkmc | and we can say we have... signed urls, notifications and websockets all for v2 :) | 12:18 |
*** kgriffs is now known as kgriffs|afk | 12:18 | |
therve | flaper87, We'd need to add the support for signed url to the websocket transport | 12:25 |
*** kgriffs|afk is now known as kgriffs | 12:27 | |
vkmc | yep | 12:29 |
*** kgriffs is now known as kgriffs|afk | 12:36 | |
*** exploreshaifali has quit IRC | 12:48 | |
*** kgriffs|afk is now known as kgriffs | 12:54 | |
*** AAzza_ has joined #openstack-zaqar | 12:55 | |
*** AAzza has quit IRC | 12:58 | |
*** AAzza has joined #openstack-zaqar | 12:59 | |
*** AAzza_ has quit IRC | 13:00 | |
*** kgriffs is now known as kgriffs|afk | 13:03 | |
*** kgriffs|afk is now known as kgriffs | 13:04 | |
*** kgriffs is now known as kgriffs|afk | 13:13 | |
*** exploreshaifali has joined #openstack-zaqar | 13:16 | |
*** sriram has joined #openstack-zaqar | 13:17 | |
*** kgriffs|afk is now known as kgriffs | 13:22 | |
flaper87 | dynarro: how's v2 going ? :) | 13:25 |
dynarro | flaper87, it's going well! | 13:26 |
dynarro | flaper87, I'll be implementing pools and flavors soon | 13:27 |
flaper87 | dynarro: oooooooooooooooooooooky | 13:27 |
dynarro | :) | 13:28 |
*** kgriffs is now known as kgriffs|afk | 13:31 | |
*** amitgandhinz has joined #openstack-zaqar | 13:35 | |
dynarro | flaper87, however it'd be awesome if you could review my patches already ;) | 13:35 |
* dynarro is giving flaper87 a cookie if he reviews my patches | 13:39 | |
*** kgriffs|afk is now known as kgriffs | 13:40 | |
* flaper87 is reviewing those patches as we speak | 13:41 | |
flaper87 | dynarro: https://review.openstack.org/#/c/196652/ <- I assume that needs to be abandoned, right> | 13:43 |
flaper87 | ? | 13:43 |
*** mpanetta has joined #openstack-zaqar | 13:44 | |
*** csoukup has joined #openstack-zaqar | 13:44 | |
dynarro | flaper87, yep | 13:52 |
*** ametts has joined #openstack-zaqar | 13:54 | |
flaper87 | dynarro: can you do that ? | 13:55 |
flaper87 | :) | 13:55 |
dynarro | flaper87, sure ;) | 13:55 |
angvp | hallooo | 13:57 |
flaper87 | yoooo | 13:58 |
jasondotstar | sup | 13:59 |
vkmc | oh hai | 13:59 |
jasondotstar | how goes? | 14:02 |
angvp | throw what? throw a step! | 14:02 |
EmilienM | hello | 14:03 |
EmilienM | vkmc: I was on PTO yesterday, but I got IRC notifs on my phone - what was the issue? | 14:03 |
vkmc | hi EmilienM! | 14:11 |
vkmc | so... pinged you cos jasondotstar was trying to figure out who can review the puppet modules for zaqar | 14:12 |
jasondotstar | get them merged when needed.... | 14:12 |
jasondotstar | not only that but... i was also asking about the jenkins gate tests.... | 14:13 |
jasondotstar | trying to figure out where those are defined, so I can see what they test | 14:13 |
EmilienM | jasondotstar: any link? | 14:14 |
EmilienM | jasondotstar: of failures | 14:14 |
jasondotstar | https://review.openstack.org/#/c/204225/ | 14:15 |
jasondotstar | puppet-unit-x.x failures | 14:15 |
*** kgriffs is now known as kgriffs|afk | 14:15 | |
jasondotstar | I'm wondering if this is b/c the puppet class in the commit is empty | 14:15 |
jasondotstar | the zaqar clas | 14:15 |
jasondotstar | s/clas/class | 14:16 |
*** malini has joined #openstack-zaqar | 14:16 | |
*** kgriffs|afk is now known as kgriffs | 14:17 | |
jasondotstar | EmilienM: ^^^^^ | 14:17 |
jasondotstar | beaker rspec failures too | 14:18 |
dynarro | I'm having troubles generating a shh key. it's giving me this error http://paste.ofcode.org/k2U7CXAnSgd5eNB6iGtH4h | 14:32 |
angvp | oh i know why | 14:34 |
angvp | the '-' character of -t rsa is wrong | 14:34 |
angvp | get this one - ;) | 14:35 |
angvp | dynarro: ^ | 14:35 |
dynarro | angvp, what's the difference? | 14:35 |
angvp | - != – | 14:35 |
angvp | one is larger and is not standard, i guess you copied the command from some web and the web rendered you a different character which looks "better" but is not a dash | 14:37 |
*** exploreshaifali has quit IRC | 14:40 | |
dynarro | angvp, oh ok! well it worked! thanks! | 14:43 |
*** kgriffs is now known as kgriffs|afk | 14:44 | |
*** kgriffs|afk is now known as kgriffs | 14:53 | |
dynarro | angvp, I don't know if I'm doing it right... I mean I generated the shh key and logged in into openstack, I added the shh key there but when I tried again to review my commit but it's still giving me this http://paste.ofcode.org/HwYkjrWH3sF2ipC7yrHWyg | 15:02 |
*** kgriffs is now known as kgriffs|afk | 15:02 | |
angvp | let's see | 15:02 |
*** achanda has joined #openstack-zaqar | 15:03 | |
angvp | dynarro: seems something bad configured? | 15:03 |
angvp | let's try something | 15:03 |
angvp | dynarro: can i see more context? what command did you do in order to get that error? | 15:05 |
*** achanda has quit IRC | 15:05 | |
dynarro | I just re-tried to do a git review | 15:06 |
*** kgriffs|afk is now known as kgriffs | 15:06 | |
*** dynarro has quit IRC | 15:28 | |
*** diga has joined #openstack-zaqar | 16:04 | |
*** ametts has quit IRC | 16:05 | |
*** exploreshaifali has joined #openstack-zaqar | 16:18 | |
*** exploreshaifali has quit IRC | 16:22 | |
*** exploreshaifali has joined #openstack-zaqar | 16:31 | |
*** kgriffs is now known as kgriffs|afk | 16:40 | |
*** kgriffs|afk is now known as kgriffs | 16:43 | |
*** davideagnello has joined #openstack-zaqar | 16:51 | |
*** diga has quit IRC | 17:05 | |
*** malini has quit IRC | 17:10 | |
*** boris-42 has quit IRC | 17:20 | |
*** achanda has joined #openstack-zaqar | 17:27 | |
*** malini has joined #openstack-zaqar | 17:49 | |
*** kgriffs is now known as kgriffs|afk | 17:50 | |
*** malini has quit IRC | 17:55 | |
*** kgriffs|afk is now known as kgriffs | 17:56 | |
*** malini has joined #openstack-zaqar | 17:57 | |
*** openstackgerrit_ has quit IRC | 18:11 | |
*** c_soukup has joined #openstack-zaqar | 18:16 | |
*** ametts has joined #openstack-zaqar | 18:18 | |
*** csoukup has quit IRC | 18:18 | |
*** kgriffs is now known as kgriffs|afk | 18:19 | |
*** kgriffs|afk is now known as kgriffs | 18:23 | |
*** malini has quit IRC | 18:24 | |
*** malini has joined #openstack-zaqar | 18:27 | |
*** kgriffs is now known as kgriffs|afk | 18:42 | |
*** kgriffs|afk is now known as kgriffs | 18:59 | |
*** achanda has quit IRC | 19:22 | |
*** csoukup has joined #openstack-zaqar | 19:42 | |
*** c_soukup has quit IRC | 19:43 | |
*** malini has quit IRC | 20:00 | |
*** malini has joined #openstack-zaqar | 20:00 | |
*** malini has quit IRC | 20:03 | |
*** boris-42 has joined #openstack-zaqar | 20:19 | |
*** achanda has joined #openstack-zaqar | 20:22 | |
*** achanda has quit IRC | 20:22 | |
*** achanda has joined #openstack-zaqar | 20:23 | |
*** achanda has quit IRC | 20:28 | |
*** achanda has joined #openstack-zaqar | 20:28 | |
*** mpanetta has quit IRC | 21:08 | |
*** ametts has quit IRC | 21:22 | |
*** sriram has quit IRC | 21:41 | |
*** amitgandhinz has quit IRC | 21:44 | |
*** csoukup has quit IRC | 21:49 | |
*** kgriffs is now known as kgriffs|afk | 21:54 | |
*** kgriffs|afk is now known as kgriffs | 22:03 | |
*** kgriffs is now known as kgriffs|afk | 22:13 | |
*** kgriffs|afk is now known as kgriffs | 22:30 | |
*** kgriffs is now known as kgriffs|afk | 22:40 | |
*** kgriffs|afk is now known as kgriffs | 22:47 | |
*** exploreshaifali has quit IRC | 23:07 | |
*** achanda has quit IRC | 23:22 | |
*** achanda has joined #openstack-zaqar | 23:30 | |
*** achanda has quit IRC | 23:30 | |
*** achanda has joined #openstack-zaqar | 23:31 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!