Tuesday, 2015-09-01

« Monday, 2015-08-31 Index Wednesday, 2015-09-02 »
*** achanda has quit IRC00:01
*** achanda_ has quit IRC00:02
*** Qiming has quit IRC00:13
*** akanksha has quit IRC00:18
*** Qiming has joined #openstack-zaqar01:27
*** csoukup has joined #openstack-zaqar03:04
*** csoukup has quit IRC03:04
*** csoukup has joined #openstack-zaqar03:05
*** achanda has joined #openstack-zaqar03:07
*** achanda has quit IRC03:51
*** diga has joined #openstack-zaqar04:00
*** diga has quit IRC04:40
*** csoukup has quit IRC04:41
*** diga has joined #openstack-zaqar04:41
*** achanda has joined #openstack-zaqar04:45
*** flwang has quit IRC05:07
*** achanda has quit IRC07:11
*** achanda has joined #openstack-zaqar07:17
*** achanda has quit IRC07:25
*** achanda has joined #openstack-zaqar07:26
*** achanda has quit IRC07:30
*** boris-42 has quit IRC09:00
*** flwang has joined #openstack-zaqar09:16
flaper87flwang: how long before the next update for https://review.openstack.org/#/c/202374/ ?09:38
openstackgerritMerged openstack/zaqar: Support signed URLs in WebSocket  https://review.openstack.org/21513409:56
openstackgerritMerged openstack/zaqar: Fixed the mistake in zaqar dev-environment  https://review.openstack.org/21880209:56
flaper87therve: ^09:57
*** flwang2 has joined #openstack-zaqar10:36
*** diga has quit IRC10:37
*** flwang has quit IRC10:37
flwang2flaper87: i'm going to submit it now. do you have any more concerns for that?11:04
*** Qiming has quit IRC11:11
flaper87flwang2: none for now11:14
flaper87if there are any, we can submit follow-up patches11:14
flwang2flaper87: cool11:14
flwang2flaper87: for those variables like _LE in i18n, can it be used like this             LOG.error(_LE('Failed to create process for sendmail, because {0}'.format(e.strerror)))11:16
flwang2i mean a dynamic error message11:17
flaper87flwang2: formatting should go outside the i18n11:30
flwang2flaper87: that's i want to confirm, thanks11:30
openstackgerritFei Long Wang proposed openstack/zaqar: Add email driver for notification  https://review.openstack.org/20237411:34
*** exploreshaifali has joined #openstack-zaqar11:35
flaper87flwang2: thanks11:36
flwang2flaper87: pls review it and i'm standing by to address any comments :)11:37
flaper87flwang2: https://review.openstack.org/#/c/202374/12/zaqar/common/configs.py,cm11:38
flaper87doesn't ListOpt split on spaces ?11:38
flaper87If not, would it be better to just accept a string and split it ourselves ?11:38
flaper87I don't think we should force ops to write lists in config files for things like commands11:39
flwang2flaper87: let me find a link to explain11:39
flwang2flaper87:  http://stackoverflow.com/questions/11284147/how-to-do-multiple-arguments-with-python-popen11:40
flaper87flwang2: wait, I know we need a list11:40
flaper87I'm just saying we shouldn't ask ppl to write lists in config files11:40
flwang2flaper87: ah, i can see your point11:41
flwang2let me think11:41
flwang2flaper87: i think what we can do is accepting a string and split it with space?11:42
flaper87flwang2: yes11:43
flaper87flwang2: but wait, I think oslo.config already solves this issue11:43
flaper87flwang2: https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L5711:48
flaper87look at MultiStrOpt11:48
flaper87if that doesn't work then we can use str + split11:49
flwang2with MultiStrOpt, seems we have to config it in zaqar.conf like    smtp_command = /usr/sbin/sendmail    smtp_command=-t    smtp_command=-oi,   based on this comments https://github.com/openstack/oslo.config/blob/master/oslo_config/cfg.py#L110811:52
flwang2if so, operators will be confused11:52
flaper87flwang2: good point11:54
flaper87flwang2: then str it is11:54
flaper87I added another comment on the review11:54
flaper87flwang2: thanks11:54
flwang2flaper87: cool, will address it together11:54
flwang2flaper87: re the _conf/conf issue, it has been fixed in https://review.openstack.org/#/c/218072/11:57
flwang2so is it necessary to add the TODO?11:58
flwang2btw, may i get your attention on this https://review.openstack.org/218083 ?11:58
flaper87flwang2: no need if it was fixed12:03
* flaper87 clicks12:03
*** Qiming has joined #openstack-zaqar12:04
flwang2therve: ping12:52
openstackgerritFei Long Wang proposed openstack/zaqar: Add email driver for notification  https://review.openstack.org/20237412:57
flwang2therve: it would be nice if you can retest the notification feature, since i found the notification is not very stable after remove the taskflow12:58
flwang2flaper87: ^12:58
flaper87mmh12:58
flaper87what are you seeing?12:58
flwang2flaper87: i saw the task can be triggered12:59
flwang2for example, add a breakpoint in task webhook or mailto, i can see the self.executor.submit(mgr.driver.execute, sub, messages) is executed, but the breakpoint isn't stepped in13:00
flwang2flaper87: would you mind giving it a test?13:00
flwang2if you have a dev env in hand13:00
flaper87flwang2: the bp is probably not being triggered because it's using eventlet13:01
flaper87isn't it?13:01
flaper87it's likely somewhere in there waiting to be executed or just blocked13:01
flwang2but when I used taskflow, it works fine13:08
flaper87flwang2: I don't recall. Does LOG.error print the traceback too ?13:08
flaper87flwang2: mmh, we need to check that13:08
flwang2flaper87:  no, based on my test13:08
ryansblog.exception will13:09
flwang2ryansb: ?13:09
ryansbyou can do "LOG.exception(exc)" and it'll log the traceback13:09
flaper87I think we might want the traceback printed in that case13:09
flaper87at least for when we catch `Exception`13:09
flwang2ryansb: i see. acutally, i mean the log can't be executed as well13:10
flaper87flwang2: don't hate us :(13:10
flwang2flaper87: so it would be nice if you guys can give it a try13:10
flwang2if it's confirmed, i think we may need to revert it13:11
flaper87ryansb: how would you feel about merging that patch as is and start fixing the bugs we find after testing it?13:11
flwang2sorry to bother you guys, since i have tried many times and im not sure if it's my env issue or a bug13:13
ryansbI would rather check it out locally and test it than merge to test13:13
ryansbbut I won't be able to do that until later today, b/c I have some heat patches that need some pre-feature-freeze updates13:13
flaper87ryansb: right, which is why I'm consider the above :)13:15
flaper87flwang2: how do you test this patch?13:15
flaper87flwang2: mind giving me steps to test/reproduce ?13:15
flwang2yep, very easy13:15
ryansbI'd rather make an exception & merge it later (even if slightly post-freeze) than merge it untested13:15
* flaper87 will test it now13:16
flwang21. create  a queue  my_queue13:16
*** amitgandhinz has joined #openstack-zaqar13:16
flwang22. create a subscription   {"subscriber": "mailto: flwang@qq.com", "ttl": 3600, "options":{}}13:16
flaper87flwang2: could you share your shell history ?13:16
flaper87:D13:16
flwang23. post message to the queue13:16
flaper87and config file13:16
flwang2flaper87: i'm using a http plugin on chrome :)13:17
flwang2but i can share my conf13:17
flaper87flwang2: ok, thanks13:17
flwang2http://paste.openstack.org/show/437712/13:20
flwang2btw, i'm using pooling13:20
* flaper87 clicks13:20
flaper87flwang2: so, create a queue13:23
flwang2i know you don't like that :)13:23
flaper87:P13:23
* flaper87 has to figure out the curl command for Zaqar because zaqarclient is not notifications friendly13:24
flaper87:(13:24
flwang2flaper87: yep, i see13:24
flwang2it should be   POST  /queues/my_queue/subscriptions13:25
openstackgerritMerged openstack/zaqar: Fix GET queue metadata for sqlalchemy  https://review.openstack.org/21808313:29
*** Qiming has quit IRC13:30
*** Qiming has joined #openstack-zaqar13:31
flaper87flwang2: subscription created13:31
flwang2flaper87: then just post messages to the queue13:32
flwang2the notifier will be called, but the task may be not13:32
*** dynarro has joined #openstack-zaqar13:33
* flaper87 can post messages13:34
flaper87WOOHOOO13:34
flaper87flwang2: I see this 2015-09-01 15:32:56.573 31084 ERROR zaqar.notification.task.mailto [-] Failed to create process for sendmail, because {error}13:34
flaper87that's because I don't have sendmail13:34
flwang2so you can trigger the task13:35
flaper87can you just do str(e) rather than e.stderror ?13:35
flaper87actually13:35
flaper87I think what you want is ) % {..}13:35
flaper87rather than _LE(), {}13:35
flaper87it didn't get formatted13:35
flaper87when you fix that, please, use LOG.exception in the second catch13:36
openstackgerritFei Long Wang proposed openstack/zaqar: Add email driver for notification  https://review.openstack.org/20237413:36
flaper87that is, keep LOG.error and add LOG.exception too13:36
flaper87flwang2: ran it several times13:36
flaper87it seems to work13:36
flaper87I mean, it's executed13:36
flwang2flaper87: ok, interesting13:36
flwang2flaper87: did you mean like this http://paste.openstack.org/show/437781/  ?13:42
flaper87flwang2: right, not sure if str(e), thoguh13:44
flaper87and pls, the LOG.exception in the except Exception below13:44
vkmco.o13:44
flwang2flaper87: i'm a little bit confused " the LOG.exception in the except Exception below", i'm doing that in http://paste.openstack.org/show/437781/, isn't it?13:45
*** mpanetta has joined #openstack-zaqar13:47
flaper87flwang2: ah wait13:47
flaper87in L22 you need both13:47
flaper87LOG.error(_LE()) to print a custom error13:47
flaper87and right below that one: LOG.exception(exc) to print the exception13:48
flaper87and the except line needs to look like:13:48
flaper87except Exception as exc:13:48
flwang2ok, i can see your point, just print more trace for debug13:48
flaper87flwang2: http://paste.openstack.org/show/437782/13:48
flaper87vkmc: morning13:48
flaper87:)13:48
vkmchey hey :)13:49
*** ametts has joined #openstack-zaqar13:50
openstackgerritFei Long Wang proposed openstack/zaqar: Add email driver for notification  https://review.openstack.org/20237413:53
flaper87flwang2: testing the patch again13:53
flwang2flaper87: cheers man13:54
flwang2i'm waiting for the test result on my 2:00AM :)13:54
flaper87flwang2: now I'm getting the expected error13:56
flaper87Failed to create process for sendmail, because [Errno 2] No such file or directory13:56
flwang2awesome13:56
flaper87ok, it's good it's being executed down to that path13:57
flaper87I assume you tested the sending part13:57
flaper87because I don't want to install sendmail13:57
flaper87:P13:57
*** kgriffs|afk is now known as kgriffs13:57
flwang2hah, fair enough13:57
flaper87flwang2: +2 from me13:58
flaper87lets see what vkmc and ryansb say13:58
flaper87we have until tomorrow to get it in13:59
flwang2flaper87: good good13:59
flwang2i can have a good sleep now13:59
ryansbflwang2: I'll post my test results on the review14:00
ryansb(hopefully in the form of a +2)14:00
flwang2ryansb: thanks man14:00
vkmcflwang2, thanks Fei Long, will check as well14:01
flaper87ryansb: awesome, thanks!14:01
vkmcflwang2, enjoy your evening now :)14:01
flwang2vkmc: thank you, guys14:01
flaper87flwang2: rest well, buddy!14:01
flaper87great work14:01
flwang2vkmc: haha, yep, i can arm around my little hacker :)14:02
flwang2have fun, guys14:02
vkmcflwang2, oh yes! hope he is feeling better... forgot to ask you :(14:03
vkmcflwang2, take care, ttyt14:03
*** kgriffs is now known as kgriffs|afk14:06
*** kgriffs|afk is now known as kgriffs14:07
*** exploreshaifali has quit IRC14:13
*** Caleb-- has quit IRC14:22
*** malini has joined #openstack-zaqar14:25
*** Caleb-- has joined #openstack-zaqar14:32
* flaper87 tackles policy14:33
*** boris-42 has joined #openstack-zaqar14:42
*** csoukup has joined #openstack-zaqar14:52
*** kgriffs is now known as kgriffs|afk15:07
*** Qiming has quit IRC15:23
*** kgriffs|afk is now known as kgriffs15:42
*** malini has quit IRC15:54
*** malini has joined #openstack-zaqar15:54
*** kgriffs is now known as kgriffs|afk16:01
*** diga has joined #openstack-zaqar16:03
*** kgriffs|afk is now known as kgriffs16:14
*** diga has quit IRC16:18
*** malini has quit IRC16:22
*** malini has joined #openstack-zaqar16:31
*** exploreshaifali has joined #openstack-zaqar16:46
*** david-ly_ has joined #openstack-zaqar16:49
*** david-lyle has quit IRC16:49
*** malini has quit IRC16:51
*** david-ly_ has quit IRC17:07
*** dynarro has quit IRC17:08
*** achanda has joined #openstack-zaqar17:25
openstackgerritClaudiu Belu proposed openstack/zaqar: Adds oslo_concurrency dependency  https://review.openstack.org/21937417:37
*** exploreshaifali has quit IRC17:46
*** malini has joined #openstack-zaqar17:49
*** david-lyle has joined #openstack-zaqar17:54
*** david-lyle has quit IRC18:01
*** david-lyle has joined #openstack-zaqar18:19
*** malini has quit IRC18:30
*** stanchan has joined #openstack-zaqar18:32
*** exploreshaifali has joined #openstack-zaqar18:34
*** malini has joined #openstack-zaqar18:39
*** ametts has quit IRC18:51
*** ametts has joined #openstack-zaqar19:04
*** ametts has quit IRC19:23
*** whydidyoustealmy has quit IRC19:34
*** ametts has joined #openstack-zaqar19:35
*** whydidyoustealmy has joined #openstack-zaqar19:35
*** whydidyoustealmy has quit IRC19:35
*** whydidyoustealmy has joined #openstack-zaqar19:35
flaper87ryansb: were you able to test flwang1's patch?19:38
ryansbyeah, I'll post a review19:40
ryansbhey, what did you change in your patch to that series?19:40
ryansbah, just fixed up logging19:41
ryansbk, +2a'd19:42
flaper87ryansb: awesome19:43
ryansbI still had #14 checked out, so just wanted to make sure you hadn't broken everything19:44
ryansb;)19:44
flaper87damnit, jenkins is sad19:45
flaper87flwang1: ^19:45
ryansbdang, now I'm sad too.19:46
*** davideagnello has quit IRC19:50
flaper87vkmc: merge conflict https://review.openstack.org/#/c/218430/ :(19:51
*** davideagnello has joined #openstack-zaqar19:53
*** malini has quit IRC19:55
jasondotstarflaper87: hey qq19:55
jasondotstarthe zaqar pkgs19:56
*** malini has joined #openstack-zaqar19:56
flaper87jasondotstar: yooooo, how's Zaqar's puppet master doing today?19:56
jasondotstarthe .deb and .rpm(s)19:56
* jasondotstar chuckles19:56
jasondotstaris there a common mirror for those?19:57
flaper87jasondotstar: the rpm's are part of RDO, that'd be fedora19:58
flaper87jasondotstar: the debs, we'll need zigo to chime in19:58
jasondotstarso..... a base os install19:59
jasondotstarwe'd need to add those repos19:59
jasondotstardetect the OS obvs19:59
jasondotstarthen add the repos accordingly19:59
flaper87don't other projects do this already?20:00
*** boris-42 has quit IRC20:00
flaper87Zaqar follows what other projects do there20:00
* flaper87 a bit confused20:00
jasondotstaryea20:00
jasondotstarthey do20:00
*** flwang2 has quit IRC20:00
flaper87but yeah, I'd expect those repos to be there20:00
flaper87:D20:00
jasondotstarbut I'm just wondering where they are20:00
jasondotstarand how they are picked up20:00
jasondotstartrying not to re-invent the wheel in my puppet module code20:01
jasondotstarso it'd be nice to know how those repos are added, if they're 'already there' somehow20:01
*** malini has quit IRC20:11
*** exploreshaifali has quit IRC20:12
openstackgerritClaudiu Belu proposed openstack/zaqar: Adds oslo_concurrency dependency  https://review.openstack.org/21937420:17
vkmcflaper87, oh noes20:20
*** achanda has quit IRC20:54
*** flwang has joined #openstack-zaqar20:57
openstackgerritFei Long Wang proposed openstack/zaqar: Fix duplicated notification  https://review.openstack.org/21807220:59
flaper87flwang1: good morning20:59
flaper87flwang1: we need a rebase on the email one, tests are failing20:59
flaper87but it was approved20:59
flaper87vkmc: flwang https://review.openstack.org/#/c/218235/ these reviews could get some love too :D21:01
flaper87i know, I know, FF21:01
vkmcFFFFFFFFFF21:01
flwangflaper87: got21:02
flwangand that's another aspect why i say it's not stable21:02
flaper87flwang: :/21:02
openstackgerritFei Long Wang proposed openstack/zaqar: Add email driver for notification  https://review.openstack.org/20237421:02
flaper87in that case, we shouldn't land it21:02
flaper87flwang: what's the cause of that failure ?21:02
flwangflaper87: no failure, but the task won't be triggered21:03
flwangthat's why i'm thinking if we should get the taskflow back21:03
flwangi will do more test today and submit a patch if it's necessary21:04
flwangflaper87: btw, would you mind run that test case locally?21:04
flwangflaper87: and seems it only happens on py2721:05
flaper87flwang: sure thing21:06
*** achanda has joined #openstack-zaqar21:07
flaper87flwang: it passed21:13
flaper87trying again21:13
flwangholy shit21:13
flaper87passed again21:13
* flaper87 tries again21:13
flwanginteresting21:13
flaper87passed again21:14
flaper87:P21:14
flaper87should I keep going?21:14
flwangno, it's ok21:15
flaper87passed again21:15
flaper87:P21:15
flwangon my local, it works fine21:15
flwangbut sometimes, jenkins will blame it on py2721:15
*** mpanetta has quit IRC21:30
vkmcflaper87, flwang, for v2, we don't support get_by_id and delete_by_id21:30
vkmcright?21:30
*** achanda has quit IRC21:30
flwang1vkmc: messages? IIRC, it's supported21:31
flwang1checking code....21:31
vkmcflwang1, it is... we said we were going to remove support for it21:31
vkmcI'm happy with it though, if we consider queues == topics21:32
flaper87it's in the code but we kinda dont21:33
flaper87we don't support getting by id21:33
flaper87but we support delete by id21:33
flaper87that's our only way to delete messages :D21:33
vkmchmm21:33
flwang1vkmc: TBH, I can't remember why we want to remove them21:33
vkmcHMM21:33
flaper87Happy to discuss this further21:33
vkmcbecause you cannot get by id in a ___QUEUE___21:33
flaper87tomorrow...21:33
flaper87:D21:33
vkmcbut we no longer have queues21:33
vkmcyes21:33
vkmclet's do that21:33
flaper87but it's not a queuing message21:33
vkmcI'm burned out21:33
flaper87:D21:33
flaper87queuing service21:34
flaper87damnit21:34
flaper87I should rest21:34
vkmcqueuing massage21:34
vkmchaha21:34
srirammassage lol21:34
* sriram claims them21:34
vkmcsriram, o/ haha21:34
sriramvkmc: hello! how goes?21:35
vkmcsriram, good good, reviewing all the things, the freeze is coming21:35
vkmcsriram, you?21:35
sriramnice, good as well, I'm contributing to github.com/stackforge/poppy these days21:36
vkmcsweet! how is that going?21:37
sriramoh yes, its awesome :)21:38
*** csoukup has quit IRC21:44
*** sriram has quit IRC21:46
openstackgerritMerged openstack/zaqar: Return empty `links` on empty collections  https://review.openstack.org/21823521:56
openstackgerritMerged openstack/zaqar: Set a secret key in devstack  https://review.openstack.org/21459421:57
*** csoukup has joined #openstack-zaqar22:01
*** amitgandhinz has quit IRC22:02
vkmcflaper87, please rebase flavors in sqlalchemy22:03
flaper87vkmc: yes mam'22:03
vkmcflaper87, tomorrow, its late thereeeee22:03
flaper87vkmc: https://review.openstack.org/#/c/218248/ also these 222:03
flaper87easy reviews22:03
flaper87client side22:03
vkmcI was on that22:04
vkmc:D22:04
openstackgerritFlavio Percoco proposed openstack/zaqar: s/update/_update/ sqlalchemy's pool controller  https://review.openstack.org/21829222:04
openstackgerritFlavio Percoco proposed openstack/zaqar: Add unittests for Flavors in sqlalchemy  https://review.openstack.org/21878422:04
openstackgerritFlavio Percoco proposed openstack/zaqar: Add support for flavors in sqlalchemy  https://review.openstack.org/21829122:04
openstackgerritFlavio Percoco proposed openstack/zaqar: Restore sqlalchemy unit tests  https://review.openstack.org/21877722:04
flaper87vkmc: ^22:04
flaper87ryansb: ^22:04
flaper87you'd +2 some of those22:04
vkmcthanks flaper8722:04
flaper87it's just a rebase22:04
flaper87vkmc: np22:04
flaper87ok, out22:06
flaper87for realz22:06
flaper87tt y'all tomorrow22:06
vkmcttyt! sleep tight22:06
vkmcor reboot... not sure if you actually sleep22:06
openstackgerritMerged openstack/python-zaqarclient: v1.1 and v2 claims return document not list  https://review.openstack.org/21824822:14
openstackgerritMerged openstack/python-zaqarclient: Send claims `limit` as a query param  https://review.openstack.org/21824922:15
*** kgriffs is now known as kgriffs|afk22:20
*** akanksha has joined #openstack-zaqar22:20
*** csoukup has quit IRC22:28
*** ametts has quit IRC22:42
*** achanda has joined #openstack-zaqar22:54
*** boris-42 has joined #openstack-zaqar22:57
*** achanda has quit IRC22:59
*** Qiming has joined #openstack-zaqar23:37
*** Qiming has quit IRC23:37
*** Qiming has joined #openstack-zaqar23:38
*** stanchan has quit IRC23:54
« Monday, 2015-08-31 Index Wednesday, 2015-09-02 »

Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!