| *** david-lyle has joined #openstack-zaqar | 00:01 | |
| *** davideagnello has quit IRC | 01:14 | |
| *** davideagnello has joined #openstack-zaqar | 04:07 | |
| *** JAHoagie has joined #openstack-zaqar | 07:52 | |
| *** JAHoagie has quit IRC | 08:08 | |
| *** akanksha_ has joined #openstack-zaqar | 10:35 | |
| *** akanksha_ has quit IRC | 12:57 | |
| *** david-lyle has quit IRC | 17:58 | |
| *** openstackgerrit has quit IRC | 18:47 | |
| *** openstackgerrit has joined #openstack-zaqar | 18:47 | |
| *** david-lyle has joined #openstack-zaqar | 18:59 | |
| openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription create v2 https://review.openstack.org/249395 | 20:53 |
|---|---|---|
| openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription create v2 https://review.openstack.org/249395 | 21:00 |
| openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription show v2 https://review.openstack.org/258245 | 21:00 |
| *** mdnadeem has joined #openstack-zaqar | 21:30 | |
| Eva-i | flwang: hey, configuration tables autogeneration tool doesn't work with Zaqar correctly - it misses many configuration options. We will need to make some refactorings to Zaqar to fix this. I know 100% working solution, but it will be hard. There's surely an easier way exists, but I need to clear some things with doc team. | 21:33 |
| flwang | what's the problem? | 21:34 |
| flwang | what do you mean 'We will need to make some refactorings to Zaqar to fix this'? | 21:34 |
| *** mdnadeem has quit IRC | 21:36 | |
| Eva-i | flwang: the tool can't find all configuration options. As I know the tool imports all modules from the project, options are getting registered in cfg.CONF, then from all options in cfg.CONF the tool generates flagmappings file used to generate tables. | 21:37 |
| openstackgerrit | Fei Long Wang proposed openstack/python-zaqarclient: Add support for subscription create v2 https://review.openstack.org/249395 | 21:38 |
| Eva-i | flwang: and Zaqar registers options lazily, so importing module from Zaqar doesn't fill up cfg.CONF | 21:38 |
| Eva-i | flwang: many options | 21:39 |
| Eva-i | flwang: for example, here https://github.com/openstack/zaqar/blob/master/zaqar/bootstrap.py#L57 | 21:39 |
| Eva-i | flwang: if I move registering these options out of the class to the module(like here: https://github.com/openstack/zaqar/blob/master/zaqar/bootstrap.py#L44), the tool registers the options. | 21:41 |
| flwang | Eva-i: ah, i see. my idea is just doc the hacking way in our developer docs and don't change any zaqar code | 21:41 |
| flwang | that's my suggestion | 21:46 |
| Eva-i | flwang: ok, that would mean I should create tables manually. I think while I'm working on config-ref text, I'll be asking Docs team about easy solution. Maybe there's just one tiny patch needed for Zaqar to make everything working. I'll tell you if I find this solution, ok? | 21:51 |
| flwang | hmm... again, i don't want to change zaqar code for doc | 21:52 |
| flwang | let me clarify | 21:52 |
| Eva-i | flwang: okay... | 21:52 |
| flwang | 1. Change the zaqar code locally | 21:53 |
| flwang | 2. generate the table | 21:53 |
| flwang | 3. document the process/change in our developer docs | 21:53 |
| flwang | is that ok? | 21:53 |
| Eva-i | flwang: oh, it's a nice idea. Totally okay. | 21:55 |
| flwang | cool | 21:56 |
| Eva-i | flwang: also I wanted to ask: many things in existing config-ref in Zaqar repo are now outdated. Would you like me to fresh things up instead of simple conversion? Can I also add some important things which, I think, are missing in config-ref? | 22:02 |
| flwang | sure, go ahead for anything you think it's right | 22:05 |
| flwang | and we can review it before merge, right? ;) | 22:06 |
| Eva-i | flwang: yeah, of course. It's just though it would be easier to review if I upload patch set with simple conversion first, and next patch set with freshing things up and improvements. But it's more work for me and personally I want to upload first patch set already with improvements. | 22:11 |
| Eva-i | *I just thought | 22:11 |
| flwang | just do the right thing and let the reviewer know | 22:18 |
| *** Eva-i has quit IRC | 22:57 | |
| *** Eva-i has joined #openstack-zaqar | 23:10 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!