flwang1 | Eva-i: yes? | 00:34 |
---|---|---|
*** mdnadeem has joined #openstack-zaqar | 02:59 | |
*** csoukup has joined #openstack-zaqar | 03:20 | |
*** flwang has quit IRC | 03:58 | |
*** csoukup has quit IRC | 04:49 | |
*** david-lyle has quit IRC | 05:00 | |
*** david-lyle has joined #openstack-zaqar | 05:01 | |
*** GB21 has joined #openstack-zaqar | 05:59 | |
*** GB21 has quit IRC | 06:15 | |
*** GB21 has joined #openstack-zaqar | 06:15 | |
*** GB21 has quit IRC | 06:51 | |
*** GB21 has joined #openstack-zaqar | 06:54 | |
openstackgerrit | MD NADEEM proposed openstack/zaqar-specs: HTTP put improvement for existing resource https://review.openstack.org/246147 | 07:15 |
*** csoukup has joined #openstack-zaqar | 07:45 | |
*** AAzza has quit IRC | 07:46 | |
*** AAzza has joined #openstack-zaqar | 07:46 | |
*** csoukup has quit IRC | 07:50 | |
*** AAzza has quit IRC | 07:57 | |
*** GB21 has quit IRC | 07:59 | |
*** GB21 has joined #openstack-zaqar | 08:01 | |
*** AAzza has joined #openstack-zaqar | 08:02 | |
*** AAzza has quit IRC | 08:06 | |
*** cpallares has quit IRC | 08:09 | |
*** AAzza has joined #openstack-zaqar | 08:09 | |
*** cpallares has joined #openstack-zaqar | 08:10 | |
*** GB21 has quit IRC | 08:15 | |
*** boris-42 has joined #openstack-zaqar | 08:28 | |
*** openstackgerrit has quit IRC | 08:32 | |
*** openstackgerrit has joined #openstack-zaqar | 08:32 | |
*** flwang has joined #openstack-zaqar | 09:04 | |
openstackgerrit | Fei Long Wang proposed openstack/zaqar: Add `_max_message_size` and `_ttl` as reserved queue attributes https://review.openstack.org/265723 | 09:09 |
*** mdnadeem has quit IRC | 09:10 | |
flwang | ryansb: vkmc: pls revisit https://review.openstack.org/249395 thanks | 09:16 |
*** GB21 has joined #openstack-zaqar | 09:29 | |
*** AAzza has quit IRC | 09:50 | |
*** AAzza has joined #openstack-zaqar | 09:51 | |
*** mdnadeem has joined #openstack-zaqar | 09:54 | |
*** mdnadeem has quit IRC | 09:54 | |
*** mdnadeem has joined #openstack-zaqar | 09:54 | |
*** AAzza has quit IRC | 09:56 | |
*** AAzza has joined #openstack-zaqar | 09:59 | |
*** flwang has quit IRC | 10:21 | |
*** GB21 has quit IRC | 10:43 | |
Eva-i | flwang1: ping | 10:54 |
*** GB21 has joined #openstack-zaqar | 11:15 | |
*** flwang_home has joined #openstack-zaqar | 11:23 | |
flwang_home | vkmc: ping | 11:23 |
flwang_home | Eva-i: ping | 11:24 |
Eva-i | flwang_home: hello | 11:24 |
Eva-i | flwang_home: you're going to sleep now? | 11:24 |
flwang_home | yep, it's 0:24 am | 11:24 |
flwang_home | so i'm not sure if i can wake up after 3 hours | 11:25 |
Eva-i | flwang_home: do you need to wake up after 3 hours? | 11:25 |
flwang_home | yep, we have weekly meeting | 11:25 |
Eva-i | flwang_home: ah, yes | 11:25 |
flwang_home | so pls let vkmc know, i may need her help to host the meeting if i can't join | 11:26 |
Eva-i | flwang_home: okay, I'll do it. Sleep well. | 11:26 |
flwang_home | Eva-i: thank you very much | 11:28 |
flwang_home | vkmc: ryansb: when you see this msg, pls help review the subscription patches of zaqar client, we really need to get them in asap. thanks a lot | 11:34 |
*** flwang_home has quit IRC | 11:42 | |
*** flwang_home has joined #openstack-zaqar | 11:43 | |
*** GB21 has quit IRC | 11:44 | |
*** flwang_home has quit IRC | 11:56 | |
*** flwang_home has joined #openstack-zaqar | 12:00 | |
*** GB21 has joined #openstack-zaqar | 12:02 | |
*** GB21 has quit IRC | 12:07 | |
*** flwang_home has quit IRC | 12:09 | |
*** njohnston has quit IRC | 13:03 | |
Eva-i | Hello. Anybody here? | 13:07 |
therve | Heya | 13:18 |
*** sriram has joined #openstack-zaqar | 14:15 | |
ryansb | flwang1: will do | 14:18 |
* ryansb is awake now | 14:18 | |
Eva-i | Wait a sec, we should have started meeting 40 minutes ago? | 14:39 |
Eva-i | vkmc: ping | 14:39 |
vkmc | Eva-i, pong | 14:39 |
vkmc | nope, is in 20min | 14:39 |
Eva-i | vkmc: alright. Would you like to host today's meeting? Fei Long may not be able to attend. | 14:40 |
vkmc | Eva-i, certainly | 14:41 |
Eva-i | vkmc: that's cool | 14:41 |
*** kgriffs|afk is now known as kgriffs | 14:43 | |
*** ametts has joined #openstack-zaqar | 14:48 | |
*** pradk has joined #openstack-zaqar | 14:58 | |
vkmc | ok... seems there is a meeting overlap | 15:01 |
Eva-i | vkmc: hm, I'm in meeting chat and I see nova's meeting. | 15:02 |
vkmc | yes | 15:02 |
vkmc | me too | 15:02 |
vkmc | do something have something urgent to discuss? otherwise we could wait til 21UTC and have the meeting then | 15:02 |
Eva-i | ryansb: would you like to have a meeting at 21 UTC? | 15:03 |
vkmc | in fact, I'd like to chat with flwang1 about changing the meeting times... maybe setting just a time | 15:03 |
ryansb | actually, we're on the calendar for 21UTC | 15:03 |
*** mpanetta has joined #openstack-zaqar | 15:03 | |
Eva-i | ryansb: oh, that's great then | 15:03 |
Eva-i | vkmc: btw I almost finished my support for binary messages patch. Now I'm writing tests. | 15:04 |
ryansb | Eva-i: Nice! | 15:04 |
ryansb | my only update is "I have lots of reviews to do, so I'll see you folks at meeting this afternoon/evening" | 15:05 |
Eva-i | Few minutes ago I made a super review for http improvement spec. https://review.openstack.org/#/c/246147 | 15:06 |
ryansb | super review indeed | 15:06 |
vkmc | ryansb, which calendar are you checking? | 15:07 |
vkmc | thanks :) | 15:07 |
vkmc | Eva-i, well done! | 15:07 |
*** malini has joined #openstack-zaqar | 15:08 | |
ryansb | vkmc: the ICAL file here http://eavesdrop.openstack.org/#Zaqar_Team_Meeting | 15:09 |
ryansb | which has our 2100UTC meeting on the 11th (today) | 15:09 |
vkmc | ryansb, cool! didn't know about it :D | 15:09 |
Eva-i | oh, the review is not very super.. I must leave a note. | 15:10 |
jasondotstar | just about to ask :-) | 15:11 |
vkmc | jasondotstar, o/ sup man | 15:15 |
vkmc | long time no chat | 15:15 |
jasondotstar | howdy | 15:15 |
jasondotstar | HNY | 15:15 |
Eva-i | vkmc: can you help me a bit with python mocking? | 15:22 |
vkmc | Eva-i, shoot | 15:26 |
vkmc | jasondotstar, hny 4 u 2 :) | 15:26 |
Eva-i | vkmc: I have an instance of NotificationFactory in a test. I want to mock it's "instance.sendMessage" method call. See https://github.com/openstack/zaqar/blob/master/zaqar/transport/websocket/factory.py#L62. How can it be done? | 15:30 |
*** amitgandhinz has joined #openstack-zaqar | 15:32 | |
Eva-i | I tried few ways and they all were wrong. | 15:35 |
*** GB21 has joined #openstack-zaqar | 15:35 | |
vkmc | import the notificationfactory | 15:36 |
vkmc | instantiate it | 15:36 |
vkmc | and patch the sendMessage method | 15:36 |
vkmc | as in https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/transport/websocket/v2/test_subscriptions.py <- | 15:36 |
therve | Eva-i, I believe it's done plenty of time in the tests | 15:36 |
*** njohnston has joined #openstack-zaqar | 15:37 | |
*** njohnston has quit IRC | 15:38 | |
*** njohnston has joined #openstack-zaqar | 15:40 | |
Eva-i | That's exactly what I'm asking. How to patch? I'm trying like this now, for example. | 15:42 |
Eva-i | http://paste.openstack.org/show/KFlimrvJM3tzOCIZ2dPt/ | 15:42 |
Eva-i | vkmc: therve | 15:42 |
therve | Eva-i, https://github.com/openstack/zaqar/blob/master/zaqar/tests/unit/transport/websocket/v2/test_messages.py#L78 | 15:43 |
therve | I think this is the simplest version | 15:43 |
openstackgerrit | Thomas Herve proposed openstack/zaqar: Fix requirements of message_delete_many API https://review.openstack.org/265890 | 15:48 |
*** stanchan has quit IRC | 15:48 | |
Eva-i | therve: oki | 15:52 |
*** csoukup has joined #openstack-zaqar | 16:08 | |
*** GB21 has quit IRC | 16:10 | |
*** GB21 has joined #openstack-zaqar | 16:11 | |
*** dynarro has joined #openstack-zaqar | 16:24 | |
*** GB21 has quit IRC | 17:19 | |
*** ametts has quit IRC | 17:25 | |
*** dynarro has quit IRC | 17:27 | |
*** malini has quit IRC | 18:07 | |
*** pradk_ has joined #openstack-zaqar | 18:10 | |
*** pradk has quit IRC | 18:11 | |
*** pradk_ is now known as pradk | 18:12 | |
*** csoukup has quit IRC | 18:18 | |
*** malini has joined #openstack-zaqar | 18:39 | |
*** davideag_ has quit IRC | 18:46 | |
*** davideagnello has joined #openstack-zaqar | 18:50 | |
*** barra204 has joined #openstack-zaqar | 18:55 | |
*** shakamunyi has quit IRC | 18:56 | |
*** flwang_home has joined #openstack-zaqar | 18:59 | |
*** flwang_home has quit IRC | 19:12 | |
*** shakamunyi has joined #openstack-zaqar | 19:12 | |
*** barra204 has quit IRC | 19:12 | |
*** csoukup has joined #openstack-zaqar | 19:14 | |
*** amitgandhinz has quit IRC | 20:03 | |
*** flwang has joined #openstack-zaqar | 20:17 | |
flwang1 | hello guys | 20:21 |
ryansb | \o | 20:21 |
flwang1 | ryansb: are we going to have today meeting in 40 mins at 21 UTC? | 20:21 |
vkmc | hey flwang1 | 20:21 |
vkmc | yes | 20:21 |
vkmc | ! | 20:21 |
ryansb | yup | 20:21 |
flwang1 | ok, that's cool | 20:22 |
flwang1 | 3:00 UTC is hard for me today :) sorry about that | 20:22 |
flwang1 | vkmc: would you mind me pushing a girl to review my subscriptions patch ? | 20:24 |
*** malini has quit IRC | 20:41 | |
flwang1 | hi guys | 21:00 |
Eva-i | hello, let's go to meeting room | 21:00 |
flwang1 | should we have the meeting at here? or the #openstack-meeting-3 channel | 21:00 |
Eva-i | I think in #openstack-meeting-3 channel | 21:01 |
Eva-i | flwang1: it on schedule | 21:01 |
Eva-i | *it's | 21:01 |
*** amitgandhinz has joined #openstack-zaqar | 21:02 | |
*** ametts has joined #openstack-zaqar | 21:03 | |
*** njohnston has quit IRC | 21:43 | |
*** njohnston has joined #openstack-zaqar | 21:44 | |
Eva-i | flwang1: please type #endmeeting in meeting chat | 21:46 |
*** njohnston has quit IRC | 21:49 | |
openstackgerrit | Eva Balycheva proposed openstack/zaqar: Support binary messages over websocket https://review.openstack.org/256978 | 21:54 |
Eva-i | vkmc: "binary messages over websocket" patch is ready for reviews. Don't believe me? Look ^ | 22:01 |
ryansb | Eva-i: on it | 22:01 |
openstackgerrit | Eva Balycheva proposed openstack/zaqar: Support binary messages over websocket https://review.openstack.org/256978 | 22:03 |
Eva-i | ryansb: oh, just uploaded a new patch set, because forgot to wipe bad comment. | 22:04 |
vkmc | Eva-i, w000t | 22:04 |
vkmc | Eva-i, that's really good to hear! | 22:04 |
vkmc | great work | 22:04 |
Eva-i | vkmc: don't say great work before reviewing =) | 22:04 |
Eva-i | vkmc: but thanks =) | 22:04 |
vkmc | Eva-i, haha I don't care, I'm happy that there is already something there to review :D | 22:05 |
Eva-i | oh, there's much to review now in Zaqar project | 22:05 |
-openstackstatus- NOTICE: Gerrit is restarting to resolve java memory issues | 22:06 | |
ryansb | haha, guess I'll review a bit later. Thanks java | 22:07 |
Eva-i | not this time, gerrit, shu shu | 22:07 |
Eva-i | java memory... | 22:07 |
vkmc | someone help Java to recover its memory | 22:09 |
vkmc | haha | 22:09 |
flwang1 | vkmc: still around? | 22:16 |
vkmc | flwang1, yes | 22:20 |
flwang1 | vkmc: i'm really sorry for the pushing, but could you pls review those subscriptions patch of client? | 22:20 |
flwang1 | all of them have got +2 and waiting for another bless | 22:21 |
vkmc | flwang1, of course, sorry | 22:21 |
vkmc | :) | 22:21 |
*** sriram has quit IRC | 22:21 | |
flwang1 | vkmc: thank you :) | 22:21 |
flwang1 | vkmc: and this one https://review.openstack.org/#/c/258750/ :) | 22:25 |
*** stanchan has joined #openstack-zaqar | 22:32 | |
openstackgerrit | Merged openstack/zaqar: Replace deprecated library function os.popen() with subprocess https://review.openstack.org/265550 | 22:40 |
*** amitgandhinz has quit IRC | 22:45 | |
openstackgerrit | Merged openstack/python-zaqarclient: Add support for subscription create v2 https://review.openstack.org/249395 | 22:54 |
openstackgerrit | Merged openstack/python-zaqarclient: Add support for subscription update v2 https://review.openstack.org/261303 | 22:54 |
*** mpanetta has quit IRC | 22:59 | |
Eva-i | Hm, maybe I'm too late reviewing this patch https://review.openstack.org/#/c/258750/. But when I reinstall python-zaqarclient via pip and run "openstack help --os-queues-api-version=2", it fails. | 23:02 |
vkmc | it's on merge conflict | 23:03 |
vkmc | I tested it and worked, but I'll try in a new env just incase | 23:03 |
Eva-i | Yep, and needs to be rebased | 23:03 |
*** csoukup has quit IRC | 23:17 | |
flwang1 | i will rebase them | 23:20 |
flwang1 | Eva-i: check your setup.cfg after checkout | 23:20 |
openstackgerrit | Eva Balycheva proposed openstack/zaqar: Support binary messages over websocket https://review.openstack.org/256978 | 23:25 |
*** ametts has quit IRC | 23:28 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!