| *** achanda has joined #openstack-zaqar | 00:11 | |
| flwang | Eva-i: ping | 00:51 |
|---|---|---|
| Eva-i | flwang: pong | 00:51 |
| Eva-i | flwang: I found few bugs in subscription patches for the client. Sad that I haven't reviewed it in time. | 00:52 |
| Eva-i | s/reviewed it/reviewed them | 00:53 |
| flwang | Eva-i: haha, pls blame me | 00:55 |
| flwang | Eva-i: did you test the zaqar ui patch, does it work? | 00:55 |
| flwang | Eva-i: and what's the bug of subscription? | 00:58 |
| Eva-i | flwang: I tested it and panel contents appear only when I apply Shu Muto's solution. I left a comment. But still I think few things are missing in the panel, so I attached a screenshot for you to check. | 00:59 |
| flwang | Eva-i: interesting... i will test it again since it works for me | 00:59 |
| Eva-i | flwang: Shu Muto came yesterday to our chat and left a message for you that the panel probably appears for you, because you haven't updated your Horizon. | 01:00 |
| Eva-i | flwang: update horizon, recreate .venv and test again ;) | 01:00 |
| Eva-i | flwang: I can't submit my bug reports, launchpad says "timeout error". | 01:03 |
| flwang | Eva-i: ok, got | 01:03 |
| Eva-i | flwang: one bug is about subscription public variable queue_name is being a tuple, not a string. Second bug is about inability to list subscriptions. | 01:03 |
| Eva-i | flwang: thank you for approving my tutorial about stages =) | 01:04 |
| flwang | Eva-i: ok, i will take a look at the bug report after you submitted | 01:08 |
| Eva-i | flwang: submitted the second one | 01:09 |
| Eva-i | flwang: and here's first one: https://bugs.launchpad.net/python-zaqarclient/+bug/1538367 | 01:12 |
| openstack | Launchpad bug 1538367 in Python client library for Zaqar "Subscription's queue_name variable is a tuple" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 01:12 |
| flwang | ah, nice catch | 01:14 |
| flwang | Eva-i: if you can submit a patch, i will approve it very fast :) | 01:14 |
| Eva-i | flwang: I'll submit both patches very soon | 01:14 |
| Eva-i | flwang: thanks | 01:14 |
| openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: Fix Subscription's queue_name variable being tuple https://review.openstack.org/272859 | 01:21 |
| flwang | approved | 01:33 |
| Eva-i | flwang: my second bug report is wrong | 01:34 |
| Eva-i | flwang: it needs to be fixed | 01:34 |
| flwang | bug report needs to be fixed, or the bug? :) | 01:35 |
| Eva-i | flwang: both =) | 01:35 |
| flwang | hah, ok | 01:35 |
| *** david-lyle has quit IRC | 01:36 | |
| Eva-i | flwang: okay, bug is fixed: https://bugs.launchpad.net/python-zaqarclient/+bug/1538366 you can now confirm this bug | 01:46 |
| openstack | Launchpad bug 1538366 in Python client library for Zaqar "Subscriptions listing does not work" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 01:46 |
| Eva-i | *bug report is fixed | 01:46 |
| flwang | reading... | 01:48 |
| *** achanda has quit IRC | 01:50 | |
| flwang | Eva-i: ah, i understand the issue, are we missing a test for 1538366? | 01:50 |
| *** Qiming has quit IRC | 01:53 | |
| Eva-i | flwang: we don't miss a test for 1538366, we just have bad unit test and incomplete functional test for subscription listing. | 01:55 |
| flwang | blame me then ;) | 01:58 |
| openstackgerrit | Merged openstack/python-zaqarclient: Fix Subscription's queue_name variable being tuple https://review.openstack.org/272859 | 01:59 |
| flwang | Eva-i: i'm reading the bug description you updated on bug https://bugs.launchpad.net/python-zaqarclient/+bug/1534427 | 02:15 |
| openstack | Launchpad bug 1534427 in Python client library for Zaqar "Some queue CLI operations don't work for v1.1 and above" [Medium,In progress] - Assigned to Fei Long Wang (flwang) | 02:15 |
| Eva-i | flwang: I'm investigated further and updating it again.. | 02:16 |
| flwang | Eva-i: you added metadata operations, right? | 02:16 |
| Eva-i | flwang: ah, this bug | 02:16 |
| flwang | but we do not support the two operations for v1.1 and v2 | 02:16 |
| flwang | so am i missing anything? | 02:16 |
| flwang | in other words, i don't think it's bug for setmetdata and get metdata | 02:17 |
| Eva-i | flwang: you're right, Fei Long. :o | 02:17 |
| Eva-i | flwang: I'll fix the bug report then | 02:18 |
| flwang | :) good | 02:18 |
| Eva-i | flwang: fixed | 02:19 |
| flwang | cool, thanks | 02:19 |
| *** Qiming has joined #openstack-zaqar | 02:22 | |
| flwang | Eva-i: so could you pls review this https://review.openstack.org/#/c/267923/ ? | 02:24 |
| flwang | based on above discussion | 02:24 |
| Eva-i | flwang: oki, I'll review it. BTW I updated my https://bugs.launchpad.net/python-zaqarclient/+bug/1538366 bug report. See the problem 1 - it seems minor, but actually great. =) | 02:40 |
| openstack | Launchpad bug 1538366 in Python client library for Zaqar "Subscriptions listing does not work" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 02:40 |
| Eva-i | mdnadeem: hello | 02:48 |
| Eva-i | mdnadeem: I haven't seen you in a while. Are you okay? =) | 02:50 |
| *** flwang has quit IRC | 02:50 | |
| *** achanda has joined #openstack-zaqar | 02:56 | |
| *** pradk has quit IRC | 02:59 | |
| *** flwang has joined #openstack-zaqar | 03:04 | |
| flwang | Eva-i: just lost connection | 03:08 |
| *** pradk has joined #openstack-zaqar | 03:12 | |
| Eva-i | flwang: you or mdnadeem lost connection? | 03:23 |
| openstackgerrit | Merged openstack/zaqar: Updated from global requirements https://review.openstack.org/272835 | 03:35 |
| flwang | Eva-i: did you see my msg about #1538366? | 03:37 |
| Eva-i | flwang: I think I haven't seen it | 03:37 |
| flwang | (15:46:17) flwang: Eva-i: as for bug #1538366, i don't really understand the problem 1 and 3 | 03:38 |
| openstack | bug 1538366 in Python client library for Zaqar "Subscriptions listing is not written good and causes many potential and real problems." [Undecided,New] https://launchpad.net/bugs/1538366 - Assigned to Eva Balycheva (ubershy) | 03:38 |
| flwang | (15:47:21) flwang: i added the queue name like this https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/queues/v2/client.py#L80 | 03:38 |
| flwang | (15:47:31) flwang: so why you still see the problem 2? | 03:38 |
| flwang | (15:47:54) flwang: Eva-i: i must miss something, pls remind me :) | 03:38 |
| flwang | Eva-i: thanks for the doc patch | 03:39 |
| Eva-i | flwang: because you haven't added the same in the Queue.subscriptions method. Have you tested your patch? | 03:40 |
| Eva-i | flwang: but I'm against adding the same to the Queue.subscriptions method. I think it's not good. | 03:40 |
| Eva-i | flwang: instead it's better to remove this from Client.subscriptions and modify this function https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/queues/v2/subscription.py#L78 | 03:43 |
| flwang | Eva-i: which patch? | 03:44 |
| flwang | i'm a little bit confused | 03:44 |
| flwang | Eva-i: anyway, i will look forward your fix | 03:46 |
| Eva-i | flwang: I'll make a new patch solving the bug https://launchpad.net/bugs/1538366 and fixing tests. Then you will rebase your patch https://review.openstack.org/#/c/269398/ into it. | 03:48 |
| openstack | Launchpad bug 1538366 in Python client library for Zaqar "Subscriptions listing is not written good and causes many potential and real problems." [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 03:48 |
| flwang | Eva-i: ok, sounds a good plan | 03:49 |
| Eva-i | flwang: oki, I'll propose a fix, you'll see if it makes things better, then you may confirm the bug report | 03:49 |
| flwang | Eva-i: cool | 03:50 |
| *** Qiming has quit IRC | 03:54 | |
| mdnadeem | Eva-i, Hi All is well , glad to hear from you :) | 04:02 |
| mdnadeem | flwang, Your demo plan is good, Please let me know if i can help in anyway | 04:03 |
| *** flwang1 has quit IRC | 04:04 | |
| Eva-i | mdnadeem: that's nice, I'm glad to see you too in chat | 04:10 |
| mdnadeem | Eva-i , :) | 04:11 |
| *** Qiming has joined #openstack-zaqar | 04:14 | |
| *** david-lyle has joined #openstack-zaqar | 04:25 | |
| *** david-lyle has quit IRC | 04:25 | |
| *** sriram has joined #openstack-zaqar | 04:35 | |
| *** david-lyle has joined #openstack-zaqar | 04:38 | |
| *** sriram has quit IRC | 04:45 | |
| openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: Improve subscription listing https://review.openstack.org/272909 | 05:40 |
| *** flwang has quit IRC | 06:22 | |
| *** flwang has joined #openstack-zaqar | 06:23 | |
| *** Qiming has quit IRC | 06:45 | |
| *** Qiming has joined #openstack-zaqar | 06:46 | |
| *** Qiming has quit IRC | 06:54 | |
| *** exploreshaifali has joined #openstack-zaqar | 07:06 | |
| *** Qiming has joined #openstack-zaqar | 07:19 | |
| *** rcernin has joined #openstack-zaqar | 07:27 | |
| *** Qiming has quit IRC | 07:32 | |
| *** Qiming has joined #openstack-zaqar | 07:56 | |
| *** Qiming has quit IRC | 08:05 | |
| *** exploreshaifali has quit IRC | 08:07 | |
| *** Qiming has joined #openstack-zaqar | 08:07 | |
| *** Qiming has quit IRC | 08:27 | |
| *** Qiming has joined #openstack-zaqar | 08:28 | |
| *** achanda has quit IRC | 09:14 | |
| *** dynarro has joined #openstack-zaqar | 09:20 | |
| *** eliqiao has quit IRC | 10:06 | |
| *** eliqiao has joined #openstack-zaqar | 10:06 | |
| *** dynarro has quit IRC | 10:19 | |
| *** exploreshaifali has joined #openstack-zaqar | 11:26 | |
| *** pcaruana has joined #openstack-zaqar | 11:44 | |
| *** exploreshaifali has quit IRC | 12:16 | |
| *** pcaruana has quit IRC | 12:37 | |
| *** david-lyle has quit IRC | 13:08 | |
| *** sriram has joined #openstack-zaqar | 14:05 | |
| *** mdnadeem has quit IRC | 14:06 | |
| *** david-lyle has joined #openstack-zaqar | 14:17 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:22 | |
| *** david-lyle has quit IRC | 14:44 | |
| *** mpanetta has joined #openstack-zaqar | 14:51 | |
| *** ametts has joined #openstack-zaqar | 14:51 | |
| *** pradk_ has joined #openstack-zaqar | 14:56 | |
| *** kgriffs|afk is now known as kgriffs | 15:16 | |
| *** Qiming has quit IRC | 15:18 | |
| EmilienM | do you guys plan to make progress on puppet-zaqar? | 15:25 |
| EmilienM | flaper87, jasondotstar ^ | 15:25 |
| jasondotstar | EmilienM: yes. sorry I got busy over the last couple days :-( | 15:26 |
| EmilienM | I'm asking about the last months actually | 15:27 |
| EmilienM | this work has been in progress for months and I don't see much progress, just asking what's going on | 15:27 |
| jasondotstar | EmilienM: understood. it's been lingering | 15:27 |
| jasondotstar | can i work directly with you on getting the a new patch pushed | 15:28 |
| jasondotstar | ? | 15:28 |
| jasondotstar | I wanted to start with the rpm_based install as one change | 15:28 |
| jasondotstar | then the deb_based install in another. | 15:28 |
| jasondotstar | instead of what I've got up there now | 15:28 |
| jasondotstar | which has merge conflicts :-( | 15:28 |
| jasondotstar | EmilienM: ^ | 15:29 |
| jasondotstar | if that's unsatisfactory, lmk. | 15:29 |
| EmilienM | forget about ubuntu now, if that's your concern | 15:29 |
| EmilienM | we have recent zaqar packaging in RDO | 15:29 |
| EmilienM | let's use it | 15:29 |
| jasondotstar | EmilienM: that's what I ran into | 15:30 |
| EmilienM | I can definitly help, I just need to know where we are | 15:30 |
| EmilienM | dprince is also willing to help | 15:30 |
| jasondotstar | EmilienM: ok | 15:30 |
| jasondotstar | take a look at my change with the merge conflick | 15:30 |
| EmilienM | jasondotstar: what is the problem? | 15:32 |
| EmilienM | you'll need to rebase | 15:32 |
| jasondotstar | EmilienM: sure. | 15:32 |
| EmilienM | we use to iterate when writting a puppet module | 15:32 |
| EmilienM | small chuncks | 15:32 |
| EmilienM | a patch for zaqar::client | 15:32 |
| EmilienM | another for zaqar::api | 15:32 |
| jasondotstar | k | 15:32 |
| jasondotstar | k | 15:32 |
| EmilienM | etc | 15:32 |
| EmilienM | each patch with manifest & tests & doc | 15:32 |
| jasondotstar | k | 15:32 |
| jasondotstar | that's useful info | 15:32 |
| EmilienM | and good commit messages | 15:32 |
| jasondotstar | i just wanted you to look at what I've got so far | 15:33 |
| EmilienM | because "continuing work on the initial pass of the zaqar module." is not valid to me | 15:33 |
| jasondotstar | I'll rebase and correct it . | 15:33 |
| jasondotstar | EmilienM: understood. it's not a good commit msg. | 15:33 |
| jasondotstar | another reason i wanted to abandon the changes out there and correct it. | 15:33 |
| jasondotstar | however- you asked about progress | 15:34 |
| *** csoukup has joined #openstack-zaqar | 15:34 | |
| jasondotstar | looking at what's out there now is the best way to see it atm. | 15:34 |
| jasondotstar | I'll ping dprince | 15:36 |
| *** ametts has quit IRC | 15:42 | |
| *** rcernin has quit IRC | 16:09 | |
| *** david-lyle has joined #openstack-zaqar | 16:14 | |
| *** malini has joined #openstack-zaqar | 16:25 | |
| *** malini1 has joined #openstack-zaqar | 16:26 | |
| *** malini has quit IRC | 16:30 | |
| *** david-lyle has quit IRC | 16:38 | |
| *** david-lyle has joined #openstack-zaqar | 16:40 | |
| *** sriram has quit IRC | 16:49 | |
| *** flwang1 has joined #openstack-zaqar | 17:19 | |
| *** sriram has joined #openstack-zaqar | 17:20 | |
| *** sriram has quit IRC | 17:20 | |
| *** sriram has joined #openstack-zaqar | 17:21 | |
| *** flwang1 has quit IRC | 17:33 | |
| *** flwang1 has joined #openstack-zaqar | 17:35 | |
| *** flwang1 has quit IRC | 17:53 | |
| *** achanda has joined #openstack-zaqar | 17:59 | |
| *** rcernin has joined #openstack-zaqar | 17:59 | |
| *** achanda has quit IRC | 18:24 | |
| *** malini1 has quit IRC | 18:30 | |
| openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: Improve subscription listing https://review.openstack.org/272909 | 18:31 |
| *** achanda has joined #openstack-zaqar | 18:33 | |
| openstackgerrit | Eva Balycheva proposed openstack/python-zaqarclient: Improve subscription listing https://review.openstack.org/272909 | 18:33 |
| *** ametts has joined #openstack-zaqar | 18:39 | |
| *** malini has joined #openstack-zaqar | 18:40 | |
| *** malini1 has joined #openstack-zaqar | 18:42 | |
| *** malini has quit IRC | 18:45 | |
| *** mpanetta has quit IRC | 18:57 | |
| openstackgerrit | Merged openstack/zaqar: Fix zaqar-bench auth method detection https://review.openstack.org/268864 | 19:01 |
| flaper87 | Do we still need zaqar-bench? | 19:01 |
| flaper87 | It feels weird to still have it around | 19:01 |
| flaper87 | I'd rather try to use some other (existing) bench tool | 19:01 |
| flaper87 | (just random thought, keep going) | 19:01 |
| *** malini1 has quit IRC | 19:05 | |
| *** mpanetta has joined #openstack-zaqar | 19:07 | |
| *** csoukup has quit IRC | 19:08 | |
| *** boris-42 has quit IRC | 19:13 | |
| sriram | brb | 19:22 |
| *** csoukup has joined #openstack-zaqar | 19:28 | |
| *** malini has joined #openstack-zaqar | 19:29 | |
| *** malini1 has joined #openstack-zaqar | 19:31 | |
| *** malini has quit IRC | 19:33 | |
| *** barra204 has quit IRC | 20:06 | |
| *** mpanetta has quit IRC | 20:13 | |
| flwang | flaper87: what's the fallback to keep it ? | 20:35 |
| Eva-i | flwang: maybe because if requires some support from time to time, for example, when we change python-zaqarclient api in incompatible way. | 20:42 |
| flwang | Eva-i: sorry? what's the topic you're talking? | 20:43 |
| Eva-i | flwang: I'm talking about zaqar-bench | 20:43 |
| flwang | Eva-i: maybe a 'contrib' package suits it | 20:44 |
| *** malini1 has quit IRC | 20:52 | |
| *** rcernin has quit IRC | 21:16 | |
| *** flwang1 has joined #openstack-zaqar | 21:18 | |
| ryansb | flwang: tossed that demo together, btw | 21:42 |
| ryansb | https://github.com/ryansb/zaqar-webscraper-demo | 21:42 |
| flwang | ryansb: can you tell me the secret why you hand is so quick? | 21:45 |
| ryansb | heh, practice ;) it's a pretty small demo, all the python together is only 130 lines | 21:46 |
| flwang | reviewing the code | 21:47 |
| ryansb | it's just a first pass, but it's got all the basic elements. You can have as many consumer.py workers as you want, and they feed URLs back to the deduplicator to make sure the same work never gets done twice | 21:48 |
| *** ametts has quit IRC | 21:53 | |
| Eva-i | ryansb: hello, I'll check it out too =) | 21:54 |
| ryansb | for my personal site (90 unique pages, very dense web of links) it takes about 3.5 minutes | 21:54 |
| ryansb | with 4 workers (instead of 1) it takes 2 minutes | 21:54 |
| flwang | ryansb: awesome, sorry was in a chat with the horizon guy | 21:56 |
| flwang | just had a quick look | 21:56 |
| ryansb | no worries | 21:56 |
| flwang | it looks nice | 21:57 |
| flwang | ryansb: sqlite is never used, right? | 22:02 |
| ryansb | not yet. I was thinking about using it to dedup messages in the dedup worker | 22:02 |
| ryansb | but I didn't end up writing it that way. I dedup URLs using a dictionary instead | 22:03 |
| flwang | so the app is most like a crawler, right? input an URL and it will grab all the urls and save/handle them, is it? | 22:04 |
| ryansb | Yeah, exactly | 22:04 |
| ryansb | right now it just writes scraped URLs to the "completed" queue | 22:05 |
| ryansb | err, topic | 22:05 |
| ryansb | so there's no saving right now. It just grabs all the URLs and writes a deduplicated list of them to "completed" | 22:05 |
| flwang | ryansb: yep, i see | 22:09 |
| ryansb | if you have suggestions & such, feel free to open them as issues | 22:11 |
| ryansb | I still need to write instructions on how to run it | 22:11 |
| ryansb | and an explanation of wtf it is | 22:12 |
| ryansb | y'know, little stuff | 22:12 |
| ryansb | ;) | 22:12 |
| flwang | hah, sure, thanks for the effort | 22:22 |
| ryansb | np. I'll do a second pass soon. | 22:28 |
| Eva-i | flwang: I know my previous bug report wasn't very cool, but now I'm preparing bug reports with some nice bugs. =) | 22:30 |
| flwang | Eva-i: cool bug means critical issue? | 22:31 |
| Eva-i | flwang: no, critial issue is ubercool bug. | 22:32 |
| Eva-i | flwang: should I not report so many bugs? | 22:32 |
| *** sriram has quit IRC | 22:34 | |
| flwang | no no no | 22:36 |
| flwang | Eva-i: feel free to open bug if you think it's a bug | 22:36 |
| flwang | it's always welcomed | 22:36 |
| Eva-i | flwang: oki | 22:37 |
| *** amitgandhinz has quit IRC | 22:54 | |
| *** c_soukup has joined #openstack-zaqar | 23:00 | |
| *** csoukup has quit IRC | 23:03 | |
| Eva-i | flwang: can you please confirm this bug we discussed on meeting: https://bugs.launchpad.net/zaqar/+bug/1535811 | 23:33 |
| openstack | Launchpad bug 1535811 in zaqar "Notifications must include queue name and message id" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 23:33 |
| Eva-i | flwang: also here are bugs reports I promised today: https://bugs.launchpad.net/python-zaqarclient/+bug/1538794 https://bugs.launchpad.net/python-zaqarclient/+bug/1538795. Sorry, but they are about websocket transport. =) | 23:36 |
| openstack | Launchpad bug 1538794 in Python client library for Zaqar "Websocket: zaqar.common.api.utils.raises_conn_error decorator passes None as request" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 23:36 |
| openstack | Launchpad bug 1538795 in Python client library for Zaqar "Websocket: NoPoolsFound exception is catched outside endpoints.py on queue list" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 23:36 |
| *** malini has joined #openstack-zaqar | 23:41 | |
| *** c_soukup has quit IRC | 23:44 | |
| *** Qiming has joined #openstack-zaqar | 23:56 | |
| *** pradk_ has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!