| *** malini has joined #openstack-zaqar | 00:09 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: (WIP) Fix freeze on some requests https://review.openstack.org/284897 | 00:10 |
|---|---|---|
| ryansb | flwang: that covers everything I wanted - maybe combine delayed & dead letter topics into one | 00:13 |
| flwang | ryansb: thanks for the feedback | 00:13 |
| Eva-i | flwang: in lazy-queues-in-subscription spec you said "I would like to see test section.". Do you mean you would like me to add information about tests in Work items? | 00:16 |
| flwang | Eva-i: yep | 00:23 |
| flwang | Eva-i: and let's move it to Newton, since we don't have enough time to do it in M | 00:24 |
| Eva-i | flwang: alright | 00:24 |
| Eva-i | flwang: please check PM I sent to you | 00:27 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Add description to 404 and 409 error responses https://review.openstack.org/284437 | 00:30 |
| flwang | Eva-i: i saw that, i will give it a try and decide if it's security issue, thanks for raising that | 00:33 |
| *** malini has quit IRC | 00:38 | |
| *** amitgandhinz has joined #openstack-zaqar | 00:44 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Add `_max_messages_post_size` and `_default_message_ttl` for queue https://review.openstack.org/265723 | 00:52 |
| *** amitgandhinz has quit IRC | 00:58 | |
| * flwang is going to delete image : careers-dev1-root based on the request from Careers NZ | 01:05 | |
| flwang | wow, 500 error | 01:06 |
| flwang | wrong channel :( | 01:06 |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/283621 | 01:45 |
| *** mpanetta has joined #openstack-zaqar | 01:52 | |
| *** amitgandhinz has joined #openstack-zaqar | 01:55 | |
| *** mpanetta has quit IRC | 01:56 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Add tempest test for wsgi v2 https://review.openstack.org/284016 | 01:59 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Add tempest test for wsgi v2 https://review.openstack.org/284016 | 02:05 |
| *** csoukup has joined #openstack-zaqar | 02:05 | |
| *** amitgandhinz has quit IRC | 02:08 | |
| *** csoukup has quit IRC | 02:09 | |
| flwang | wxy: Eva-i: around? | 02:13 |
| flwang | need to know your comments on the TTL subscription of redis | 02:14 |
| wxy | flwang: I'm here. | 02:14 |
| flwang | i'm picking the ttl subscription issue again | 02:15 |
| flwang | but seems there is no good way for the subscriber set | 02:15 |
| flwang | we can clear the subscription by expire(), but we need a way to clean subscription id and subscriber as well | 02:17 |
| openstackgerrit | Thai Tran proposed openstack/zaqar-ui: WIP Ability to delete queues https://review.openstack.org/285083 | 02:17 |
| wxy | You said the lua can help us. | 02:18 |
| flwang | lua can help clean the subscription id | 02:18 |
| flwang | but it's hard to handle the subscriber | 02:19 |
| flwang | see line 134-137 https://review.openstack.org/#/c/276548/2/zaqar/storage/redis/subscriptions.py | 02:19 |
| flwang | 1. add the 'subscriber' into a set, to make sure it's unique in this queue-project | 02:21 |
| flwang | 2. add subscription id into a sorted set | 02:21 |
| flwang | 3. add the subscription into hash | 02:22 |
| flwang | expires() can resolve the #2 | 02:22 |
| flwang | s/#2/#3 | 02:22 |
| flwang | lua can resolve #2 by cleaning the sorted set regularly | 02:22 |
| flwang | but i don't have a good way to clean #1, maybe we should use a different data structure | 02:23 |
| wxy | Does lua has a funtion like "srem"? | 02:23 |
| flwang | lua is a script | 02:23 |
| flwang | we can write a script with it to talk with redis directly | 02:23 |
| flwang | but it's hard to know in a set, which one is out of date | 02:24 |
| wxy | I see it use redis.call() | 02:26 |
| wxy | can we pass the member_key and subscriber to lua, then lua call redis to delete it ? | 02:26 |
| wxy | redis.call('SREM', member_key , subscriber ) | 02:29 |
| flwang | wxy: we can, but when? | 02:38 |
| flwang | since there is a race condition issue | 02:38 |
| flwang | the lua script has to be called regularly | 02:38 |
| flwang | so before we clean it, another user may failed because duplicated subscriber | 02:39 |
| wxy | Is there a way that the lua could be called once the subscription is expired? | 02:42 |
| flwang | wxy: i don't know TBH | 02:47 |
| flwang | i don't think redis can know where to call your script | 02:48 |
| flwang | for a specific db/set | 02:48 |
| flwang | it's hard IMHO | 02:48 |
| flwang | that's why i'm thinking if we should change the type of subscriber's container from set to sorted_set to let the 'score' save the expire time | 02:49 |
| flwang | so that we can have a script to do the clean, even we can do the clean in zaqar before we find a good way to do that | 02:50 |
| wxy | another way is to use callback mechanism in redis, we could catch EXPIRED event, then do the clean up. | 02:54 |
| *** wanghao has quit IRC | 02:54 | |
| wxy | But not sure it's the best way. | 02:54 |
| *** wanghao has joined #openstack-zaqar | 02:55 | |
| wxy | if we change the data structure like you said, I think we need a bp to do this. | 02:56 |
| flwang1 | wxy: it won't change too much i hope, and i wish we can get it done in Mitaka | 02:57 |
| flwang1 | and i don't think a bp can help anything | 02:58 |
| flwang1 | the problem is clear, we just need to figure out a way to do that | 02:58 |
| flwang1 | wxy: or this way http://stackoverflow.com/questions/16741476/redis-session-expiration-and-reverse-lookup/16747795#16747795 | 03:02 |
| flwang1 | wxy: but it still has the race condition issue | 03:03 |
| *** amitgandhinz has joined #openstack-zaqar | 03:04 | |
| wxy | yes, daemon can't ensure timeliness. | 03:05 |
| flwang | wxy: and i'm thinking if we can totally remove subscriber set | 03:14 |
| flwang | we may lose some performance for querying the subscriber, but it should be fine since it's it's a create, we don't really care about the performance | 03:14 |
| *** amitgandhinz has quit IRC | 03:18 | |
| *** boris-42 has quit IRC | 03:24 | |
| wxy | it's a way. | 03:33 |
| wxy | flwang: or the callback i said before: http://redis.io/topics/notifications | 03:33 |
| *** csoukup has joined #openstack-zaqar | 03:35 | |
| flwang | wxy: it's cool, but after a quick glance, i didn't see how to write the event handler | 03:39 |
| wxy | http://stackoverflow.com/questions/23964548/notification-of-key-expiration-in-redis-python | 03:41 |
| flwang | wxy: it looks good | 03:45 |
| flwang | wxy: but it said | 03:47 |
| flwang | the callback is called when the line is executed, not after 5 seconds | 03:47 |
| wxy | He should lisen EXPIRED, not EXPIRE | 03:48 |
| wxy | IMO | 03:49 |
| flwang | wxy: i can't see EXPIRED in the list http://redis.io/topics/notifications | 03:49 |
| flwang | EXPIRE generates an expire event when an expire is set to the key, or a expired event every time setting an expire results into the key being deleted (see EXPIRE documentation for more info). | 03:50 |
| flwang | seems in the callback function, we need to check if the expired time is meet or not? | 03:50 |
| flwang | i have to run to pick up my son, pls leave your comment on the patch, we can discuss there, thanks a lot | 03:52 |
| flwang | wxy: ttyl | 03:53 |
| wxy | i got the 'expired' from the test in http://stackoverflow.com/questions/23964548/notification-of-key-expiration-in-redis-python | 03:53 |
| wxy | but i didn't have a try. | 03:53 |
| *** flwang1 has quit IRC | 03:54 | |
| wxy | sure, I'd like to see it works. | 03:54 |
| *** amitgandhinz has joined #openstack-zaqar | 04:14 | |
| *** amitgandhinz has quit IRC | 04:27 | |
| *** amitgandhinz has joined #openstack-zaqar | 05:24 | |
| *** amitgandhinz has quit IRC | 05:38 | |
| *** wanghao has quit IRC | 06:05 | |
| *** wanghao has joined #openstack-zaqar | 06:06 | |
| *** wanghao has quit IRC | 06:07 | |
| *** wanghao has joined #openstack-zaqar | 06:08 | |
| *** amitgandhinz has joined #openstack-zaqar | 06:34 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Add tempest test for wsgi v2 https://review.openstack.org/284016 | 06:41 |
| *** amitgandhinz has quit IRC | 06:47 | |
| *** rcernin has joined #openstack-zaqar | 07:05 | |
| *** amitgandhinz has joined #openstack-zaqar | 07:44 | |
| *** jtomasek has joined #openstack-zaqar | 07:52 | |
| *** amitgandhinz has quit IRC | 07:58 | |
| *** csoukup has quit IRC | 08:06 | |
| *** achanda has quit IRC | 08:29 | |
| *** achanda has joined #openstack-zaqar | 08:33 | |
| *** therve has joined #openstack-zaqar | 08:36 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar-specs: Make queues lazy in subscriptions https://review.openstack.org/284180 | 08:51 |
| *** amitgandhinz has joined #openstack-zaqar | 08:54 | |
| *** achanda has quit IRC | 09:03 | |
| *** amitgandhinz has quit IRC | 09:07 | |
| *** rcernin has quit IRC | 09:14 | |
| *** rcernin has joined #openstack-zaqar | 09:28 | |
| *** wanghao has quit IRC | 09:35 | |
| *** wanghao has joined #openstack-zaqar | 09:35 | |
| *** amitgandhinz has joined #openstack-zaqar | 10:04 | |
| *** amitgandhinz has quit IRC | 10:17 | |
| openstackgerrit | wanghao proposed openstack/zaqar-specs: Confirm subscriber befor send messages https://review.openstack.org/284555 | 10:32 |
| *** achanda has joined #openstack-zaqar | 10:33 | |
| *** flwang1 has joined #openstack-zaqar | 10:36 | |
| *** achanda has quit IRC | 10:38 | |
| *** csoukup has joined #openstack-zaqar | 11:02 | |
| *** amitgandhinz has joined #openstack-zaqar | 11:14 | |
| *** amitgandhinz has quit IRC | 11:27 | |
| *** achanda has joined #openstack-zaqar | 11:35 | |
| *** achanda has quit IRC | 11:39 | |
| *** eliqiao_ is now known as eliqiao | 12:17 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:24 | |
| *** amitgandhinz has quit IRC | 12:37 | |
| Eva-i | flwang: hello. I saw your review. If you want I can quickly edit how requests are logged in websocket transport, just say how you would like them to be. I mean really quick. | 12:46 |
| Eva-i | flwang: okay, we can keep it like this. I'll be happy. | 12:50 |
| *** flwang1 has quit IRC | 12:54 | |
| *** itisha has joined #openstack-zaqar | 13:15 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:34 | |
| *** achanda has joined #openstack-zaqar | 13:37 | |
| *** dynarro has joined #openstack-zaqar | 13:38 | |
| *** achanda has quit IRC | 13:42 | |
| *** amitgandhinz has quit IRC | 13:47 | |
| *** malini has joined #openstack-zaqar | 13:47 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:48 | |
| *** dynarro has quit IRC | 13:48 | |
| *** amitgandhinz has quit IRC | 13:50 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:50 | |
| *** malini has quit IRC | 14:10 | |
| *** godlike has quit IRC | 14:11 | |
| *** godlike has joined #openstack-zaqar | 14:11 | |
| *** sriram has joined #openstack-zaqar | 14:19 | |
| *** sriram has quit IRC | 14:19 | |
| *** sriram has joined #openstack-zaqar | 14:19 | |
| *** dynarro has joined #openstack-zaqar | 14:34 | |
| *** achanda has joined #openstack-zaqar | 15:24 | |
| *** dynarro has quit IRC | 15:26 | |
| *** achanda has quit IRC | 15:51 | |
| *** sriram has quit IRC | 16:03 | |
| *** mpanetta has joined #openstack-zaqar | 16:16 | |
| *** mpanetta has quit IRC | 16:23 | |
| *** rcernin has quit IRC | 16:31 | |
| *** csoukup has quit IRC | 16:37 | |
| *** csoukup has joined #openstack-zaqar | 16:53 | |
| *** achanda has joined #openstack-zaqar | 17:10 | |
| *** AAzza_ has joined #openstack-zaqar | 17:12 | |
| *** mpanetta has joined #openstack-zaqar | 17:18 | |
| *** mpanetta has quit IRC | 17:18 | |
| *** AAzza has quit IRC | 17:20 | |
| *** AAzza_ is now known as AAzza | 17:20 | |
| *** sriram has joined #openstack-zaqar | 17:33 | |
| *** pt_15 has joined #openstack-zaqar | 18:08 | |
| *** malini has joined #openstack-zaqar | 18:16 | |
| *** malini1 has joined #openstack-zaqar | 18:18 | |
| *** malini has quit IRC | 18:20 | |
| *** achanda has quit IRC | 18:51 | |
| *** achanda has joined #openstack-zaqar | 18:55 | |
| *** malini1 has quit IRC | 19:08 | |
| *** malini has joined #openstack-zaqar | 19:25 | |
| *** malini1 has joined #openstack-zaqar | 19:27 | |
| *** malini has quit IRC | 19:30 | |
| openstackgerrit | Thai Tran proposed openstack/zaqar-ui: Ability to delete queues https://review.openstack.org/285083 | 19:35 |
| *** sriram has quit IRC | 20:08 | |
| *** itisha has quit IRC | 20:09 | |
| *** malini1 has quit IRC | 20:14 | |
| *** malini has joined #openstack-zaqar | 20:14 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Fix validation in websocket unit tests https://review.openstack.org/283838 | 20:33 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Fix validation in websocket unit tests https://review.openstack.org/283838 | 20:36 |
| david_cu | Eva-i hello ping | 20:38 |
| Eva-i | david_cu: hello | 20:38 |
| david_cu | a few weeks back you sent me these curl scripts for subscriptions, just have a question about one http://paste.openstack.org/show/mzEr6SrjjcpEfWx6kTeM/ | 20:39 |
| Eva-i | david_cu: sure, what's the question? | 20:39 |
| david_cu | how does one get the ZAQAR_CLIENT_ID | 20:39 |
| Eva-i | david_cu: here: http://paste.openstack.org/show/rnfSctG4zGivGxPbm9pD/ | 20:40 |
| david_cu | i see so it's just a uuid you create, it doesn't come from keystone or something? | 20:41 |
| Eva-i | david_cu: yes, it doesn't come from keystone. | 20:41 |
| david_cu | great, thanks for clearing that up for me :) | 20:41 |
| Eva-i | david_cu: no problem ;) | 20:41 |
| Eva-i | david_cu: also, if Zaqar is configured to use keystone auth, "X-PROJECT-ID" header is not needed in requests. Valid "X-Auth-Token" header is enough. | 20:44 |
| *** achanda has quit IRC | 20:45 | |
| david_cu | i don't think i configured it for that actually, how would i go about doing that? in zaqar.conf? | 20:47 |
| Eva-i | david_cu: yes, in zaqar.conf. If zaqar is part of DevStack, it is already configured to use auth_strategy = keystone. Also for more information you can look here: http://docs.openstack.org/draft/config-reference/messaging/zaqar-authentication.html | 20:51 |
| david_cu | awesome, i'll check this out, greatly appreciated | 20:54 |
| *** fesp has joined #openstack-zaqar | 20:58 | |
| *** pt_15 has quit IRC | 21:15 | |
| *** fesp has quit IRC | 21:37 | |
| *** fesp has joined #openstack-zaqar | 21:39 | |
| ryansb | Eva-i: I can't get your websockets patch to work in devstack presently | 21:39 |
| ryansb | do I need to do special things to enable CORS in keystone, and if so is there a doc I should look at? | 21:40 |
| Eva-i | ryansb: yes, you need to enable CORS in keystone. I let me provide you a link | 21:41 |
| Eva-i | ryansb: https://ask.openstack.org/en/question/86759/zaqar-server-issue/?answer=87222#post-id-87222. Read after "Or If you still want to use Zaqar Websocket API:". | 21:43 |
| Eva-i | ryansb: or you can just disable keystone auth devstack's zaqar.conf. | 21:44 |
| *** malini has quit IRC | 21:52 | |
| ryansb | thanks, worked great | 21:52 |
| *** ksheedlo-rax is now known as ksheedlo | 21:56 | |
| ryansb | bam, let there be binary websockets | 21:58 |
| Eva-i | ryansb: woow, nice =) | 22:24 |
| *** jtomasek has quit IRC | 22:54 | |
| openstackgerrit | David Cusatis proposed openstack/zaqar-ui: Add Subscriptions to Queue drawer https://review.openstack.org/284921 | 22:58 |
| *** fesp has quit IRC | 22:59 | |
| *** wanghao has quit IRC | 23:08 | |
| *** wanghao has joined #openstack-zaqar | 23:09 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!