| *** GB21 has quit IRC | 00:13 | |
| *** ametts has quit IRC | 00:21 | |
| *** wanghao_ has joined #openstack-zaqar | 00:51 | |
| *** kgriffs is now known as kgriffs|afk | 00:54 | |
| wanghao_ | flwang: hi | 01:08 |
|---|---|---|
| wanghao_ | flwang: the patch(https://review.openstack.org/#/c/286433/) depends on this one to let jekins pass, I added depends-on in that. | 01:08 |
| wanghao_ | So I feel we didn't need to add depens-on in https://review.openstack.org/#/c/287114/2. | 01:09 |
| flwang | wanghao_: ah, ok | 01:10 |
| *** shu-mutou-OFF is now known as shu-mutou | 01:22 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Forbid update subscription to duplicate in Redis https://review.openstack.org/279946 | 01:59 |
| *** kgriffs|afk is now known as kgriffs | 02:11 | |
| *** pt_15 has quit IRC | 02:25 | |
| *** itisha has quit IRC | 02:29 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Renew subscription on update with TTL in Redis https://review.openstack.org/289665 | 02:40 |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Fix the get/set queue metadata https://review.openstack.org/289179 | 03:05 |
| Eva-i | flwang: so I want to fix two bugs for mongodb driver. Same bugs as wangxiyuan is currently fixing for Redis. I noticed, for example, that my 409 error patch shares much code with wangxiyuan's 409 error patch. It means my patches depend on his patches. | 03:33 |
| Eva-i | flwang: maybe I should not post my patches, but ask wangxiyuan to make his patches solve problems for both mongodb and redis drivers(I can share my code for mongodb and add myself as co-author)? For example, see new test case for Redis he wrote: https://review.openstack.org/#/c/279946/6/zaqar/tests/unit/storage/test_impl_redis.py@447. This test case should be in base.SubscriptionControllerTest, but he can't put it there, because mongo is still | 03:39 |
| *** kgriffs is now known as kgriffs|afk | 03:41 | |
| flwang | Eva-i: sure, you can cowork with him | 03:43 |
| flwang | do whatever you think it's correct :) | 03:43 |
| Eva-i | flwang: oki! | 03:43 |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Fix the get/set queue metadata https://review.openstack.org/289179 | 03:46 |
| flwang | Eva-i: thank you! | 03:50 |
| *** wxy has joined #openstack-zaqar | 03:52 | |
| Eva-i | flwang: great, he agreed! =) | 04:05 |
| wxy | sorry guys ,l'm away on a business travel this week. can not always in irc | 04:23 |
| wxy | if the patch has to be updated, feel free to do it. Thanks. | 04:26 |
| Eva-i | wxy: sure, happy travelling | 04:38 |
| shu-mutou | flwang: I'd like to confirm about metadata of queue. | 05:11 |
| *** boris-42 has quit IRC | 05:54 | |
| *** shakamunyi has quit IRC | 06:02 | |
| *** rcernin has joined #openstack-zaqar | 06:02 | |
| *** shu-mutou is now known as shu-mutou-AFK | 06:21 | |
| *** david-lyle has quit IRC | 06:44 | |
| *** david-lyle_ has joined #openstack-zaqar | 06:44 | |
| *** jtomasek has joined #openstack-zaqar | 06:49 | |
| *** pcaruana has quit IRC | 06:57 | |
| *** openstackgerrit has quit IRC | 10:33 | |
| *** openstackgerrit has joined #openstack-zaqar | 10:33 | |
| *** wxy has quit IRC | 11:29 | |
| *** itisha has joined #openstack-zaqar | 11:31 | |
| *** wanghao_ has quit IRC | 11:37 | |
| *** wxy has joined #openstack-zaqar | 11:39 | |
| *** davideagnello has quit IRC | 12:03 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:00 | |
| *** pt_15 has joined #openstack-zaqar | 15:22 | |
| *** ametts has joined #openstack-zaqar | 15:37 | |
| *** ff has joined #openstack-zaqar | 15:40 | |
| *** ametts has quit IRC | 15:56 | |
| *** mdnadeem has quit IRC | 16:13 | |
| *** mdnadeem has joined #openstack-zaqar | 16:13 | |
| *** david_cu has joined #openstack-zaqar | 16:15 | |
| *** david-lyle_ is now known as david-lyle | 16:28 | |
| *** kgriffs|afk is now known as kgriffs | 16:35 | |
| *** kgriffs is now known as kgriffs|afk | 16:45 | |
| *** ff has quit IRC | 16:55 | |
| *** ff has joined #openstack-zaqar | 16:57 | |
| *** ff has quit IRC | 16:58 | |
| *** kgriffs|afk is now known as kgriffs | 17:05 | |
| *** shakamunyi has joined #openstack-zaqar | 17:06 | |
| *** shakamunyi has quit IRC | 17:23 | |
| *** rcernin has quit IRC | 17:34 | |
| *** shakamunyi has joined #openstack-zaqar | 17:37 | |
| *** wxy has quit IRC | 17:39 | |
| *** davideagnello has joined #openstack-zaqar | 17:41 | |
| *** exploreshaifali has joined #openstack-zaqar | 17:47 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Forbid update subscription to duplicate https://review.openstack.org/279946 | 17:59 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Forbid update subscription to duplicate https://review.openstack.org/279946 | 18:15 |
| *** kgriffs is now known as kgriffs|afk | 18:25 | |
| *** david_cu has quit IRC | 18:59 | |
| *** amitgandhinz has quit IRC | 19:15 | |
| *** amitgandhinz has joined #openstack-zaqar | 19:15 | |
| *** kgriffs|afk is now known as kgriffs | 19:15 | |
| *** ametts has joined #openstack-zaqar | 19:17 | |
| *** flwang has quit IRC | 19:26 | |
| *** exploreshaifali has quit IRC | 19:33 | |
| *** flwang has joined #openstack-zaqar | 19:39 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Forbid update subscription to duplicate https://review.openstack.org/279946 | 19:59 |
| *** david_cu has joined #openstack-zaqar | 20:00 | |
| *** amitgandhinz has quit IRC | 20:00 | |
| *** ametts has quit IRC | 20:01 | |
| *** david_cu has quit IRC | 20:04 | |
| *** david_cu has joined #openstack-zaqar | 20:14 | |
| openstackgerrit | Thai Tran proposed openstack/zaqar-ui: New queues does not display message count https://review.openstack.org/286862 | 20:16 |
| *** ametts has joined #openstack-zaqar | 20:18 | |
| *** amitgandhinz has joined #openstack-zaqar | 20:37 | |
| *** amitgandhinz has quit IRC | 21:02 | |
| *** amitgandhinz has joined #openstack-zaqar | 21:03 | |
| *** kgriffs is now known as kgriffs|afk | 21:04 | |
| *** kgriffs|afk is now known as kgriffs | 21:13 | |
| *** kgriffs is now known as kgriffs|afk | 21:15 | |
| *** kgriffs|afk is now known as kgriffs | 21:16 | |
| *** kgriffs is now known as kgriffs|afk | 21:16 | |
| *** boris-42 has joined #openstack-zaqar | 21:17 | |
| *** jtomasek has quit IRC | 21:20 | |
| *** amitgandhinz has quit IRC | 21:30 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Forbid update subscription to duplicate https://review.openstack.org/279946 | 21:31 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Renew subscription on update with TTL https://review.openstack.org/289665 | 21:31 |
| *** amitgandhinz has joined #openstack-zaqar | 21:33 | |
| *** kgriffs|afk is now known as kgriffs | 21:37 | |
| *** tqtran has joined #openstack-zaqar | 21:42 | |
| Eva-i | flwang: hello, dear Fei Long | 21:58 |
| flwang | Eva-i: hi | 21:58 |
| Eva-i | flwang: so I want to write good tests for renew subscription patch. But to write them first I need to release patch for this new Redis bug: https://bugs.launchpad.net/zaqar/+bug/1554683. What do you think? | 22:00 |
| openstack | Launchpad bug 1554683 in zaqar "Subscription update in Redis driver doesn't pack new options in msgpack" [Undecided,New] - Assigned to Eva Balycheva (ubershy) | 22:00 |
| Eva-i | The patch will be really small. | 22:01 |
| flwang | hmm... why we do have that issue? I think it has been fixed by therve | 22:02 |
| Eva-i | flwang: we just have it. You can try curls from the bug report and reproduce bug | 22:03 |
| Eva-i | I don't remember therve fixing it, but I'm relatively new person in Zaqar project. | 22:04 |
| flwang | Eva-i: let me check the code | 22:05 |
| *** ametts has quit IRC | 22:05 | |
| *** csoukup has joined #openstack-zaqar | 22:06 | |
| flwang | Eva-i: see https://github.com/openstack/zaqar/blame/master/zaqar/storage/redis/subscriptions.py#L117 | 22:08 |
| Eva-i | flwang: yes | 22:08 |
| Eva-i | flwang: same thing should be done in update(), if the user passes new options | 22:09 |
| Eva-i | flwang: now if the user passes new options, they are written without packing | 22:09 |
| flwang | Eva-i: ok, so you did an update in your test, right? | 22:09 |
| Eva-i | flwang: yes, in test from bug report | 22:10 |
| flwang | Eva-i: ah, i see. | 22:10 |
| flwang | confirmed, thanks | 22:11 |
| Eva-i | flwang: no problem! | 22:12 |
| *** ametts has joined #openstack-zaqar | 22:19 | |
| *** amitgandhinz has quit IRC | 22:35 | |
| *** kgriffs is now known as kgriffs|afk | 22:43 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Fix updating subscription options in Redis driver https://review.openstack.org/290170 | 22:45 |
| Eva-i | flwang: ryansb: could you please review this tiny patch https://review.openstack.org/#/c/290170/ | 22:48 |
| Eva-i | vkmc: ^ | 22:56 |
| *** david_cu has quit IRC | 23:03 | |
| *** csoukup has quit IRC | 23:47 | |
| *** ametts has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!