| *** achanda has joined #openstack-zaqar | 00:03 | |
| *** flwang has quit IRC | 00:07 | |
| *** flwang1 has joined #openstack-zaqar | 00:09 | |
| *** achanda has quit IRC | 00:15 | |
| *** flwang1 has quit IRC | 00:23 | |
| *** flwang1 has joined #openstack-zaqar | 00:26 | |
| flwang1 | wxy: ping re queue's metadata update client patch | 00:37 |
|---|---|---|
| *** JAHoagie has joined #openstack-zaqar | 00:49 | |
| *** shu-mutou-AFK is now known as shu-mutou | 00:58 | |
| wxy | flwang1: pong, just start work.:) | 01:00 |
| *** JAHoagie has quit IRC | 01:00 | |
| flwang1 | wxy: ok, the server side patch https://review.openstack.org/292843 is there, need some polish, but you got the idea | 01:01 |
| flwang1 | i will upload a new patch set soon | 01:01 |
| wxy | flwang1: got it , I'll read and review it at once. | 01:02 |
| flwang1 | wxy: cheers | 01:02 |
| *** odyssey4me has quit IRC | 01:04 | |
| *** odyssey4me has joined #openstack-zaqar | 01:06 | |
| *** achanda has joined #openstack-zaqar | 01:26 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Fix PATCH queue's metadata https://review.openstack.org/292843 | 01:28 |
| *** eliqiao_ has joined #openstack-zaqar | 01:40 | |
| *** kgriffs|afk is now known as kgriffs | 01:42 | |
| *** eliqiao has quit IRC | 01:43 | |
| *** tqtran-afk has quit IRC | 01:48 | |
| *** kgriffs is now known as kgriffs|afk | 01:51 | |
| *** kgriffs|afk is now known as kgriffs | 01:51 | |
| *** wanghao has quit IRC | 02:12 | |
| *** wanghao has joined #openstack-zaqar | 02:12 | |
| *** eliqiao_ is now known as eliqiao | 02:14 | |
| *** odyssey4me has quit IRC | 02:19 | |
| *** AAzza has quit IRC | 02:19 | |
| *** Qiming has joined #openstack-zaqar | 02:23 | |
| *** odyssey4me has joined #openstack-zaqar | 02:25 | |
| *** AAzza has joined #openstack-zaqar | 02:25 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Fix PATCH queue's metadata https://review.openstack.org/292843 | 02:32 |
| *** achanda has quit IRC | 02:48 | |
| *** achanda has joined #openstack-zaqar | 02:50 | |
| *** achanda has quit IRC | 02:52 | |
| *** achanda has joined #openstack-zaqar | 02:55 | |
| *** Qiming has quit IRC | 02:57 | |
| *** GB21 has joined #openstack-zaqar | 03:09 | |
| *** GB21 has quit IRC | 03:15 | |
| flwang1 | wxy: ping | 03:49 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Remove unnecessary assert https://review.openstack.org/293810 | 03:51 |
| wxy | flwang1: hey | 04:07 |
| Eva-i | flwang1: hello | 05:06 |
| Eva-i | flwang1: are you still here? | 05:06 |
| *** GB21 has joined #openstack-zaqar | 05:22 | |
| *** GB21 has quit IRC | 05:31 | |
| *** mdnadeem has quit IRC | 05:33 | |
| *** GB21 has joined #openstack-zaqar | 05:33 | |
| *** achanda has quit IRC | 05:37 | |
| *** GB21 has quit IRC | 05:51 | |
| *** GB21 has joined #openstack-zaqar | 05:51 | |
| *** GB21 has quit IRC | 05:57 | |
| *** GB21 has joined #openstack-zaqar | 05:59 | |
| *** itisha has quit IRC | 06:19 | |
| *** GB21 has quit IRC | 06:19 | |
| *** GB21 has joined #openstack-zaqar | 06:21 | |
| *** mdnadeem has joined #openstack-zaqar | 06:35 | |
| *** kgriffs is now known as kgriffs|afk | 06:44 | |
| *** GB21 has quit IRC | 06:49 | |
| *** GB21 has joined #openstack-zaqar | 06:49 | |
| *** kgriffs|afk is now known as kgriffs | 06:53 | |
| *** GB21 has quit IRC | 07:13 | |
| *** GB21 has joined #openstack-zaqar | 07:13 | |
| Eva-i | hello wxy | 07:14 |
| wxy | Eva-i: :) | 07:14 |
| *** tesseract has joined #openstack-zaqar | 07:15 | |
| *** tesseract is now known as Guest57182 | 07:15 | |
| Eva-i | wxy: recheck will probably do nothing to Fei Long's patch. Tests now fail because websocket library which Zaqar uses updated in incompatible way. See this bug: https://bugs.launchpad.net/zaqar/+bug/1558062. I recommended Fei Long to rebase his change to my patch (https://review.openstack.org/293413) so the tests will pass, but for some reason he don't want to. :o | 07:17 |
| openstack | Launchpad bug 1558062 in zaqar "Zaqar shouldn't instantiate websocket protocol with 'debug' option" [Undecided,In progress] - Assigned to Eva Balycheva (ubershy) | 07:17 |
| *** shakamunyi has quit IRC | 07:18 | |
| wxy | Eva-i: I noticed that he added "depends-on" in the commit message. | 07:18 |
| Eva-i | wxy: oh, you're right! | 07:20 |
| wxy | Eva-i: And the jenkins only failed with python34. I don't know why, but it always happens. :( | 07:20 |
| Eva-i | wxy: I thought depends-on is for cross-project patches | 07:20 |
| Eva-i | wxy: don't worry, I know why jenkins fails with python34. I'm going to fix it after RC1. | 07:21 |
| wxy | Eva-i: That's a great news. | 07:22 |
| *** shakamunyi has joined #openstack-zaqar | 07:23 | |
| *** GB21 has quit IRC | 07:24 | |
| openstackgerrit | Neerja Narayan proposed openstack/zaqar: Adding Negative tests cases to Zaqar v1.0 https://review.openstack.org/291643 | 07:27 |
| *** rcernin has joined #openstack-zaqar | 07:39 | |
| *** wanghao has quit IRC | 07:56 | |
| *** wanghao has joined #openstack-zaqar | 07:57 | |
| *** GB21 has joined #openstack-zaqar | 08:00 | |
| *** GB21 has quit IRC | 08:15 | |
| *** GB21 has joined #openstack-zaqar | 08:15 | |
| *** pcaruana has joined #openstack-zaqar | 08:24 | |
| *** GB21 has quit IRC | 08:28 | |
| *** GB21 has joined #openstack-zaqar | 08:30 | |
| *** barra204 has joined #openstack-zaqar | 08:42 | |
| *** shakamunyi has quit IRC | 08:44 | |
| *** GB21 has quit IRC | 09:04 | |
| *** GB21 has joined #openstack-zaqar | 09:28 | |
| *** GB21 has quit IRC | 09:44 | |
| *** achanda has joined #openstack-zaqar | 09:44 | |
| *** achanda has quit IRC | 09:45 | |
| *** achanda has joined #openstack-zaqar | 09:46 | |
| *** achanda has quit IRC | 09:46 | |
| odyssey4me | o/ | 09:51 |
| *** GB21 has joined #openstack-zaqar | 10:11 | |
| *** bradjones has quit IRC | 10:27 | |
| *** bradjones has joined #openstack-zaqar | 10:36 | |
| *** bradjones has joined #openstack-zaqar | 10:36 | |
| *** shu-mutou is now known as shu-mutou-AFK | 10:36 | |
| *** GB21 has quit IRC | 10:52 | |
| *** GB21 has joined #openstack-zaqar | 10:52 | |
| *** GB21 has quit IRC | 10:58 | |
| *** GB21 has joined #openstack-zaqar | 10:58 | |
| *** GB21 has quit IRC | 11:07 | |
| *** GB21 has joined #openstack-zaqar | 11:08 | |
| *** boris-42 has joined #openstack-zaqar | 11:14 | |
| *** shu-mutou-AFK has quit IRC | 11:20 | |
| *** wxy has quit IRC | 11:40 | |
| *** GB21 has quit IRC | 11:47 | |
| *** openstackgerrit has quit IRC | 11:48 | |
| *** openstackgerrit has joined #openstack-zaqar | 11:48 | |
| *** GB21 has joined #openstack-zaqar | 11:48 | |
| *** GB21 has quit IRC | 11:53 | |
| *** GB21 has joined #openstack-zaqar | 11:55 | |
| *** GB21 has quit IRC | 12:01 | |
| *** GB21 has joined #openstack-zaqar | 12:03 | |
| *** GB21 has quit IRC | 12:24 | |
| *** venkat_ has joined #openstack-zaqar | 13:05 | |
| *** mpanetta has joined #openstack-zaqar | 13:07 | |
| *** mpanetta has quit IRC | 13:12 | |
| *** mpanetta has joined #openstack-zaqar | 13:12 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:19 | |
| *** ametts has joined #openstack-zaqar | 13:37 | |
| *** venkat_ has quit IRC | 13:51 | |
| *** venkat_ has joined #openstack-zaqar | 14:01 | |
| *** GB21 has joined #openstack-zaqar | 14:25 | |
| *** pcaruana has quit IRC | 14:28 | |
| *** achanda has joined #openstack-zaqar | 14:29 | |
| *** achanda has quit IRC | 14:40 | |
| *** csoukup has joined #openstack-zaqar | 14:54 | |
| *** amitgandhinz has quit IRC | 14:58 | |
| *** amitgandhinz has joined #openstack-zaqar | 14:58 | |
| *** achanda has joined #openstack-zaqar | 15:03 | |
| *** achanda has quit IRC | 15:08 | |
| *** GB21 has quit IRC | 15:15 | |
| *** JAHoagie has joined #openstack-zaqar | 15:47 | |
| *** khushbu has joined #openstack-zaqar | 15:56 | |
| *** flwang has joined #openstack-zaqar | 16:01 | |
| *** khushbu has quit IRC | 16:02 | |
| *** venkat_ has quit IRC | 16:04 | |
| *** khushbu has joined #openstack-zaqar | 16:14 | |
| *** pcaruana has joined #openstack-zaqar | 16:22 | |
| *** itisha has joined #openstack-zaqar | 16:33 | |
| *** khushbu has quit IRC | 16:33 | |
| flwang | flaper87: ping | 16:33 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Fix PATCH queue's metadata https://review.openstack.org/292843 | 16:39 |
| flwang | ryansb: vkmc: flaper87:anybody around? | 16:40 |
| flwang | we need to discuss https://review.openstack.org/#/c/293413/ | 16:40 |
| flaper87 | flwang: pong | 16:42 |
| flaper87 | actually, 2mins | 16:43 |
| flaper87 | brbr | 16:43 |
| flaper87 | brb, even | 16:43 |
| flwang | flaper87: ok, i will wait for you :) | 16:43 |
| flaper87 | here now | 16:47 |
| flaper87 | flwang: sup? | 16:47 |
| flwang | https://review.openstack.org/#/c/293413/ | 16:47 |
| flwang | for this one, should we bump the lib version? | 16:48 |
| flaper87 | what does `fresh 'autobahn'` mean? | 16:48 |
| flaper87 | latest? | 16:48 |
| flaper87 | Did they break us ? | 16:48 |
| flwang | yes, since they removed a param of __init__ | 16:48 |
| flaper87 | we can't bump the version now | 16:48 |
| flaper87 | Is there any other way to enable debug ? | 16:49 |
| flwang | the 'debug' removal won't impact anything | 16:49 |
| flaper87 | I don't understand why they wouldn't allow people to enable debug | 16:49 |
| flwang | it's a deprecated param and the logging won't be impacted based on the patch said | 16:50 |
| flaper87 | Anyway, we can avoid passing debug to autobhan altogether | 16:50 |
| flaper87 | ok | 16:50 |
| flaper87 | Let's remove it in Zaqar | 16:50 |
| flaper87 | bump the minor version in requirements | 16:50 |
| flaper87 | and that will land probably in newton and we can backport it to Mitaka | 16:51 |
| flwang | it's breaking our gate | 16:51 |
| flwang | we can't merge the queue's PATCH fix before this one | 16:51 |
| flaper87 | +2'd | 16:52 |
| flaper87 | go, merge it | 16:52 |
| flaper87 | flwang: ^ | 16:52 |
| flwang | flaper87: and this one, when you have a moment https://review.openstack.org/292843 | 16:52 |
| flwang | PATCH support for queue's metadata | 16:53 |
| flwang | i grab some code from glance | 16:53 |
| flwang | flaper87: and i would like to see your opinion on this one https://review.openstack.org/#/c/292702/ which is adding some check in v1 for metadata's value, because we have a new feature in v2's queue metadata thanks | 16:58 |
| flaper87 | flwang: will check | 16:59 |
| flwang | really appreciate | 16:59 |
| *** mpanetta has quit IRC | 17:07 | |
| *** david_cu has joined #openstack-zaqar | 17:16 | |
| *** david_cu_ has joined #openstack-zaqar | 17:17 | |
| *** david_cu has quit IRC | 17:20 | |
| *** david_cu_ has quit IRC | 17:25 | |
| *** Guest57182 has quit IRC | 17:36 | |
| *** flwang has quit IRC | 17:48 | |
| *** rcernin has quit IRC | 17:55 | |
| *** tqtran-afk has joined #openstack-zaqar | 17:56 | |
| *** tqtran-afk is now known as tqtran | 18:13 | |
| *** pcaruana has quit IRC | 18:18 | |
| *** pcaruana has joined #openstack-zaqar | 18:30 | |
| *** wanghao has quit IRC | 18:35 | |
| *** wanghao has joined #openstack-zaqar | 18:35 | |
| *** amitgandhinz has quit IRC | 19:20 | |
| *** ametts has quit IRC | 19:29 | |
| Eva-i | flwang1: good morning | 20:07 |
| flwang1 | morning | 20:07 |
| *** kgriffs is now known as kgriffs|afk | 20:07 | |
| flwang1 | Eva-i: can you pls revisit https://review.openstack.org/#/c/292843/ ? | 20:11 |
| Eva-i | flwang1: sure, already | 20:11 |
| Eva-i | revisiting | 20:11 |
| flwang1 | thanks | 20:12 |
| *** flwang has joined #openstack-zaqar | 20:12 | |
| * ryansb also visiting | 20:13 | |
| flwang1 | ryansb: really appreciate it | 20:15 |
| flwang1 | we need to get it in today | 20:15 |
| ryansb | ooh, JSON PATCH | 20:15 |
| flwang1 | if possible | 20:15 |
| ryansb | yay | 20:15 |
| flwang1 | ryansb: i know i know | 20:15 |
| flwang1 | it's rush to get this in at this moment, but seems there is no good way unless we want to release the ugly PATCH in mitaka :) | 20:16 |
| ryansb | yup | 20:16 |
| Eva-i | I want beautiful PATCH | 20:16 |
| flwang1 | ryansb: Eva-i: by many code from glance, so should be ok | 20:16 |
| *** pcaruana has quit IRC | 20:17 | |
| ryansb | Eva-i: you don't seem to test updating one key then confirming others are unchanged | 20:17 |
| ryansb | would it be possible to add one? | 20:17 |
| flwang1 | ryansb: ? | 20:17 |
| ryansb | in https://review.openstack.org/#/c/292843/8/zaqar/tests/unit/transport/wsgi/v2_0/test_queue_lifecycle.py | 20:17 |
| ryansb | it would be good to do a test like | 20:17 |
| ryansb | [{"op":"add", "path": "/metadata/key", "value": 1}] | 20:18 |
| ryansb | [{"op":"add", "path": "/metadata/key2", "value": 1}] | 20:18 |
| ryansb | [{"op":"modify", "path": "/metadata/key", "value": 5}] | 20:18 |
| ryansb | then test that key == 5 and key2 == 1 still | 20:18 |
| flwang1 | ryansb: oh, no problem, i can do that | 20:18 |
| ryansb | and s/modify/replace/ oops | 20:19 |
| flwang1 | and i'm going to add a test for queue_patching of validation | 20:19 |
| ryansb | kk | 20:20 |
| Eva-i | flwang1: ryansb: should we send 404 responses to user, on replace and delete operations with metadata, when keys are not found? | 20:21 |
| ryansb | I don't think so | 20:21 |
| ryansb | it's an idempotency concern | 20:21 |
| ryansb | so e.g. if user sends `remove` then gets no response, then resends, they should not get an error | 20:22 |
| Eva-i | ryansb: patch is not idempotent as I see: http://restcookbook.com/HTTP%20Methods/idempotency/ | 20:22 |
| ryansb | oh, it isn't? | 20:22 |
| Eva-i | ryansb: there is also this opinion: http://programmers.stackexchange.com/a/260828 | 20:23 |
| flwang1 | ryansb: patch is not | 20:23 |
| ryansb | I stand corrected then | 20:23 |
| flwang1 | IMHO, we're playing with key of metadata | 20:24 |
| flwang1 | not the core/key attributes of a queue | 20:24 |
| Eva-i | RFC says things about "unsuccessful operation" in this case. 200 OK response seems successful | 20:24 |
| flwang1 | for example, take glance image as an example | 20:24 |
| flwang1 | if the patch is against a core attribute, like image disk_format | 20:24 |
| flwang1 | then maybe we should throw error, but for a key in metadata, i don't really think it's a good idea to throw errors | 20:25 |
| flwang1 | Eva-i: can you paste the link/sentence? | 20:25 |
| Eva-i | flwang1: what link? | 20:26 |
| flwang1 | RFC says things about "unsuccessful operation" in this case | 20:27 |
| Eva-i | flwang1: ryansb: http://tools.ietf.org/html/rfc6902#section-4.2 | 20:27 |
| Eva-i | same is for replace | 20:27 |
| Eva-i | flwang1: ryansb: "The target location MUST exist for the operation to be successful." | 20:28 |
| ryansb | there you have it | 20:28 |
| Eva-i | We can vote. I'm for RFC way. But I'm not 100% against a way without showing errors when keys don't exist. | 20:30 |
| *** pcaruana has joined #openstack-zaqar | 20:30 | |
| flwang1 | Eva-i: we can do that | 20:34 |
| flwang1 | then the question is what's the error we should use | 20:34 |
| flwang1 | 404 or 409 | 20:34 |
| flwang1 | or 400 | 20:34 |
| Eva-i | flwang1: I think definitely 404. | 20:34 |
| Eva-i | fits best | 20:34 |
| flwang1 | glance is using 409 | 20:35 |
| flwang1 | https://github.com/openstack/glance/blob/master/glance/api/v2/images.py#L192 | 20:35 |
| Eva-i | flwang1: thanks for information. I think glance is wrong =) | 20:36 |
| flwang1 | Eva-i: haha | 20:37 |
| flwang1 | https://github.com/stefankoegl/python-json-patch/blob/master/jsonpatch.py#L402 | 20:39 |
| flwang1 | i would say glance is correct | 20:39 |
| Eva-i | flwang1: oh, that's good argument. Now I'm starting to think I'm wrong. | 20:41 |
| Eva-i | flwang1: okay, I wouldn't mind 409 if you use it. | 20:42 |
| flwang1 | im going to use 409 unless if there is another object :) | 20:42 |
| *** ametts has joined #openstack-zaqar | 20:42 | |
| ryansb | ++ | 20:53 |
| Eva-i | flwang1: oki | 20:54 |
| flwang1 | Eva-i: for this line metadata.pop(path_child) | 21:02 |
| flwang1 | you said it may cause 500 error, why? | 21:02 |
| Eva-i | it will throw KeyError in case key does not exist, no? | 21:03 |
| flwang1 | if path_child in metadata: | 21:03 |
| Eva-i | flwang1: ah yes, it's my mistake | 21:04 |
| flwang1 | Eva-i: ryansb: vkmc: flaper87: any other comments for the patch before i uploading another patchset? | 21:11 |
| ryansb | no, lookks ok | 21:11 |
| Eva-i | flwang1: no comments from me | 21:12 |
| openstackgerrit | Merged openstack/zaqar: Don't pass debug option to websocket constructor https://review.openstack.org/293413 | 21:14 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Remove unnecessary assert https://review.openstack.org/293810 | 21:20 |
| *** Eva-i has quit IRC | 21:23 | |
| *** Eva-i has joined #openstack-zaqar | 21:25 | |
| *** csoukup has quit IRC | 22:08 | |
| *** csoukup has joined #openstack-zaqar | 22:10 | |
| *** ametts has quit IRC | 22:14 | |
| Eva-i | flwang: flwang1: let's resume this patch and make it work with our new queue PATCH method in v2 https://review.openstack.org/#/c/289179/ ? | 22:44 |
| *** tqtran is now known as tqtran-afk | 22:54 | |
| *** csoukup has quit IRC | 22:57 | |
| *** tqtran-afk has quit IRC | 23:01 | |
| *** eliqiao has quit IRC | 23:43 | |
| *** eliqiao has joined #openstack-zaqar | 23:45 | |
| flwang1 | yep, i mentioned that with wxy | 23:49 |
| flwang1 | but i'm not sure what's the progress | 23:49 |
| *** davideagnello has quit IRC | 23:53 | |
| *** davideagnello has joined #openstack-zaqar | 23:54 | |
| *** davideagnello has quit IRC | 23:59 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!