| *** c_soukup has quit IRC | 00:02 | |
| *** achanda has joined #openstack-zaqar | 00:20 | |
| *** achanda has quit IRC | 00:23 | |
| *** cpallares has quit IRC | 00:43 | |
| *** flaper87 has quit IRC | 00:45 | |
| *** flaper87 has joined #openstack-zaqar | 00:46 | |
| *** cpallares has joined #openstack-zaqar | 00:47 | |
| *** amitgandhinz has joined #openstack-zaqar | 00:53 | |
| *** amitgandhinz has quit IRC | 01:12 | |
| *** achanda has joined #openstack-zaqar | 01:12 | |
| openstackgerrit | Fernando Ribeiro proposed openstack/zaqar: Added first batch of samples in multiple languages https://review.openstack.org/294971 | 01:15 |
|---|---|---|
| *** fribeiro_ has joined #openstack-zaqar | 01:21 | |
| fribeiro_ | Eva-I: Thanks for your feedback, just send another patch set, still didn't pass the ci gate | 01:21 |
| Eva-i | fribeiro_: np, I'll finish doing few things now and check out your patch. ;) | 01:25 |
| *** fribeiro_ has quit IRC | 01:41 | |
| *** amitgandhinz has joined #openstack-zaqar | 01:57 | |
| openstackgerrit | wanghao proposed openstack/zaqar: Show default attributes for queue https://review.openstack.org/286433 | 01:58 |
| *** flwang has joined #openstack-zaqar | 02:05 | |
| flwang | anybody around? | 02:08 |
| flwang | flaper87: do you have the permission to approve stable/mitaka? | 02:10 |
| *** amitgandhinz has quit IRC | 02:10 | |
| flwang | Eva-i: around? | 02:12 |
| Eva-i | flwang: yes, I'm here | 02:12 |
| flwang | Eva-i: see this http://logs.openstack.org/02/292702/2/check/gate-zaqar-tox-integration/9bcc264/testr_results.html.gz ? | 02:12 |
| fribeiro | i am also around, but very much powerless ☺ | 02:13 |
| Eva-i | flwang: yes, I see | 02:14 |
| flwang | fribeiro: hi there | 02:14 |
| flwang | Eva-i: it could be a bug of the test code | 02:14 |
| flwang | if so, we have to fix it in Newton | 02:14 |
| Eva-i | flwang: oh, I haven't noticed this test fail. It fails, because in the API v1 test we're trying to create queue with metadata with key "_queue". And because it is prefixed by "_" it fails. | 02:21 |
| flwang | Eva-i: if you can draft a quick patch, i can nijia approve it | 02:21 |
| Eva-i | flwang: it's not too late to make our change more backward compatible by restricting only known reserved queue attributes, as I made in previous patch set. | 02:22 |
| Eva-i | flwang: I can quick fix it | 02:22 |
| flwang | but i have mreged the patch :( | 02:22 |
| flwang | my hand is too fast than my eyes | 02:23 |
| Eva-i | flwang: it's not merged as I see: https://review.openstack.org/#/c/292702/ | 02:23 |
| flwang | can you try to upload a new patchset? | 02:23 |
| Eva-i | flwang: you can still stop the process | 02:23 |
| flwang | i just -1 it | 02:24 |
| flwang | can you upload a new patchset? | 02:24 |
| Eva-i | flwang: yes | 02:24 |
| flwang | thank you | 02:24 |
| flwang | sorry for the late review, today is NZ holiday | 02:24 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Validate PUT of reserved queue attributes metadata https://review.openstack.org/292702 | 02:26 |
| Eva-i | flwang: okay, I uploaded patch set that fixes test as it is more quick | 02:26 |
| Eva-i | flwang: now we have to decide is this what we want | 02:27 |
| Eva-i | flwang: the merging process now definitely stopped | 02:27 |
| flwang | decide what? | 02:27 |
| Eva-i | flwang: maybe the probability that some people are using queue metadata attributes prefixed with "_" on API v1 is not so low as we thought, because our own test failed. Maybe it's still a good idea to restrict only known queue reserved attributes instead of restricting any with "_" prefix in name? | 02:31 |
| flwang | Eva-i: personally, i can't see any reason why we have to restrict all the metadata starts with _ | 02:32 |
| flwang | TBH | 02:32 |
| Eva-i | flwang: so, you do not agree with Flavio? | 02:32 |
| flwang | Eva-i: yes, i don't. I can't see any benefit with that change | 02:33 |
| flwang | but a possible compatibility breaking | 02:33 |
| Eva-i | flwang: me too. I thought I'm a minority with my opinion. | 02:34 |
| flwang | but given it's a PUT | 02:34 |
| flwang | so maybe it's not a big deal | 02:35 |
| Eva-i | flwang: so now it's 2 vs 2 opinions. | 02:37 |
| Eva-i | flwang: if you want, I can quickly revert patch to patch set 1. | 02:37 |
| flwang | no, hold on | 02:37 |
| flwang | so if a user upgrade their zaqar to Mitaka, the new change shouldn't break anything, right? | 02:38 |
| flwang | given it's a PUT action, which only effects when we crate a new queue, isn't it? | 02:38 |
| Eva-i | flwang: It will break on the first user attempt to put metadata with "_" prefixed key using API v1. Before this change this operation is successful, after - it's not. | 02:40 |
| flwang | Eva-i: yep, i know | 02:40 |
| Eva-i | flwang: as I know on API v1 it's impossible to create queue with metadata. The user should create a queue and put metadata using /metadata endpoint. | 02:42 |
| flwang | therve: congrats!!! | 02:42 |
| flwang | Eva-i: yep | 02:42 |
| Eva-i | flwang: so the change will affect metadata putting, not queue putting. | 02:43 |
| flwang | Eva-i: ok | 02:43 |
| flwang | so let's keep current change | 02:43 |
| flwang | given we have deprecated v1 | 02:43 |
| flwang | so i don't really worry about this, TBH | 02:43 |
| Eva-i | flwang: okay, let's keep it. But know that it will break my heart. | 02:44 |
| *** barra204 has joined #openstack-zaqar | 02:49 | |
| Eva-i | flwang: is something good happened to therve? | 02:53 |
| flwang | therve: he will be the PTL of Heat for Newton release | 02:53 |
| flwang | Eva-i: ^ | 02:53 |
| flwang | Eva-i: and i think it's a good sign for Zaqar :) | 02:54 |
| Eva-i | flwang: but the election hasn't started as I know. He only make himself candidate. | 02:54 |
| Eva-i | *made | 02:54 |
| Eva-i | flwang: also why I don't see you in the list of candidates? =) | 02:54 |
| flwang | Eva-i: you should subscribe the openstack-dev mail list | 02:54 |
| Eva-i | flwang: I'm already subscribed. | 02:55 |
| flwang | Eva-i: http://lists.openstack.org/pipermail/openstack-dev/2015-September/075540.html | 02:55 |
| flwang | Eva-i: then you should read mails :D | 02:55 |
| flwang | Eva-i: sorry, old link | 02:56 |
| flwang | Eva-i: http://lists.openstack.org/pipermail/openstack-dev/2016-March/090422.html | 02:57 |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Validate PUT of reserved queue attributes metadata https://review.openstack.org/292702 | 03:02 |
| Eva-i | flwang: oh, you're right | 03:05 |
| Eva-i | flwang: therve: congrats to you =) | 03:05 |
| *** amitgandhinz has joined #openstack-zaqar | 03:07 | |
| Eva-i | wxy: thanks for your comment | 03:08 |
| *** achanda has quit IRC | 03:15 | |
| *** amitgandhinz has quit IRC | 03:20 | |
| Eva-i | fribeiro: hello, are you still here? | 03:26 |
| fribeiro | Yes | 03:34 |
| fribeiro | Go ahead | 03:34 |
| wxy | Eva-i: :) | 03:35 |
| Eva-i | fribeiro: I left new comment in https://review.openstack.org/#/c/294971, can you answer my question? | 03:37 |
| *** fribeiro_ has joined #openstack-zaqar | 03:38 | |
| fribeiro | Done | 03:46 |
| *** amitgandhinz has joined #openstack-zaqar | 03:47 | |
| fribeiro_ | Eva-i: not only the java samples, but pretty much every one, requires some setup which is not described in the samples themselves, but perhaps can be later added to the docs | 03:47 |
| Eva-i | fribeiro_: if converted to maven projects, will java samples work? | 03:50 |
| fribeiro_ | Eva-i: yeah, i could set the project up (pom.xml included) and add it to the commit instead of just the java code | 03:51 |
| fribeiro_ | Eva-i: same go for jax-rs, which is also not in java se | 03:52 |
| fribeiro_ | Eva-i: and actually for node.js as well, only included the actual code, not the project | 03:54 |
| Eva-i | fribeiro_: do you think it will be overkill to convert such small samples to projects? | 03:54 |
| fribeiro_ | Eva-i: yeah, would set the bar too high, basically every future sample would also need to be a fully working example rather than just sample code that one uses to learn how things work | 03:55 |
| fribeiro_ | Eva-i: that is actually why i have renamed the folder from 'examples' to 'samples', which are less pretentious | 03:55 |
| fribeiro_ | Eva-i: even the python example would have to be changed, really, they require packages with the dev may not have installed | 03:57 |
| Eva-i | fribeiro_: aha, I see. Maybe some samples can be combined, so there will be not much projects will be created. | 03:57 |
| fribeiro_ | Eva-i: i'd rather go with the samples and focus on having more samples (only covered two use cases in a handful of languages) than anything else | 03:57 |
| fribeiro_ | Eva-i: adding docs that build on these samples and help people to create projects based on them seems like the way to go | 03:58 |
| fribeiro_ | Eva-i: zaqar itself would only have samples, the docs would have instructions on how to turn them into *examples* per se, fully working apps | 03:59 |
| fribeiro_ | Eva-i: does that make sense? | 03:59 |
| Eva-i | fribeiro_: without ability to run them easily, maybe these samples should be put as text in http://docs.openstack.org/developer/zaqar/ | 04:00 |
| *** amitgandhinz has quit IRC | 04:01 | |
| fribeiro_ | Eva-i: well, i think there is value in having them as part of the code base as well as the docs, really | 04:01 |
| fribeiro_ | Eva-i: not everyone will have both when taking a first look or something | 04:02 |
| Eva-i | fribeiro_: yes, it makes sense. Still it's possible to run these things by one executable, by bash script that will ask the user if it wish to install dependencies and run the sample. But yeah, overkill. | 04:02 |
| fribeiro_ | Eva-i: i think so | 04:02 |
| fribeiro_ | Eva-i: not a enterprise product that i can think of ever went that far | 04:02 |
| fribeiro_ | Eva-i: it is usually just a bunch of things that a dev needs to stich together himself | 04:03 |
| Eva-i | fribeiro_: okay. | 04:03 |
| Eva-i | fribeiro_: I'll configure and run samples tomorrow then. | 04:04 |
| Eva-i | fribeiro_: sorry for making you wait, I want to test them. | 04:05 |
| *** shu-mutou is now known as shu-mutou-AFK | 04:05 | |
| fribeiro_ | Eva-i: that's fine | 04:05 |
| *** fribeiro_ has quit IRC | 04:14 | |
| *** achanda has joined #openstack-zaqar | 04:18 | |
| *** david_cu has quit IRC | 04:34 | |
| openstackgerrit | Merged openstack/zaqar: Validate PUT of reserved queue attributes metadata https://review.openstack.org/292702 | 04:41 |
| *** amitgandhinz has joined #openstack-zaqar | 04:57 | |
| *** amitgandhinz has quit IRC | 05:11 | |
| *** amitgandhinz has joined #openstack-zaqar | 06:07 | |
| *** stanchan has joined #openstack-zaqar | 06:19 | |
| *** amitgandhinz has quit IRC | 06:21 | |
| *** mpanetta has joined #openstack-zaqar | 06:27 | |
| *** mpanetta has quit IRC | 06:32 | |
| *** amitgandhinz has joined #openstack-zaqar | 07:17 | |
| *** amitgandhinz has quit IRC | 07:22 | |
| openstackgerrit | wanghao proposed openstack/python-zaqarclient: Fix tests related to queue attributes in API V2 https://review.openstack.org/287114 | 07:25 |
| *** pcaruana has joined #openstack-zaqar | 07:38 | |
| *** achanda has quit IRC | 08:16 | |
| *** amitgandhinz has joined #openstack-zaqar | 08:18 | |
| *** amitgandhinz has quit IRC | 08:22 | |
| *** achanda has joined #openstack-zaqar | 09:03 | |
| *** openstackstatus has joined #openstack-zaqar | 09:09 | |
| *** ChanServ sets mode: +v openstackstatus | 09:09 | |
| flwang | flaper87: can you approve https://review.openstack.org/#/c/297510/2 and https://review.openstack.org/#/c/297490/ ? i'm going to release rc2 | 09:12 |
| *** amitgandhinz has joined #openstack-zaqar | 09:18 | |
| *** amitgandhinz has quit IRC | 09:23 | |
| *** achanda has quit IRC | 09:41 | |
| *** stanchan has quit IRC | 09:51 | |
| *** amitgandhinz has joined #openstack-zaqar | 10:19 | |
| *** amitgandhinz has quit IRC | 10:24 | |
| *** mpanetta has joined #openstack-zaqar | 10:29 | |
| *** mpanetta has quit IRC | 10:34 | |
| *** achanda has joined #openstack-zaqar | 10:41 | |
| *** achanda has quit IRC | 10:50 | |
| *** amitgandhinz has joined #openstack-zaqar | 11:20 | |
| *** amitgandhinz has quit IRC | 11:25 | |
| *** cschulz has joined #openstack-zaqar | 11:59 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:21 | |
| *** amitgandhinz has quit IRC | 12:26 | |
| *** david-lyle has quit IRC | 12:45 | |
| *** flaper87 has quit IRC | 12:46 | |
| *** flaper87 has joined #openstack-zaqar | 12:46 | |
| *** achanda has joined #openstack-zaqar | 12:47 | |
| *** achanda has quit IRC | 12:53 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:58 | |
| *** amitgandhinz has quit IRC | 12:58 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:59 | |
| *** kgriffs|afk is now known as kgriffs | 14:01 | |
| openstackgerrit | Serge Kovaleff proposed openstack/zaqar: Fix service_available opt registration https://review.openstack.org/297695 | 14:11 |
| *** fribeiro_ has joined #openstack-zaqar | 14:22 | |
| *** c_soukup has joined #openstack-zaqar | 14:22 | |
| openstackgerrit | Fernando Ribeiro proposed openstack/zaqar: Added first batch of samples in multiple languages https://review.openstack.org/294971 | 14:25 |
| *** mpanetta has joined #openstack-zaqar | 14:32 | |
| *** fribeiro_ has quit IRC | 14:35 | |
| openstackgerrit | Fernando Ribeiro proposed openstack/zaqar: Added first batch of samples in multiple languages https://review.openstack.org/294971 | 14:41 |
| *** achanda has joined #openstack-zaqar | 14:50 | |
| openstackgerrit | Fernando Ribeiro proposed openstack/zaqar: Added first batch of samples in multiple languages https://review.openstack.org/294971 | 14:50 |
| *** achanda has quit IRC | 14:55 | |
| openstackgerrit | Fernando Ribeiro proposed openstack/zaqar: Added first batch of samples in multiple languages https://review.openstack.org/294971 | 15:02 |
| openstackgerrit | Fernando Ribeiro proposed openstack/zaqar: Added first batch of samples in multiple languages https://review.openstack.org/294971 | 15:03 |
| *** fribeiro_ has joined #openstack-zaqar | 15:04 | |
| fribeiro_ | allright, should be ready now :) had a fight with git, but we are good now | 15:04 |
| *** c_soukup has quit IRC | 15:12 | |
| *** kgriffs is now known as kgriffs|afk | 15:19 | |
| *** david-lyle has joined #openstack-zaqar | 15:34 | |
| *** david-lyle_ has joined #openstack-zaqar | 15:38 | |
| *** david-lyle has quit IRC | 15:38 | |
| *** david-lyle_ is now known as david-lyle | 15:39 | |
| *** fribeiro_ has quit IRC | 15:50 | |
| *** pcaruana has quit IRC | 16:11 | |
| *** kgriffs|afk is now known as kgriffs | 16:16 | |
| *** achanda has joined #openstack-zaqar | 16:53 | |
| *** achanda has quit IRC | 16:59 | |
| *** achanda has joined #openstack-zaqar | 17:02 | |
| Eva-i | fribeiro: hello, cool =) | 17:15 |
| *** mpanetta has quit IRC | 18:30 | |
| *** csoukup has joined #openstack-zaqar | 18:32 | |
| *** csoukup has left #openstack-zaqar | 18:33 | |
| *** achanda has quit IRC | 18:45 | |
| *** achanda has joined #openstack-zaqar | 18:52 | |
| *** kgriffs is now known as kgriffs|afk | 19:12 | |
| *** kgriffs|afk is now known as kgriffs | 19:41 | |
| *** achanda has quit IRC | 19:47 | |
| *** amitgandhinz has quit IRC | 19:51 | |
| *** tqtran has joined #openstack-zaqar | 20:14 | |
| *** achanda has joined #openstack-zaqar | 20:17 | |
| fribeiro | Eva-I: read your new comment just now, let me know if you need more feedback. I am happy with what we have now, really | 20:24 |
| fribeiro | Eva-i: Looking forward to work on the docs next | 20:24 |
| *** wanghao has quit IRC | 20:26 | |
| *** wanghao has joined #openstack-zaqar | 20:27 | |
| Eva-i | fribeiro: yes, sure. These samples are hard to review. | 20:32 |
| *** cpallares has quit IRC | 20:33 | |
| *** achanda has quit IRC | 20:35 | |
| *** fribeiro_ has joined #openstack-zaqar | 20:40 | |
| *** fribeiro_ has quit IRC | 20:49 | |
| *** amitgandhinz has joined #openstack-zaqar | 20:52 | |
| *** amitgandhinz has quit IRC | 20:57 | |
| *** amitgandhinz has joined #openstack-zaqar | 21:00 | |
| *** david-lyle_ has joined #openstack-zaqar | 21:08 | |
| *** david-lyle has quit IRC | 21:08 | |
| *** david-lyle has joined #openstack-zaqar | 21:13 | |
| *** david-lyle_ has quit IRC | 21:14 | |
| *** achanda has joined #openstack-zaqar | 21:17 | |
| *** amitgandhinz has quit IRC | 21:49 | |
| *** amitgandhinz has joined #openstack-zaqar | 22:50 | |
| *** amitgandhinz has quit IRC | 23:04 | |
| openstackgerrit | Fernando Ribeiro proposed openstack/zaqar: Added first batch of samples in multiple languages https://review.openstack.org/294971 | 23:17 |
| *** dhellmann has quit IRC | 23:24 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!