| *** tqtran has quit IRC | 00:15 | |
| *** Qiming has quit IRC | 00:28 | |
| *** achanda has quit IRC | 00:40 | |
| *** shu-mutou has joined #openstack-zaqar | 00:46 | |
| *** kgriffs is now known as kgriffs|afk | 00:52 | |
| * flwang is working on Rally gate job and enable the Tempest job | 01:05 | |
| *** tqtran has joined #openstack-zaqar | 01:11 | |
| *** tqtran has quit IRC | 01:16 | |
| *** achanda has joined #openstack-zaqar | 01:18 | |
| *** Qiming has joined #openstack-zaqar | 01:26 | |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Add update queue function in v2 https://review.openstack.org/294368 | 02:30 |
|---|---|---|
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Add update queue function in v2 https://review.openstack.org/294368 | 02:37 |
| *** gcb has quit IRC | 02:47 | |
| *** mdnadeem_ has quit IRC | 02:58 | |
| *** mdnadeem has quit IRC | 02:58 | |
| *** mdnadeem has joined #openstack-zaqar | 02:58 | |
| *** eliqiao has quit IRC | 03:01 | |
| *** openstackstatus has quit IRC | 03:01 | |
| *** eliqiao has joined #openstack-zaqar | 03:02 | |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Add update queue function in v2 https://review.openstack.org/294368 | 03:06 |
| *** khushbu_ has joined #openstack-zaqar | 03:07 | |
| *** gcb has joined #openstack-zaqar | 03:08 | |
| *** kgriffs|afk is now known as kgriffs | 03:08 | |
| *** achanda has quit IRC | 03:09 | |
| wxy | flwang: Eva-i: ryansb: I updated the client patch follwed by your suggestion: https://review.openstack.org/294368 The unit test and functional test have been passed on my machine. Please review it and hope all of you like it. :) | 03:09 |
| flwang | wxy: cool, thanks | 03:15 |
| *** kgriffs is now known as kgriffs|afk | 03:30 | |
| *** khushbu_ has quit IRC | 03:34 | |
| *** kgriffs|afk is now known as kgriffs | 03:34 | |
| openstackgerrit | wangxiyuan proposed openstack/python-zaqarclient: Add update queue function in v2 https://review.openstack.org/294368 | 03:38 |
| *** khushbu_ has joined #openstack-zaqar | 03:44 | |
| *** kgriffs is now known as kgriffs|afk | 03:55 | |
| openstackgerrit | Merged openstack/python-zaqarclient: Fix tests related to queue attributes in API V2 https://review.openstack.org/287114 | 04:06 |
| *** khushbu_ has quit IRC | 04:20 | |
| *** achanda has joined #openstack-zaqar | 04:22 | |
| *** achanda has quit IRC | 04:37 | |
| *** eliqiao_ has joined #openstack-zaqar | 04:43 | |
| *** eliqiao has quit IRC | 04:44 | |
| *** flwang1 has quit IRC | 04:53 | |
| *** GB21 has joined #openstack-zaqar | 05:00 | |
| *** achanda has joined #openstack-zaqar | 05:03 | |
| *** wanghao has quit IRC | 05:13 | |
| *** wanghao has joined #openstack-zaqar | 05:13 | |
| *** shu-mutou is now known as shu-mutou-AFK | 05:26 | |
| *** achanda has quit IRC | 05:33 | |
| *** rcernin has joined #openstack-zaqar | 05:45 | |
| *** achanda has joined #openstack-zaqar | 05:59 | |
| *** GB21 has quit IRC | 06:12 | |
| *** GB21 has joined #openstack-zaqar | 06:12 | |
| *** achanda has quit IRC | 06:22 | |
| *** GB21 has quit IRC | 06:26 | |
| *** pcaruana has joined #openstack-zaqar | 06:26 | |
| *** GB21 has joined #openstack-zaqar | 06:28 | |
| *** eliqiao_ is now known as eliqiao | 06:28 | |
| *** tqtran has joined #openstack-zaqar | 06:43 | |
| *** GB21 has quit IRC | 06:44 | |
| *** GB21 has joined #openstack-zaqar | 06:44 | |
| *** tesseract has joined #openstack-zaqar | 06:45 | |
| *** tesseract is now known as Guest12876 | 06:45 | |
| *** tqtran has quit IRC | 06:47 | |
| *** GB21 has quit IRC | 06:51 | |
| *** GB21 has joined #openstack-zaqar | 06:54 | |
| *** GB21 has quit IRC | 07:02 | |
| *** GB21 has joined #openstack-zaqar | 07:03 | |
| *** khushbu_ has joined #openstack-zaqar | 07:10 | |
| *** GB21 has quit IRC | 07:16 | |
| *** khushbu_ has quit IRC | 07:22 | |
| *** GB21 has joined #openstack-zaqar | 07:29 | |
| *** GB21 has quit IRC | 07:37 | |
| *** shu-mutou-AFK is now known as shu-mutou | 07:46 | |
| *** GB21 has joined #openstack-zaqar | 08:26 | |
| *** openstackstatus has joined #openstack-zaqar | 08:30 | |
| *** ChanServ sets mode: +v openstackstatus | 08:30 | |
| -openstackstatus- NOTICE: jobs depending on npm are now working again | 08:35 | |
| *** shu-mutou is now known as shu-mutou-AFK | 08:51 | |
| *** khushbu has joined #openstack-zaqar | 08:54 | |
| *** khushbu has quit IRC | 09:32 | |
| *** achanda has joined #openstack-zaqar | 09:56 | |
| *** akanksha_ has joined #openstack-zaqar | 10:01 | |
| *** achanda has quit IRC | 10:02 | |
| *** Qiming has quit IRC | 10:13 | |
| *** GB21 has quit IRC | 10:28 | |
| *** GB21 has joined #openstack-zaqar | 10:31 | |
| *** Guest12876 is now known as tesseract | 10:47 | |
| *** tesseract is now known as Guest74036 | 10:48 | |
| *** GB21 has quit IRC | 10:49 | |
| *** GB21 has joined #openstack-zaqar | 10:50 | |
| *** khushbu has joined #openstack-zaqar | 10:57 | |
| *** achanda has joined #openstack-zaqar | 10:58 | |
| *** achanda has quit IRC | 11:03 | |
| *** khushbu has quit IRC | 11:12 | |
| *** GB21 has quit IRC | 11:21 | |
| *** Qiming has joined #openstack-zaqar | 11:28 | |
| *** GB21 has joined #openstack-zaqar | 11:52 | |
| *** jhesketh has joined #openstack-zaqar | 11:58 | |
| *** ChanServ changes topic to "OpenStack Queuing and Notification Service || Smile :D || Meetings every Monday @ 21:00 UTC/15:00 UTC || Wiki: https://wiki.openstack.org/wiki/Zaqar || Paste: http://paste.openstack.org/ || Send messages and make some noise :D" | 11:58 | |
| *** khushbu_ has joined #openstack-zaqar | 12:02 | |
| *** jhesketh has quit IRC | 12:07 | |
| *** achanda has joined #openstack-zaqar | 12:07 | |
| *** jhesketh has joined #openstack-zaqar | 12:07 | |
| *** achanda has quit IRC | 12:15 | |
| *** GB21 has quit IRC | 12:16 | |
| *** achanda has joined #openstack-zaqar | 12:47 | |
| *** khushbu_ has quit IRC | 12:49 | |
| *** khushbu_ has joined #openstack-zaqar | 12:52 | |
| *** achanda has quit IRC | 12:58 | |
| EmilienM | can someone approve https://review.openstack.org/#/c/301380/ please ? | 13:01 |
| *** achanda has joined #openstack-zaqar | 13:08 | |
| *** shakamunyi has quit IRC | 13:10 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:11 | |
| *** shakamunyi has joined #openstack-zaqar | 13:12 | |
| *** achanda has quit IRC | 13:13 | |
| *** wanghao has quit IRC | 13:14 | |
| *** wanghao has joined #openstack-zaqar | 13:14 | |
| *** khushbu_ has quit IRC | 13:25 | |
| *** khushbu_ has joined #openstack-zaqar | 13:35 | |
| *** ametts has joined #openstack-zaqar | 13:56 | |
| *** mpanetta has joined #openstack-zaqar | 14:19 | |
| *** Qiming_ has joined #openstack-zaqar | 14:32 | |
| *** Qiming has quit IRC | 14:32 | |
| *** khushbu_ has quit IRC | 14:43 | |
| *** ametts has quit IRC | 14:48 | |
| *** ametts has joined #openstack-zaqar | 14:49 | |
| *** david_cu has joined #openstack-zaqar | 14:51 | |
| *** david_cu has quit IRC | 14:52 | |
| *** david_cu has joined #openstack-zaqar | 14:52 | |
| *** david_cu_ has joined #openstack-zaqar | 14:55 | |
| *** david_cu has quit IRC | 14:57 | |
| *** ametts has quit IRC | 14:57 | |
| *** Qiming_ has quit IRC | 14:57 | |
| *** ametts has joined #openstack-zaqar | 14:58 | |
| *** Qiming has joined #openstack-zaqar | 14:59 | |
| *** david_cu_ has quit IRC | 15:00 | |
| *** amitgandhinz has quit IRC | 15:04 | |
| *** khushbu has joined #openstack-zaqar | 15:08 | |
| *** Guest74036 has quit IRC | 15:10 | |
| *** amitgandhinz has joined #openstack-zaqar | 15:21 | |
| *** achanda has joined #openstack-zaqar | 15:24 | |
| *** david_cu has joined #openstack-zaqar | 15:29 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/302895 | 15:30 |
| *** achanda has quit IRC | 15:37 | |
| *** Qiming has quit IRC | 15:41 | |
| *** GB21 has joined #openstack-zaqar | 15:42 | |
| *** pcaruana has quit IRC | 15:53 | |
| *** shakamunyi has quit IRC | 15:56 | |
| *** ametts has quit IRC | 16:01 | |
| *** kgriffs|afk is now known as kgriffs | 16:13 | |
| *** ametts has joined #openstack-zaqar | 16:17 | |
| *** david_cu has quit IRC | 16:30 | |
| *** david-lyle has quit IRC | 16:36 | |
| *** amitgandhinz has quit IRC | 16:49 | |
| *** rcernin has quit IRC | 16:52 | |
| *** david-lyle has joined #openstack-zaqar | 17:06 | |
| *** ametts has quit IRC | 17:07 | |
| *** pcaruana has joined #openstack-zaqar | 17:08 | |
| *** david-lyle has quit IRC | 17:11 | |
| *** david-lyle has joined #openstack-zaqar | 17:17 | |
| *** ametts has joined #openstack-zaqar | 17:21 | |
| *** david-lyle has quit IRC | 17:23 | |
| *** amitgandhinz has joined #openstack-zaqar | 17:24 | |
| *** akanksha_ has quit IRC | 17:27 | |
| *** rcernin has joined #openstack-zaqar | 17:33 | |
| *** tqtran has joined #openstack-zaqar | 17:33 | |
| *** david-lyle has joined #openstack-zaqar | 17:58 | |
| *** kgriffs is now known as kgriffs|afk | 18:00 | |
| *** david_cu has joined #openstack-zaqar | 18:06 | |
| *** amitgandhinz has quit IRC | 18:37 | |
| *** njohnston has quit IRC | 18:49 | |
| *** GB21 has quit IRC | 19:03 | |
| *** shu-mutou-AFK has quit IRC | 19:04 | |
| *** david-lyle_ has joined #openstack-zaqar | 19:13 | |
| *** david-lyle has quit IRC | 19:15 | |
| *** david-lyle_ has quit IRC | 19:19 | |
| *** david-lyle has joined #openstack-zaqar | 19:29 | |
| *** david-lyle has quit IRC | 19:31 | |
| *** david-lyle has joined #openstack-zaqar | 19:31 | |
| *** khushbu has quit IRC | 19:32 | |
| *** david-lyle has quit IRC | 19:37 | |
| *** ametts has quit IRC | 20:01 | |
| *** jtomasek has quit IRC | 20:03 | |
| *** jtomasek has joined #openstack-zaqar | 20:05 | |
| *** ametts has joined #openstack-zaqar | 20:17 | |
| *** ametts has quit IRC | 20:41 | |
| *** david-lyle has joined #openstack-zaqar | 20:56 | |
| Eva-i | flwang: ryansb: Hello. Please look at my last comment in this review: https://review.openstack.org/#/c/294368/. Should I be more confident in case like this and just ask to do? | 20:58 |
| flwang | Eva-i: just had a quick look | 21:00 |
| flwang | Eva-i: we shouldn't hide the 404 | 21:00 |
| *** pcaruana has quit IRC | 21:01 | |
| *** davideagnello has quit IRC | 21:02 | |
| *** davideagnello has joined #openstack-zaqar | 21:02 | |
| Eva-i | flwang: Aha, okay, so I was unsure for a reason. Well, our API v1 in the client always pre-creates queue. So modifying metadata works. Our API v2 doesn't pre-create queue. I'm not saying hiding 404 error, but avoiding it, maintaining same behavior like in API v1 in the client. Still you want the behaviour in API v2 differ? | 21:04 |
| flwang | api v1 pre-create queue? are you sure? | 21:05 |
| flwang | the lazy queue was supported since v1.1, so i don't really understand your point | 21:05 |
| Eva-i | I'm sure. In API v1 no need pass "force_create=True" argument, so queue metadata modifying works without error. | 21:06 |
| flwang | Eva-i: we're going to deprecate v1 and we can't /shouldn't stay at v1 if we need better things happen | 21:06 |
| flwang | Eva-i: if the queue is not existing and user do update metadata, what happened? | 21:07 |
| Eva-i | In the client in API v2? Queue doesn't being auto-created, so PATCH request from the client returns 404 response from server. | 21:10 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support Tempest test as gate job https://review.openstack.org/302479 | 21:11 |
| Eva-i | In the client API v1 queue is auto-created by default. So the request changing metadata succeds. | 21:11 |
| Eva-i | To make sure queue is created in API v2, the user must pass "force_create=True" to the Queue constructor. | 21:12 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Support Tempest test as gate job https://review.openstack.org/302479 | 21:12 |
| flwang | i think you're mixing v1 and v1.1 | 21:13 |
| Eva-i | https://github.com/openstack/python-zaqarclient/blob/master/zaqarclient/queues/v1/queues.py#L74 | 21:13 |
| flwang | Eva-i: ok, i see | 21:14 |
| Eva-i | It was okay to not pre-create queue in API v1.1 and API v2, because there were no operations that could fail because of unexising queue. Now we have queue metadata PATCH that can throw 404 error. | 21:14 |
| flwang | that because, in v1, when user call any our queue commands | 21:14 |
| flwang | the client will create a queue | 21:14 |
| Eva-i | That's all I can say about it. | 21:15 |
| flwang | i got it now | 21:15 |
| flwang | but | 21:15 |
| flwang | like i mentioned in the server patch, i don't think a metadata update action should create the queue automatically | 21:16 |
| flwang | just you want to delete a non-existing queue | 21:16 |
| flwang | you should get 404 instead of creating it and delete it | 21:16 |
| Eva-i | Oki. So the users must pass "force_create" to make it work. | 21:16 |
| flwang | Eva-i: for case, why do we have to do any trick instead of throwing the 404? | 21:17 |
| *** shakamunyi has joined #openstack-zaqar | 21:17 | |
| flwang | just to stay at the old v1 mode? | 21:18 |
| Eva-i | flwang: yes | 21:18 |
| flwang | no | 21:18 |
| Eva-i | flwang: happily we can define now any behavior we want | 21:18 |
| flwang | you and me have had many discussion about this kind case | 21:19 |
| Eva-i | flwang: because in client API v2 setting metadata is something new. | 21:19 |
| flwang | about the backward compatibility | 21:19 |
| flwang | i totally understand backward compatibility is very important | 21:19 |
| flwang | but again, it's case by case | 21:19 |
| Eva-i | flwang: there's no backward compatibility problem in this case. As I said it's because in API v2 setting metadata is something new. | 21:20 |
| flwang | my personal policy is if we're making things much better, then sometimes we have to drop something | 21:20 |
| *** njohnsto_ has joined #openstack-zaqar | 21:20 | |
| flwang | Eva-i: then why do we have to 'hide' the 404? | 21:21 |
| flwang | if compatibility is not your concern | 21:23 |
| *** shakamunyi has quit IRC | 21:24 | |
| *** flwang1 has joined #openstack-zaqar | 21:24 | |
| Eva-i | flwang: "just to stay in the old v1 mode". And also to make things more convenient. Also I find auto_create and force_create arguments a bit confusing for Queue constructor. Even if auto_create is True, the queue will not be created in API v2 and API v1.1. There was no problem with it until API v2 started getting 404 error. | 21:24 |
| Eva-i | flwang: I'm okay with with both options. Just prefer other more. | 21:25 |
| flwang | "just to stay in the old v1 mode", like i said, for this case, i won't go for it | 21:28 |
| Eva-i | flwang: yes, sure | 21:29 |
| flwang | as for the constructor of queue, yep, we need to improve it | 21:29 |
| flwang | i know what's the problem, but i haven't got a chance to fix it | 21:29 |
| flwang | it's complex because the lazy thing | 21:29 |
| flwang | and because we always want to support v1 | 21:30 |
| Eva-i | It's not complex. Pre-creating queue doesn't do any harm as I know. | 21:30 |
| Eva-i | In case of metadata operations. | 21:31 |
| flwang | ok | 21:31 |
| flwang | can you fix it if you think it's easy? ;) | 21:31 |
| *** kgriffs|afk is now known as kgriffs | 21:34 | |
| Eva-i | flwang: yes. I would just put "ensure_exists(force-create=True)" after this line: https://review.openstack.org/#/c/294368/15/zaqarclient/queues/v2/queues.py@60. Or I don't see something bad? | 21:35 |
| Eva-i | *"self.ensure_exists(force-create=True)" | 21:36 |
| Eva-i | flwang: I might be wrong. I don't know.... | 21:37 |
| Eva-i | flwang: you made me doubt. I guess now I don't have any strong opinion. | 21:38 |
| flwang | Eva-i: again, why do you think when user want to update an non-existing stuff, we should create a new one for them? especially user may want to remove a key from the metadata | 21:40 |
| flwang | for me, it's really weird | 21:40 |
| flwang | and i don't think it's a same scenario as the posting messages case | 21:41 |
| Eva-i | flwang: there's no removing just a key in the client patch. There's setting whole metadata dict. | 21:42 |
| flwang | lets forget the code | 21:42 |
| flwang | let's focus on the real case | 21:42 |
| flwang | why do you think when user want to update an non-existing stuff, we should create a new one for them? | 21:43 |
| flwang | did you see it in any other place? | 21:43 |
| Eva-i | flwang: maybe not updating, but setting. it's the same as sending messages to non-existing place. | 21:45 |
| Eva-i | flwang: I don't know. I don't have any more arguments. If you are still not convinced, let's just go your way. | 21:46 |
| Eva-i | ;) | 21:46 |
| Eva-i | I knew from the start that the idea of metadata for queues is not fully compatible with the idea of queue laziness. There's a contradiction, so I don't have a precise answer. | 21:47 |
| Eva-i | There's no right answer. | 21:47 |
| Eva-i | Either way is fine. Just in one case the user need to handle 404 error. Maybe we just should leave a comment in this method docstring that it can throw 404 error. | 21:50 |
| *** mpanetta has quit IRC | 21:51 | |
| Eva-i | The library user has to keep in mind 404 error and be more careful. | 21:59 |
| *** david_cu has quit IRC | 22:00 | |
| flwang | Eva-i: yep, we can add DocImpact for the patch | 22:02 |
| flwang | and i'm happy to hear the other voices | 22:02 |
| flwang | Eva-i: FWIW, it's a good talk | 22:06 |
| flwang | thanks | 22:06 |
| *** david_cu has joined #openstack-zaqar | 22:08 | |
| *** david_cu has quit IRC | 22:12 | |
| Eva-i | flwang: thank you too! | 22:12 |
| *** kgriffs is now known as kgriffs|afk | 22:13 | |
| *** shakamunyi has joined #openstack-zaqar | 22:18 | |
| *** barra204 has joined #openstack-zaqar | 22:20 | |
| *** shakamunyi has quit IRC | 22:24 | |
| *** barra204 has quit IRC | 22:25 | |
| flwang | vkmc: any luck you around? | 22:28 |
| *** rcernin has quit IRC | 22:29 | |
| *** Qiming has joined #openstack-zaqar | 23:09 | |
| *** tqtran has quit IRC | 23:27 | |
| openstackgerrit | Merged openstack/zaqar: Added samples in multiple languages https://review.openstack.org/294971 | 23:56 |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!