| *** tqtran has quit IRC | 00:54 | |
| *** Qiming_ has joined #openstack-zaqar | 01:03 | |
| *** stanchan has quit IRC | 01:12 | |
| *** amitgandhinz has joined #openstack-zaqar | 01:14 | |
| *** tqtran has joined #openstack-zaqar | 01:51 | |
| openstackgerrit | Eva Balycheva proposed openstack/zaqar: Fix cache decorator tests https://review.openstack.org/314396 | 01:54 |
|---|---|---|
| *** tqtran has quit IRC | 01:57 | |
| Eva-i | flwang: so I did investigation. It was originally bug in oslo.cache. Then it was fixed in a backward incompatible way (it's just can't be fixed other way). And so Zaqar test code needs to be changed. | 01:57 |
| flwang | Eva-i: so we only need to change the test code, not the main logic code, right? | 02:02 |
| Eva-i | flwang: yes, main logic will continue safely working, though it will make some useless work (like packing info, trying to set cache, trying to get from cache). See https://github.com/openstack/zaqar/blob/master/zaqar/common/decorators.py#L76 | 02:05 |
| Eva-i | flwang: Now this line https://github.com/openstack/zaqar/blob/master/zaqar/common/decorators.py#L134 is always true, when cache is not explicitly enabled by the user/test. We can improve it, if you want. We can make it stop trying to do caching if it detects disabled cache. | 02:08 |
| Eva-i | flwang: good bye, Fei Long, I'm going to sleep. You can think if you want to improve decorator or not. | 02:26 |
| flwang | Eva-i: ok, thanks | 02:27 |
| *** amitgandhinz has quit IRC | 03:44 | |
| *** tqtran has joined #openstack-zaqar | 03:53 | |
| *** tqtran has quit IRC | 03:57 | |
| *** mdnadeem_ has left #openstack-zaqar | 04:20 | |
| *** Qiming_ has quit IRC | 04:23 | |
| *** Qiming_ has joined #openstack-zaqar | 04:26 | |
| *** Qiming_ has quit IRC | 04:55 | |
| *** Qiming_ has joined #openstack-zaqar | 05:01 | |
| *** amitgandhinz has joined #openstack-zaqar | 05:45 | |
| *** amitgandhinz has quit IRC | 05:50 | |
| *** rcernin has joined #openstack-zaqar | 06:26 | |
| *** amitgandhinz has joined #openstack-zaqar | 06:46 | |
| *** amitgandhinz has quit IRC | 06:51 | |
| *** tesseract has joined #openstack-zaqar | 07:03 | |
| *** amitgandhinz has joined #openstack-zaqar | 07:48 | |
| *** amitgandhinz has quit IRC | 07:53 | |
| *** vipuls has quit IRC | 08:22 | |
| *** vipuls has joined #openstack-zaqar | 08:25 | |
| *** amitgandhinz has joined #openstack-zaqar | 08:49 | |
| *** amitgandhinz has quit IRC | 08:54 | |
| *** vipul- has joined #openstack-zaqar | 09:13 | |
| *** vipuls has quit IRC | 09:13 | |
| *** amitgandhinz has joined #openstack-zaqar | 09:50 | |
| *** amitgandhinz has quit IRC | 09:54 | |
| *** Qiming_ is now known as Qiming_afk | 10:30 | |
| *** Qiming_afk is now known as Qiming | 10:45 | |
| *** Qiming has quit IRC | 10:46 | |
| *** amitgandhinz has joined #openstack-zaqar | 10:50 | |
| *** amitgandhinz has quit IRC | 10:55 | |
| *** amitgandhinz has joined #openstack-zaqar | 11:51 | |
| *** amitgandhinz has quit IRC | 11:56 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:52 | |
| *** amitgandhinz has quit IRC | 12:57 | |
| *** Qiming has joined #openstack-zaqar | 12:58 | |
| *** itisha has quit IRC | 12:59 | |
| *** Qiming has quit IRC | 13:05 | |
| *** amitgandhinz has joined #openstack-zaqar | 13:24 | |
| *** AAzza has quit IRC | 13:47 | |
| *** AAzza has joined #openstack-zaqar | 13:48 | |
| *** AAzza has quit IRC | 13:52 | |
| *** AAzza has joined #openstack-zaqar | 13:53 | |
| *** ametts has joined #openstack-zaqar | 13:58 | |
| *** Qiming__ has joined #openstack-zaqar | 14:00 | |
| *** Qiming__ has quit IRC | 14:09 | |
| *** mpanetta_ has joined #openstack-zaqar | 14:11 | |
| *** pcaruana has joined #openstack-zaqar | 14:53 | |
| *** david_cu_ has joined #openstack-zaqar | 15:21 | |
| *** flwang has quit IRC | 15:39 | |
| *** tesseract has quit IRC | 15:52 | |
| *** flwang has joined #openstack-zaqar | 15:58 | |
| Eva-i | ryansb: hello, dear Ryan. Can you please review this tiny patch https://review.openstack.org/#/c/314396/ ? It fixes failing tests. You can see them fail for example here: https://review.openstack.org/#/c/314273/. | 16:18 |
| *** tqtran has joined #openstack-zaqar | 16:26 | |
| Eva-i | ryansb: thanks | 16:33 |
| ryansb | :D | 16:33 |
| *** flaper87 has quit IRC | 16:46 | |
| *** flaper87 has joined #openstack-zaqar | 16:46 | |
| Eva-i | ryansb: BTW, how are you? Have you rested well from the trip to Austin? | 16:48 |
| *** david_cu_ has quit IRC | 17:06 | |
| *** david_cu_ has joined #openstack-zaqar | 17:07 | |
| *** david_cu_ has quit IRC | 17:11 | |
| *** david_cu_ has joined #openstack-zaqar | 18:07 | |
| *** david_cu_ has quit IRC | 18:13 | |
| *** rcernin has quit IRC | 18:13 | |
| *** david_cu_ has joined #openstack-zaqar | 18:30 | |
| *** rcernin has joined #openstack-zaqar | 18:43 | |
| *** pcaruana has quit IRC | 19:12 | |
| *** rcernin has quit IRC | 19:51 | |
| *** rcernin has joined #openstack-zaqar | 19:58 | |
| *** ametts has quit IRC | 21:17 | |
| openstackgerrit | Merged openstack/zaqar: Fix cache decorator tests https://review.openstack.org/314396 | 21:17 |
| *** mpanetta_ has quit IRC | 21:44 | |
| *** amitgandhinz has quit IRC | 22:11 | |
| *** rcernin has quit IRC | 23:28 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!