| Eva-i | flwang: should I approve this patch even if tests still fail with falcon in python 3 environment and create a additional patch? | 00:00 |
|---|---|---|
| flwang | wait a moment | 00:00 |
| flwang | Eva-i: i didn't notice the ascii failures | 00:00 |
| Eva-i | flwang: it's in zaqar.tests.unit.transport.wsgi.v2_0.test_messages.TestMessagesMongoDB test class | 00:01 |
| Eva-i | flwang: sorry, I just provided test case name instead of test class name. Please look again | 00:02 |
| flwang | Eva-i: and more zaqar.tests.unit.transport.wsgi.v1_1.test_queue_lifecycle.TestQueueLifecycleMongoDB | 00:03 |
| Eva-i | flwang: yes | 00:03 |
| flwang | kgriffs: around? | 00:03 |
| Eva-i | flwang: will we backport this patch? | 00:03 |
| Eva-i | flwang: if yes, then it's better to solve all compatibility problem in single patch | 00:04 |
| Eva-i | flwang: I think | 00:04 |
| flwang | Eva-i: i don't think we should backport this, personally, i prefer to bump the falcon version for mitaka and previous | 00:04 |
| Eva-i | flwang: you mean to limit falcon version in requirements.txt? | 00:05 |
| Eva-i | flwang: for old Zaqar releases | 00:05 |
| flwang | Eva-i: yes, thought it may be a little bit hard | 00:06 |
| flwang | Eva-i: pls help take a look at the ascii issue, i will be back after lunch | 00:07 |
| flwang | thanks | 00:07 |
| Eva-i | flwang: oki, sure =) | 00:08 |
| flwang | ttyl | 00:08 |
| tqtran | flwang: is there a way to add metadata to a queue using openstack cli? | 00:11 |
| tqtran | or would i have to use curl to achieve that? | 00:11 |
| Eva-i | tqtran: hello. If it's Zaqar API v2 I think first we should merge this patch to python-zaqarclient once it's ready: https://review.openstack.org/#/c/294368/. Then setting metadata to queue using API v2 and python-zaqarclient will work. I'm not sure, now curl requests might be the only option. | 00:14 |
| Eva-i | tqtran: but we will fix it soon in python-zaqarclient | 00:15 |
| tqtran | ah i see, and im assuming that we will have to update openstack client too? | 00:15 |
| Eva-i | tqtran: maybe if you instantiate the client with api v1 specified, setting metadata will work | 00:15 |
| tqtran | right now, the only options i see are create, delete, list and stats | 00:16 |
| Eva-i | tqtran: yes | 00:17 |
| *** amitgandhinz has joined #openstack-zaqar | 00:19 | |
| Eva-i | tqtran: so for now for working with queue metadata, maybe try to use api v1 in openstack CLI (with python-zaqarclient plugin) or in python-zaqarclient as lib. | 00:20 |
| Eva-i | until the patch will be merged | 00:20 |
| *** tqtran has quit IRC | 00:22 | |
| Eva-i | tqtran: also we don't have to update openstack client, we just have to update our python-zaqarcleint which is used as plugin in openstack client. | 00:22 |
| *** rcernin has quit IRC | 00:24 | |
| *** shu-mutou has joined #openstack-zaqar | 00:54 | |
| Eva-i | flwang: okay, I found this: https://www.diffchecker.com/x7guc75k | 00:56 |
| Eva-i | flwang: I'm don't know now how to fix it and I'm going to sleep soon. I'm reading PEP 3333 now. | 00:57 |
| Eva-i | flwang: sorry for my english today, I make too many mistakes | 00:58 |
| *** openstackgerrit has quit IRC | 01:02 | |
| *** openstackgerrit has joined #openstack-zaqar | 01:03 | |
| Eva-i | flwang: here's an updated diff for better clarity: https://www.diffchecker.com/qe5tzftr | 01:09 |
| flwang | Eva-i: cool, thanks | 01:09 |
| Eva-i | flwang: I think we should catch this exception somewhere to send 400 error request as usual in this case | 01:17 |
| flwang | Eva-i: yep, it's a bigger change than current patch | 01:18 |
| flwang | and your investigation is valuable | 01:18 |
| flwang | thanks a lot | 01:18 |
| Eva-i | flwang: thank you too for today. I'm going to sleep now. | 01:21 |
| wxy | flwang: Eva-i: tqtran: the patch https://review.openstack.org/#/c/294368/. has be ready for review for some time. | 01:21 |
| Eva-i | wxy: yes | 01:22 |
| flwang | Eva-i: good night | 01:23 |
| flwang | wxy: since the summit, patches are delayed | 01:24 |
| flwang | wxy: i will review it today and sorry the delay, pls blame me | 01:25 |
| wxy | flwang: It doesn't matter. | 01:28 |
| *** david_c__ has joined #openstack-zaqar | 01:32 | |
| *** david_cu_ has quit IRC | 01:35 | |
| *** amitgandhinz has quit IRC | 02:43 | |
| *** tqtran has joined #openstack-zaqar | 03:47 | |
| *** tqtran has quit IRC | 03:48 | |
| openstackgerrit | ZhiQiang Fan proposed openstack/zaqar: remove verbose option in devstack plugin https://review.openstack.org/315875 | 04:30 |
| *** amitgandhinz has joined #openstack-zaqar | 04:44 | |
| *** amitgandhinz has quit IRC | 04:49 | |
| *** amitgandhinz has joined #openstack-zaqar | 05:45 | |
| *** eliqiao has quit IRC | 05:45 | |
| *** amitgandhinz has quit IRC | 05:49 | |
| *** rcernin has joined #openstack-zaqar | 05:50 | |
| *** eliqiao has joined #openstack-zaqar | 05:52 | |
| *** flwang1 has joined #openstack-zaqar | 06:40 | |
| flwang1 | Eva-i: wxy: wanghao: around? | 06:40 |
| *** amitgandhinz has joined #openstack-zaqar | 06:46 | |
| *** amitgandhinz has quit IRC | 06:50 | |
| *** tesseract has joined #openstack-zaqar | 06:56 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Move to falcon middleware https://review.openstack.org/315737 | 07:37 |
| *** mdnadeem has joined #openstack-zaqar | 07:40 | |
| therve | flwang, Hey there. So what's going on with that patch? | 07:41 |
| *** mdnadeem_ has quit IRC | 07:43 | |
| *** flwang1 has quit IRC | 07:46 | |
| *** amitgandhinz has joined #openstack-zaqar | 07:46 | |
| *** amitgandhinz has quit IRC | 07:52 | |
| therve | :/ | 07:55 |
| Eva-i | therve: hello | 07:56 |
| therve | Hey | 07:56 |
| Eva-i | therve: there are two problems with compatibility with the new falcon version, this patch only solves one of these problems | 07:57 |
| therve | Eva-i, What's the other one? | 07:57 |
| Eva-i | therve: will it be okay if I approve this patch and add additional patch later? | 07:57 |
| therve | Well I don't really care, I need zaqar to start :) | 07:58 |
| therve | It's blocking heat gate | 07:58 |
| Eva-i | therve: okay, I'll approve your patch. I think heat gate will work after that. | 07:58 |
| Eva-i | therve: the other problem is wrong ascii test failing, see ascii-related tests here: http://logs.openstack.org/37/315737/1/check/gate-zaqar-python34/7d38be0/testr_results.html.gz | 07:59 |
| therve | That'd be cool | 07:59 |
| therve | Eva-i, Isn't that fixed by latest flwang change? | 07:59 |
| therve | If the tests are failing it's not like you'll be able to land it anyway :) | 08:00 |
| Eva-i | therve: okay, let me see if flwang fixed it | 08:00 |
| Eva-i | therve: I just got up and only saw chat | 08:00 |
| Eva-i | therve: aha, he didn't fixed the problem, just made ascii tests pass temporarly. | 08:05 |
| therve | Ah okay :) | 08:05 |
| Eva-i | therve: I don't like it much, but will still approve. | 08:06 |
| therve | Eva-i, Is it only a py3 issue? | 08:06 |
| Eva-i | therve: yes | 08:06 |
| therve | So yeah I think we can live with that for a bit :) | 08:06 |
| Eva-i | therve: falcon lib changed in this way: https://www.diffchecker.com/qe5tzftr | 08:07 |
| Eva-i | therve: sure | 08:07 |
| therve | Eva-i, Seems to pass, can you approve it? | 08:12 |
| Eva-i | therve: oki, done | 08:16 |
| therve | Thanks a ton! | 08:17 |
| therve | Ah hum | 08:17 |
| therve | Eva-i, Maybe I'm asking a lot, but can you actually approve it :) | 08:17 |
| therve | Unless flaper87 roams around | 08:17 |
| Eva-i | therve: you mean do workflow +1? | 08:17 |
| therve | Yes | 08:18 |
| Eva-i | therve: okay | 08:18 |
| *** flwang1 has joined #openstack-zaqar | 08:28 | |
| flwang1 | therve: Eva-i has merged it | 08:30 |
| *** Kevin_Zheng has quit IRC | 08:31 | |
| flwang1 | therve: thanks again for the quick fix | 08:32 |
| *** eliqiao has quit IRC | 08:32 | |
| Eva-i | therve: yes, thank you! | 08:33 |
| openstackgerrit | Merged openstack/zaqar: Move to falcon middleware https://review.openstack.org/315737 | 08:33 |
| *** eliqiao has joined #openstack-zaqar | 08:33 | |
| flwang1 | Eva-i: thanks for the approval | 08:34 |
| Eva-i | flwang1: sure, no problem | 08:39 |
| *** flwang1 has quit IRC | 08:46 | |
| therve | Sweet | 08:47 |
| *** amitgandhinz has joined #openstack-zaqar | 08:49 | |
| *** flwang1 has joined #openstack-zaqar | 08:50 | |
| *** amitgandhinz has quit IRC | 08:53 | |
| flwang1 | Eva-i: any suggestion for the fix the ascii issue? | 09:00 |
| flwang1 | in my test, if there is unicode words in path, user will get 404 instead of 400, can you confirm that? | 09:07 |
| *** Kevin_Zheng has joined #openstack-zaqar | 09:20 | |
| Kevin_Zheng | flwang1: do we have an IRC channel for distil? | 09:21 |
| wxy | flwang1: what's up? Just be online from a meeting. | 09:47 |
| *** amitgandhinz has joined #openstack-zaqar | 09:49 | |
| Eva-i | flwang1: I send request with unicode characters via curl to Zaqar on python 3 and get 400 error. | 09:49 |
| Eva-i | flwang1: maybe I'm doing something wrong | 09:50 |
| Eva-i | flwang1: how do you test it? | 09:50 |
| *** amitgandhinz has quit IRC | 09:54 | |
| flwang1 | Eva-i: have you upgrade to falcon 1.0? | 10:02 |
| Eva-i | flwang1: yes | 10:02 |
| flwang1 | weird | 10:02 |
| flwang1 | i just try to PUT to create a queue | 10:03 |
| Eva-i | flwang1: http://paste.openstack.org/show/Dih7gCxtbSwgthV4zr2C/ | 10:04 |
| Eva-i | flwang1: me too as you see | 10:05 |
| flwang1 | Eva-i: ok, cool, i will try it again | 10:14 |
| flwang1 | Eva-i: so what's your concern about current fix? | 10:14 |
| Eva-i | flwang1: can you please tell me exact path you use in curl request | 10:14 |
| flwang1 | 127.0.0.1:8888/v2/queues/non-ascii-n\u0153me | 10:14 |
| Eva-i | flwang1: strange, I get this: http://paste.openstack.org/show/bcXeUy9wAPjMwXhNnvz1/ | 10:16 |
| Eva-i | flwang1: maybe curl performs some conversion... | 10:18 |
| flwang1 | Eva-i: try a pure http client | 10:20 |
| Eva-i | flwang1: which for example? | 10:20 |
| flwang1 | DHC on chrome | 10:20 |
| Eva-i | flwang1: okay | 10:21 |
| Eva-i | flwang1: aha, I see 404 error with your request. It's because either DHC or Zaqar interpreter "\" as "/" for some reason. | 10:28 |
| Eva-i | flwang1: and curl just ignores "\" sign, like it doesn't exist | 10:30 |
| flwang1 | Eva-i: ah, right | 10:31 |
| flwang1 | maybe it's related to DHC | 10:31 |
| Eva-i | flwang1: Zaqar returns nicely 400 error, when I add snail (🐌) to path. In both DHC and curl. | 10:32 |
| flwang1 | Eva-i: ok, cool | 10:32 |
| Eva-i | flwang1: So I can't reproduce the problem manually. So maybe Zaqar is working fine. | 10:33 |
| flwang1 | Eva-i: yep | 10:33 |
| flwang1 | Eva-i: "And by Fei Long's added patch set it basically turns off tests related to the problem two. | 10:33 |
| flwang1 | Personally I don't like this approach. The patch would still be good without turning off ascii-related tests. But I still approve it, because there's a block in heat gate currently." | 10:33 |
| flwang1 | can you explain more about this? | 10:33 |
| Eva-i | flwang1: yes. I thought you only made tests related to non-ascii characters pass and Zaqar code is still wrong. | 10:34 |
| Eva-i | flwang1: but maybe just our tests were not good. And Zaqar is working fine actually | 10:35 |
| Eva-i | with the new version of falcon | 10:35 |
| Eva-i | flwang1: so I guess I was wrong in my comment | 10:35 |
| Eva-i | flwang1: I'll add additional note to merged patch that I was wrong, all right? | 10:36 |
| flwang1 | i see | 10:36 |
| flwang1 | thanks :) | 10:36 |
| Eva-i | =) | 10:41 |
| therve | Eva-i, Are you trying with python3 though? | 10:49 |
| Eva-i | therve: yes | 10:49 |
| therve | OK cool | 10:49 |
| Eva-i | therve: and with updated falcon | 10:49 |
| Eva-i | therve: everything seems fine now | 10:49 |
| Eva-i | therve: I just was wrong | 10:50 |
| therve | That happens to the best of us | 10:50 |
| *** amitgandhinz has joined #openstack-zaqar | 10:50 | |
| *** amitgandhinz has quit IRC | 10:54 | |
| *** wanghao has quit IRC | 11:10 | |
| *** wanghao has joined #openstack-zaqar | 11:12 | |
| *** amitgandhinz has joined #openstack-zaqar | 11:51 | |
| *** amitgandhinz has quit IRC | 11:55 | |
| *** shu-mutou is now known as shu-mutou-AFK | 12:19 | |
| *** rcernin_ has joined #openstack-zaqar | 12:42 | |
| *** rcernin has quit IRC | 12:42 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:51 | |
| *** amitgandhinz has quit IRC | 12:57 | |
| *** amitgandhinz has joined #openstack-zaqar | 12:57 | |
| *** rcernin_ has quit IRC | 13:16 | |
| *** odyssey4me has quit IRC | 13:21 | |
| *** odyssey4me has joined #openstack-zaqar | 13:21 | |
| *** rcernin has joined #openstack-zaqar | 13:27 | |
| *** openstack has joined #openstack-zaqar | 13:45 | |
| *** openstack has joined #openstack-zaqar | 13:53 | |
| *** ametts has joined #openstack-zaqar | 14:04 | |
| *** njohnston_afk is now known as njohnston__ | 14:05 | |
| *** dynarro has joined #openstack-zaqar | 14:27 | |
| *** openstackgerrit has quit IRC | 15:17 | |
| *** openstackgerrit has joined #openstack-zaqar | 15:18 | |
| *** GB21 has joined #openstack-zaqar | 15:55 | |
| *** tesseract has quit IRC | 15:56 | |
| *** rcernin has quit IRC | 16:02 | |
| *** mpanetta has joined #openstack-zaqar | 16:04 | |
| openstackgerrit | OpenStack Proposal Bot proposed openstack/zaqar: Updated from global requirements https://review.openstack.org/314383 | 16:08 |
| *** GB21 has quit IRC | 16:15 | |
| *** mpanetta_ has joined #openstack-zaqar | 16:31 | |
| *** mpanetta_ has quit IRC | 16:32 | |
| *** mpanetta_ has joined #openstack-zaqar | 16:33 | |
| *** mpanetta has quit IRC | 16:33 | |
| *** david_c__ has quit IRC | 16:38 | |
| *** david_cu_ has joined #openstack-zaqar | 16:38 | |
| *** david_cu_ has quit IRC | 16:42 | |
| *** dynarro has quit IRC | 17:07 | |
| *** david_cu_ has joined #openstack-zaqar | 17:39 | |
| *** david_cu_ has quit IRC | 17:44 | |
| *** david_cu_ has joined #openstack-zaqar | 18:15 | |
| *** amitgandhinz has left #openstack-zaqar | 18:36 | |
| *** khushbu_ has joined #openstack-zaqar | 18:57 | |
| *** ri0 has joined #openstack-zaqar | 19:49 | |
| *** ri0 has quit IRC | 20:01 | |
| *** khushbu_ has quit IRC | 20:19 | |
| *** ametts has quit IRC | 20:36 | |
| *** david_c__ has joined #openstack-zaqar | 21:01 | |
| *** david_cu_ has quit IRC | 21:04 | |
| *** david_c__ has quit IRC | 21:12 | |
| *** david_cu_ has joined #openstack-zaqar | 21:12 | |
| *** david_cu_ has quit IRC | 21:17 | |
| *** mpanetta_ has quit IRC | 23:11 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!