| openstackgerrit | wanghao proposed openstack/zaqar: [WIP]Subscription Confirmation Support for MongoDB https://review.openstack.org/316601 | 01:01 |
|---|---|---|
| *** tqtran has quit IRC | 01:16 | |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Adding Negative tests cases to Zaqar v2 https://review.openstack.org/319825 | 01:52 |
| wxy | flwang: So jtomasek's problem is these two bug: https://bugs.launchpad.net/zaqar/+bug/1590112 https://bugs.launchpad.net/zaqar/+bug/1590173 | 02:13 |
| openstack | Launchpad bug 1590112 in zaqar "Zaqar can't delete the dead subscription for websocket" [High,New] - Assigned to Fei Long Wang (flwang) | 02:13 |
| openstack | Launchpad bug 1590173 in zaqar "Notifier can't get all the subscriptions due to the default limit" [High,New] - Assigned to Fei Long Wang (flwang) | 02:13 |
| wxy | flwang: right? | 02:14 |
| flwang1 | wxy: it's the 2nd one | 02:23 |
| flwang1 | but the first one should be fixed as well | 02:23 |
| wxy | flwang1: got it. BTW, our redis backend still has some bugs. This is one fix for it. Could you please take a look at it? https://review.openstack.org/#/c/326287/ | 02:29 |
| wxy | flwang1: My purpose is to merge this one asap: https://review.openstack.org/#/c/319825/ to make our tempest test stronger. | 02:31 |
| *** openstackgerrit has quit IRC | 02:47 | |
| *** openstackgerrit has joined #openstack-zaqar | 02:48 | |
| flwang1 | wxy: so you mean https://review.openstack.org/#/c/326287/ will fix the redis failure of https://review.openstack.org/#/c/319825/ ? | 03:23 |
| wxy | flwang1: not all. And this bug: https://bugs.launchpad.net/zaqar/+bug/1590227 | 03:24 |
| openstack | Launchpad bug 1590227 in zaqar "(redis) message for a queue is not lazy" [Undecided,New] | 03:24 |
| wxy | flwang1: this two can solve the redis failure. | 03:24 |
| flwang1 | wxy: but we don't have a fix for https://bugs.launchpad.net/zaqar/+bug/1590227 | 03:25 |
| openstack | Launchpad bug 1590227 in zaqar "(redis) message for a queue is not lazy" [Undecided,New] | 03:25 |
| flwang1 | yet | 03:25 |
| wxy | flwang1: yes. I created it just now. | 03:26 |
| flwang1 | wxy: awesome, thanks for taking care our redis | 03:26 |
| flwang1 | which difinately needs some love | 03:27 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: Fix the wrong check of X-PROJECT-ID https://review.openstack.org/305035 | 03:30 |
| flwang1 | wxy: ping | 04:32 |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Fix subscription limit per queue https://review.openstack.org/326710 | 04:32 |
| flwang1 | wanghao: ping | 04:33 |
| wxy | flwang: pong | 04:33 |
| flwang1 | i have tested https://review.openstack.org/326710 and uploaded a new patch set | 04:33 |
| flwang1 | but it needs a little bit change for the test case | 04:33 |
| flwang1 | can you help take a look? i'm going to off to pick my son | 04:33 |
| wxy | flwang: sure. leave it to ours | 04:34 |
| flwang1 | wxy: thanks | 04:34 |
| flwang1 | it would be nice if you can verify the fix as well | 04:35 |
| flwang1 | thank you, ttyl | 04:35 |
| wxy | flwang: ok. I'll try | 04:35 |
| wxy | np | 04:36 |
| *** njohnston is now known as njohnston|sleep | 04:53 | |
| Eva-i | flwang1: flwang: sorry, no "message id in notifications" proof-of=concept patch for today, almost done though. | 05:03 |
| *** GB21 has joined #openstack-zaqar | 05:09 | |
| *** GB21 has quit IRC | 05:44 | |
| *** jtomasek has quit IRC | 06:01 | |
| *** GB21 has joined #openstack-zaqar | 06:06 | |
| wanghao | flwang1, pong | 06:06 |
| wanghao | flwang1: sure, will see it soon. | 06:08 |
| *** rcernin has joined #openstack-zaqar | 06:12 | |
| openstackgerrit | Thomas Herve proposed openstack/zaqar: Fix subscription limit per queue https://review.openstack.org/326710 | 06:39 |
| *** openstackgerrit has quit IRC | 06:48 | |
| *** openstackgerrit has joined #openstack-zaqar | 06:48 | |
| therve | wanghao, Thanks for the comment, I commit back the original patch and added a test | 06:54 |
| *** tesseract has joined #openstack-zaqar | 07:00 | |
| wanghao | therve: yeah, I saw it, thanks for working this bug. | 07:06 |
| wanghao | therve: I'll test it in my local env. | 07:07 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: [WIP]Subscription Confirmation Support for MongoDB https://review.openstack.org/316601 | 07:07 |
| openstackgerrit | wangxiyuan proposed openstack/zaqar: [WIP]Subscription Confirmation Support for MongoDB https://review.openstack.org/316601 | 07:15 |
| openstackgerrit | Thomas Herve proposed openstack/zaqar: Fix subscription limit per queue https://review.openstack.org/326710 | 07:25 |
| wanghao | therve, flwang: I tested this patch in my env, it works fine. We can merge it sonn after jekins is happy. | 07:28 |
| therve | wanghao, Yeah had a dumb pep8 error, should be better now | 07:28 |
| wanghao | therve: cool | 07:29 |
| *** openstackgerrit has quit IRC | 07:48 | |
| *** openstackgerrit has joined #openstack-zaqar | 07:48 | |
| openstackgerrit | Thomas Herve proposed openstack/zaqar: Remove leftovers on websocket disconnections https://review.openstack.org/326897 | 08:07 |
| *** openstackgerrit has quit IRC | 08:48 | |
| *** openstackgerrit has joined #openstack-zaqar | 08:48 | |
| *** GB21 has quit IRC | 08:53 | |
| flwang1 | therve: ping | 08:58 |
| therve | flwang1, Hey | 09:00 |
| flwang1 | therve: as for https://review.openstack.org/#/c/326710/, have you tested the code? | 09:03 |
| therve | flwang1, Yep | 09:03 |
| therve | wanghao did too | 09:04 |
| flwang1 | therve: ok, it didn't work for me, so i uploaded the patchset 2 | 09:05 |
| therve | flwang1, What was the issue? | 09:06 |
| flwang1 | only get 10 | 09:06 |
| flwang1 | therve: ok, anyway, i will test it again | 09:07 |
| *** GB21 has joined #openstack-zaqar | 09:09 | |
| *** GB21 has quit IRC | 09:18 | |
| flwang1 | therve: ok, it works for me this time | 09:19 |
| flwang1 | therve: would you mind adding a debug log for each notification sending? | 09:20 |
| flwang1 | at line 48 | 09:20 |
| therve | flwang1, Sure what do you want in it? | 09:20 |
| flwang1 | therve: just print the sub dict | 09:21 |
| flwang1 | then it would be easier to debug for operator in the future | 09:21 |
| flwang1 | i can do a nijia approve after adding the log | 09:22 |
| flwang1 | though it shouldn't be a blocker | 09:22 |
| flwang1 | wxy: wanghao: can you guys propose a patch for project-config to switch the voting of the zaqarclient functional test and tempest test? | 09:24 |
| wxy | flwang1: It's time to be off. I can do it tonight. | 09:31 |
| flwang1 | wxy: ok, sorry, no problem. i can do it :) | 09:31 |
| wxy | flwang1: I think that do we need this patch be merged first? https://review.openstack.org/#/c/319825/ | 09:32 |
| wxy | flwang1: to make sure the tempest is ok enough. | 09:32 |
| flwang1 | wxy: i prefer to hold it until we fix the failure | 09:33 |
| flwang1 | it's time to switch the voting of tempest and functional test | 09:34 |
| openstackgerrit | Thomas Herve proposed openstack/zaqar: Fix subscription limit per queue https://review.openstack.org/326710 | 09:34 |
| openstackgerrit | Thomas Herve proposed openstack/zaqar: Remove leftovers on websocket disconnections https://review.openstack.org/326897 | 09:34 |
| wxy | flwang1: Ok, let's do it. | 09:34 |
| flwang1 | what's your thought to get the nagative tempest test in asap? | 09:34 |
| wxy | flwang1: If you are busy. Leave it to me. | 09:35 |
| flwang1 | i mean why those negative test need to be merged ASAP? | 09:35 |
| wxy | flwang1: It can ensure our new patch is better. | 09:37 |
| flwang1 | wxy: oh, yes, but i think we should change the voting first unless the patch can pass all the tests | 09:38 |
| flwang1 | since it can't now, so i would prefer to leave it a while | 09:38 |
| flwang1 | i'm sorry for that | 09:38 |
| flwang1 | therve: thanks for the new patch sets | 09:38 |
| therve | np | 09:38 |
| flwang1 | wxy: can you give it a bless https://review.openstack.org/#/c/326710/5 ? | 09:38 |
| flwang1 | therve: i just realized you have contributed to zaqar over 50 commits | 09:40 |
| *** GB21 has joined #openstack-zaqar | 09:42 | |
| therve | Cool | 09:42 |
| odyssey4me | flwang1 kong I've created a specialist core group for openstack-ansible-os_zaqar and have added you both to it. You may manage the group at your discretion. https://review.openstack.org/#/admin/groups/1406,members | 10:46 |
| *** tesseract has quit IRC | 10:50 | |
| *** tesseract has joined #openstack-zaqar | 10:51 | |
| openstackgerrit | Merged openstack/zaqar: Fix subscription limit per queue https://review.openstack.org/326710 | 11:23 |
| *** eggmaster has joined #openstack-zaqar | 11:53 | |
| *** GB21 has quit IRC | 12:23 | |
| eggmaster | flaper87: Hi there. As I mentioned to you in pvt, I'm standing up a zaqar dev env to test a patch. Following this http://docs.openstack.org/developer/zaqar/devref/development.environment.html | 12:44 |
| eggmaster | I can bring up 'zaqar-server -d' and see connections to mongodb increase | 12:44 |
| eggmaster | However when I run 'tox -epy27' I see some errors around bad uri for mongodb connection, see https://paste.fedoraproject.org/376169/65389814/ | 12:45 |
| eggmaster | Just wondering if those stacktraces are real errors. Output suggests success..."congratulations :)" :) | 12:46 |
| eggmaster | unless it's sarcastically trolling me ;) | 12:46 |
| *** njohnston|sleep is now known as njohnston | 13:28 | |
| *** wanghao_ has joined #openstack-zaqar | 13:45 | |
| *** ametts has joined #openstack-zaqar | 14:02 | |
| *** mpanetta has joined #openstack-zaqar | 14:08 | |
| *** pt_15 has joined #openstack-zaqar | 14:28 | |
| openstackgerrit | Merged openstack/zaqar: Use assertEqual/GreaterEqual/LessEqual https://review.openstack.org/286541 | 14:30 |
| Eva-i | eggmaster: Hello. For some reason few months ago py tests started to show much junk. We haven't figured why though. But if tests are saying "congratulations" then they pass. | 14:35 |
| eggmaster | Eva-i: thanks! | 15:56 |
| *** wanghao_ has quit IRC | 15:58 | |
| *** tesseract has quit IRC | 16:31 | |
| *** rcernin has quit IRC | 16:42 | |
| flwang1 | flaper87: any luck you around? are you still working on the deprecate v1.1? | 17:03 |
| flwang1 | odyssey4me: awesome, thanks | 17:03 |
| *** itisha has joined #openstack-zaqar | 17:26 | |
| -openstackstatus- NOTICE: Zuul has been restarted to correct an error condition. Events since 17:30 may have been missed; please 'recheck' your changes if they were uploaded since then, or have "NOT_REGISTERED" errors. | 18:11 | |
| openstackgerrit | Steve Linabery proposed openstack/zaqar: Relocates cli options registration from bootstrap to server https://review.openstack.org/327268 | 18:13 |
| eggmaster | flaper87: ^ | 18:14 |
| flwang1 | eggmaster: flaper87 has proposed a fix for that issue | 18:21 |
| eggmaster | flwang1: orly? where? | 18:21 |
| flwang1 | https://review.openstack.org/326421 | 18:21 |
| eggmaster | flwang1: thank you. | 18:22 |
| flwang1 | eggmaster: i don't mind abandon his patch in favor of yours ;d | 18:26 |
| eggmaster | flwang1: well... | 18:26 |
| eggmaster | flwang1: it would make one small thing tidier, which is that I just commented on a RH downstream bug with mine :P | 18:26 |
| flwang1 | eggmaster: is it really urgent? | 18:27 |
| flwang1 | if not, i would like to talk to flaper87 before abandon his patch :) | 18:27 |
| flwang1 | just to be gentle :D | 18:27 |
| eggmaster | flwang1: it's not super urgent... | 18:27 |
| eggmaster | but I think mine is better... he didn't move log.register_option | 18:28 |
| eggmaster | it's blocking some work I'm trying to do for packaging tempest for RDO | 18:29 |
| eggmaster | so in that sense it's urgent, but no one will die :) | 18:29 |
| flwang1 | eggmaster: cool | 18:30 |
| flwang1 | and thanks for the first patch to zaqar | 18:30 |
| eggmaster | glad to! | 18:30 |
| flwang1 | you're more than welcome to stay in this channel :) | 18:30 |
| eggmaster | I'll try not to wear out the welcome :) | 18:31 |
| eggmaster | thx | 18:31 |
| flwang1 | eggmaster: :) | 18:34 |
| openstackgerrit | Steve Linabery proposed openstack/zaqar: Relocates cli options registration from bootstrap to server https://review.openstack.org/327268 | 18:59 |
| eggmaster | failed pep8 gate, fixed | 19:00 |
| *** jtomasek has joined #openstack-zaqar | 19:01 | |
| openstackgerrit | Fei Long Wang proposed openstack/zaqar: Use debug instead of warning for pipeline implement error https://review.openstack.org/327296 | 19:19 |
| *** rcernin has joined #openstack-zaqar | 19:25 | |
| *** flwang has quit IRC | 19:29 | |
| *** flwang has joined #openstack-zaqar | 19:34 | |
| *** shu-mutou-AFK has quit IRC | 19:37 | |
| openstackgerrit | Doug Hellmann proposed openstack/zaqar: Add release notes https://review.openstack.org/326704 | 19:42 |
| *** flwang1 has quit IRC | 20:30 | |
| *** openstackgerrit has quit IRC | 20:48 | |
| *** openstackgerrit has joined #openstack-zaqar | 20:48 | |
| *** JAHoagie has joined #openstack-zaqar | 20:50 | |
| *** ametts has quit IRC | 21:14 | |
| eggmaster | I see a couple more failed gates here, although I've no idea how to debug those https://review.openstack.org/#/c/327268/ | 21:20 |
| eggmaster | I'll continue my education tomorrow. biab. | 21:20 |
| *** stanchan has joined #openstack-zaqar | 21:33 | |
| *** mpanetta has quit IRC | 21:43 | |
| flwang | Eva-i: vkmc: ryansb: can you help review https://review.openstack.org/#/c/326704/ ? | 21:44 |
| *** rcernin is now known as rcernin|off | 21:54 | |
| *** rcernin|off has quit IRC | 22:21 | |
| openstackgerrit | Alan Pevec proposed openstack/zaqar: Relocates cli options registration from bootstrap to server https://review.openstack.org/327268 | 22:25 |
| openstackgerrit | Merged openstack/zaqar: Fix fail of getting claim after claim expire(Redis) https://review.openstack.org/326287 | 23:04 |
| *** stanchan has quit IRC | 23:53 | |
Generated by irclog2html.py 2.14.0 by Marius Gedminas - find it at mg.pov.lt!